"что дальше?" answers with the next three, not the whole day (V-618)

Measured on the box at 04:45: "что дальше?" read 43 entries, 05:45 to 21:12, as
one spoken sentence. The rest-of-day path already trimmed to what had not
happened yet, and at 04:45 that trim removes nothing — the whole day is still
ahead. Trimming was never the narrowing; nothing capped the read.

Plan.Next(now, n) is After with a cap, and the overflow is counted rather than
dropped. The cap is three. One entry is defensible and reads as an oracle: it
says what is next and says nothing about whether the day is full. Three is what
the feed already reads back for headlines, it fits in one breath, and the reply
is spoken — he cannot scroll it back. Above three the answer stops being an
answer and becomes a recital, which is the defect.

The sentence says whether more remains: plan_next is "дальше: …" and
plan_next_more appends "и ещё 40 дел до конца дня." So a capped answer never
implies the day ends after the third line.

After is now strictly after now. An entry at exactly the asking minute is the
thing happening, not the thing next.

"что у меня сегодня?" is untouched and was never on this path: it carries no
plan word, so IsDayPlanQuery declines it and the calendar listing answers the
whole day. TestWholeDayQuestionIsNotTheRestOfTheDay pins the two apart.

The empty case already said the right thing — plan_rest_empty, "на сегодня
больше ничего не запланировано", not the whole-day empty line that would deny a
day he just lived — and now has a test at the cap boundary too.

Routing fixture unchanged, 64/91 (70.3% full, 70.3% intent-only) before and
after: no router file is touched. Suite green.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-06 05:08:48 +04:00
parent 0b1efe4911
commit 10975eff07
6 changed files with 201 additions and 4 deletions
+79
View File
@@ -1,6 +1,7 @@
package morning
import (
"fmt"
"strings"
"testing"
"time"
@@ -171,6 +172,84 @@ func TestPlanAfter(t *testing.T) {
}
}
// nextFixture — a day with more entries than the cap, built in a zone three
// hours off UTC so the test fails under TZ=UTC as well as under the machine's
// own zone if the plan ever renders in the wrong one.
func nextFixture(t *testing.T) (Plan, time.Time) {
t.Helper()
zone := time.FixedZone("MSK", 3*60*60)
now := time.Date(2026, 8, 3, 4, 45, 0, 0, zone)
var events []PlanEntry
for _, hhmm := range [][2]int{{5, 45}, {10, 0}, {14, 0}, {18, 30}, {21, 12}} {
events = append(events, PlanEntry{
At: planAt(now, hhmm[0], hhmm[1]),
Text: fmt.Sprintf("событие %02d:%02d", hhmm[0], hhmm[1]),
Kind: PlanEvent,
})
}
return BuildPlan(nil, nil, events, nil, now), now
}
// "что дальше?" asked at 04:45 on a day with everything still ahead. The trim
// removes nothing there, so before V-618 she read the whole day out loud.
func TestPlanNextCapsWhatIsSpoken(t *testing.T) {
p, now := nextFixture(t)
got := p.Next(now, NextSpoken).FormatRU()
want := "дальше: 05:45 — событие 05:45; 10:00 — событие 10:00; " +
"14:00 — событие 14:00. и ещё 2 дела до конца дня."
if got != want {
t.Errorf("got %q\nwant %q", got, want)
}
// No date: he asked what is next, not what day it is.
if strings.Contains(got, "03.08.2026") {
t.Errorf("rest-of-day answer stamps a date: %q", got)
}
}
// Nothing hidden means nothing claimed hidden.
func TestPlanNextWithinTheCapSaysNoMore(t *testing.T) {
p, now := nextFixture(t)
got := p.Next(planAt(now, 15, 0), NextSpoken).FormatRU()
want := "дальше: 18:30 — событие 18:30; 21:12 — событие 21:12"
if got != want {
t.Errorf("got %q\nwant %q", got, want)
}
}
// The whole-day question is not narrowed: same plan, no trim, no cap.
func TestPlanWholeDayIsNotNarrowed(t *testing.T) {
p, _ := nextFixture(t)
got := p.FormatRU()
if n := strings.Count(got, "событие"); n != 5 {
t.Errorf("whole day read %d of 5 entries: %q", n, got)
}
if !strings.HasPrefix(got, "план на 03.08.2026: ") {
t.Errorf("whole day lost its date: %q", got)
}
}
// The empty case says the day is over rather than returning an empty sentence,
// and it does not say the day was empty.
func TestPlanNextEmptySaysSo(t *testing.T) {
p, now := nextFixture(t)
got := p.Next(planAt(now, 23, 30), NextSpoken).FormatRU()
if got != "на сегодня больше ничего не запланировано." {
t.Errorf("got %q", got)
}
}
// An entry at exactly the asking minute is what is happening, not what is next.
func TestPlanNextIsStrictlyAfterNow(t *testing.T) {
p, now := nextFixture(t)
rest := p.Next(planAt(now, 5, 45), NextSpoken)
if len(rest.Items) != 3 || rest.Items[0].At.Hour() != 10 {
t.Errorf("got %+v", rest.Items)
}
if rest.More != 1 {
t.Errorf("More = %d, want 1", rest.More)
}
}
// The plan says what today still has not got done, and a closed window does not
// make a skipped routine untrue. Evaluate reports Active only inside the
// window, so keying the checklist line off it meant the one thing the plan can