Make delivery and integration failures explicit

Persist reminder presentations and retry state, atomically complete collapsed deliveries, fall back across away reaches, and block permanent failures visibly (V-715, V-678). Fail closed when enabled integrations lack credentials and keep remote arms explicitly dark (V-691). Give mavweb one sanitized, request-correlated error contract (V-689). Owner explicitly requested direct commits to master.
This commit is contained in:
2026-08-13 02:50:59 +04:00
parent da9114b623
commit 35c6ff5a71
67 changed files with 3174 additions and 477 deletions
+21 -9
View File
@@ -559,7 +559,7 @@ func run(args []string) error {
func personaFacts(cfg *config.Config) persona.Facts {
f := persona.Facts{
// Telegram lives outside the voice block, so it counts either way.
Telegram: cfg.Telegram != nil && cfg.Telegram.BotToken != "" && cfg.Telegram.ChatID != "",
Telegram: cfg.Telegram != nil && !cfg.Telegram.Disabled && cfg.Telegram.BotToken != "" && cfg.Telegram.ChatID != "",
}
if cfg.Voice == nil {
return f
@@ -678,16 +678,12 @@ func wireGatherer(st *store.Store, cfg *config.Config, rules []loop.Rule) *loop.
// reconciled to "unknown" here, before the tick loop resumes sending, so
// nothing auto-resends into that ambiguity.
func wireDispatcher(st *store.Store, cfg *config.Config, voiceW *voiceWiring) (*delivery.Dispatcher, error) {
var ntfy delivery.Sink
if cfg.Ntfy != nil {
s, err := ntfysink.New(*cfg.Ntfy)
if err != nil {
return nil, fmt.Errorf("wire ntfy sink: %w", err)
}
ntfy = s
ntfy, err := wireNtfySink(cfg.Ntfy)
if err != nil {
return nil, err
}
var telegram delivery.Sink
if cfg.Telegram != nil {
if cfg.Telegram != nil && !cfg.Telegram.Disabled {
s, err := telegramsink.New(*cfg.Telegram)
if err != nil {
return nil, fmt.Errorf("wire telegram sink: %w", err)
@@ -712,6 +708,22 @@ func wireDispatcher(st *store.Store, cfg *config.Config, voiceW *voiceWiring) (*
}), nil
}
// wireNtfySink keeps an optional reach optional without ever turning a missing
// secret into anonymous publishing. A block is live unless it says disabled;
// therefore an expanded-empty token in a live block fails startup instead of
// spending days in a permanent 403 retry loop. Disabled is an explicit
// operator choice and lets another away reach take over.
func wireNtfySink(cfg *ntfysink.Config) (delivery.Sink, error) {
if cfg == nil || cfg.Disabled {
return nil, nil
}
sink, err := ntfysink.New(*cfg)
if err != nil {
return nil, fmt.Errorf("wire ntfy sink: %w", err)
}
return sink, nil
}
// wireTickLoop reads the loop's three intervals and its schedules out of the
// config, so the two boot paths cannot disagree about them.
func wireTickLoop(st *store.Store, gatherer *loop.Gatherer, dispatcher *delivery.Dispatcher, phr phraser.Phraser, rules []loop.Rule, cfg *config.Config) *tickLoop {