a device's history is not a scan request (V-554)
Found verifying the three fixes on the box: "кто изобрёл телефон" ran a LAN scan and answered "нашла 3 устройства". The network seed set opens with "кто в сети сейчас" and names devices throughout, so a "кто ..." question about any device noun landed there. Three topicOther seeds, same shape as the V-553 fix. TestONNXTopics 34/34 -> 38/38 on held-out utterances, and a real scan is still a scan.
This commit is contained in:
@@ -115,6 +115,15 @@ func TestONNXTopics(t *testing.T) {
|
||||
// as weather, including the two that lean on the keyword floor.
|
||||
{"будет ли завтра дождь в москве", topicWeather, isWeatherQuery},
|
||||
{"какая температура завтра утром", topicWeather, isWeatherQuery},
|
||||
// The same shape one topic over, seen on the box (Vikunja #554): a
|
||||
// device has a history, and asking about it is not asking what is
|
||||
// plugged in. "кто изобрёл телефон" answered "нашла 3 устройства".
|
||||
// Held out from the seeds, which name the telephone and the computer.
|
||||
{"кто придумал радио", topicOther, isNetworkQuery},
|
||||
{"когда изобрели телевизор", topicOther, isNetworkQuery},
|
||||
{"как устроен телефон внутри", topicOther, isNetworkQuery},
|
||||
// The control: a real scan is still a scan.
|
||||
{"какие устройства подключены к вайфаю", topicNetwork, isNetworkQuery},
|
||||
}
|
||||
|
||||
h := &reactiveHandler{recall: recallWiring{embedder: emb}}
|
||||
|
||||
Reference in New Issue
Block a user