Let a question go after it has stepped aside three times (V-654)

A side query suspends the parked question rather than dropping it. Nothing bounded that. No attempt is spent, so MaxAttempts never applies, and noteSuspended restarts the 90s clock, so the TTL cannot arrive while he keeps talking. Measured 2026-08-07: one unfilled time slot rode the tail of six consecutive unrelated replies.

PendingQuestion.Suspends counts the step-asides, MaxSuspends is 3, and past it she lets the request go with the same clarifyDropped line every other drop uses. The count is of consecutive step-asides and resets the moment he answers.

Also splits the re-ask off the answer into its own sentence. The comma splice buried the question in the tail of a reply about something else.
This commit is contained in:
2026-08-07 12:16:15 +04:00
parent beb093aebb
commit 4fdecf9a25
4 changed files with 211 additions and 22 deletions
+50
View File
@@ -740,3 +740,53 @@ func TestACompleteTurnStillDoesNotAsk(t *testing.T) {
}
}
}
// TestTheResumedQuestionIsItsOwnSentence — V-654. The re-ask used to be spliced
// onto the answer with a comma, so a real answer and an unrelated open question
// read as one run-on thought and the question vanished into its tail.
func TestTheResumedQuestionIsItsOwnSentence(t *testing.T) {
const resumed = "На какое время поставить напоминание?"
cases := []struct {
name string
reply string
want string
}{
{
// The measured line, shortened. Two sentences, and the question keeps
// its capital.
name: "a statement keeps its full stop",
reply: "Вайфай пароль лежит в ящике стола.",
want: "Вайфай пароль лежит в ящике стола. " + resumed,
},
{
name: "a reply with no terminator is given one",
reply: "Вайфай пароль лежит в ящике стола",
want: "Вайфай пароль лежит в ящике стола. " + resumed,
},
{
// She sometimes answers a side query by asking him to say it again.
// Two questions, and neither may swallow the other.
name: "a question keeps its mark",
reply: "Можешь переформулировать?",
want: "Можешь переформулировать? " + resumed,
},
{
name: "an ellipsis is already an ending",
reply: "Не уверена…",
want: "Не уверена… " + resumed,
},
{
name: "a resume with no answer in front of it is just the question",
reply: "",
want: resumed,
},
}
for _, tc := range cases {
if got := withResumed(tc.reply, resumed); got != tc.want {
t.Errorf("%s: withResumed(%q) = %q, want %q", tc.name, tc.reply, got, tc.want)
}
}
if got := withResumed("Готово.", ""); got != "Готово." {
t.Errorf("nothing to resume must leave the reply alone, got %q", got)
}
}