Merge: a reminder said whole is not asked about (#214)
V-572. "напомни в 11:00 позвонить маме" answered "Когда?". ReminderGrammar builds its slots by hand and the extractor never ran over a stage 0 decision, so HasTime was false however clearly the hour was spoken, and missingFor read the silence as absence. fillMatchedSlots in internal/router/router.go now runs the stage 2 extractor over every stage 0 decision and fills only what the grammar left empty. A matched value always wins. The LLM path had the same hole and the same fix, so both share one function rather than ten grammars re-implementing extraction. Slots.Text is deliberately not filled. A grammar that left Text empty meant it: agendaQueryBuild hands the query chain the sentence itself. Filling it would also make SlotText unaskable, which is the bug V-383 fixed on the LLM side. Enabled for all ten grammars and inert for nine. Extract fills Time for a reminder, Fn for an act and Key for a fact, and nothing for query, system, note or chat. Benchmarked at 20000x with the real date parser: every stage 0 shape stays inside the noise, and the reminder rule gains, because actionReminder was already running that same parse one layer down. TestONNXBaseline 64/91 before and after, no case regressed. The fixture's own "slots deferred to daemon" line went 6 to 0. On the box: "хорошо, напомню сегодня в 11:00." Conflict in internal/router/router.go resolved by hand: V-564's grammar-outcome note and V-572's slot fill both belong, fill first. Full -race suite green. --no-verify: the pre-commit hook refuses master, and the owner asked for straight-to-master merges for this unattended run.
This commit is contained in:
@@ -162,6 +162,19 @@ on in deploy** — this section used to say it was wired `nil`, which stopped be
|
||||
Cascade order: `stage0.go` exact-match fast-path → LLM router (when non-nil) → classifier
|
||||
fallback. Any LLM error falls through to the classifier so a turn never breaks on the model.
|
||||
|
||||
**A stage-0 decision is slot-extracted too, since 06-08-2026** (V-572). `fillMatchedSlots`
|
||||
in `router.go` runs the stage-2 extractor over whatever a grammar built and fills only the
|
||||
slots it left empty — a matched value always wins, because the rule read a literal pattern
|
||||
and the extractor guesses. It did not run before, so `ReminderGrammar` handed the daemon
|
||||
`HasTime: false` for "напомни в 11:00 позвонить маме" and `missingFor` read the silence as
|
||||
absence and asked "Когда?". It applies to every grammar and is inert for all but the
|
||||
reminder: `Extract` fills Time, Fn and Key and nothing else, and the query, clock, agenda,
|
||||
feed, list, task and narrative rules all emit intents with no such slot. Benchmarked at
|
||||
20000x, a stage-0 query costs 3.7µs against 3.9µs before. **`Slots.Text` is deliberately not
|
||||
filled** — a grammar that left it empty meant it, and `agendaQueryBuild` hands the query
|
||||
chain the utterance itself. Fixture unchanged at 64/91, with "slots deferred to daemon"
|
||||
6 → 0.
|
||||
|
||||
Measured on the 77-case RU fixture. **Re-measured 2026-08-02: the classifier scores 68.8%
|
||||
full accuracy at p50 16.6µs**, not the 36.8% at p50 31ms that stood here from
|
||||
`docs/evals/2026-07-31-model-bakeoff.md`. That older figure predates the stage 0 rules and the
|
||||
|
||||
Reference in New Issue
Block a user