media: move a file into the store instead of reading it in
Put takes a []byte, so storing a recording meant the whole recording in memory. A two hour meeting at 16 kHz mono is about 230 MB of WAV, and building it from PCM held a second copy of the same size in the process that also owns the database and the resident model. PutFile stats the file, hashes it in a stream and renames it into place, so the peak is one buffer regardless of length. SpoolFile hands out the scratch file it moves from, under the media dir so it shares the same disk and the same permissions. Audio also gets its own per blob cap of 512 MiB. The image cap of 64 MiB is 35 minutes of audio, which contradicted the two hour session cap: the long meeting was exactly the one that failed to store. audio.WAVHeader is split out of WAVFromPCM because a spooled capture writes a placeholder header first and stamps the real length at the end. Found in review of #73.
This commit is contained in:
@@ -94,14 +94,33 @@ func PCMFromWAV(wav []byte) (Format, []byte, error) {
|
||||
// header so the result can be written to disk and played with `aplay`.
|
||||
// Used by the reference client to write the TTS reply; not on the wire.
|
||||
func WAVFromPCM(format Format, pcm []byte) ([]byte, error) {
|
||||
hdr, err := WAVHeader(format, len(pcm))
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out := make([]byte, wavHeaderSize+len(pcm))
|
||||
copy(out, hdr)
|
||||
copy(out[wavHeaderSize:], pcm)
|
||||
return out, nil
|
||||
}
|
||||
|
||||
// WAVHeaderSize is the fixed size of the header WAVHeader writes. A caller
|
||||
// spooling audio to a file reserves this many bytes up front and rewrites them
|
||||
// once it knows the length.
|
||||
const WAVHeaderSize = wavHeaderSize
|
||||
|
||||
// WAVHeader builds just the 44-byte canonical header for n bytes of PCM. It
|
||||
// exists so a long recording can be written straight to a file: holding the
|
||||
// whole meeting in memory to prepend 44 bytes is what the streaming path is
|
||||
// avoiding.
|
||||
func WAVHeader(format Format, n int) ([]byte, error) {
|
||||
if !format.IsValid() {
|
||||
return nil, fmt.Errorf("audio: WAVFromPCM: %w: %+v", ErrNotCanonicalPCM, format)
|
||||
}
|
||||
out := make([]byte, wavHeaderSize+len(pcm))
|
||||
copy(out[wavHeaderSize:], pcm)
|
||||
out := make([]byte, wavHeaderSize)
|
||||
// RIFF header
|
||||
copy(out[0:4], []byte("RIFF"))
|
||||
binary.LittleEndian.PutUint32(out[4:8], uint32(36+len(pcm)))
|
||||
binary.LittleEndian.PutUint32(out[4:8], uint32(36+n))
|
||||
copy(out[8:12], []byte("WAVE"))
|
||||
// fmt chunk
|
||||
copy(out[12:16], []byte("fmt "))
|
||||
@@ -116,6 +135,6 @@ func WAVFromPCM(format Format, pcm []byte) ([]byte, error) {
|
||||
binary.LittleEndian.PutUint16(out[34:36], uint16(format.SampleBits))
|
||||
// data chunk
|
||||
copy(out[36:40], []byte("data"))
|
||||
binary.LittleEndian.PutUint32(out[40:44], uint32(len(pcm)))
|
||||
binary.LittleEndian.PutUint32(out[40:44], uint32(n))
|
||||
return out, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user