kami/Maven
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

maven: dedupe knowledge prompt to router.KnowledgePrompt (task 4 follow-up)

Browse Source 
Task 4 created and tested router.KnowledgePrompt() but the live path in
LLMPhraser.PhraseQuery used a separate hardcoded copy of the same RU
anti-hallucination prompt, leaving KnowledgePrompt() as dead code and two
strings that could drift. Point the phraser at the tested helper so there
is a single source of truth.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
kami
2026-07-06 11:51:31 +04:00
parent 9ffefd9e8c
commit 9488225556
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/phraser/llmphraser.go
+4 -2
View File
@@ -16,6 +16,7 @@ import (
"github.com/kami/maven/internal/delivery" "github.com/kami/maven/internal/delivery"
"github.com/kami/maven/internal/loop" "github.com/kami/maven/internal/loop"
"github.com/kami/maven/internal/router"
) )
var listenRE = regexp.MustCompile(`listening on (https?://\S+)`) var listenRE = regexp.MustCompile(`listening on (https?://\S+)`)
@@ -171,8 +172,9 @@ func (p *LLMPhraser) PhraseNudge(ctx context.Context, c loop.Candidate) (deliver
// LLM error — better to give the raw data than silence. // LLM error — better to give the raw data than silence.
func (p *LLMPhraser) PhraseQuery(ctx context.Context, utterance string, notes []string) (string, error) { func (p *LLMPhraser) PhraseQuery(ctx context.Context, utterance string, notes []string) (string, error) {
if len(notes) == 0 { if len(notes) == 0 {
// General knowledge — no notes to ground the answer // General knowledge — no notes to ground the answer. The system
sys := "Ты — Мавена, персональный ассистент. Ответь кратко из своих знаний. Если не знаешь — скажи \"не знаю\". Не выдумывай." // prompt is the single tested source in router.KnowledgePrompt.
sys := router.KnowledgePrompt()
prompt := fmt.Sprintf("Пользователь спрашивает: \"%s\".", utterance) prompt := fmt.Sprintf("Пользователь спрашивает: \"%s\".", utterance)
resp, err := p.chatWithSystem(ctx, sys, prompt, 256) resp, err := p.chatWithSystem(ctx, sys, prompt, 256)
if err != nil || resp == "" { if err != nil || resp == "" {