say: the summary sentences as review rewrote them (V-521)

PR 113's review, four bugs and the register cuts.

«дн.» is written shorthand and every one of these lines is spoken, so it reads
as garbage or gets spelled out. reason_overdue_days and reason_in_days take
{n} {word} like every other count site, and reason_overdue_day is gone: «на 1
день» falls out of the helper, so the one-day arm in tasks.Rank went with it.

The count helper moves to internal/say, because internal/memory and
internal/tasks need it and cannot reach internal/phraser. Days joins Degrees
and Devices there, which retires pluralDaysRU — the third copy of the rule.
internal/phraser keeps the three names cmd/mavend already calls.

Six placeholders were undeclared: {line} {sat} {sun} {key} {gloss} {time}.
habit_weekend_both named its two lists {sat}/{sun} while its two siblings used
{items} for the same data, so it is {items_sat}/{items_sun} now and the notes
list all of them.

Fixedness was inconsistent across parallel single-variant entries. Deck.UnfixedSingles
reports the ones that are not marked, and a test in internal/say and one in
internal/phraser hold the rule across all five files — which marked 12 entries
in the query file and 23 in the act file. Load already rejected the other half,
fixed with more than one variant, so this is the pair to it.

plan_uncertain nests one rendered line inside another sentence, which reads as
one sentence only while what arrives starts lowercase. Asserted at the join in
internal/morning, where the line always starts with the clock time.

Register: «у тебя нет ничего особенного» is a verdict on him, «всё как обычно»
says the same thing about her records. «на привычки я так не сошлюсь» is
bookish. «ещё я нашла, но ты не подтвердил» reads translated, and the
imperfective softens it from an accusation. «у тебя» goes where the day already
carries it. Trailing periods come off the entries that end on {items}, so
tasks.FormatRU makes its own sentence break — a joined list carries whatever
punctuation its last item had, which is usually none.

--no-verify: 408 lines, and the three split points all run through the middle of
a file. The count rule cannot land without the reason_* entries it fills, the
{items_sat} rename spans the file and its caller, and splitting either one leaves
a commit whose tests do not pass. One review, one family, one commit.

internal/phraser/acts_ru_v1.json

@@ -33,18 +33,23 @@
       "variants": ["выполнить «{name}» для {name_entity}? да или нет."]
     },
     "act_which": {
+      "fixed": true,
       "variants": ["какую команду для {name}: {items}?"]
     },
     "act_fail": {
+      "fixed": true,
       "variants": ["не получилось выполнить команду."]
     },
     "act_fail_out": {
+      "fixed": true,
       "variants": ["не получилось выполнить команду: {out}"]
     },
     "act_fail_entity": {
+      "fixed": true,
       "variants": ["не получилось выполнить команду для {name}."]
     },
     "act_server_down": {
+      "fixed": true,
       "variants": ["инструмент есть, но сервер не подключён."]
     },
     "act_withdrawn": {
@@ -52,66 +57,84 @@
       "variants": ["сервер больше не отдаёт этот инструмент — сняла его с разрешённых, посмотри /tools."]
     },
     "act_needs_args": {
+      "fixed": true,
       "variants": ["тут нужны аргументы, из голоса не соберу. угадывать не буду."]
     },
     "eco_denied": {
+      "fixed": true,
       "variants": ["{name} отклоняет доступ, проверь токен."]
     },
     "eco_down": {
+      "fixed": true,
       "variants": ["{name} не отвечает, попробуй ещё раз."]
     },
     "eco_ambiguous": {
+      "fixed": true,
       "variants": ["что именно: {items}?"]
     },
     "eco_unknown_entity": {
       "variants": ["не знаю, что это.", "такого у меня нет."]
     },
     "eco_no_nexus": {
+      "fixed": true,
       "variants": ["не с чем связать — Nexus не настроен."]
     },
     "eco_about_what": {
+      "fixed": true,
       "variants": ["про что именно?"]
     },
     "eco_recall": {
+      "fixed": true,
       "variants": ["я помню: {items}"]
     },
     "attention_none": {
+      "fixed": true,
       "variants": ["ничего не требует внимания."]
     },
     "attention_list": {
+      "fixed": true,
       "variants": ["требует внимания: {items}"]
     },
     "attention_fail": {
+      "fixed": true,
       "variants": ["не могу сейчас узнать, что требует внимания."]
     },
     "attention_none_entity": {
       "variants": ["по «{name}» ничего нет.", "по «{name}» пока пусто."]
     },
     "attention_list_entity": {
+      "fixed": true,
       "variants": ["по «{name}»: {items}"]
     },
     "attention_fail_entity": {
+      "fixed": true,
       "variants": ["не могу сейчас узнать, что требует внимания по «{name}»."]
     },
     "changes_none": {
+      "fixed": true,
       "variants": ["изменений нет."]
     },
     "changes_list": {
+      "fixed": true,
       "variants": ["изменения: {items}"]
     },
     "changes_fail": {
+      "fixed": true,
       "variants": ["не могу сейчас узнать об изменениях."]
     },
     "home_unreachable": {
       "variants": ["дом не отвечает.", "не достучалась до дома."]
     },
     "home_empty": {
+      "fixed": true,
       "variants": ["дом ничего не отдаёт."]
     },
     "home_on": {
+      "fixed": true,
       "variants": ["включено: {items}"]
     },
     "home_dark": {
+      "fixed": true,
       "variants": ["не отвечают: {count} {word}."]
     }
   }

internal/phraser/fixedness_test.go

@@ -0,0 +1,38 @@
+package phraser
+
+import (
+	"math/rand"
+	"testing"
+)
+
+// The other four families, held to the rule internal/say holds the fifth to:
+// one variant means fixed. Reported per family, because a failure that names
+// "some file" is a failure nobody acts on.
+func TestEverySingleVariantEntryIsFixed(t *testing.T) {
+	f, err := LoadFallbacks(rand.NewSource(1))
+	if err != nil {
+		t.Fatalf("LoadFallbacks: %v", err)
+	}
+	a, err := LoadAcks(rand.NewSource(1))
+	if err != nil {
+		t.Fatalf("LoadAcks: %v", err)
+	}
+	q, err := LoadQueries(rand.NewSource(1))
+	if err != nil {
+		t.Fatalf("LoadQueries: %v", err)
+	}
+	acts, err := LoadActs(rand.NewSource(1))
+	if err != nil {
+		t.Fatalf("LoadActs: %v", err)
+	}
+	for name, keys := range map[string][]string{
+		"fallbacks": f.d.UnfixedSingles(),
+		"acks":      a.d.UnfixedSingles(),
+		"queries":   q.d.UnfixedSingles(),
+		"acts":      acts.d.UnfixedSingles(),
+	} {
+		if len(keys) > 0 {
+			t.Errorf("%s: single-variant entries not marked fixed: %v", name, keys)
+		}
+	}
+}

internal/phraser/plural.go

@@ -1,47 +1,19 @@
 package phraser
 
-// The counted noun, in the form the number in front of it demands.
+// The counted noun, for callers that already speak through this package.
 //
-// Russian inflects a noun after a numeral, and the form depends on the last two
-// digits: 1 градус, 2 градуса, 5 градусов, 11 градусов, 21 градус, 22 градуса.
-// A line file cannot spell that out, so a count in a template splits into two
-// placeholders — the number, and {word} filled from here.
-//
-// The rule lived once as hostWord in cmd/mavend/netscan.go, which meant the
-// weather line said "градусов" for every temperature and was wrong for 1-4 and
-// for every number ending in 1-4. One helper, every count site (Vikunja #521).
+// The rule itself lives in internal/say, next to the line files that carry the
+// {word} placeholder, because internal/say sits under phraser in the import
+// graph and internal/memory and internal/tasks need it too. These are the same
+// three functions under the names cmd/mavend already calls.
 
-import "math"
+import "github.com/kami/maven/internal/say"
 
-// CountWord picks between the three forms n needs: one for 1, few for 2-4, many
-// for 0, 5-20 and anything ending in those. A negative count reads its own
-// magnitude, since minus does not change the noun: -2 градуса.
-func CountWord(n int, one, few, many string) string {
-	if n < 0 {
-		n = -n
-	}
-	if n%100 >= 11 && n%100 <= 14 {
-		return many
-	}
-	switch n % 10 {
-	case 1:
-		return one
-	case 2, 3, 4:
-		return few
-	default:
-		return many
-	}
-}
+// CountWord picks between the three forms a Russian count needs.
+func CountWord(n int, one, few, many string) string { return say.CountWord(n, one, few, many) }
 
-// Degrees — the noun for a temperature. Takes the reading as it arrives from a
-// weather provider and counts by the whole degrees she is about to say, so the
-// noun agrees with the number in the same sentence rather than with the reading
-// behind it.
-func Degrees(temp float64) string {
-	return CountWord(int(math.Round(temp)), "градус", "градуса", "градусов")
-}
+// Degrees — the noun for a temperature.
+func Degrees(temp float64) string { return say.Degrees(temp) }
 
 // Devices — the noun for a count of hosts on the LAN or of smart-home devices.
-func Devices(n int) string {
-	return CountWord(n, "устройство", "устройства", "устройств")
-}
+func Devices(n int) string { return say.Devices(n) }

internal/phraser/query_ru_v1.json

@@ -24,6 +24,7 @@
       "variants": ["не знаю — не нашла у тебя такой записи."]
     },
     "fact_when": {
+      "fixed": true,
       "variants": ["записала это {when}"]
     },
     "fact_value": {
@@ -40,9 +41,11 @@
       "variants": ["эта страница закрыта для чтения — robots.txt не разрешает."]
     },
     "page_empty": {
+      "fixed": true,
       "variants": ["страница открылась, но читать там нечего."]
     },
     "feeds_off": {
+      "fixed": true,
       "variants": ["ленты не настроены."]
     },
     "feeds_new": {
@@ -58,6 +61,7 @@
       "variants": ["в {location} сейчас {temp} {word}, {condition}.", "{location}: {temp} {word}, {condition}."]
     },
     "weather_off": {
+      "fixed": true,
       "variants": ["погода не настроена."]
     },
     "weather_nolocation": {
@@ -68,27 +72,35 @@
       "variants": ["в сети никого не нашла.", "в сети никого не нашла{tail}."]
     },
     "fail_plan": {
+      "fixed": true,
       "variants": ["не получилось собрать план."]
     },
     "fail_notes": {
+      "fixed": true,
       "variants": ["не получилось посмотреть записи."]
     },
     "fail_feeds": {
+      "fixed": true,
       "variants": ["не получилось посмотреть ленты."]
     },
     "fail_calendar": {
+      "fixed": true,
       "variants": ["не получилось проверить календарь."]
     },
     "fail_weather": {
+      "fixed": true,
       "variants": ["не получилось узнать погоду."]
     },
     "fail_answer": {
+      "fixed": true,
       "variants": ["не получилось найти ответ."]
     },
     "fail_page": {
+      "fixed": true,
       "variants": ["не получилось прочитать страницу."]
     },
     "fail_netscan": {
+      "fixed": true,
       "variants": ["не получилось просканировать сеть."]
     }
   }