a missing slot asks, whatever the confidence (V-557)

The clarify path was gated on dec.Clarify, so a turn the cascade routed
confidently but incompletely skipped it. "напомни позвонить" reached applyAction,
failed on the missing time and parked nothing, and the "в семь вечера" that
followed was routed as a world question and web-searched.

The gate now also fires when missingFor names a required slot. A bare capture
verb gets a stage-0 rule of its own: it was reaching the resident model as chat,
which answered by agreeing to a wording change nobody asked for.
This commit is contained in:
2026-08-06 00:08:43 +04:00
parent b6305f1b6e
commit ea0eb167fd
5 changed files with 179 additions and 4 deletions
+77
View File
@@ -10,6 +10,7 @@ import (
"github.com/kami/maven/internal/dialogue"
"github.com/kami/maven/internal/ipc"
"github.com/kami/maven/internal/memory"
"github.com/kami/maven/internal/phraser/eval"
"github.com/kami/maven/internal/router"
"github.com/kami/maven/internal/store"
@@ -646,3 +647,79 @@ func TestUnresolvedActSaysItDoesNotKnowTheCommand(t *testing.T) {
}
// newRoutingClarifyHandler wires the real cascade (hash embedder, no model) onto
// the clarify handler, so a test can drive handleText end to end and see which
// gate claimed the turn.
func newRoutingClarifyHandler(t *testing.T) (*reactiveHandler, *store.Store) {
t.Helper()
h, st, _ := newClarifyHandler(t)
h.router = buildRouter(router.NewHashEmbedder(1024), h.matcher, 0.55, nil)
h.recall = recallWiring{embedder: router.NewHashEmbedder(1024), memStore: memory.NewInMemoryStore()}
return h, st
}
// TestIncompleteReminderAsksInsteadOfFailing — Vikunja #557. "напомни позвонить"
// is routed confidently and is still half a request. It used to reach applyAction,
// fail on the missing time and park nothing, so the "в семь вечера" that followed
// was routed as a world question and web-searched.
func TestIncompleteReminderAsksInsteadOfFailing(t *testing.T) {
ctx := context.Background()
h, st := newRoutingClarifyHandler(t)
reply := h.handleText(ctx, "web", "напомни позвонить маме")
want, _ := clarifyQuestionFor(dialogue.SlotTime, 1)
if reply != want {
t.Fatalf("reply = %q, want the time question %q", reply, want)
}
if h.clarifyStore.Get(dialogueIDFor(sourceText, "web"), h.now()) == nil {
t.Fatal("the request must be parked, or the answer has nowhere to land")
}
if reply := h.handleText(ctx, "web", "в семь вечера"); strings.Contains(reply, "нашла") {
t.Fatalf("the answer to her own question must not be looked up: %q", reply)
}
if reminders, err := st.DueReminders(ctx, h.now().Add(48*time.Hour)); err != nil || len(reminders) != 1 {
t.Fatalf("the answer did not complete the reminder: reminders=%v err=%v", reminders, err)
}
}
// TestBareCaptureVerbAsksWhatToRecord — the other half of #557. A bare "запиши"
// went to the resident model as chat, which agreed to a wording change nobody
// asked for. It is a fact with no key, and that gap has a question.
func TestBareCaptureVerbAsksWhatToRecord(t *testing.T) {
ctx := context.Background()
h, _ := newRoutingClarifyHandler(t)
reply := h.handleText(ctx, "web", "запиши")
want, _ := clarifyQuestionFor(dialogue.SlotKey, 1)
if reply != want {
t.Fatalf("reply = %q, want %q", reply, want)
}
if h.clarifyStore.Get(dialogueIDFor(sourceText, "web"), h.now()) == nil {
t.Fatal("the request must be parked so the next utterance completes it")
}
}
// TestACompleteTurnStillDoesNotAsk — the gate reads a missing slot, not any
// slot, so a request she can act on must never turn into a question. Checked on
// the decision rather than through the cascade: what is at stake is the gate's
// condition, and driving it through the hash embedder would measure routing.
func TestACompleteTurnStillDoesNotAsk(t *testing.T) {
ctx := context.Background()
h, _, _ := newClarifyHandler(t)
complete := []router.Decision{
{Intent: router.IntentReminder, Slots: router.Slots{Text: "позвонить маме", HasTime: true}, Utterance: "напомни в 11 позвонить маме"},
{Intent: router.IntentFact, Slots: router.Slots{Key: "water", Value: "выпил", HasKey: true}, Utterance: "я выпил воды"},
{Intent: router.IntentNote, Slots: router.Slots{Text: "купить хлеб"}, Utterance: "запиши купить хлеб"},
{Intent: router.IntentQuery, Slots: router.Slots{Text: "что у меня сегодня"}, Utterance: "что у меня сегодня"},
}
for _, dec := range complete {
if gaps := missingFor(dec); len(gaps) > 0 {
t.Errorf("%q reads as incomplete: %v", dec.Utterance, gaps)
}
if reply, asked := h.askClarify(ctx, dec); asked {
t.Errorf("%q was answered with a question: %q", dec.Utterance, reply)
}
}
}