Compare commits
44 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 2ad7635501 | |||
| 9949b309b1 | |||
| 62d47d28ac | |||
| 3dbf67f8f9 | |||
| 84ba217892 | |||
| f179ae2fde | |||
| d00929ac0b | |||
| b6f47fbeb6 | |||
| 2e9b9ec1cf | |||
| bfb57c3148 | |||
| d1f6f6355f | |||
| 92ecb691de | |||
| 4282f6b9a9 | |||
| 7bb9f9be06 | |||
| 1e47eaca5a | |||
| 892330eb84 | |||
| 9a3bcd7c46 | |||
| 98ee701e03 | |||
| 04c1088088 | |||
| 07c191d8b8 | |||
| c668310b3e | |||
| 1bd2acdc2a | |||
| 15e5dd8eaa | |||
| 10cf6f525c | |||
| e2210f6844 | |||
| 214a4032cf | |||
| dc70a5a7ab | |||
| 06aded6ab0 | |||
| d2be98ee2a | |||
| 62d320f93a | |||
| 796e6af3cf | |||
| 74a70880a8 | |||
| a40bc559d5 | |||
| 1db0fcfcd0 | |||
| 4ca68d2f3f | |||
| 5a1d465db5 | |||
| 43838445ab | |||
| 11831c6ace | |||
| 93c1a41d4a | |||
| bce5ed210c | |||
| c31f0d1001 | |||
| 0b3b8d0a9e | |||
| fe0e654ab1 | |||
| a54ebac0cb |
@@ -0,0 +1,101 @@
|
|||||||
|
# Resident model bake-off — 31-07-2026
|
||||||
|
|
||||||
|
**Recommendation: keep Qwen3.5-0.8B.** LFM2.5-1.2B is worse at routing (52.6% vs 60.5%
|
||||||
|
intent accuracy), and the loss is almost entirely Russian (18/61 vs 22/61 RU, while EN is a
|
||||||
|
wash). It is also 2.4× slower. The Thinking variant is far worse again.
|
||||||
|
|
||||||
|
Settles Vikunja **#278 / #250**.
|
||||||
|
|
||||||
|
- Same fixture and scorer as `ROUTING-EVAL-31-07-2026.md`: `internal/router/eval/`
|
||||||
|
(`ru_routing_v1.json`, 76 held-out cases).
|
||||||
|
- Reproduce: `MAVEN_LLM_URL=http://127.0.0.1:<port> make eval-router`
|
||||||
|
(`TestLLMRouterBaseline`). Note: there is no `make eval-models` target.
|
||||||
|
- All three models served by the same `llama-server` flags — `-c 2048 -ngl 99 -t 6`, only
|
||||||
|
`-m` and `--port` differ. One server at a time on an otherwise idle box, so latencies are
|
||||||
|
real and not contention.
|
||||||
|
- Measured on top of the router prompt fix (`origin/overnight/router-prompt` merged in), so
|
||||||
|
the Qwen column is directly comparable to the numbers already recorded.
|
||||||
|
|
||||||
|
## Results
|
||||||
|
|
||||||
|
`llm-only` — the model alone. This is the column that measures the model.
|
||||||
|
|
||||||
|
| | Qwen3.5-0.8B | LFM2.5-1.2B Instruct | LFM2.5-1.2B Thinking |
|
||||||
|
|---|---|---|---|
|
||||||
|
| **intent-only accuracy** | **60.5%** | 52.6% | 36.8% |
|
||||||
|
| full accuracy (intent+slots+gate) | **36.8%** | 32.9% | 21.1% |
|
||||||
|
| **RU** | **22/61** | 18/61 | 10/61 |
|
||||||
|
| EN | 6/15 | **7/15** | 6/15 |
|
||||||
|
| route errors | 0 | 0 | 0 |
|
||||||
|
| **p50 / p95 latency** | **1.05s / 1.71s** | 2.47s / 3.62s | 2.42s / 3.24s |
|
||||||
|
| missed clarify | 6 / 6 | 6 / 6 | 6 / 6 |
|
||||||
|
|
||||||
|
`cascade+llm` — stage-0 → model → classifier floor, what #320 would actually ship. Same
|
||||||
|
ordering.
|
||||||
|
|
||||||
|
| | Qwen3.5-0.8B | LFM2.5-1.2B Instruct | LFM2.5-1.2B Thinking |
|
||||||
|
|---|---|---|---|
|
||||||
|
| intent-only accuracy | **61.8%** | 55.3% | 38.2% |
|
||||||
|
| full accuracy | **46.1%** | 42.1% | 30.3% |
|
||||||
|
| RU / EN | **27/61** / 8/15 | 23/61 / **9/15** | 15/61 / 8/15 |
|
||||||
|
| route errors | 0 | 0 | 0 |
|
||||||
|
| p50 / p95 latency | **1.28s / 1.94s** | 2.18s / 2.72s | 2.27s / 3.19s |
|
||||||
|
|
||||||
|
Full logs: the three runs are archived in the session scratchpad
|
||||||
|
(`qwen08.txt`, `lfm-instruct.txt`, `lfm-thinking.txt`).
|
||||||
|
|
||||||
|
## Russian-specific failures — the owner's worry is confirmed
|
||||||
|
|
||||||
|
LFM2.5's Russian loss is not spread out. It has one large, specific failure: **it hears
|
||||||
|
almost any Russian imperative or short phrase as `reminder`.**
|
||||||
|
|
||||||
|
- `перезапусти докер` → reminder (want act)
|
||||||
|
- `включи вытяжку` → reminder (want act)
|
||||||
|
- `закрой жалюзи` → reminder (want act)
|
||||||
|
- `заметка: продлить домен в августе` → reminder (want note)
|
||||||
|
- `запиши что кран на кухне снова капает` → reminder (want note)
|
||||||
|
- `доброе утро` → reminder (want chat)
|
||||||
|
- `спасибо тебе` → reminder (want note/chat)
|
||||||
|
- `переходи в тихий режим` → reminder (want system)
|
||||||
|
|
||||||
|
That is `note→reminder ×4`, `act→reminder ×4`, `chat→reminder ×2` in one run. Qwen's
|
||||||
|
equivalent failure axis is `query→fact ×8`, which is a narrower and already-understood bug.
|
||||||
|
|
||||||
|
Two more Russian-side problems worth naming:
|
||||||
|
|
||||||
|
1. **Fact keys come back empty or wrong in Russian.** `воды попил наконец`, `поужинал`,
|
||||||
|
`поспал часов пять` and `отметь что я позавтракал овсянкой` all returned an empty key.
|
||||||
|
`сходил в душ` and `отдохнул минут двадцать` both returned `water`. Qwen does not do this.
|
||||||
|
2. **It leaked German.** `slept about seven hours` produced the fact key
|
||||||
|
`"7 Stunden geschlafen"`. Grammar-valid, semantically garbage — a sign the multilingual
|
||||||
|
mix is not anchored where Maven needs it.
|
||||||
|
|
||||||
|
The claimed tool-calling advantage did not show up here. `act` is the closest thing this
|
||||||
|
fixture has to a tool call, and LFM2.5 got it wrong more often than Qwen, mostly by calling
|
||||||
|
it a reminder. It also produced no `fn` slot on any act, same as Qwen.
|
||||||
|
|
||||||
|
## The Thinking variant
|
||||||
|
|
||||||
|
Not viable. 36.8% intent accuracy, 10/61 Russian, and no latency saving over Instruct — the
|
||||||
|
thinking trace costs time without buying accuracy on a short enum classification. With the
|
||||||
|
`enable_thinking=false` diagnostic it collapsed further to 28.9% with 2 route errors
|
||||||
|
(`query→reminder ×12`). Do not pursue.
|
||||||
|
|
||||||
|
## Notes
|
||||||
|
|
||||||
|
- Nothing crashed, nothing ignored the GBNF grammar, and no model produced unparseable JSON
|
||||||
|
in the shippable configurations. Zero route errors for both Instruct and Thinking in
|
||||||
|
`llm-only` and `cascade+llm`. The problem with LFM2.5 is what it decides, not whether it
|
||||||
|
can emit the contract.
|
||||||
|
- The `6 / 6` missed clarify is unchanged across all three models. No model fixes the missing
|
||||||
|
refusal lane — that is `Confidence: 1.0` hardcoded in `llmrouter.go` (Vikunja #359), not a
|
||||||
|
model property.
|
||||||
|
- The report labels every configuration `(0.8B)`; that string is hardcoded in the test, not a
|
||||||
|
reflection of which gguf was loaded. Model identity was confirmed per run via `/v1/models`.
|
||||||
|
- No Go code was changed for this measurement, and no bug was found that needed one.
|
||||||
|
|
||||||
|
## What this does not settle
|
||||||
|
|
||||||
|
Routing only. LFM2.5 might still phrase better, and phrasing is the resident model's other
|
||||||
|
job — that needs its own fixture. But routing is the load-bearing path and Maven is
|
||||||
|
Russian-first, so on the evidence here the switch is not worth making.
|
||||||
@@ -0,0 +1,140 @@
|
|||||||
|
# Phrasing evaluation — 31-07-2026
|
||||||
|
|
||||||
|
How Maven words a nudge, measured instead of argued. Counterpart to
|
||||||
|
`ROUTING-EVAL-31-07-2026.md`.
|
||||||
|
|
||||||
|
- Fixture + scorer: `internal/phraser/eval/` (`nudges_v1.json`, 15 cases; `eval.go`, `checks.go`)
|
||||||
|
- Reproduce: `MAVEN_LLM_URL=http://127.0.0.1:18099 make eval-phrasing`
|
||||||
|
- Model: Qwen3.5-0.8B Q4_K_M, the resident model. Not swapped.
|
||||||
|
- Commit: `a40bc55` (prompt fix)
|
||||||
|
|
||||||
|
Every check is a string or length test a human can read and disagree with. No model
|
||||||
|
grades another model here.
|
||||||
|
|
||||||
|
## Result
|
||||||
|
|
||||||
|
| | before | after |
|
||||||
|
|---|---|---|
|
||||||
|
| **cases passing every check** | **0/15** | **13/15** |
|
||||||
|
| mood in enum | 6/15 | 15/15 |
|
||||||
|
| Russian | 2/15 | 14/15 |
|
||||||
|
| length (≤120 chars, ≤16 words) | 13/15 | 15/15 |
|
||||||
|
| feminine self-reference | 15/15 | 15/15 |
|
||||||
|
| no cringe | 13/15 | 15/15 |
|
||||||
|
| on topic | 6/15 | 13/15 |
|
||||||
|
| p50 latency | 11.4s | 11.4s |
|
||||||
|
|
||||||
|
Latency did not move and is not good. 11s to word one nudge on this box.
|
||||||
|
|
||||||
|
## The bug reproduced
|
||||||
|
|
||||||
|
Yes, exactly as reported. 7 of 15 messages were the literal string `"..."`, and one was
|
||||||
|
`"full voice message"`. Both are text copied straight out of the prompt.
|
||||||
|
|
||||||
|
The system prompt said:
|
||||||
|
|
||||||
|
```
|
||||||
|
Respond ONLY with valid JSON: {"response": "full voice message", "mood": "neutral"}
|
||||||
|
```
|
||||||
|
|
||||||
|
and the user prompt said:
|
||||||
|
|
||||||
|
```
|
||||||
|
Respond as JSON: {"response": "...", "mood": "..."}
|
||||||
|
```
|
||||||
|
|
||||||
|
A 0.8B does not read `"..."` as "put your answer here". It reads it as the answer. The
|
||||||
|
prompt was a worked example whose worked part was blank, so the model filled the slot by
|
||||||
|
copying. This is the whole of finding 1.
|
||||||
|
|
||||||
|
## What else was wrong
|
||||||
|
|
||||||
|
Four separate faults, all prompt-side:
|
||||||
|
|
||||||
|
1. **Placeholder echo** (7 cases) — above.
|
||||||
|
2. **Wrong language** (13/15 failed the language check). The prompt was entirely English
|
||||||
|
and said "in the user's language (Russian or English)". The model picked English. It is
|
||||||
|
never English: the nudge is spoken by a Russian piper voice.
|
||||||
|
3. **Rule names are English identifiers.** `netdata_critical`, `service_down`, `break` went
|
||||||
|
into the prompt raw. The model cannot nudge about a topic it has not been told in words,
|
||||||
|
so 9/15 were off topic. The daemon knows what its own rules mean; now it says so.
|
||||||
|
4. **Mood invented** (`"warm"`, twice). The enum was listed in a parenthesis at the end of
|
||||||
|
an English sentence. Now it is its own line: "ровно одно из: neutral, happy, thinking,
|
||||||
|
tired, confused."
|
||||||
|
|
||||||
|
Plus two non-prompt faults the run exposed:
|
||||||
|
|
||||||
|
- **The no-parse fallback was English.** When the model returned nothing usable, the body
|
||||||
|
became `fmt.Sprintf("%s — %s", rule, sev)` — `"water — care"` — and that string went to
|
||||||
|
a Russian TTS. Now it falls back to plain Russian.
|
||||||
|
- **Durations were English.** `humanDur` returns "3 hours"; it was landing verbatim inside
|
||||||
|
Russian sentences. Nudges now use a Russian formatter.
|
||||||
|
|
||||||
|
## Three iterations, and what each taught
|
||||||
|
|
||||||
|
| | score | change |
|
||||||
|
|---|---|---|
|
||||||
|
| baseline | 0/15 | — |
|
||||||
|
| iter 1 | 2/15 | Russian prompt, filled-in examples, Russian durations |
|
||||||
|
| iter 2 | 11/15 | required keyword per rule, one example instead of five, Russian fallback |
|
||||||
|
| iter 3 | **13/15** | examples moved to topics that are not rules |
|
||||||
|
|
||||||
|
The interesting step is 1 → 2. Fixing the placeholder did not fix the disease, it moved it:
|
||||||
|
the model stopped copying `"..."` and started copying my first example instead. Five nudges
|
||||||
|
in a row came back as `"Ты не пил воду три часа. Налей стакан."` regardless of the rule.
|
||||||
|
|
||||||
|
**A small model copies the nearest concrete text in its prompt.** That is one failure mode
|
||||||
|
with two symptoms. The fix that stuck was making the examples about laundry and a laptop
|
||||||
|
battery — topics no rule ever produces, so copying them is visible in the score rather than
|
||||||
|
invisibly passing the water cases.
|
||||||
|
|
||||||
|
## Do not oversell 13/15
|
||||||
|
|
||||||
|
Seven of the thirteen passes are the **deterministic fallback**, not the model:
|
||||||
|
`"Напоминаю: таблетки."`, `"Сервис не отвечает."`, `"Критический алярм: проверь диск."`,
|
||||||
|
`"Ты давно не пил воду."`. Those are strings this commit added to Go. The model returned
|
||||||
|
nothing parseable and the fallback scored.
|
||||||
|
|
||||||
|
So the honest reading is roughly **6/15 from the model, 7/15 from a fallback, 2/15 failing**.
|
||||||
|
The prompt fix is real — `"..."` is nearly gone and the language and mood checks are clean —
|
||||||
|
but a large part of the jump is that failure now degrades into Russian instead of into
|
||||||
|
`"water — care"`. That is a genuine improvement for the operator and a weak one for the model.
|
||||||
|
|
||||||
|
The two remaining failures: one `"..."` recurrence (`routine-stretch`) and one meal nudge
|
||||||
|
that never says food.
|
||||||
|
|
||||||
|
## Broken, found, not fixed
|
||||||
|
|
||||||
|
1. ~~**`checkFeminine` only catches half the constraint.**~~ **Fixed** (#381). It scanned for
|
||||||
|
masculine self-reference only, so three messages that addressed the *owner* in the feminine
|
||||||
|
("ты давно не отдыхал**а**") scored clean. There is now a second check, `hisgender`: a
|
||||||
|
feminine past-tense verb (-ла/-лась) in a sentence addressed to him ("ты", "тебе", "твой")
|
||||||
|
fails, unless the verb is hers ("я заметила", "напомнила тебе"). It is a suffix rule, not a
|
||||||
|
parser — see the comment in `checks.go` for what it misses. A fresh 15-case run after adding
|
||||||
|
it scored **12/15** with `hisgender` 15/15; the model did not repeat the feminine address in
|
||||||
|
that sample, and the check is pinned by unit tests on the recorded bad strings instead.
|
||||||
|
2. **Grammar is not checked at all, and it is bad.** `"Он не ел 11 дней"` (it was 11 hours),
|
||||||
|
`"Сонуждились 7 дней"` (not a word), `"Они забыли воду"` (wrong person entirely). Every
|
||||||
|
one of these passes all six checks. The fixture measures properties, not fluency, and at
|
||||||
|
0.8B fluency is the binding constraint.
|
||||||
|
3. **Unit confusion.** The model turns hours into days about a third of the time. The
|
||||||
|
prompt now says "11 ч"; it reads it as days.
|
||||||
|
4. **11s p50.** Unchanged and untouched here. A nudge the model takes eleven seconds to
|
||||||
|
word has missed its moment. Worth its own task.
|
||||||
|
5. **The keyword hint is close to teaching to the test.** `ruleKeywords` names the word the
|
||||||
|
on-topic check looks for. It is defensible — the daemon genuinely knows its rule topics
|
||||||
|
and the model genuinely cannot infer them from `netdata_critical` — but the on-topic
|
||||||
|
number is softer than the others because of it.
|
||||||
|
|
||||||
|
## Next steps
|
||||||
|
|
||||||
|
1. ~~**Add a second-person gender check**~~ — done, `hisgender` in `checks.go` (#381).
|
||||||
|
2. **Decide whether the fallback should count as a pass.** Right now `Score` cannot tell a
|
||||||
|
model answer from a fallback. Either mark fallback bodies in `PhrasedNudge` or count them
|
||||||
|
in their own column. Without that, any future prompt change can score well by failing
|
||||||
|
more.
|
||||||
|
3. **Attack the 11s.** Nudge phrasing is short and non-interactive; thinking off is the first
|
||||||
|
thing to try, as it was for routing (#376).
|
||||||
|
4. **Re-measure when #122 lands.** The CPT'd Qwen3-1.7B is the target. 13/15 with seven
|
||||||
|
fallbacks is the floor it has to beat, and the fluency problems above are the ones a
|
||||||
|
bigger, Russian-trained checkpoint should actually fix.
|
||||||
@@ -75,6 +75,14 @@ same vector. A note is indexed in both places with the same embedding, so if it
|
|||||||
`QueryNotes` it fails again here — the branch can only ever return a **fact**. Its comment calls it
|
`QueryNotes` it fails again here — the branch can only ever return a **fact**. Its comment calls it
|
||||||
"additive"; for notes it is not.
|
"additive"; for notes it is not.
|
||||||
|
|
||||||
|
**Fixed (Vikunja #373).** The memory pass now runs *first*, as one search over notes and facts with
|
||||||
|
one gate, so whichever memory is clearly the best match answers — note or fact. The notes-only pass
|
||||||
|
stays behind it for notes the vector index does not hold. No threshold changed, so the set of
|
||||||
|
questions Maven answers is the same; only which memory answers them. The fixture gained two mixed
|
||||||
|
note+fact cases (`ru-mixed-031`, `ru-mixed-032`), which is why the counts below are out of 27
|
||||||
|
answerable cases and not 25: hash recall@1 36.0% (9/25) → 37.0% (10/27), e5 recall@1 72.0% (18/25) →
|
||||||
|
70.4% (19/27) with answered-after-gate 68.0% → 66.7% and false recall unchanged at 1/5.
|
||||||
|
|
||||||
### 5. Ranking has no recency or type signal, and the store is not the bottleneck
|
### 5. Ranking has no recency or type signal, and the store is not the bottleneck
|
||||||
|
|
||||||
`internal/store/notes.go:67` sorts by cosine and uses `ts` only to break an exact float tie, which
|
`internal/store/notes.go:67` sorts by cosine and uses `ts` only to break an exact float tie, which
|
||||||
@@ -143,14 +151,97 @@ the vector memory table was written by the old model, so after this deploy they
|
|||||||
against a new query. A live database needs every note and fact re-embedded before recall works at
|
against a new query. A live database needs every note and fact re-embedded before recall works at
|
||||||
all. Filed as its own task.
|
all. Filed as its own task.
|
||||||
|
|
||||||
|
## Margin gate — 31-07-2026, third run
|
||||||
|
|
||||||
|
Next-steps item 3, done. The absolute gate is replaced by a **margin gate**: answer only when the
|
||||||
|
top hit beats the runner-up by more than delta (`top1 − top2 > δ`). Same fixture, same e5 embedder,
|
||||||
|
same store as the run above. `internal/memory/gate.go` holds the check; both read paths call it
|
||||||
|
(`cmd/mavend/recall.go` and the notes-RAG branch in `voice.go`). New knob `voice.query_min_margin`
|
||||||
|
in `deploy/mavend.json`, default 0.008.
|
||||||
|
|
||||||
|
### Why the absolute gate could not work, in one line of data
|
||||||
|
|
||||||
|
The harness now prints the margin distributions, and they barely overlap where the raw scores
|
||||||
|
overlap completely:
|
||||||
|
|
||||||
|
| | top-1 score | margin (top1 − top2) |
|
||||||
|
|---|---|---|
|
||||||
|
| right note first (n=18) | min 0.810, median 0.862, max 0.890 | min 0.001, median 0.029, max 0.053 |
|
||||||
|
| must stay silent (n=5) | min 0.795, median 0.815, max 0.835 | min 0.000, median 0.002, **max 0.019** |
|
||||||
|
|
||||||
|
Four of the five must-be-silent cases have a margin at or under 0.002 — when there is nothing to
|
||||||
|
recall, e5 finds several notes equally close and no clear winner. That is the signal the absolute
|
||||||
|
score throws away.
|
||||||
|
|
||||||
|
### The delta sweep
|
||||||
|
|
||||||
|
Absolute gate held at 0.55 throughout.
|
||||||
|
|
||||||
|
```
|
||||||
|
delta 0.000: answered 18/25 (72%) false recall 5/5
|
||||||
|
delta 0.002: answered 17/25 (68%) false recall 3/5
|
||||||
|
delta 0.005: answered 17/25 (68%) false recall 2/5
|
||||||
|
delta 0.008: answered 17/25 (68%) false recall 1/5 <- chosen
|
||||||
|
delta 0.010: answered 15/25 (60%) false recall 1/5
|
||||||
|
delta 0.012: answered 14/25 (56%) false recall 1/5
|
||||||
|
delta 0.015: answered 12/25 (48%) false recall 1/5
|
||||||
|
delta 0.020: answered 11/25 (44%) false recall 0/5
|
||||||
|
delta 0.025: answered 9/25 (36%) false recall 0/5
|
||||||
|
delta 0.030: answered 8/25 (32%) false recall 0/5
|
||||||
|
delta 0.040: answered 4/25 (16%) false recall 0/5
|
||||||
|
delta 0.050: answered 2/25 ( 8%) false recall 0/5
|
||||||
|
delta 0.060: answered 0/25 ( 0%) false recall 0/5
|
||||||
|
```
|
||||||
|
|
||||||
|
### Chosen: δ = 0.008
|
||||||
|
|
||||||
|
It is the best point on the frontier, not a taste call. **0.008 dominates 0.010, 0.012 and 0.015
|
||||||
|
outright** — same 1/5 false recall, 8 to 20 points more real recall. Everything below it buys recall
|
||||||
|
back only by admitting more false recalls (0.005 → 2/5, 0.002 → 3/5). The next real improvement is
|
||||||
|
0.020 at 0/5 false, and it costs 24 points of recall to get there.
|
||||||
|
|
||||||
|
The brief's bar was "recall above 60% with false recall at 1/5 or better". 0.008 clears it with room:
|
||||||
|
68% and 1/5.
|
||||||
|
|
||||||
|
### Before / after
|
||||||
|
|
||||||
|
| | absolute gate 0.55 (previous) | margin gate δ=0.008 |
|
||||||
|
|---|---|---|
|
||||||
|
| recall@1 (ranking, ungated) | 72.0% (18/25) | 72.0% (18/25) — unchanged, the gate does not rank |
|
||||||
|
| **answered after the gate** | 72.0% (18/25) | **68.0% (17/25)** |
|
||||||
|
| **false recall** | **5/5 (100%)** | **1/5 (20%)** |
|
||||||
|
| fixture cases passed | 18/30 | **21/30** |
|
||||||
|
|
||||||
|
Four false recalls removed for one real answer. That is the trade the spec asks for — she is not a
|
||||||
|
guesser-of-truth. The one survivor is `en-pref-025` ("should i be offered wine"), which recalls a
|
||||||
|
filler note at 0.796 with a 0.019 margin: the widest silent-case margin in the fixture, and it sits
|
||||||
|
inside the real-recall range, so no delta removes it without taking real answers with it.
|
||||||
|
|
||||||
|
### Does the absolute cutoff still earn its keep? Marginally — kept
|
||||||
|
|
||||||
|
On this fixture with e5 it is a **no-op**: the lowest right-note score is 0.791, so 0.55 rejects
|
||||||
|
nothing the margin does not already reject. It is kept for two reasons, neither glamorous. It still
|
||||||
|
does real work for the hash embedder (its own sweep shows answers dropping from 16% to 0% between
|
||||||
|
0.30 and 0.50), and it is the only thing standing between the user and a reply built from a store
|
||||||
|
where everything is far away but one row happens to be a little less far — a near-empty database, or
|
||||||
|
the stale-vector case below. Cheap insurance, no measured cost. If a later embedder makes it bite,
|
||||||
|
the sweep is one command.
|
||||||
|
|
||||||
|
### Caveat on the numbers
|
||||||
|
|
||||||
|
Five must-be-silent cases is a thin basis for a 4-point decision. 1/5 and 2/5 differ by one case.
|
||||||
|
The shape of the frontier is trustworthy — margins separate, absolute scores do not — but δ=0.008
|
||||||
|
itself should be re-read off a bigger fixture (next-steps item 6) before anyone defends the third
|
||||||
|
decimal.
|
||||||
|
|
||||||
## Next steps — ordered by value-to-risk; nothing here is a decision
|
## Next steps — ordered by value-to-risk; nothing here is a decision
|
||||||
|
|
||||||
1. **Swap the embedder to `multilingual-e5-small` with `query:`/`passage:` prefixes.** One config
|
1. **Swap the embedder to `multilingual-e5-small` with `query:`/`passage:` prefixes.** One config
|
||||||
change plus a prefix in `onnxembedder.go`, re-measurable in one command.
|
change plus a prefix in `onnxembedder.go`, re-measurable in one command.
|
||||||
2. **Re-run `make eval-recall`, then set the gate from the sweep** — not before. Any
|
2. **Re-run `make eval-recall`, then set the gate from the sweep** — not before. Any
|
||||||
`query_min_score` picked against today's embedder describes a model on its way out.
|
`query_min_score` picked against today's embedder describes a model on its way out.
|
||||||
3. **Replace the absolute-score gate with a margin gate** (`top1 − top2 > δ`) — as the routing eval
|
3. ~~**Replace the absolute-score gate with a margin gate**~~ — done, see the section above.
|
||||||
concluded, absolute cosine cannot see a flat distribution.
|
δ=0.008, false recall 5/5 → 1/5.
|
||||||
4. **Delete or repair the dead `memStore` branch** at `voice.go:776` — search before the gate,
|
4. **Delete or repair the dead `memStore` branch** at `voice.go:776` — search before the gate,
|
||||||
gate it separately, or restrict it to facts and say so.
|
gate it separately, or restrict it to facts and say so.
|
||||||
5. **Add a mild time decay to ranking** — the newest statement of a preference is the true one.
|
5. **Add a mild time decay to ranking** — the newest statement of a preference is the true one.
|
||||||
|
|||||||
+108
-10
@@ -66,15 +66,113 @@ Three things this run settles:
|
|||||||
`запиши что…` phrasings toward fact, and that suspicion stands — all five `ru-note-*`
|
`запиши что…` phrasings toward fact, and that suspicion stands — all five `ru-note-*`
|
||||||
cases now land on fact. Tracked as Vikunja #375.
|
cases now land on fact. Tracked as Vikunja #375.
|
||||||
|
|
||||||
**Thinking off is the best configuration measured so far**, on both accuracy and latency
|
The `thinking off` column above read as the best configuration measured so far (Vikunja #376).
|
||||||
(Vikunja #376). That is worth understanding before flipping: routing is a short
|
**It was wrong** — see the controlled re-run below. Ignore that column.
|
||||||
classification into a fixed enum with grammar-constrained output, so there is little to
|
|
||||||
reason about, and the thinking trace mostly gives a small model room to talk itself out of
|
|
||||||
the right answer. Phrasing is a different job and needs measuring separately.
|
|
||||||
|
|
||||||
Still `6 / 6` missed clarify — the router has no way to say "I don't know" (Vikunja #359).
|
Still `6 / 6` missed clarify — the router has no way to say "I don't know" (Vikunja #359).
|
||||||
That is unchanged by anything here.
|
That is unchanged by anything here.
|
||||||
|
|
||||||
|
## Thinking off — 31-07-2026, controlled re-run (Vikunja #376)
|
||||||
|
|
||||||
|
The "thinking off wins by 6 points" observation above **does not hold**. It was a measurement
|
||||||
|
artefact, and the earlier table's `thinking off` column should be ignored.
|
||||||
|
|
||||||
|
The thinking-off variant was scored by a hand-rolled HTTP client living in the test file
|
||||||
|
instead of `llm.Client`. That copy did not send `repeat_penalty`, which the real router does
|
||||||
|
send (`routeRepeatPenalty = 1.15`). So the two columns differed on two axes at once, and the
|
||||||
|
one that mattered was the penalty, not the thinking mode.
|
||||||
|
|
||||||
|
Re-measured with everything else held equal — same fixture, same prompt, same grammar, same
|
||||||
|
sampling, same idle box, the three configurations run back to back and never concurrently:
|
||||||
|
|
||||||
|
| | llm-only, thinking on | llm-only, thinking off | cascade+llm |
|
||||||
|
|---|---|---|---|
|
||||||
|
| intent-only accuracy | 59.2% (45/76) | 59.2% (45/76) | 61.8% (47/76) |
|
||||||
|
| full accuracy (intent+slots+gate) | 38.2% (29/76) | 38.2% (29/76) | 57.9% (44/76) |
|
||||||
|
| route errors | 3 | 3 | 0 |
|
||||||
|
| grammar violations | 3 (all 3 route errors) | 3 (same 3 cases) | 0 |
|
||||||
|
| missed clarify | 5 / 6 | 5 / 6 | 5 / 6 |
|
||||||
|
| p50 latency | 836ms | 920ms | 810ms |
|
||||||
|
| p95 latency | 1.41s | 2.00s | 1.31s |
|
||||||
|
|
||||||
|
Thinking off is not just a tie on the headline numbers — it is identical case for case, with
|
||||||
|
the same confusion matrix and the same three unparseable replies. The latency difference is
|
||||||
|
run-to-run noise on one box, and it points the wrong way here.
|
||||||
|
|
||||||
|
The reason is simpler than any accuracy argument: **this llama-server build ignores the
|
||||||
|
request-level thinking switch for this model.** Probed directly against the running server
|
||||||
|
with `chat_template_kwargs.enable_thinking = false`, `chat_template_kwargs.thinking = false`
|
||||||
|
and top-level `reasoning_budget = 0` — all three return a byte-identical answer with the
|
||||||
|
thinking trace still in `reasoning_content`, and the server reports the prompt prefix as
|
||||||
|
cached, meaning the rendered template did not change. There was never anything being turned
|
||||||
|
off, which is also why the numbers match exactly.
|
||||||
|
|
||||||
|
Nothing was defaulted. `internal/llm` still has no `chat_template_kwargs` field, `VoiceConfig`
|
||||||
|
has no thinking flag, and `deploy/mavend.json` is unchanged. The misleading third
|
||||||
|
configuration is removed from `internal/router/eval` so the table it produced cannot be quoted
|
||||||
|
again.
|
||||||
|
|
||||||
|
Two caveats worth saying out loud:
|
||||||
|
|
||||||
|
- **The fixture is 76 cases.** A 6-point difference on 76 cases is roughly 4-5 cases and would
|
||||||
|
not have been worth trusting even if it had reproduced. This one was exactly 0 cases, which
|
||||||
|
is a much easier call.
|
||||||
|
- **This is one server build and one checkpoint** (`b9351`, Qwen3.5-0.8B Q4_K_M). If the
|
||||||
|
#122 checkpoint or a newer llama.cpp does honour the switch, the question reopens — but it
|
||||||
|
reopens as an unmeasured question, not as a 6-point win.
|
||||||
|
|
||||||
|
Phrasing was **not** measured. Whether thinking helps there is still open, and now also blocked
|
||||||
|
on the same "can we even turn it off" question.
|
||||||
|
|
||||||
|
## Clock and calendar rule — 31-07-2026 (Vikunja #374)
|
||||||
|
|
||||||
|
`routeSystem` never said whether "который час" or "какое число завтра" are `system` or
|
||||||
|
`query`, and `system→query ×4` showed up in every run. The rule added says: the clock and the
|
||||||
|
calendar date themselves are `system`; what is *written in* the calendar or in memory
|
||||||
|
("что у меня завтра", "какие есть напоминания") stays `query`; and a time named inside a
|
||||||
|
request ("напомни завтра…") is just a detail of the request, not a reason for `system`.
|
||||||
|
|
||||||
|
That split is not a preference. In `cmd/mavend/voice.go` only `replySystem` owns the clock and
|
||||||
|
the date formatter, so a clock question routed to `query` falls into the embedder + note RAG
|
||||||
|
and answers "не знаю". The agenda, on the other hand, is answered by `ParseCalendarDate` +
|
||||||
|
`CalendarEvents` *inside* the `query` branch, so that side has to stay `query`. The rule sits
|
||||||
|
above the question test because every one of these utterances carries a question word and a
|
||||||
|
later rule would never be reached.
|
||||||
|
|
||||||
|
The fixture is now 77 cases: one calendar-agenda case was added
|
||||||
|
(`ru-query-019` "что у меня стоит в календаре на послезавтра", intent `query`) specifically so
|
||||||
|
an over-broad system rule cannot pass unnoticed. The clock/date cases (`ru-sys-001/002/005`,
|
||||||
|
`en-sys-001`) already existed.
|
||||||
|
|
||||||
|
Three runs, same box, back to back, never concurrently:
|
||||||
|
|
||||||
|
| | baseline | first rule (too broad) | rule as committed |
|
||||||
|
|---|---|---|---|
|
||||||
|
| llm-only intent-only | 59.2% (45/76) | 54.5% (42/77) | 59.7% (46/77) |
|
||||||
|
| llm-only full | 38.2% | 35.1% | 39.0% |
|
||||||
|
| llm-only route errors | 3 | 4 | 5 |
|
||||||
|
| llm-only p50 | 1.09s | 0.91s | 0.93s |
|
||||||
|
| cascade+llm intent-only | 61.8% (47/76) | 58.4% | 62.3% (48/77) |
|
||||||
|
| cascade+llm full | 57.9% | 54.5% | 59.7% |
|
||||||
|
| cascade+llm route errors | 0 | 0 | 0 |
|
||||||
|
| cascade+llm p50 | 0.91s | 0.80s | 1.04s |
|
||||||
|
|
||||||
|
**The targeted bug is fixed and the headline number did not move.** `system→query ×4` is gone
|
||||||
|
in both LLM configurations — the `time` and `date` tags go from 0/2 and 0/2 to 2/2 and 2/2 —
|
||||||
|
but the model then over-applies the rule, and `query→system ×5` plus `reminder→system ×2`
|
||||||
|
appear where they did not exist before. Net accuracy is a wash, inside the noise of a 77-case
|
||||||
|
fixture.
|
||||||
|
|
||||||
|
The first attempt is shown because it is the honest history: it said "спрашивает время, дату
|
||||||
|
или день недели → system" with no scope, which swept up reminders, and it cost 3-5 points. It
|
||||||
|
was tightened once, on the reasoning that a rule capturing "напомни завтра в 7" is simply
|
||||||
|
wrong, and not tuned further. The remaining `query/reminder → system` over-trigger is a new,
|
||||||
|
separate weakness of the sub-1B model and deserves its own task rather than more prompt
|
||||||
|
kneading against a held-out fixture.
|
||||||
|
|
||||||
|
The rule is kept. It is correct about what the daemon can answer, and the failure it replaces
|
||||||
|
was silent ("не знаю" to "который час") while the one it introduces is loud.
|
||||||
|
|
||||||
## Findings
|
## Findings
|
||||||
|
|
||||||
### 1. The resident model does route better — 50.0% vs 36.8%
|
### 1. The resident model does route better — 50.0% vs 36.8%
|
||||||
@@ -145,11 +243,11 @@ Note the grammar's `string ::= "\"" ([^"\\] | "\\" .)* "\""` is unbounded, so no
|
|||||||
|
|
||||||
### 7. Two hypotheses tested and closed
|
### 7. Two hypotheses tested and closed
|
||||||
|
|
||||||
- **Thinking mode is a non-issue.** Qwen3.5's template defaults `thinking = 1`, so
|
- **Thinking mode is a non-issue.** Confirmed twice now, the second time properly — see the
|
||||||
grammar-constrained JSON lands in `reasoning_content` with `content` empty —
|
controlled re-run section. Grammar-constrained JSON lands in `reasoning_content` with
|
||||||
`llm.Client`'s fallback handles it. A `thinking off` run scored *identically* (18/76,
|
`content` empty and `llm.Client`'s fallback handles it; the request-level switch does
|
||||||
48.7%, same p50). `internal/llm` deliberately does **not** grow a `chat_template_kwargs`
|
nothing on this build. `internal/llm` deliberately does **not** grow a
|
||||||
field.
|
`chat_template_kwargs` field.
|
||||||
- **Runaway array repetition does not reproduce.** An isolated smoke test with a stripped
|
- **Runaway array repetition does not reproduce.** An isolated smoke test with a stripped
|
||||||
grammar emitted `{"intent":"reminder"}` until `MaxTokens`; under the real `routeSystem`
|
grammar emitted `{"intent":"reminder"}` until `MaxTokens`; under the real `routeSystem`
|
||||||
prompt the few-shot examples anchor it to one object. 2 errors in 76, not 76.
|
prompt the few-shot examples anchor it to one object. 2 errors in 76, not 76.
|
||||||
|
|||||||
+78
-17
@@ -40,9 +40,44 @@ var clarifyQuestions = map[dialogue.Slot]string{
|
|||||||
dialogue.SlotFn: "Что сделать?",
|
dialogue.SlotFn: "Что сделать?",
|
||||||
}
|
}
|
||||||
|
|
||||||
// clarifyDropped — she asked once, the answer still did not fill the gap, so
|
// clarifyGaveUp — she is out of questions and still does not have the slot. She
|
||||||
// the request is gone. Said plainly, once, with no second question.
|
// says so out loud: dropping the request in silence would leave him thinking it
|
||||||
const clarifyDropped = "Не разобрала — скажи целиком, пожалуйста."
|
// landed. Feminine self-reference ("поняла"), as everywhere.
|
||||||
|
const clarifyGaveUp = "Прости, я не поняла. Скажи, пожалуйста, по-другому."
|
||||||
|
|
||||||
|
// clarifyExpired — his answer came after the TTL, so the parked request is
|
||||||
|
// already gone. Same tone as clarifyGaveUp, different reason: too much time
|
||||||
|
// passed, not "I did not understand". Feminine self-reference ("ждала",
|
||||||
|
// "отпустила"); he is addressed with a plain imperative.
|
||||||
|
const clarifyExpired = "Прости, я слишком долго ждала ответа и отпустила прошлую просьбу. Если она ещё нужна, скажи заново."
|
||||||
|
|
||||||
|
// clarifyExpiredNotice returns that line when a parked question had just timed
|
||||||
|
// out, and "" when nothing was parked. Call it right after
|
||||||
|
// resolveClarifyAnswer: a live question is answered there, an expired one is
|
||||||
|
// only reported here — the words themselves still go on to be routed fresh.
|
||||||
|
func (h *reactiveHandler) clarifyExpiredNotice() string {
|
||||||
|
if h.clarifyStore == nil {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
if !h.clarifyStore.TakeExpired(voiceDialogueID, h.now()) {
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
log.Printf("voice: clarify — parked question expired, telling him and routing the words fresh")
|
||||||
|
return clarifyExpired
|
||||||
|
}
|
||||||
|
|
||||||
|
// withNotice glues the expiry notice in front of this turn's reply. One turn
|
||||||
|
// carries one reply on the wire, so the notice cannot be a message of its own —
|
||||||
|
// but neither the notice nor the fresh answer may be dropped.
|
||||||
|
func withNotice(notice, reply string) string {
|
||||||
|
if notice == "" {
|
||||||
|
return reply
|
||||||
|
}
|
||||||
|
if reply == "" {
|
||||||
|
return notice
|
||||||
|
}
|
||||||
|
return notice + " " + reply
|
||||||
|
}
|
||||||
|
|
||||||
// missingFor returns the slots a decision still needs, most important first.
|
// missingFor returns the slots a decision still needs, most important first.
|
||||||
// Empty ⇒ there is nothing identifiable to ask about.
|
// Empty ⇒ there is nothing identifiable to ask about.
|
||||||
@@ -79,13 +114,14 @@ func (h *reactiveHandler) askClarify(dec router.Decision) (string, bool) {
|
|||||||
return "", false
|
return "", false
|
||||||
}
|
}
|
||||||
h.clarifyStore.Put(voiceDialogueID, &dialogue.PendingQuestion{
|
h.clarifyStore.Put(voiceDialogueID, &dialogue.PendingQuestion{
|
||||||
Intent: dialogue.Intent(dec.Intent),
|
Intent: dialogue.Intent(dec.Intent),
|
||||||
Slots: toDialogueSlots(dec.Slots),
|
Slots: toDialogueSlots(dec.Slots),
|
||||||
Missing: []dialogue.Slot{slot},
|
Missing: []dialogue.Slot{slot},
|
||||||
Utterance: dec.Utterance,
|
Utterance: dec.Utterance,
|
||||||
Asked: h.now(),
|
Asked: h.now(),
|
||||||
TTL: clarifyTTL,
|
TTL: clarifyTTL,
|
||||||
Attempts: 1, // asked once; MaxAttempts is 1, so there is no second ask
|
Attempts: 1, // this ask
|
||||||
|
MaxAttempts: h.clarifyMaxAttempts,
|
||||||
})
|
})
|
||||||
log.Printf("voice: clarify — asked about %s for intent=%s", slot, dec.Intent)
|
log.Printf("voice: clarify — asked about %s for intent=%s", slot, dec.Intent)
|
||||||
return question, true
|
return question, true
|
||||||
@@ -97,8 +133,9 @@ func (h *reactiveHandler) askClarify(dec router.Decision) (string, bool) {
|
|||||||
// resolveConfirm and checked in the same place.
|
// resolveConfirm and checked in the same place.
|
||||||
//
|
//
|
||||||
// The answer is parsed with the same extractor the router uses, for the intent
|
// The answer is parsed with the same extractor the router uses, for the intent
|
||||||
// she parked — no second parser. If it still does not fill the gap the request
|
// she parked — no second parser. If it still does not fill the gap she asks
|
||||||
// is dropped: she does not ask again.
|
// again, up to MaxAttempts; after that she says out loud that she did not
|
||||||
|
// understand. She never drops the request in silence.
|
||||||
func (h *reactiveHandler) resolveClarifyAnswer(ctx context.Context, text string) (string, bool) {
|
func (h *reactiveHandler) resolveClarifyAnswer(ctx context.Context, text string) (string, bool) {
|
||||||
if h.clarifyStore == nil {
|
if h.clarifyStore == nil {
|
||||||
return "", false
|
return "", false
|
||||||
@@ -107,17 +144,14 @@ func (h *reactiveHandler) resolveClarifyAnswer(ctx context.Context, text string)
|
|||||||
if q == nil {
|
if q == nil {
|
||||||
return "", false
|
return "", false
|
||||||
}
|
}
|
||||||
// One shot either way: the question is consumed whether or not the answer
|
|
||||||
// works, so a failed answer can't leave the question armed.
|
|
||||||
h.clarifyStore.Delete(voiceDialogueID)
|
|
||||||
|
|
||||||
intent := router.Intent(q.Intent)
|
intent := router.Intent(q.Intent)
|
||||||
answer := h.extractor.Extract(ctx, intent, text, h.now())
|
answer := h.extractor.Extract(ctx, intent, text, h.now())
|
||||||
merged := q.Answer(text, toDialogueSlots(answer))
|
merged := q.Answer(text, toDialogueSlots(answer))
|
||||||
if len(dialogue.StillMissing(q.Missing, merged)) > 0 {
|
if len(dialogue.StillMissing(q.Missing, merged)) > 0 {
|
||||||
log.Printf("voice: clarify — answer %q did not fill %v, dropping", text, q.Missing)
|
return h.reaskOrGiveUp(q, merged, text), true
|
||||||
return clarifyDropped, true
|
|
||||||
}
|
}
|
||||||
|
h.clarifyStore.Delete(voiceDialogueID)
|
||||||
|
|
||||||
// Rebuild the decision as if it had routed cleanly, then run it down the
|
// Rebuild the decision as if it had routed cleanly, then run it down the
|
||||||
// normal path. Clarify is deliberately false and the intent is unchanged:
|
// normal path. Clarify is deliberately false and the intent is unchanged:
|
||||||
@@ -133,6 +167,29 @@ func (h *reactiveHandler) resolveClarifyAnswer(ctx context.Context, text string)
|
|||||||
return h.finishClarified(ctx, dec), true
|
return h.finishClarified(ctx, dec), true
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// reaskOrGiveUp handles an answer that left the gap open: ask the same question
|
||||||
|
// again while she has attempts left, otherwise say she did not understand and
|
||||||
|
// let the request go. Never returns "" — a mute give-up reads as "done".
|
||||||
|
func (h *reactiveHandler) reaskOrGiveUp(q *dialogue.PendingQuestion, merged dialogue.Slots, text string) string {
|
||||||
|
question := ""
|
||||||
|
if len(q.Missing) > 0 {
|
||||||
|
question = clarifyQuestions[q.Missing[0]]
|
||||||
|
}
|
||||||
|
if question == "" || !q.CanAsk() {
|
||||||
|
h.clarifyStore.Delete(voiceDialogueID)
|
||||||
|
log.Printf("voice: clarify — gave up on %v after %d question(s), answer was %q", q.Missing, q.Attempts, text)
|
||||||
|
return clarifyGaveUp
|
||||||
|
}
|
||||||
|
// Re-park with whatever the answer DID give, the clock restarted and one
|
||||||
|
// more question spent.
|
||||||
|
q.Slots = merged
|
||||||
|
q.Attempts++
|
||||||
|
q.Asked = h.now()
|
||||||
|
h.clarifyStore.Put(voiceDialogueID, q)
|
||||||
|
log.Printf("voice: clarify — answer %q did not fill %v, asking again (attempt %d)", text, q.Missing, q.Attempts)
|
||||||
|
return question
|
||||||
|
}
|
||||||
|
|
||||||
// finishClarified runs a completed decision through the same steps a freshly
|
// finishClarified runs a completed decision through the same steps a freshly
|
||||||
// routed one takes: remember the turn, act, then phrase.
|
// routed one takes: remember the turn, act, then phrase.
|
||||||
func (h *reactiveHandler) finishClarified(ctx context.Context, dec router.Decision) string {
|
func (h *reactiveHandler) finishClarified(ctx context.Context, dec router.Decision) string {
|
||||||
@@ -146,6 +203,10 @@ func (h *reactiveHandler) finishClarified(ctx context.Context, dec router.Decisi
|
|||||||
if reply == "" {
|
if reply == "" {
|
||||||
reply = h.replier.Reply(dec)
|
reply = h.replier.Reply(dec)
|
||||||
}
|
}
|
||||||
|
if reply == "" {
|
||||||
|
// Belt: an empty reply here would be a silent drop.
|
||||||
|
reply = clarifyGaveUp
|
||||||
|
}
|
||||||
return reply
|
return reply
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
+102
-11
@@ -86,7 +86,7 @@ func TestClarifyReminderCompletesOnAnswer(t *testing.T) {
|
|||||||
if !handled {
|
if !handled {
|
||||||
t.Fatal("the answer to an open question must be consumed as an answer")
|
t.Fatal("the answer to an open question must be consumed as an answer")
|
||||||
}
|
}
|
||||||
if reply == clarifyDropped {
|
if reply == clarifyGaveUp {
|
||||||
t.Fatalf("a good answer must not drop the request: %q", reply)
|
t.Fatalf("a good answer must not drop the request: %q", reply)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -111,7 +111,7 @@ func TestClarifyFactCompletesOnAnswer(t *testing.T) {
|
|||||||
if _, asked := h.askClarify(clarifyDec(router.IntentFact, router.Slots{Text: "запиши"}, "запиши")); !asked {
|
if _, asked := h.askClarify(clarifyDec(router.IntentFact, router.Slots{Text: "запиши"}, "запиши")); !asked {
|
||||||
t.Fatal("a fact with no key should be asked about")
|
t.Fatal("a fact with no key should be asked about")
|
||||||
}
|
}
|
||||||
if reply, handled := h.resolveClarifyAnswer(ctx, "пил воду"); !handled || reply == clarifyDropped {
|
if reply, handled := h.resolveClarifyAnswer(ctx, "пил воду"); !handled || reply == clarifyGaveUp {
|
||||||
t.Fatalf("answer should complete the fact, handled=%v reply=%q", handled, reply)
|
t.Fatalf("answer should complete the fact, handled=%v reply=%q", handled, reply)
|
||||||
}
|
}
|
||||||
if fact, err := st.LatestFact(ctx, "water"); err != nil || fact.Key != "water" {
|
if fact, err := st.LatestFact(ctx, "water"); err != nil || fact.Key != "water" {
|
||||||
@@ -137,26 +137,87 @@ func TestClarifyAnswerAfterTTLIsANewRequest(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestClarifyUnclearAnswerDropsWithoutAskingAgain — MaxAttempts is 1.
|
// TestClarifyAsksThreeTimesThenSaysSo — three questions are allowed, the fourth
|
||||||
func TestClarifyUnclearAnswerDropsWithoutAskingAgain(t *testing.T) {
|
// is not, and running out is SPOKEN. Silence would read as "handled".
|
||||||
|
func TestClarifyAsksThreeTimesThenSaysSo(t *testing.T) {
|
||||||
ctx := context.Background()
|
ctx := context.Background()
|
||||||
h, st, _ := newClarifyHandler(t)
|
h, st, _ := newClarifyHandler(t)
|
||||||
|
|
||||||
if _, asked := h.askClarify(clarifyDec(router.IntentReminder, router.Slots{Text: "напомни"}, "напомни")); !asked {
|
if _, asked := h.askClarify(clarifyDec(router.IntentReminder, router.Slots{Text: "напомни"}, "напомни")); !asked {
|
||||||
t.Fatal("expected a question")
|
t.Fatal("expected a first question")
|
||||||
}
|
}
|
||||||
|
// Two more unclear answers ⇒ two more questions (3 asks in total).
|
||||||
|
for i := 2; i <= 3; i++ {
|
||||||
|
reply, handled := h.resolveClarifyAnswer(ctx, "ну не знаю")
|
||||||
|
if !handled {
|
||||||
|
t.Fatalf("answer %d must be consumed as an answer", i)
|
||||||
|
}
|
||||||
|
if reply != "На когда напомнить?" {
|
||||||
|
t.Fatalf("attempt %d should ask again, got %q", i, reply)
|
||||||
|
}
|
||||||
|
if h.clarifyStore.Get(voiceDialogueID, h.now()) == nil {
|
||||||
|
t.Fatalf("attempt %d must leave the question armed", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
reply, handled := h.resolveClarifyAnswer(ctx, "ну не знаю")
|
reply, handled := h.resolveClarifyAnswer(ctx, "ну не знаю")
|
||||||
if !handled || reply != clarifyDropped {
|
if !handled || reply != clarifyGaveUp {
|
||||||
t.Fatalf("an unclear answer should drop the request, handled=%v reply=%q", handled, reply)
|
t.Fatalf("the fourth try must give up out loud, handled=%v reply=%q", handled, reply)
|
||||||
}
|
}
|
||||||
if strings.Contains(reply, "?") {
|
if reply == "" || strings.Contains(reply, "?") {
|
||||||
t.Fatalf("she must not ask a second question: %q", reply)
|
t.Fatalf("giving up must be spoken and must not be another question: %q", reply)
|
||||||
}
|
}
|
||||||
if h.clarifyStore.Get(voiceDialogueID, h.now()) != nil {
|
if h.clarifyStore.Get(voiceDialogueID, h.now()) != nil {
|
||||||
t.Fatal("a dropped request must leave no armed question")
|
t.Fatal("a given-up request must leave no armed question")
|
||||||
}
|
}
|
||||||
if reminders, err := st.DueReminders(ctx, h.now().Add(48*time.Hour)); err != nil || len(reminders) != 0 {
|
if reminders, err := st.DueReminders(ctx, h.now().Add(48*time.Hour)); err != nil || len(reminders) != 0 {
|
||||||
t.Fatalf("a dropped request must not create anything: reminders=%v err=%v", reminders, err)
|
t.Fatalf("a given-up request must not create anything: reminders=%v err=%v", reminders, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestClarifyMaxAttemptsIsConfigurable — one question when the config says one.
|
||||||
|
func TestClarifyMaxAttemptsIsConfigurable(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
h, _, _ := newClarifyHandler(t)
|
||||||
|
h.clarifyMaxAttempts = 1
|
||||||
|
|
||||||
|
if _, asked := h.askClarify(clarifyDec(router.IntentReminder, router.Slots{Text: "напомни"}, "напомни")); !asked {
|
||||||
|
t.Fatal("expected a question")
|
||||||
|
}
|
||||||
|
if reply, handled := h.resolveClarifyAnswer(ctx, "ну не знаю"); !handled || reply != clarifyGaveUp {
|
||||||
|
t.Fatalf("with max 1 she must give up at once, handled=%v reply=%q", handled, reply)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestClarifyRestatedAnswerWins — «в 11:00», then «нет, в 15:00». The second
|
||||||
|
// value is the one that lands.
|
||||||
|
func TestClarifyRestatedAnswerWins(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
h, st, _ := newClarifyHandler(t)
|
||||||
|
|
||||||
|
if _, asked := h.askClarify(clarifyDec(router.IntentReminder, router.Slots{Text: "напомни позвонить маме"}, "напомни позвонить маме")); !asked {
|
||||||
|
t.Fatal("expected a question")
|
||||||
|
}
|
||||||
|
// First answer parses, but re-park it by hand as if she had asked again:
|
||||||
|
// what matters here is that Answer prefers the newer value over the parked
|
||||||
|
// one, which is the case the daemon hits on a re-ask.
|
||||||
|
q := h.clarifyStore.Get(voiceDialogueID, h.now())
|
||||||
|
if q == nil {
|
||||||
|
t.Fatal("expected an armed question")
|
||||||
|
}
|
||||||
|
first := h.extractor.Extract(ctx, router.IntentReminder, "в 11:00", h.now())
|
||||||
|
q.Slots = q.Answer("в 11:00", toDialogueSlots(first))
|
||||||
|
|
||||||
|
if reply, handled := h.resolveClarifyAnswer(ctx, "нет, в 15:00"); !handled || reply == clarifyGaveUp {
|
||||||
|
t.Fatalf("the restated answer should complete the request, handled=%v reply=%q", handled, reply)
|
||||||
|
}
|
||||||
|
reminders, err := st.DueReminders(ctx, h.now().Add(48*time.Hour))
|
||||||
|
if err != nil || len(reminders) != 1 {
|
||||||
|
t.Fatalf("expected one reminder: %v err=%v", reminders, err)
|
||||||
|
}
|
||||||
|
want := h.extractor.Extract(ctx, router.IntentReminder, "в 15:00", h.now())
|
||||||
|
if !reminders[0].FireTs.Equal(want.Time) {
|
||||||
|
t.Fatalf("reminder at %v, want the restated %v", reminders[0].FireTs, want.Time)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -228,6 +289,36 @@ func TestNoQuestionWhenNothingIsMissing(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TestClarifyExpiryIsAnnouncedAndWordsStillRoute — his answer lands after the
|
||||||
|
// TTL: she must say the old request is gone AND still answer the new words.
|
||||||
|
func TestClarifyExpiryIsAnnouncedAndWordsStillRoute(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
h, _, now := newClarifyHandler(t)
|
||||||
|
emb := router.NewHashEmbedder(1024)
|
||||||
|
h.embedder = emb
|
||||||
|
h.router = buildRouter(emb, h.matcher, 0.55, nil)
|
||||||
|
|
||||||
|
if _, asked := h.askClarify(clarifyDec(router.IntentReminder, router.Slots{Text: "напомни"}, "напомни")); !asked {
|
||||||
|
t.Fatal("expected a question")
|
||||||
|
}
|
||||||
|
*now = now.Add(clarifyTTL + time.Second)
|
||||||
|
|
||||||
|
reply := h.handleText(ctx, "как дела")
|
||||||
|
if !strings.HasPrefix(reply, clarifyExpired) {
|
||||||
|
t.Fatalf("expired question must be announced first, got %q", reply)
|
||||||
|
}
|
||||||
|
if strings.TrimSpace(strings.TrimPrefix(reply, clarifyExpired)) == "" {
|
||||||
|
t.Fatalf("the new words must still be answered, got only the notice: %q", reply)
|
||||||
|
}
|
||||||
|
if h.clarifyStore.Get(voiceDialogueID, h.now()) != nil {
|
||||||
|
t.Fatal("the expired question must be gone")
|
||||||
|
}
|
||||||
|
// The notice is said once, not on every later utterance.
|
||||||
|
if reply := h.handleText(ctx, "как дела"); strings.Contains(reply, clarifyExpired) {
|
||||||
|
t.Fatalf("notice repeated on a later turn: %q", reply)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// TestNoPendingQuestionFallsThrough — with nothing parked, an utterance routes
|
// TestNoPendingQuestionFallsThrough — with nothing parked, an utterance routes
|
||||||
// normally.
|
// normally.
|
||||||
func TestNoPendingQuestionFallsThrough(t *testing.T) {
|
func TestNoPendingQuestionFallsThrough(t *testing.T) {
|
||||||
|
|||||||
@@ -189,7 +189,9 @@ func (l *lockedAPI) MorningStatus(ctx context.Context) ([]ipc.MorningRoutineStat
|
|||||||
func run(args []string) error {
|
func run(args []string) error {
|
||||||
cfgPath := flag.String("config", defaultConfigPath(), "path to mavend JSON config")
|
cfgPath := flag.String("config", defaultConfigPath(), "path to mavend JSON config")
|
||||||
wrappedKeyPath := flag.String("wrapped-key-file", "", "path to wrapped encryption key blob (enables cold-start unlock)")
|
wrappedKeyPath := flag.String("wrapped-key-file", "", "path to wrapped encryption key blob (enables cold-start unlock)")
|
||||||
|
reembed := flag.Bool("reembed", false, "re-embed every stored note and fact with the configured embedder, then serve normally (run once after an embedder swap)")
|
||||||
flag.CommandLine.Parse(args)
|
flag.CommandLine.Parse(args)
|
||||||
|
reembedOnStart = *reembed
|
||||||
cfg, err := config.Load(*cfgPath)
|
cfg, err := config.Load(*cfgPath)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return err
|
return err
|
||||||
|
|||||||
@@ -0,0 +1,158 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"math"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/kami/maven/internal/ipc"
|
||||||
|
"github.com/kami/maven/internal/memory"
|
||||||
|
"github.com/kami/maven/internal/phraser"
|
||||||
|
"github.com/kami/maven/internal/router"
|
||||||
|
"github.com/kami/maven/internal/voice"
|
||||||
|
)
|
||||||
|
|
||||||
|
// fixedEmbedder hands back a vector chosen per text, so a test can say exactly
|
||||||
|
// how close each stored memory is to the question. The real embedders make
|
||||||
|
// scores that are realistic but not controllable, and this test is about the
|
||||||
|
// gate, not about the embedder.
|
||||||
|
type fixedEmbedder struct{ vecs map[string][]float32 }
|
||||||
|
|
||||||
|
func (f *fixedEmbedder) Dim() int { return 4 }
|
||||||
|
func (f *fixedEmbedder) Close() error { return nil }
|
||||||
|
|
||||||
|
func (f *fixedEmbedder) Embed(_ context.Context, text string) ([]float32, error) {
|
||||||
|
v, ok := f.vecs[text]
|
||||||
|
if !ok {
|
||||||
|
return nil, fmt.Errorf("fixedEmbedder: no vector for %q", text)
|
||||||
|
}
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// scoreVec builds a unit vector whose cosine against the query vector
|
||||||
|
// (1,0,0,0) is exactly score.
|
||||||
|
func scoreVec(score float64) []float32 {
|
||||||
|
rest := math.Sqrt(1 - score*score)
|
||||||
|
return []float32{float32(score), float32(rest), 0, 0}
|
||||||
|
}
|
||||||
|
|
||||||
|
// recordingPhraser remembers what the query path handed it to phrase, which is
|
||||||
|
// how the test can tell which pass produced the answer.
|
||||||
|
type recordingPhraser struct {
|
||||||
|
*phraser.Stub
|
||||||
|
notes []string
|
||||||
|
}
|
||||||
|
|
||||||
|
func (r *recordingPhraser) PhraseQuery(ctx context.Context, utterance string, notes []string) (string, error) {
|
||||||
|
r.notes = notes
|
||||||
|
return r.Stub.PhraseQuery(ctx, utterance, notes)
|
||||||
|
}
|
||||||
|
|
||||||
|
// recallCase — one stored memory: its text, how close it is to the question,
|
||||||
|
// whether it is a note or a fact, and whether the notes table holds it too.
|
||||||
|
type recallCase struct {
|
||||||
|
text string
|
||||||
|
score float64
|
||||||
|
kind string
|
||||||
|
}
|
||||||
|
|
||||||
|
// buildRecallHandler stores the given memories and returns a handler whose
|
||||||
|
// query path can be run directly. Notes go into BOTH the notes table and the
|
||||||
|
// vector index, which is what the daemon does (voice.go's IntentNote).
|
||||||
|
func buildRecallHandler(t *testing.T, question string, mems []recallCase) (*reactiveHandler, *recordingPhraser) {
|
||||||
|
t.Helper()
|
||||||
|
ctx := context.Background()
|
||||||
|
st := newTestStore(t)
|
||||||
|
emb := &fixedEmbedder{vecs: map[string][]float32{question: {1, 0, 0, 0}}}
|
||||||
|
mem := memory.NewInMemoryStore()
|
||||||
|
now := time.Now()
|
||||||
|
|
||||||
|
for i, m := range mems {
|
||||||
|
vec := scoreVec(m.score)
|
||||||
|
emb.vecs[m.text] = vec
|
||||||
|
id := fmt.Sprintf("%s:%d", m.kind, i)
|
||||||
|
if m.kind == "note" {
|
||||||
|
if _, err := st.WriteNote(ctx, now, m.text, vec, "tap:voice"); err != nil {
|
||||||
|
t.Fatalf("WriteNote: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if err := mem.Insert(ctx, id, vec, map[string]string{"text": m.text, "type": m.kind}); err != nil {
|
||||||
|
t.Fatalf("memory insert: %v", err)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
phr := &recordingPhraser{Stub: phraser.NewStub()}
|
||||||
|
h := &reactiveHandler{
|
||||||
|
api: ipc.NewStoreAPI(st),
|
||||||
|
embedder: emb,
|
||||||
|
replier: voice.NewStubReplier(),
|
||||||
|
phraser: phr,
|
||||||
|
now: func() time.Time { return now },
|
||||||
|
memStore: mem,
|
||||||
|
dataStore: st,
|
||||||
|
queryMinScore: 0.55,
|
||||||
|
queryMinMargin: 0.008,
|
||||||
|
weatherProvider: nil,
|
||||||
|
}
|
||||||
|
return h, phr
|
||||||
|
}
|
||||||
|
|
||||||
|
func askQuery(t *testing.T, h *reactiveHandler, question string) string {
|
||||||
|
t.Helper()
|
||||||
|
return h.applyAction(context.Background(), router.Decision{
|
||||||
|
Intent: router.IntentQuery,
|
||||||
|
Utterance: question,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestQueryRecallNoteCanWin — the note-recall regression (Vikunja #373). Notes
|
||||||
|
// and facts share one vector index, and a note that clearly beats everything
|
||||||
|
// else must be the answer. Before the fix the memory pass only ran after the
|
||||||
|
// notes-only gate had already rejected the same note at the same score, so only
|
||||||
|
// a fact could ever come back from it.
|
||||||
|
func TestQueryRecallNoteCanWin(t *testing.T) {
|
||||||
|
const q = "где молоко"
|
||||||
|
|
||||||
|
t.Run("a clearly best note answers", func(t *testing.T) {
|
||||||
|
h, phr := buildRecallHandler(t, q, []recallCase{
|
||||||
|
{text: "молоко стоит в холодильнике", score: 0.90, kind: "note"},
|
||||||
|
{text: "выучил пару аккордов", score: 0.50, kind: "note"},
|
||||||
|
})
|
||||||
|
reply := askQuery(t, h, q)
|
||||||
|
if want := "вот что я нашла: молоко стоит в холодильнике"; reply != want {
|
||||||
|
t.Errorf("reply %q, want %q", reply, want)
|
||||||
|
}
|
||||||
|
// One text, the winning memory's — the answer came from the memory
|
||||||
|
// pass, not from handing the phraser every note in the table.
|
||||||
|
if len(phr.notes) != 1 || phr.notes[0] != "молоко стоит в холодильнике" {
|
||||||
|
t.Errorf("phraser got %q, want just the recalled note", phr.notes)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
// The other half of "one gate over everything": a fact that matches better
|
||||||
|
// than the best note now answers, instead of losing to a note that only had
|
||||||
|
// to beat other notes.
|
||||||
|
t.Run("the better-matching fact answers", func(t *testing.T) {
|
||||||
|
h, _ := buildRecallHandler(t, q, []recallCase{
|
||||||
|
{text: "молоко стоит в холодильнике", score: 0.80, kind: "note"},
|
||||||
|
{text: "купил молоко в среду", score: 0.95, kind: "fact"},
|
||||||
|
})
|
||||||
|
if reply := askQuery(t, h, q); reply != "купил молоко в среду" {
|
||||||
|
t.Errorf("reply %q, want the fact read back", reply)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
// The gate is untouched: two memories this close mean the embedder cannot
|
||||||
|
// tell them apart, and silence still beats a coin flip.
|
||||||
|
t.Run("no clear best stays silent", func(t *testing.T) {
|
||||||
|
h, _ := buildRecallHandler(t, q, []recallCase{
|
||||||
|
{text: "молоко стоит в холодильнике", score: 0.860, kind: "note"},
|
||||||
|
{text: "молоко закончилось", score: 0.858, kind: "note"},
|
||||||
|
})
|
||||||
|
if reply := askQuery(t, h, q); reply != "не знаю." {
|
||||||
|
t.Errorf("reply %q, want silence", reply)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
+18
-18
@@ -2,24 +2,24 @@ package main
|
|||||||
|
|
||||||
import "github.com/kami/maven/internal/memory"
|
import "github.com/kami/maven/internal/memory"
|
||||||
|
|
||||||
// bestRecall is the read side of the long-term memory store: the top hit's
|
// bestRecall is the read side of the long-term memory store: the top hit when
|
||||||
// stored text when it clears the confidence gate. This recalls across BOTH
|
// it clears the confidence gate. The index holds BOTH notes and facts, and
|
||||||
// notes and facts (facts aren't in the notes table, so this is the only path
|
// either can win — the caller looks at the returned hit's meta["type"] to see
|
||||||
// that can answer "when did I last …?" from a captured fact). A note hit here
|
// which. Facts aren't in the notes table, so this is the only path that can
|
||||||
// is redundant with the notes-RAG path — by design; the two indexes can diverge
|
// answer "when did I last …?" from a captured fact.
|
||||||
// once the backend is swapped for a persistent/external store. ok=false when
|
//
|
||||||
// there's no hit above the threshold or the hit carries no text.
|
// The whole hit is returned, not just its text, because "which memory answered"
|
||||||
func bestRecall(results []memory.Result, min float64) (string, bool) {
|
// decides how the answer is said: a note gets phrased in Maven's voice, a fact
|
||||||
if len(results) == 0 {
|
// is read back as stored.
|
||||||
return "", false
|
//
|
||||||
|
// ok=false when the hit fails the confidence gate (see memory.Confident: an
|
||||||
|
// absolute floor plus a margin over the runner-up) or carries no text.
|
||||||
|
func bestRecall(results []memory.Result, minScore, minMargin float64) (memory.Result, bool) {
|
||||||
|
if !memory.Confident(results, minScore, minMargin) {
|
||||||
|
return memory.Result{}, false
|
||||||
}
|
}
|
||||||
top := results[0]
|
if results[0].Meta["text"] == "" {
|
||||||
if top.Score < min {
|
return memory.Result{}, false
|
||||||
return "", false
|
|
||||||
}
|
}
|
||||||
text := top.Meta["text"]
|
return results[0], true
|
||||||
if text == "" {
|
|
||||||
return "", false
|
|
||||||
}
|
|
||||||
return text, true
|
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -8,23 +8,24 @@ import (
|
|||||||
|
|
||||||
func TestBestRecall(t *testing.T) {
|
func TestBestRecall(t *testing.T) {
|
||||||
const min = 0.55
|
const min = 0.55
|
||||||
|
const margin = 0.008
|
||||||
|
|
||||||
t.Run("empty results", func(t *testing.T) {
|
t.Run("empty results", func(t *testing.T) {
|
||||||
if _, ok := bestRecall(nil, min); ok {
|
if _, ok := bestRecall(nil, min, margin); ok {
|
||||||
t.Error("empty results returned ok")
|
t.Error("empty results returned ok")
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
t.Run("top below threshold", func(t *testing.T) {
|
t.Run("top below threshold", func(t *testing.T) {
|
||||||
res := []memory.Result{{Score: 0.4, Meta: map[string]string{"text": "выпил воды"}}}
|
res := []memory.Result{{Score: 0.4, Meta: map[string]string{"text": "выпил воды"}}}
|
||||||
if _, ok := bestRecall(res, min); ok {
|
if _, ok := bestRecall(res, min, margin); ok {
|
||||||
t.Error("below-threshold hit returned ok")
|
t.Error("below-threshold hit returned ok")
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
t.Run("hit without text meta", func(t *testing.T) {
|
t.Run("hit without text meta", func(t *testing.T) {
|
||||||
res := []memory.Result{{Score: 0.9, Meta: map[string]string{"type": "fact"}}}
|
res := []memory.Result{{Score: 0.9, Meta: map[string]string{"type": "fact"}}}
|
||||||
if _, ok := bestRecall(res, min); ok {
|
if _, ok := bestRecall(res, min, margin); ok {
|
||||||
t.Error("textless hit returned ok")
|
t.Error("textless hit returned ok")
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -34,12 +35,43 @@ func TestBestRecall(t *testing.T) {
|
|||||||
{Score: 0.82, Meta: map[string]string{"text": "выпил воды в три часа", "type": "fact"}},
|
{Score: 0.82, Meta: map[string]string{"text": "выпил воды в три часа", "type": "fact"}},
|
||||||
{Score: 0.60, Meta: map[string]string{"text": "другое"}},
|
{Score: 0.60, Meta: map[string]string{"text": "другое"}},
|
||||||
}
|
}
|
||||||
got, ok := bestRecall(res, min)
|
got, ok := bestRecall(res, min, margin)
|
||||||
if !ok {
|
if !ok {
|
||||||
t.Fatal("clearing hit not returned")
|
t.Fatal("clearing hit not returned")
|
||||||
}
|
}
|
||||||
if got != "выпил воды в три часа" {
|
if got.Meta["text"] != "выпил воды в три часа" {
|
||||||
t.Errorf("wrong text: %q", got)
|
t.Errorf("wrong text: %q", got.Meta["text"])
|
||||||
|
}
|
||||||
|
if got.Meta["type"] != "fact" {
|
||||||
|
t.Errorf("kind lost: %q", got.Meta["type"])
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
// The index holds notes and facts together, so a note has to be able to win
|
||||||
|
// it — for a long time it could not (Vikunja #373).
|
||||||
|
t.Run("a note can win", func(t *testing.T) {
|
||||||
|
res := []memory.Result{
|
||||||
|
{Score: 0.86, Meta: map[string]string{"text": "молоко в холодильнике", "type": "note"}},
|
||||||
|
{Score: 0.61, Meta: map[string]string{"text": "выпил воды", "type": "fact"}},
|
||||||
|
}
|
||||||
|
got, ok := bestRecall(res, min, margin)
|
||||||
|
if !ok {
|
||||||
|
t.Fatal("clearly-best note not returned")
|
||||||
|
}
|
||||||
|
if got.Meta["type"] != "note" || got.Meta["text"] != "молоко в холодильнике" {
|
||||||
|
t.Errorf("got %v, want the note", got.Meta)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
// The runner-up is almost as close, so the embedder cannot tell the two
|
||||||
|
// notes apart. Silence beats reading back a coin flip.
|
||||||
|
t.Run("runner-up too close", func(t *testing.T) {
|
||||||
|
res := []memory.Result{
|
||||||
|
{Score: 0.860, Meta: map[string]string{"text": "выпил воды в три часа"}},
|
||||||
|
{Score: 0.858, Meta: map[string]string{"text": "другое"}},
|
||||||
|
}
|
||||||
|
if _, ok := bestRecall(res, min, margin); ok {
|
||||||
|
t.Error("thin-margin hit returned ok")
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -29,7 +29,9 @@ func newLLMReplier(c completer) *llmReplier {
|
|||||||
return &llmReplier{c: c, stub: voice.NewStubReplier()}
|
return &llmReplier{c: c, stub: voice.NewStubReplier()}
|
||||||
}
|
}
|
||||||
|
|
||||||
const replySystem = `Ты — Maven, домашняя ассистентка (о себе — в женском роде). Подтверди действие РОВНО ОДНИМ коротким предложением (≤120 символов), тепло и по-русски. Не задавай вопросов, не повторяй слова, не добавляй ничего после точки. Respond ONLY with valid JSON: {"response": "...", "mood": "neutral"}.`
|
const replySystem = `Ты — Maven, домашняя ассистентка (о себе — в женском роде). Подтверди действие РОВНО ОДНИМ коротким предложением (≤120 символов), тепло и по-русски. Не задавай вопросов, не повторяй слова, не добавляй ничего после точки. Отвечай ТОЛЬКО одним объектом JSON с полями "response" (текст) и "mood" (ровно одно из: neutral, happy, thinking, tired, confused).
|
||||||
|
Пример: {"response": "Записала, что ты выпил стакан воды.", "mood": "neutral"}
|
||||||
|
Никогда не пиши "..." в поле response.`
|
||||||
|
|
||||||
func (r *llmReplier) Reply(d router.Decision) string {
|
func (r *llmReplier) Reply(d router.Decision) string {
|
||||||
if d.Clarify {
|
if d.Clarify {
|
||||||
|
|||||||
@@ -0,0 +1,78 @@
|
|||||||
|
package main
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/kami/maven/internal/router"
|
||||||
|
)
|
||||||
|
|
||||||
|
// systemHandler — a handler with nothing but a fixed clock, which is all
|
||||||
|
// replySystem needs.
|
||||||
|
func systemHandler(now time.Time) *reactiveHandler {
|
||||||
|
return &reactiveHandler{now: func() time.Time { return now }}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestReplySystemDateOffset — "какое число завтра" must answer tomorrow's
|
||||||
|
// date, not today's (Vikunja #388).
|
||||||
|
func TestReplySystemDateOffset(t *testing.T) {
|
||||||
|
// Thursday, 30 July 2026.
|
||||||
|
now := time.Date(2026, 7, 30, 14, 5, 0, 0, time.UTC)
|
||||||
|
h := systemHandler(now)
|
||||||
|
cases := []struct{ utterance, want string }{
|
||||||
|
{"какое сегодня число", "сегодня четверг, 30 июля 2026 года"},
|
||||||
|
{"какое число", "сегодня четверг, 30 июля 2026 года"},
|
||||||
|
{"какое число завтра", "завтра пятница, 31 июля 2026 года"},
|
||||||
|
{"какое число послезавтра", "послезавтра суббота, 1 августа 2026 года"},
|
||||||
|
{"какое было число вчера", "вчера среда, 29 июля 2026 года"},
|
||||||
|
}
|
||||||
|
for _, c := range cases {
|
||||||
|
got := h.replySystem(context.Background(), router.Decision{Utterance: c.utterance})
|
||||||
|
if got != c.want {
|
||||||
|
t.Errorf("replySystem(%q) = %q, want %q", c.utterance, got, c.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A day she cannot work out must not come back as today's date — that is the
|
||||||
|
// same silent wrong answer #388 was about, one step further out.
|
||||||
|
func TestReplySystemUnknownDayIsHonest(t *testing.T) {
|
||||||
|
now := time.Date(2026, 7, 30, 14, 5, 0, 0, time.UTC)
|
||||||
|
h := systemHandler(now)
|
||||||
|
for _, u := range []string{
|
||||||
|
"какое число в пятницу",
|
||||||
|
"какое число через неделю",
|
||||||
|
"какое число в понедельник",
|
||||||
|
} {
|
||||||
|
got := h.replySystem(context.Background(), router.Decision{Utterance: u})
|
||||||
|
if got != onlyNearDaysReply {
|
||||||
|
t.Errorf("replySystem(%q) = %q, want the honest reply", u, got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// The days she does know must not be caught by the same guard.
|
||||||
|
if got := h.replySystem(context.Background(), router.Decision{Utterance: "какое число завтра"}); got == onlyNearDaysReply {
|
||||||
|
t.Error("завтра was treated as an unknown day")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// TestReplySystemClockCity — the clock arm must not answer local time for a
|
||||||
|
// question about another city (Vikunja #388). She keeps one clock, so every
|
||||||
|
// named place gets the honest "local time only" answer.
|
||||||
|
func TestReplySystemClockCity(t *testing.T) {
|
||||||
|
now := time.Date(2026, 7, 30, 12, 0, 0, 0, time.UTC)
|
||||||
|
h := systemHandler(now)
|
||||||
|
cases := []struct{ utterance, want string }{
|
||||||
|
{"который час", "сейчас 12 часов ровно"},
|
||||||
|
{"который час в киеве", onlyLocalTimeReply},
|
||||||
|
{"сколько времени в москве", onlyLocalTimeReply},
|
||||||
|
{"который час в лондоне", onlyLocalTimeReply},
|
||||||
|
{"который час в бишкеке", onlyLocalTimeReply},
|
||||||
|
}
|
||||||
|
for _, c := range cases {
|
||||||
|
got := h.replySystem(context.Background(), router.Decision{Utterance: c.utterance})
|
||||||
|
if got != c.want {
|
||||||
|
t.Errorf("replySystem(%q) = %q, want %q", c.utterance, got, c.want)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
+285
-50
@@ -171,6 +171,7 @@ func wireVoice(cfg *config.Config, coreAPI ipc.CoreAPI, phr phraser.Phraser, mem
|
|||||||
emb = router.NewHashEmbedder(1024)
|
emb = router.NewHashEmbedder(1024)
|
||||||
}
|
}
|
||||||
w.embedder = emb
|
w.embedder = emb
|
||||||
|
checkStoredEmbedder(dataStore, emb)
|
||||||
|
|
||||||
// ----- tool executor (the enabled act allowlist, store-backed) -----
|
// ----- tool executor (the enabled act allowlist, store-backed) -----
|
||||||
// Config tools are the declarative bootstrap: seed them into the store as
|
// Config tools are the declarative bootstrap: seed them into the store as
|
||||||
@@ -206,11 +207,11 @@ func wireVoice(cfg *config.Config, coreAPI ipc.CoreAPI, phr phraser.Phraser, mem
|
|||||||
if threshold <= 0 {
|
if threshold <= 0 {
|
||||||
threshold = config.DefaultRouterThreshold
|
threshold = config.DefaultRouterThreshold
|
||||||
}
|
}
|
||||||
// Both routing paths are weak on held-out utterances — the classifier gets
|
// The resident model routes by default: 63.2% of held-out intents right
|
||||||
// 36.8% of intents right, the resident model 50.0% and much slower. Off by
|
// against the classifier's 50.0%, at about 1s a turn instead of 30ms (see
|
||||||
// default (see config.VoiceConfig.LLMRouter); the classifier always stays
|
// config.VoiceConfig.LLMRouter). The classifier always stays wired as the
|
||||||
// wired as the fallback, so a model error never breaks a turn.
|
// fallback, so a model error never breaks a turn.
|
||||||
rtr := buildRouter(emb, matcher, threshold, pickLLMRouter(cfg.Voice.LLMRouter, llmClient))
|
rtr := buildRouter(emb, matcher, threshold, pickLLMRouter(cfg.Voice.UseLLMRouter(), llmClient))
|
||||||
|
|
||||||
// ----- sessions registry (shared with voicesink) -----
|
// ----- sessions registry (shared with voicesink) -----
|
||||||
sessions := voice.NewSessions()
|
sessions := voice.NewSessions()
|
||||||
@@ -227,7 +228,18 @@ func wireVoice(cfg *config.Config, coreAPI ipc.CoreAPI, phr phraser.Phraser, mem
|
|||||||
}
|
}
|
||||||
|
|
||||||
// ----- dialogue (multi-turn slot carry-over; 2-min follow-up window) -----
|
// ----- dialogue (multi-turn slot carry-over; 2-min follow-up window) -----
|
||||||
dialogueSessions := dialogue.NewSessionStore(2 * time.Minute)
|
// Store-backed when the daemon passes a store, so a restart mid-conversation
|
||||||
|
// keeps the thread (Vikunja #363). Sessions past their TTL are dropped on
|
||||||
|
// load, never revived. Clarify's parked question stays in memory only.
|
||||||
|
var dialogueSessions *dialogue.SessionStore
|
||||||
|
if dataStore != nil {
|
||||||
|
dialogueSessions = dialogue.NewPersistentSessionStore(2*time.Minute, dataStore)
|
||||||
|
if err := dialogueSessions.Load(context.Background(), time.Now()); err != nil {
|
||||||
|
log.Printf("dialogue: load saved sessions: %v", err)
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
dialogueSessions = dialogue.NewSessionStore(2 * time.Minute)
|
||||||
|
}
|
||||||
clarifyStore := dialogue.NewClarifyStore(clarifyTTL)
|
clarifyStore := dialogue.NewClarifyStore(clarifyTTL)
|
||||||
timeParser := router.NewPythonDateParser()
|
timeParser := router.NewPythonDateParser()
|
||||||
|
|
||||||
@@ -255,10 +267,13 @@ func wireVoice(cfg *config.Config, coreAPI ipc.CoreAPI, phr phraser.Phraser, mem
|
|||||||
dataStore: dataStore,
|
dataStore: dataStore,
|
||||||
dialogueSessions: dialogueSessions,
|
dialogueSessions: dialogueSessions,
|
||||||
clarifyStore: clarifyStore,
|
clarifyStore: clarifyStore,
|
||||||
extractor: router.Extractor{Time: timeParser, Acts: matcher, Facts: router.DefaultFactParser{}},
|
// 0 here (unset config) ⇒ the dialogue default.
|
||||||
queryMinScore: cfg.Voice.QueryMinScore,
|
clarifyMaxAttempts: cfg.Voice.ClarifyMaxAttempts,
|
||||||
timeParser: timeParser,
|
extractor: router.Extractor{Time: timeParser, Acts: matcher, Facts: router.DefaultFactParser{}},
|
||||||
ecosystem: eco,
|
queryMinScore: cfg.Voice.QueryMinScore,
|
||||||
|
queryMinMargin: cfg.Voice.QueryMinMargin,
|
||||||
|
timeParser: timeParser,
|
||||||
|
ecosystem: eco,
|
||||||
}
|
}
|
||||||
|
|
||||||
// ----- the server (TCP listener) -----
|
// ----- the server (TCP listener) -----
|
||||||
@@ -300,6 +315,9 @@ type reactiveHandler struct {
|
|||||||
// load-bearing math (same posture as the presence thresholds). Set by
|
// load-bearing math (same posture as the presence thresholds). Set by
|
||||||
// wireVoice from VoiceConfig; default 0.55.
|
// wireVoice from VoiceConfig; default 0.55.
|
||||||
queryMinScore float64
|
queryMinScore float64
|
||||||
|
// queryMinMargin — the second half of that gate: how far the top hit must
|
||||||
|
// beat the runner-up. 0 ⇒ margin off.
|
||||||
|
queryMinMargin float64
|
||||||
|
|
||||||
// timeParser — used as a fallback for stage-0 reminder grammar matches
|
// timeParser — used as a fallback for stage-0 reminder grammar matches
|
||||||
// (where the extractor didn't run). Shared with the router's extractor.
|
// (where the extractor didn't run). Shared with the router's extractor.
|
||||||
@@ -314,6 +332,10 @@ type reactiveHandler struct {
|
|||||||
// clarify.go). nil ⇒ she falls back to the canned "не поняла" reply.
|
// clarify.go). nil ⇒ she falls back to the canned "не поняла" reply.
|
||||||
clarifyStore *dialogue.ClarifyStore
|
clarifyStore *dialogue.ClarifyStore
|
||||||
|
|
||||||
|
// clarifyMaxAttempts — questions per request before she gives up out loud.
|
||||||
|
// 0 ⇒ dialogue.DefaultMaxAttempts (3). Set from VoiceConfig.
|
||||||
|
clarifyMaxAttempts int
|
||||||
|
|
||||||
// extractor parses the answer to an open question, with the same parsers
|
// extractor parses the answer to an open question, with the same parsers
|
||||||
// the router's own stage-2 uses.
|
// the router's own stage-2 uses.
|
||||||
extractor router.Extractor
|
extractor router.Extractor
|
||||||
@@ -392,9 +414,17 @@ func (h *reactiveHandler) HandlePushToTalk(ctx context.Context, req voice.PushTo
|
|||||||
return h.reply(ctx, reply, nil)
|
return h.reply(ctx, reply, nil)
|
||||||
}
|
}
|
||||||
|
|
||||||
// 1b2. clarify answer — if she asked a question last turn, this utterance is
|
// 1b2. expired clarify — a question was parked but its TTL ran out, so the
|
||||||
// its answer, not a fresh command. After the confirm check: a y/n gate is
|
// request behind it is gone. Say that out loud (see clarify.go) and carry
|
||||||
// armed by her own prompt and is the narrower claim on the utterance.
|
// on: these words are still routed as a fresh utterance below, with the
|
||||||
|
// notice glued in front of whatever the fresh routing answers. Checked
|
||||||
|
// BEFORE the answer path: reading a parked question drops an expired one.
|
||||||
|
expiredNotice := h.clarifyExpiredNotice()
|
||||||
|
|
||||||
|
// 1b3. clarify answer — if she asked a live question last turn, this
|
||||||
|
// utterance is its answer, not a fresh command. After the confirm check: a
|
||||||
|
// y/n gate is armed by her own prompt and is the narrower claim on the
|
||||||
|
// utterance.
|
||||||
if reply, handled := h.resolveClarifyAnswer(ctx, text); handled {
|
if reply, handled := h.resolveClarifyAnswer(ctx, text); handled {
|
||||||
return h.reply(ctx, reply, nil)
|
return h.reply(ctx, reply, nil)
|
||||||
}
|
}
|
||||||
@@ -404,7 +434,7 @@ func (h *reactiveHandler) HandlePushToTalk(ctx context.Context, req voice.PushTo
|
|||||||
// unreliably (it's a command, not a free-form query), so we match it
|
// unreliably (it's a command, not a free-form query), so we match it
|
||||||
// before routing. Same pattern as the confirm turn above.
|
// before routing. Same pattern as the confirm turn above.
|
||||||
if reply, handled := h.resolveQuietToggle(ctx, text); handled {
|
if reply, handled := h.resolveQuietToggle(ctx, text); handled {
|
||||||
return h.reply(ctx, reply, nil)
|
return h.reply(ctx, withNotice(expiredNotice, reply), nil)
|
||||||
}
|
}
|
||||||
|
|
||||||
// 2. router — classify the utterance.
|
// 2. router — classify the utterance.
|
||||||
@@ -413,10 +443,10 @@ func (h *reactiveHandler) HandlePushToTalk(ctx context.Context, req voice.PushTo
|
|||||||
// ErrNoIntents ⇒ classifier unseeded (cold boot). reply with a
|
// ErrNoIntents ⇒ classifier unseeded (cold boot). reply with a
|
||||||
// "still warming up" rather than a wire error.
|
// "still warming up" rather than a wire error.
|
||||||
if errors.Is(err, router.ErrNoIntents) {
|
if errors.Is(err, router.ErrNoIntents) {
|
||||||
return h.reply(ctx, "я ещё не понимаю свободную речь — скоро научусь.", nil)
|
return h.reply(ctx, withNotice(expiredNotice, "я ещё не понимаю свободную речь — скоро научусь."), nil)
|
||||||
}
|
}
|
||||||
log.Printf("voice: router error: %v", err)
|
log.Printf("voice: router error: %v", err)
|
||||||
return h.reply(ctx, "не получилось разобрать команду.", nil)
|
return h.reply(ctx, withNotice(expiredNotice, "не получилось разобрать команду."), nil)
|
||||||
}
|
}
|
||||||
|
|
||||||
// 2b. dialogue — fill this turn's missing slots from a prior same-intent
|
// 2b. dialogue — fill this turn's missing slots from a prior same-intent
|
||||||
@@ -437,7 +467,7 @@ func (h *reactiveHandler) HandlePushToTalk(ctx context.Context, req voice.PushTo
|
|||||||
// stands.
|
// stands.
|
||||||
if dec.Clarify {
|
if dec.Clarify {
|
||||||
if question, asked := h.askClarify(dec); asked {
|
if question, asked := h.askClarify(dec); asked {
|
||||||
return h.reply(ctx, question, nil)
|
return h.reply(ctx, withNotice(expiredNotice, question), nil)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -453,7 +483,7 @@ func (h *reactiveHandler) HandlePushToTalk(ctx context.Context, req voice.PushTo
|
|||||||
|
|
||||||
// 5. tts — synthesise the reply text; return to the voice server which
|
// 5. tts — synthesise the reply text; return to the voice server which
|
||||||
// ships it back on the conn.
|
// ships it back on the conn.
|
||||||
return h.reply(ctx, replyText, nil)
|
return h.reply(ctx, withNotice(expiredNotice, replyText), nil)
|
||||||
}
|
}
|
||||||
|
|
||||||
// handleText — the core reactive path without stt/tts: confirm check →
|
// handleText — the core reactive path without stt/tts: confirm check →
|
||||||
@@ -468,7 +498,9 @@ func (h *reactiveHandler) handleText(ctx context.Context, text string) string {
|
|||||||
return reply
|
return reply
|
||||||
}
|
}
|
||||||
|
|
||||||
// 1b2. clarify answer — same check as HandlePushToTalk.
|
// 1b2/1b3. expired clarify then clarify answer — same order and reasons as
|
||||||
|
// HandlePushToTalk.
|
||||||
|
expiredNotice := h.clarifyExpiredNotice()
|
||||||
if reply, handled := h.resolveClarifyAnswer(ctx, text); handled {
|
if reply, handled := h.resolveClarifyAnswer(ctx, text); handled {
|
||||||
return reply
|
return reply
|
||||||
}
|
}
|
||||||
@@ -477,10 +509,10 @@ func (h *reactiveHandler) handleText(ctx context.Context, text string) string {
|
|||||||
dec, err := h.router.Route(ctx, text, h.now())
|
dec, err := h.router.Route(ctx, text, h.now())
|
||||||
if err != nil {
|
if err != nil {
|
||||||
if errors.Is(err, router.ErrNoIntents) {
|
if errors.Is(err, router.ErrNoIntents) {
|
||||||
return "я ещё не понимаю свободную речь — скоро научусь."
|
return withNotice(expiredNotice, "я ещё не понимаю свободную речь — скоро научусь.")
|
||||||
}
|
}
|
||||||
log.Printf("voice: handleText router error: %v", err)
|
log.Printf("voice: handleText router error: %v", err)
|
||||||
return "не получилось разобрать команду."
|
return withNotice(expiredNotice, "не получилось разобрать команду.")
|
||||||
}
|
}
|
||||||
log.Printf("voice: route result: intent=%s slots=%+v", dec.Intent, dec.Slots)
|
log.Printf("voice: route result: intent=%s slots=%+v", dec.Intent, dec.Slots)
|
||||||
|
|
||||||
@@ -497,7 +529,7 @@ func (h *reactiveHandler) handleText(ctx context.Context, text string) string {
|
|||||||
// 2c. clarify — same as HandlePushToTalk: ask about the one missing thing.
|
// 2c. clarify — same as HandlePushToTalk: ask about the one missing thing.
|
||||||
if dec.Clarify {
|
if dec.Clarify {
|
||||||
if question, asked := h.askClarify(dec); asked {
|
if question, asked := h.askClarify(dec); asked {
|
||||||
return question
|
return withNotice(expiredNotice, question)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -509,7 +541,7 @@ func (h *reactiveHandler) handleText(ctx context.Context, text string) string {
|
|||||||
if replyText == "" {
|
if replyText == "" {
|
||||||
replyText = h.replier.Reply(dec)
|
replyText = h.replier.Reply(dec)
|
||||||
}
|
}
|
||||||
return replyText
|
return withNotice(expiredNotice, replyText)
|
||||||
}
|
}
|
||||||
|
|
||||||
// applyAction — executes the router's Decision. Intent-by-intent:
|
// applyAction — executes the router's Decision. Intent-by-intent:
|
||||||
@@ -720,7 +752,9 @@ func (h *reactiveHandler) applyAction(ctx context.Context, dec router.Decision)
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Calendar questions: "что у меня сегодня?", "планы на завтра?"
|
// Calendar questions: "что у меня сегодня?", "планы на завтра?"
|
||||||
if date, ok := router.ParseCalendarDate(dec.Utterance, time.Now()); ok {
|
// h.now(), not time.Now(): the handler's clock is the injected one, so
|
||||||
|
// this arm can be tested at a fixed time like the rest.
|
||||||
|
if date, ok := router.ParseCalendarDate(dec.Utterance, h.now()); ok {
|
||||||
events, err := h.api.CalendarEvents(ctx, date, date.Add(24*time.Hour))
|
events, err := h.api.CalendarEvents(ctx, date, date.Add(24*time.Hour))
|
||||||
if err != nil {
|
if err != nil {
|
||||||
log.Printf("voice: calendar events: %v", err)
|
log.Printf("voice: calendar events: %v", err)
|
||||||
@@ -755,27 +789,54 @@ func (h *reactiveHandler) applyAction(ctx context.Context, dec router.Decision)
|
|||||||
log.Printf("voice: embed query: %v", err)
|
log.Printf("voice: embed query: %v", err)
|
||||||
return "не получилось найти ответ."
|
return "не получилось найти ответ."
|
||||||
}
|
}
|
||||||
|
// Long-term memory first: ONE search over everything Maven remembers
|
||||||
|
// (notes and facts share this index) and ONE confidence gate, so the
|
||||||
|
// memory that is clearly the best match answers — a note just as much
|
||||||
|
// as a fact.
|
||||||
|
//
|
||||||
|
// This used to run only after the notes-only gate below had already
|
||||||
|
// rejected the same note at the same score, which no note could ever
|
||||||
|
// survive a second time: the branch could only return a fact (#373).
|
||||||
|
// Order, not the gate, was the bug — the set of questions Maven answers
|
||||||
|
// is unchanged, only which memory gets to answer them.
|
||||||
|
if h.memStore != nil {
|
||||||
|
if hits, herr := h.memStore.Search(ctx, vec, 3); herr == nil {
|
||||||
|
if hit, ok := bestRecall(hits, h.queryMinScore, h.queryMinMargin); ok {
|
||||||
|
text := hit.Meta["text"]
|
||||||
|
// A note is phrased in Maven's voice; a fact is read back
|
||||||
|
// as it was stored.
|
||||||
|
if hit.Meta["type"] == "note" {
|
||||||
|
if reply, perr := h.phraser.PhraseQuery(ctx, dec.Utterance, []string{text}); perr == nil && reply != "" {
|
||||||
|
return reply
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return text
|
||||||
|
}
|
||||||
|
} else {
|
||||||
|
log.Printf("voice: memory search: %v", herr)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
notes, err := h.api.QueryNotes(ctx, vec, 5)
|
notes, err := h.api.QueryNotes(ctx, vec, 5)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
log.Printf("voice: query notes: %v", err)
|
log.Printf("voice: query notes: %v", err)
|
||||||
return "не получилось найти ответ."
|
return "не получилось найти ответ."
|
||||||
}
|
}
|
||||||
// Confidence gate: below threshold, say "I don't know" rather than read
|
// Notes-only pass, for notes the vector index above does not hold (an
|
||||||
// back the least-unrelated note — a confident wrong recall is worse than
|
// older note written before it existed). Same gate, notes-only
|
||||||
// a gap (spec's "not a guesser-of-truth"). Same instinct as the loop's
|
// candidates.
|
||||||
// since(key)==null → don't fire. Tuned for the ONNX embedder; the Hash
|
//
|
||||||
// floor scores lexically and may rarely clear it.
|
// Confidence gate: below it, say "I don't know" rather than read back
|
||||||
if len(notes) == 0 || notes[0].Score < h.queryMinScore {
|
// the least-unrelated note — a confident wrong recall is worse than a
|
||||||
// Long-term memory recall (notes + facts) before general knowledge:
|
// gap (spec's "not a guesser-of-truth"). Same instinct as the loop's
|
||||||
// the notes table can't answer fact questions, but the memory store
|
// since(key)==null → don't fire. Two parts: an absolute cosine floor,
|
||||||
// indexes both. Only runs when notes-RAG already gave up → additive.
|
// and a margin over the runner-up, which is the part that works with
|
||||||
if h.memStore != nil {
|
// the e5 embedder's narrow score band. See memory.Confident.
|
||||||
if hits, herr := h.memStore.Search(ctx, vec, 3); herr == nil {
|
noteScores := make([]float64, len(notes))
|
||||||
if text, ok := bestRecall(hits, h.queryMinScore); ok {
|
for i, n := range notes {
|
||||||
return text
|
noteScores[i] = n.Score
|
||||||
}
|
}
|
||||||
}
|
if !memory.ConfidentScores(noteScores, h.queryMinScore, h.queryMinMargin) {
|
||||||
}
|
|
||||||
// Try general knowledge from the phraser before giving up
|
// Try general knowledge from the phraser before giving up
|
||||||
reply, err := h.phraser.PhraseQuery(ctx, dec.Utterance, nil)
|
reply, err := h.phraser.PhraseQuery(ctx, dec.Utterance, nil)
|
||||||
if err != nil || reply == "" {
|
if err != nil || reply == "" {
|
||||||
@@ -877,6 +938,101 @@ var ruMonths = []string{
|
|||||||
"июля", "августа", "сентября", "октября", "ноября", "декабря",
|
"июля", "августа", "сентября", "октября", "ноября", "декабря",
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// onlyLocalTimeReply — the honest answer when the user asks the time somewhere
|
||||||
|
// other than here. She only keeps one clock, and saying so is better than
|
||||||
|
// naming the wrong city's time.
|
||||||
|
//
|
||||||
|
// There used to be a city→time-zone table here. It was removed on purpose: the
|
||||||
|
// user only ever asks for local time, so the table was a second list of cities
|
||||||
|
// to keep in step with the weather one for no gain.
|
||||||
|
const onlyLocalTimeReply = "я знаю только местное время, про другие города пока не скажу."
|
||||||
|
|
||||||
|
// notPlaceAfterV — words that follow "в" without naming a place, so
|
||||||
|
// mentionsUnknownPlace does not mistake them for a city.
|
||||||
|
var notPlaceAfterV = map[string]bool{
|
||||||
|
"данный": true, "данную": true, "этот": true, "эту": true,
|
||||||
|
"котором": true, "какое": true, "какой": true, "который": true,
|
||||||
|
"общем": true, "точности": true, "курсе": true, "сутках": true,
|
||||||
|
"часах": true, "минутах": true, "секундах": true, "неделе": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// mentionsUnknownPlace reports whether the question has a "в <слово>" phrase
|
||||||
|
// that looks like a place we do not know ("который час в киеве"). Used only to
|
||||||
|
// pick the honest "local time only" reply instead of answering local time as
|
||||||
|
// if it were the city's.
|
||||||
|
func mentionsUnknownPlace(u string) bool {
|
||||||
|
toks := strings.Fields(u)
|
||||||
|
for i := 0; i+1 < len(toks); i++ {
|
||||||
|
if toks[i] != "в" && toks[i] != "во" {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
next := strings.Trim(toks[i+1], ".,?!")
|
||||||
|
if next == "" || notPlaceAfterV[next] {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
// A number after "в" is a clock ("в 5 часов"), not a place.
|
||||||
|
if _, err := strconv.Atoi(strings.SplitN(next, ":", 2)[0]); err == nil {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
// onlyNearDaysReply — she can work out today, tomorrow, the day after and
|
||||||
|
// yesterday, and nothing further. Said out loud instead of answering today's
|
||||||
|
// date for a day she did not understand.
|
||||||
|
const onlyNearDaysReply = "я считаю только сегодня, завтра, послезавтра и вчера — про другие дни пока не скажу."
|
||||||
|
|
||||||
|
// dayWords — day references the calendar parser cannot resolve. A weekday name
|
||||||
|
// or a "через …" phrase means he asked about a specific other day.
|
||||||
|
var dayWords = []string{
|
||||||
|
"понедельник", "вторник", "сред", "четверг", "пятниц", "суббот", "воскресен",
|
||||||
|
"через", "monday", "tuesday", "wednesday", "thursday", "friday", "saturday", "sunday",
|
||||||
|
}
|
||||||
|
|
||||||
|
// mentionsUnknownDay reports whether the question names a day the calendar
|
||||||
|
// parser could not resolve. Mirror of mentionsUnknownPlace: it exists only to
|
||||||
|
// pick an honest reply over a confidently wrong one.
|
||||||
|
//
|
||||||
|
// Only called after ParseCalendarDate has already failed, so "завтра" and the
|
||||||
|
// other words it does know never reach here.
|
||||||
|
func mentionsUnknownDay(u string) bool {
|
||||||
|
for _, w := range dayWords {
|
||||||
|
if strings.Contains(u, w) {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
// ruClock renders the clock part of the time reply: "15 часов 4 минуты".
|
||||||
|
func ruClock(t time.Time) string {
|
||||||
|
h, m := t.Hour(), t.Minute()
|
||||||
|
hourWord := ruPlural(h, "час", "часа", "часов")
|
||||||
|
if m == 0 {
|
||||||
|
return fmt.Sprintf("%d %s ровно", h, hourWord)
|
||||||
|
}
|
||||||
|
return fmt.Sprintf("%d %s %d %s", h, hourWord, m, ruPlural(m, "минута", "минуты", "минут"))
|
||||||
|
}
|
||||||
|
|
||||||
|
// dayPrefix names the day relative to now ("завтра", "вчера", …) so the date
|
||||||
|
// reply opens the way a person would say it.
|
||||||
|
func dayPrefix(now, day time.Time) string {
|
||||||
|
base := time.Date(now.Year(), now.Month(), now.Day(), 0, 0, 0, 0, now.Location())
|
||||||
|
switch int(day.Sub(base).Hours() / 24) {
|
||||||
|
case -1:
|
||||||
|
return "вчера"
|
||||||
|
case 0:
|
||||||
|
return "сегодня"
|
||||||
|
case 1:
|
||||||
|
return "завтра"
|
||||||
|
case 2:
|
||||||
|
return "послезавтра"
|
||||||
|
}
|
||||||
|
return "это"
|
||||||
|
}
|
||||||
|
|
||||||
func ruPlural(n int, one, two, many string) string {
|
func ruPlural(n int, one, two, many string) string {
|
||||||
n = n % 100
|
n = n % 100
|
||||||
if n > 10 && n < 20 {
|
if n > 10 && n < 20 {
|
||||||
@@ -955,18 +1111,29 @@ func (h *reactiveHandler) replySystem(ctx context.Context, dec router.Decision)
|
|||||||
|
|
||||||
switch {
|
switch {
|
||||||
case strings.Contains(u, "час") || strings.Contains(u, "врем"):
|
case strings.Contains(u, "час") || strings.Contains(u, "врем"):
|
||||||
h := now.Hour()
|
// "который час в киеве" — she keeps one clock, so any named place gets
|
||||||
m := now.Minute()
|
// the honest answer. Never local time dressed up as the city's.
|
||||||
hourWord := ruPlural(h, "час", "часа", "часов")
|
if mentionsUnknownPlace(u) {
|
||||||
if m == 0 {
|
return onlyLocalTimeReply
|
||||||
return fmt.Sprintf("сейчас %d %s ровно", h, hourWord)
|
|
||||||
}
|
}
|
||||||
minWord := ruPlural(m, "минута", "минуты", "минут")
|
return "сейчас " + ruClock(now)
|
||||||
return fmt.Sprintf("сейчас %d %s %d %s", h, hourWord, m, minWord)
|
|
||||||
case strings.Contains(u, "день") || strings.Contains(u, "числ"):
|
case strings.Contains(u, "день") || strings.Contains(u, "числ"):
|
||||||
dow := ruWeekdays[now.Weekday()]
|
// "какое число завтра" — answer for the day the user asked about,
|
||||||
month := ruMonths[now.Month()-1]
|
// not today. Reuses the router's calendar day-word parser.
|
||||||
return fmt.Sprintf("сегодня %s, %d %s %d года", dow, now.Day(), month, now.Year())
|
day := now
|
||||||
|
prefix := "сегодня"
|
||||||
|
if d, ok := router.ParseCalendarDate(u, now); ok {
|
||||||
|
day = d
|
||||||
|
prefix = dayPrefix(now, d)
|
||||||
|
} else if mentionsUnknownDay(u) {
|
||||||
|
// He named a day she cannot work out ("в пятницу", "через неделю").
|
||||||
|
// Answering today's date here would be the same silent wrong answer
|
||||||
|
// this arm was fixed for, so say what she can do instead.
|
||||||
|
return onlyNearDaysReply
|
||||||
|
}
|
||||||
|
dow := ruWeekdays[day.Weekday()]
|
||||||
|
month := ruMonths[day.Month()-1]
|
||||||
|
return fmt.Sprintf("%s %s, %d %s %d года", prefix, dow, day.Day(), month, day.Year())
|
||||||
case strings.Contains(u, "кто дома") || strings.Contains(u, "человек дома"):
|
case strings.Contains(u, "кто дома") || strings.Contains(u, "человек дома"):
|
||||||
return "присутствие пока не подключено к голосовому запросу."
|
return "присутствие пока не подключено к голосовому запросу."
|
||||||
case strings.Contains(u, "памят") || strings.Contains(u, "процессор") || strings.Contains(u, "загрузк") || strings.Contains(u, "статус") || strings.Contains(u, "работа") || strings.Contains(u, "сервис") || strings.Contains(u, "диск") || strings.Contains(u, "ip") || strings.Contains(u, "аптайм") || strings.Contains(u, "трафик") || strings.Contains(u, "интернет"):
|
case strings.Contains(u, "памят") || strings.Contains(u, "процессор") || strings.Contains(u, "загрузк") || strings.Contains(u, "статус") || strings.Contains(u, "работа") || strings.Contains(u, "сервис") || strings.Contains(u, "диск") || strings.Contains(u, "ip") || strings.Contains(u, "аптайм") || strings.Contains(u, "трафик") || strings.Contains(u, "интернет"):
|
||||||
@@ -1709,3 +1876,71 @@ func jsonStringImpl(s string) string {
|
|||||||
b = append(b, '"')
|
b = append(b, '"')
|
||||||
return string(b)
|
return string(b)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// reembedOnStart is the -reembed flag (set in run()). Opt-in on purpose: see
|
||||||
|
// runReembed.
|
||||||
|
var reembedOnStart bool
|
||||||
|
|
||||||
|
// checkStoredEmbedder compares the embedder we just loaded with the one that
|
||||||
|
// wrote the vectors already in the DB (Vikunja #378).
|
||||||
|
//
|
||||||
|
// The two models we have both make 384-dim vectors, so a size check catches
|
||||||
|
// nothing: after a swap, recall silently compares vectors from different
|
||||||
|
// spaces and the scores are noise. So we say it out loud. Recall itself is not
|
||||||
|
// changed here — the fix is `mavend -reembed`.
|
||||||
|
func checkStoredEmbedder(dataStore *store.Store, emb router.Embedder) {
|
||||||
|
if dataStore == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
current := router.EmbedderID(emb)
|
||||||
|
if reembedOnStart {
|
||||||
|
runReembed(dataStore, emb, current)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
stored, mismatch, err := dataStore.CheckEmbedder(context.Background(), current)
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("voice: embedder marker check failed: %v", err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if mismatch {
|
||||||
|
log.Printf("voice: WARNING embedder MISMATCH — stored vectors were written by %q but the configured embedder is %q; recall scores are noise until the notes and facts are re-embedded — run `mavend -reembed` once (Vikunja #378)", stored, current)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("voice: embedder marker ok (%s)", current)
|
||||||
|
}
|
||||||
|
|
||||||
|
// runReembed is the one-shot backfill behind -reembed.
|
||||||
|
//
|
||||||
|
// Why a flag and not automatic on mismatch: the embedder is ONNX on the
|
||||||
|
// laptop's CPU, so a few thousand notes is minutes of work. Doing that silently
|
||||||
|
// inside a normal start would look like the daemon hanging on boot. So the user
|
||||||
|
// runs it once, deliberately, after an embedder swap; the mismatch warning
|
||||||
|
// above tells them to. It re-embeds, logs what it did, and then the daemon
|
||||||
|
// carries on serving as usual — no separate binary, no second start needed.
|
||||||
|
func runReembed(dataStore *store.Store, emb router.Embedder, current string) {
|
||||||
|
log.Printf("voice: re-embedding stored notes and facts with %s — this can take a few minutes, do not interrupt", current)
|
||||||
|
res, err := dataStore.ReembedAll(context.Background(), current,
|
||||||
|
// EmbedPassage, not EmbedQuery: these are stored texts being searched
|
||||||
|
// FOR, which is the side they were written with.
|
||||||
|
func(ctx context.Context, text string) ([]float32, error) {
|
||||||
|
return router.EmbedPassage(ctx, emb, text)
|
||||||
|
})
|
||||||
|
if err != nil {
|
||||||
|
log.Printf("voice: re-embed FAILED, nothing was changed and no marker was written — safe to run again: %v", err)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
if res.Skipped {
|
||||||
|
log.Printf("voice: re-embed skipped — the stored vectors were already written by %s", current)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
log.Printf("voice: re-embed done — %d notes in the notes table, %d notes and %d facts in the memory index, took %s; stored vectors now belong to %s",
|
||||||
|
res.Notes, res.MemNotes, res.Facts, res.Took.Round(time.Second), current)
|
||||||
|
|
||||||
|
// A row with no text cannot be re-embedded, so its vector is still the old
|
||||||
|
// model's noise while the marker now says everything is current. Both write
|
||||||
|
// paths always store the text, so this should be zero — say it loudly
|
||||||
|
// rather than bury it in the line above if it ever isn't.
|
||||||
|
if res.NoText > 0 {
|
||||||
|
log.Printf("voice: WARNING %d stored rows had no text, so their vectors could not be re-embedded and are still noise; they will never match anything useful (Vikunja #378)", res.NoText)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
+4
-1
@@ -40,7 +40,10 @@
|
|||||||
"tokenizer_path": "/opt/maven/models/embedder/multilingual-e5-small/tokenizer.json",
|
"tokenizer_path": "/opt/maven/models/embedder/multilingual-e5-small/tokenizer.json",
|
||||||
"lib_path": "/opt/maven/lib/libonnxruntime.so"
|
"lib_path": "/opt/maven/lib/libonnxruntime.so"
|
||||||
},
|
},
|
||||||
"llm_router": false,
|
"llm_router": true,
|
||||||
|
"query_min_score": 0.55,
|
||||||
|
"query_min_margin": 0.008,
|
||||||
|
"clarify_max_attempts": 3,
|
||||||
"tool_timeout": "30s",
|
"tool_timeout": "30s",
|
||||||
"tools": [
|
"tools": [
|
||||||
{ "name": "status", "cmd": ["systemctl", "status"], "scope": "homelab", "destructive": false },
|
{ "name": "status", "cmd": ["systemctl", "status"], "scope": "homelab", "destructive": false },
|
||||||
|
|||||||
+63
-11
@@ -258,18 +258,25 @@ type VoiceConfig struct {
|
|||||||
RouterThreshold float64 `json:"router_threshold,omitempty"`
|
RouterThreshold float64 `json:"router_threshold,omitempty"`
|
||||||
|
|
||||||
// LLMRouter — route with the resident model instead of the embedding
|
// LLMRouter — route with the resident model instead of the embedding
|
||||||
// classifier. Measured on the held-out fixture (ROUTING-EVAL-31-07-2026.md)
|
// classifier. On by default since Vikunja #320.
|
||||||
// the model gets 50.0% of intents right against the classifier's 36.8%, but
|
|
||||||
// it costs about 800ms per turn instead of 30ms.
|
|
||||||
//
|
//
|
||||||
// TODO: the default stays false until this lands.
|
// Measured on the held-out fixture (ROUTING-EVAL-31-07-2026.md): 63.2% of
|
||||||
// Extractor.Extract never runs on an LLM decision, so acts arrive with no
|
// intents right against the classifier's 50.0%, and no route errors. It
|
||||||
// Fn and reminders with no Time. Turning this on today makes routing more
|
// costs about 1s per turn instead of 30ms.
|
||||||
// accurate and less safe.
|
|
||||||
//
|
//
|
||||||
// The router can now refuse: it answers "unknown" when it cannot route, and
|
// It is safe to leave on. The model can refuse — it answers "unknown" when
|
||||||
// the turn drops to the classifier and its clarify gate (Vikunja #359).
|
// it cannot route, and the turn drops to the classifier and its clarify
|
||||||
LLMRouter bool `json:"llm_router,omitempty"`
|
// gate. Any LLM error does the same, so a turn never breaks on the model.
|
||||||
|
// Slot extraction runs on LLM decisions too, so acts get their Fn and
|
||||||
|
// reminders their Time.
|
||||||
|
//
|
||||||
|
// Set it false to go back to the classifier, e.g. on a box with no
|
||||||
|
// llama-server or when 1s a turn is too slow.
|
||||||
|
//
|
||||||
|
// It is a pointer so that "missing from the file" and "explicitly false"
|
||||||
|
// are different things: missing means on, false means off. Read it with
|
||||||
|
// UseLLMRouter(), not directly.
|
||||||
|
LLMRouter *bool `json:"llm_router,omitempty"`
|
||||||
|
|
||||||
// QueryMinScore — the note-recall confidence gate. Top cosine below this
|
// QueryMinScore — the note-recall confidence gate. Top cosine below this
|
||||||
// ⇒ "I don't know" instead of a guess. Tuned for the ONNX embedder (0.55);
|
// ⇒ "I don't know" instead of a guess. Tuned for the ONNX embedder (0.55);
|
||||||
@@ -277,6 +284,18 @@ type VoiceConfig struct {
|
|||||||
// default if unset.
|
// default if unset.
|
||||||
QueryMinScore float64 `json:"query_min_score,omitempty"`
|
QueryMinScore float64 `json:"query_min_score,omitempty"`
|
||||||
|
|
||||||
|
// QueryMinMargin — the second half of the recall gate: the top hit must
|
||||||
|
// beat the runner-up by more than this. The absolute score above cannot do
|
||||||
|
// the job on its own, because the e5 embedder puts every cosine in one
|
||||||
|
// narrow high band, so a made-up question scores as high as a real one.
|
||||||
|
// The margin asks whether one note is clearly the best instead.
|
||||||
|
// Negative ⇒ off. 0 ⇒ the default below.
|
||||||
|
QueryMinMargin float64 `json:"query_min_margin,omitempty"`
|
||||||
|
|
||||||
|
// ClarifyMaxAttempts — how many clarifying questions she may ask about one
|
||||||
|
// request before she gives up and says she did not understand. Default 3.
|
||||||
|
ClarifyMaxAttempts int `json:"clarify_max_attempts,omitempty"`
|
||||||
|
|
||||||
// Persona — optional prompt prefix that tunes maven's character. Prepended
|
// Persona — optional prompt prefix that tunes maven's character. Prepended
|
||||||
// to every LLM system prompt (nudge phrasing, note queries, general
|
// to every LLM system prompt (nudge phrasing, note queries, general
|
||||||
// knowledge). Empty string ⇒ current hardcoded persona (feminine-gendered
|
// knowledge). Empty string ⇒ current hardcoded persona (feminine-gendered
|
||||||
@@ -404,7 +423,16 @@ const (
|
|||||||
DefaultAutotuneInterval = 10 * time.Minute
|
DefaultAutotuneInterval = 10 * time.Minute
|
||||||
DefaultRouterThreshold = 0.55
|
DefaultRouterThreshold = 0.55
|
||||||
DefaultQueryMinScore = 0.55
|
DefaultQueryMinScore = 0.55
|
||||||
DefaultToolTimeout = 30 * time.Second
|
// Read off the margin sweep in internal/memory/recalleval on the e5
|
||||||
|
// embedder: 0.008 answers 68% of real questions (down from 72%) and cuts
|
||||||
|
// false recall from 5/5 to 1/5. Every larger delta costs real recall
|
||||||
|
// without removing that last one until 0.020, which drops recall to 44%.
|
||||||
|
DefaultQueryMinMargin = 0.008
|
||||||
|
// DefaultClarifyMaxAttempts — see dialogue.DefaultMaxAttempts.
|
||||||
|
DefaultClarifyMaxAttempts = 3
|
||||||
|
DefaultToolTimeout = 30 * time.Second
|
||||||
|
// DefaultLLMRouter — route with the resident model unless told otherwise.
|
||||||
|
DefaultLLMRouter = true
|
||||||
|
|
||||||
DefaultFactEnrichmentInterval = 30 * time.Second
|
DefaultFactEnrichmentInterval = 30 * time.Second
|
||||||
)
|
)
|
||||||
@@ -486,9 +514,24 @@ func (c *Config) applyDefaults() {
|
|||||||
if c.Voice.QueryMinScore <= 0 {
|
if c.Voice.QueryMinScore <= 0 {
|
||||||
c.Voice.QueryMinScore = DefaultQueryMinScore
|
c.Voice.QueryMinScore = DefaultQueryMinScore
|
||||||
}
|
}
|
||||||
|
// Unset ⇒ default. Negative is how you turn the margin off on purpose,
|
||||||
|
// so it is clamped to 0 rather than replaced by the default.
|
||||||
|
switch {
|
||||||
|
case c.Voice.QueryMinMargin == 0:
|
||||||
|
c.Voice.QueryMinMargin = DefaultQueryMinMargin
|
||||||
|
case c.Voice.QueryMinMargin < 0:
|
||||||
|
c.Voice.QueryMinMargin = 0
|
||||||
|
}
|
||||||
|
if c.Voice.ClarifyMaxAttempts <= 0 {
|
||||||
|
c.Voice.ClarifyMaxAttempts = DefaultClarifyMaxAttempts
|
||||||
|
}
|
||||||
if c.Voice.ToolTimeout <= 0 {
|
if c.Voice.ToolTimeout <= 0 {
|
||||||
c.Voice.ToolTimeout = Duration(DefaultToolTimeout)
|
c.Voice.ToolTimeout = Duration(DefaultToolTimeout)
|
||||||
}
|
}
|
||||||
|
if c.Voice.LLMRouter == nil {
|
||||||
|
on := DefaultLLMRouter
|
||||||
|
c.Voice.LLMRouter = &on
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// routines: default severity to care-class (1) — the safe floor: a
|
// routines: default severity to care-class (1) — the safe floor: a
|
||||||
@@ -507,6 +550,15 @@ func (c *Config) applyDefaults() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// UseLLMRouter reports whether to route with the resident model. Unset means
|
||||||
|
// on; only an explicit false in the config turns it off.
|
||||||
|
func (v *VoiceConfig) UseLLMRouter() bool {
|
||||||
|
if v == nil || v.LLMRouter == nil {
|
||||||
|
return DefaultLLMRouter
|
||||||
|
}
|
||||||
|
return *v.LLMRouter
|
||||||
|
}
|
||||||
|
|
||||||
func (c *Config) validate() error {
|
func (c *Config) validate() error {
|
||||||
if c.Phraser != nil {
|
if c.Phraser != nil {
|
||||||
if c.Phraser.ModelPath == "" {
|
if c.Phraser.ModelPath == "" {
|
||||||
|
|||||||
@@ -171,14 +171,26 @@ func TestWeatherConfigNilOK(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestLLMRouterDefaultsOff(t *testing.T) {
|
func TestLLMRouterDefaultsOn(t *testing.T) {
|
||||||
p := writeConfig(t, `{"voice":{"enabled":true,"bind":"127.0.0.1:9100"}}`)
|
p := writeConfig(t, `{"voice":{"enabled":true,"bind":"127.0.0.1:9100"}}`)
|
||||||
c, err := Load(p)
|
c, err := Load(p)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Load: %v", err)
|
t.Fatalf("Load: %v", err)
|
||||||
}
|
}
|
||||||
if c.Voice.LLMRouter {
|
if !c.Voice.UseLLMRouter() {
|
||||||
t.Error("voice.llm_router absent should mean false")
|
t.Error("voice.llm_router absent should mean on")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Missing and explicitly false must not mean the same thing.
|
||||||
|
func TestLLMRouterExplicitFalseTurnsItOff(t *testing.T) {
|
||||||
|
p := writeConfig(t, `{"voice":{"enabled":true,"bind":"127.0.0.1:9100","llm_router":false}}`)
|
||||||
|
c, err := Load(p)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
if c.Voice.UseLLMRouter() {
|
||||||
|
t.Error("voice.llm_router false should turn it off")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -188,7 +200,7 @@ func TestLLMRouterRead(t *testing.T) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Load: %v", err)
|
t.Fatalf("Load: %v", err)
|
||||||
}
|
}
|
||||||
if !c.Voice.LLMRouter {
|
if !c.Voice.UseLLMRouter() {
|
||||||
t.Error("voice.llm_router true was not read")
|
t.Error("voice.llm_router true was not read")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -17,10 +17,11 @@ const (
|
|||||||
SlotText Slot = "text" // Slots.Text
|
SlotText Slot = "text" // Slots.Text
|
||||||
)
|
)
|
||||||
|
|
||||||
// MaxAttempts is 1 because Maven is not a nag (DESIGN.md § Non-goals). She asks
|
// DefaultMaxAttempts — how many questions she may ask about one request.
|
||||||
// one clarifying question. If the answer still leaves the slot empty she drops
|
// Three, because after three tries the likely problem is that she misheard the
|
||||||
// the request instead of asking again.
|
// whole request, not one slot — so another question about that slot won't help.
|
||||||
const MaxAttempts = 1
|
// Configurable: voice.clarify_max_attempts.
|
||||||
|
const DefaultMaxAttempts = 3
|
||||||
|
|
||||||
// PendingQuestion is what Maven holds while she waits for an answer to an open
|
// PendingQuestion is what Maven holds while she waits for an answer to an open
|
||||||
// question. Unlike the yes/no confirms in cmd/mavend/voice.go, the answer here
|
// question. Unlike the yes/no confirms in cmd/mavend/voice.go, the answer here
|
||||||
@@ -32,7 +33,17 @@ type PendingQuestion struct {
|
|||||||
Utterance string // the user's original raw words
|
Utterance string // the user's original raw words
|
||||||
Asked time.Time
|
Asked time.Time
|
||||||
TTL time.Duration
|
TTL time.Duration
|
||||||
Attempts int // questions already asked; capped by MaxAttempts
|
Attempts int // questions already asked
|
||||||
|
// MaxAttempts caps Attempts. 0 ⇒ DefaultMaxAttempts.
|
||||||
|
MaxAttempts int
|
||||||
|
}
|
||||||
|
|
||||||
|
// maxAttempts is MaxAttempts with the default filled in.
|
||||||
|
func (q *PendingQuestion) maxAttempts() int {
|
||||||
|
if q.MaxAttempts <= 0 {
|
||||||
|
return DefaultMaxAttempts
|
||||||
|
}
|
||||||
|
return q.MaxAttempts
|
||||||
}
|
}
|
||||||
|
|
||||||
func (q *PendingQuestion) IsExpired(now time.Time) bool {
|
func (q *PendingQuestion) IsExpired(now time.Time) bool {
|
||||||
@@ -41,12 +52,9 @@ func (q *PendingQuestion) IsExpired(now time.Time) bool {
|
|||||||
|
|
||||||
// CanAsk reports whether Maven may ask another question about this request.
|
// CanAsk reports whether Maven may ask another question about this request.
|
||||||
func (q *PendingQuestion) CanAsk() bool {
|
func (q *PendingQuestion) CanAsk() bool {
|
||||||
return q.Attempts < MaxAttempts
|
return q.Attempts < q.maxAttempts()
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: the daemon will phrase the question text from Missing (one short ru
|
|
||||||
// question per Slot, feminine self-reference) and speak it here.
|
|
||||||
|
|
||||||
// ClarifyStore holds the parked questions. Same shape and locking as
|
// ClarifyStore holds the parked questions. Same shape and locking as
|
||||||
// SessionStore: keyed by dialogue id, expired entries dropped on read.
|
// SessionStore: keyed by dialogue id, expired entries dropped on read.
|
||||||
type ClarifyStore struct {
|
type ClarifyStore struct {
|
||||||
@@ -67,8 +75,7 @@ func NewClarifyStore(defaultTTL time.Duration) *ClarifyStore {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: the daemon will Put a question here when Decision.Clarify fires, in
|
// Put parks a question. Called on a clarify decision (cmd/mavend/clarify.go).
|
||||||
// place of the flat "не разобрала" reply (cmd/mavend/voice.go).
|
|
||||||
func (s *ClarifyStore) Put(id string, q *PendingQuestion) {
|
func (s *ClarifyStore) Put(id string, q *PendingQuestion) {
|
||||||
if q.TTL <= 0 {
|
if q.TTL <= 0 {
|
||||||
q.TTL = s.defaultTTL
|
q.TTL = s.defaultTTL
|
||||||
@@ -78,8 +85,7 @@ func (s *ClarifyStore) Put(id string, q *PendingQuestion) {
|
|||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
}
|
}
|
||||||
|
|
||||||
// TODO: the daemon will Get on the next turn, parse that turn into Slots, call
|
// Get returns the live parked question, or nil when there is none.
|
||||||
// Answer, and Delete — the open-question twin of resolveConfirm.
|
|
||||||
func (s *ClarifyStore) Get(id string, now time.Time) *PendingQuestion {
|
func (s *ClarifyStore) Get(id string, now time.Time) *PendingQuestion {
|
||||||
s.mu.RLock()
|
s.mu.RLock()
|
||||||
q, ok := s.questions[id]
|
q, ok := s.questions[id]
|
||||||
@@ -94,6 +100,21 @@ func (s *ClarifyStore) Get(id string, now time.Time) *PendingQuestion {
|
|||||||
return q
|
return q
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TakeExpired reports whether a question was parked here but its TTL ran out,
|
||||||
|
// and drops it. Get drops such a question silently, which leaves the user
|
||||||
|
// thinking his request is still alive — the caller uses this to tell him it is
|
||||||
|
// gone before treating his words as a fresh utterance.
|
||||||
|
func (s *ClarifyStore) TakeExpired(id string, now time.Time) bool {
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
q, ok := s.questions[id]
|
||||||
|
if !ok || !q.IsExpired(now) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
delete(s.questions, id)
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
func (s *ClarifyStore) Delete(id string) {
|
func (s *ClarifyStore) Delete(id string) {
|
||||||
s.mu.Lock()
|
s.mu.Lock()
|
||||||
delete(s.questions, id)
|
delete(s.questions, id)
|
||||||
@@ -101,44 +122,45 @@ func (s *ClarifyStore) Delete(id string) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
// Answer merges the slots parsed from the user's answer into the parked ones.
|
// Answer merges the slots parsed from the user's answer into the parked ones.
|
||||||
// Only the slots listed in Missing are filled, and an already filled slot is
|
// Only the slots listed in Missing are touched. Within those, a value the answer
|
||||||
// never overwritten — the answer completes the original request, it does not
|
// carries WINS over what was parked: she asked about this slot, so «нет, в пять»
|
||||||
// restate it. Parsing the answer text into `answer` is the caller's job; this
|
// after «в три» must replace the time, not be thrown away.
|
||||||
// package must stay free of internal/router.
|
//
|
||||||
|
// This is the clarify answer only. A correction in a fresh turn ("вообще-то
|
||||||
|
// перенеси на пять") is a different code path (followUpMerge) — not here.
|
||||||
|
//
|
||||||
|
// Parsing the answer text into `answer` is the caller's job; this package must
|
||||||
|
// stay free of internal/router.
|
||||||
func (q *PendingQuestion) Answer(text string, answer Slots) Slots {
|
func (q *PendingQuestion) Answer(text string, answer Slots) Slots {
|
||||||
out := q.Slots
|
out := q.Slots
|
||||||
for _, slot := range q.Missing {
|
for _, slot := range q.Missing {
|
||||||
switch slot {
|
switch slot {
|
||||||
case SlotTime:
|
case SlotTime:
|
||||||
if !out.HasTime && answer.HasTime {
|
if answer.HasTime {
|
||||||
out.Time = answer.Time
|
out.Time = answer.Time
|
||||||
out.HasTime = true
|
out.HasTime = true
|
||||||
}
|
}
|
||||||
case SlotKey:
|
case SlotKey:
|
||||||
if !out.HasKey && answer.HasKey {
|
if answer.HasKey {
|
||||||
out.Key = answer.Key
|
out.Key = answer.Key
|
||||||
out.HasKey = true
|
out.HasKey = true
|
||||||
}
|
}
|
||||||
case SlotValue:
|
case SlotValue:
|
||||||
if out.Value == "" && answer.Value != "" {
|
if answer.Value != "" {
|
||||||
out.Value = answer.Value
|
out.Value = answer.Value
|
||||||
}
|
}
|
||||||
case SlotFn:
|
case SlotFn:
|
||||||
if !out.HasFn && answer.HasFn {
|
if answer.HasFn {
|
||||||
out.Fn = answer.Fn
|
out.Fn = answer.Fn
|
||||||
out.HasFn = true
|
out.HasFn = true
|
||||||
if len(out.Args) == 0 {
|
out.Args = append([]string(nil), answer.Args...)
|
||||||
out.Args = append([]string(nil), answer.Args...)
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
case SlotText:
|
case SlotText:
|
||||||
if out.Text == "" {
|
if answer.Text != "" {
|
||||||
if answer.Text != "" {
|
out.Text = answer.Text
|
||||||
out.Text = answer.Text
|
} else if out.Text == "" {
|
||||||
} else {
|
// No parse for a text slot — the raw answer IS the text.
|
||||||
// No parse for a text slot — the raw answer IS the text.
|
out.Text = text
|
||||||
out.Text = text
|
|
||||||
}
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -1,6 +1,7 @@
|
|||||||
package dialogue
|
package dialogue
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"reflect"
|
||||||
"testing"
|
"testing"
|
||||||
"time"
|
"time"
|
||||||
)
|
)
|
||||||
@@ -59,6 +60,28 @@ func TestClarifyStoreGetPutDelete(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TestClarifyStoreTakeExpired — TakeExpired reports (and drops) only a question
|
||||||
|
// whose TTL ran out.
|
||||||
|
func TestClarifyStoreTakeExpired(t *testing.T) {
|
||||||
|
s := NewClarifyStore(time.Minute)
|
||||||
|
if s.TakeExpired("voice", base) {
|
||||||
|
t.Fatal("nothing parked ⇒ nothing expired")
|
||||||
|
}
|
||||||
|
s.Put("voice", &PendingQuestion{Missing: []Slot{SlotTime}, Asked: base, TTL: time.Minute})
|
||||||
|
if s.TakeExpired("voice", base.Add(30*time.Second)) {
|
||||||
|
t.Fatal("a live question must not report as expired")
|
||||||
|
}
|
||||||
|
if s.Get("voice", base.Add(30*time.Second)) == nil {
|
||||||
|
t.Fatal("a live question must survive TakeExpired")
|
||||||
|
}
|
||||||
|
if !s.TakeExpired("voice", base.Add(2*time.Minute)) {
|
||||||
|
t.Fatal("a stale question must report as expired")
|
||||||
|
}
|
||||||
|
if s.TakeExpired("voice", base.Add(2*time.Minute)) {
|
||||||
|
t.Fatal("TakeExpired must drop the question, so the second call is false")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestNewClarifyStoreDefaultTTL(t *testing.T) {
|
func TestNewClarifyStoreDefaultTTL(t *testing.T) {
|
||||||
s := NewClarifyStore(0)
|
s := NewClarifyStore(0)
|
||||||
q := &PendingQuestion{Asked: base}
|
q := &PendingQuestion{Asked: base}
|
||||||
@@ -89,12 +112,13 @@ func TestAnswerFillsOnlyMissingSlots(t *testing.T) {
|
|||||||
want: Slots{Text: "напомни позвонить", Time: answerTime, HasTime: true},
|
want: Slots{Text: "напомни позвонить", Time: answerTime, HasTime: true},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "does not overwrite a filled time",
|
// He restated it: «нет, в пять». The new value wins.
|
||||||
|
name: "a restated time overwrites the parked one",
|
||||||
parked: Slots{Time: other, HasTime: true},
|
parked: Slots{Time: other, HasTime: true},
|
||||||
missing: []Slot{SlotTime},
|
missing: []Slot{SlotTime},
|
||||||
text: "в три",
|
text: "нет, в три",
|
||||||
answer: Slots{Time: answerTime, HasTime: true},
|
answer: Slots{Time: answerTime, HasTime: true},
|
||||||
want: Slots{Time: other, HasTime: true},
|
want: Slots{Time: answerTime, HasTime: true},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "ignores slots that were not missing",
|
name: "ignores slots that were not missing",
|
||||||
@@ -121,12 +145,12 @@ func TestAnswerFillsOnlyMissingSlots(t *testing.T) {
|
|||||||
want: Slots{Fn: "restart", Args: []string{"nginx"}, HasFn: true},
|
want: Slots{Fn: "restart", Args: []string{"nginx"}, HasFn: true},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "keeps existing args when fn was already known",
|
name: "a restated fn replaces the fn and its args",
|
||||||
parked: Slots{Fn: "restart", Args: []string{"nginx"}, HasFn: true},
|
parked: Slots{Fn: "restart", Args: []string{"nginx"}, HasFn: true},
|
||||||
missing: []Slot{SlotFn},
|
missing: []Slot{SlotFn},
|
||||||
text: "останови postgres",
|
text: "останови postgres",
|
||||||
answer: Slots{Fn: "stop", Args: []string{"postgres"}, HasFn: true},
|
answer: Slots{Fn: "stop", Args: []string{"postgres"}, HasFn: true},
|
||||||
want: Slots{Fn: "restart", Args: []string{"nginx"}, HasFn: true},
|
want: Slots{Fn: "stop", Args: []string{"postgres"}, HasFn: true},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "raw answer becomes the text when nothing was parsed",
|
name: "raw answer becomes the text when nothing was parsed",
|
||||||
@@ -157,36 +181,34 @@ func TestAnswerFillsOnlyMissingSlots(t *testing.T) {
|
|||||||
for _, tc := range cases {
|
for _, tc := range cases {
|
||||||
t.Run(tc.name, func(t *testing.T) {
|
t.Run(tc.name, func(t *testing.T) {
|
||||||
q := &PendingQuestion{Slots: tc.parked, Missing: tc.missing, Asked: base}
|
q := &PendingQuestion{Slots: tc.parked, Missing: tc.missing, Asked: base}
|
||||||
got := q.Answer(tc.text, tc.answer)
|
// Whole-struct compare: a new field in Slots is covered for free.
|
||||||
if got.Time != tc.want.Time || got.HasTime != tc.want.HasTime ||
|
if got := q.Answer(tc.text, tc.answer); !reflect.DeepEqual(got, tc.want) {
|
||||||
got.Key != tc.want.Key || got.HasKey != tc.want.HasKey ||
|
|
||||||
got.Value != tc.want.Value || got.Text != tc.want.Text ||
|
|
||||||
got.Fn != tc.want.Fn || got.HasFn != tc.want.HasFn {
|
|
||||||
t.Fatalf("Answer = %+v, want %+v", got, tc.want)
|
t.Fatalf("Answer = %+v, want %+v", got, tc.want)
|
||||||
}
|
}
|
||||||
if len(got.Args) != len(tc.want.Args) {
|
|
||||||
t.Fatalf("Args = %v, want %v", got.Args, tc.want.Args)
|
|
||||||
}
|
|
||||||
for i := range got.Args {
|
|
||||||
if got.Args[i] != tc.want.Args[i] {
|
|
||||||
t.Fatalf("Args = %v, want %v", got.Args, tc.want.Args)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestCanAskCapsAtOneQuestion(t *testing.T) {
|
func TestCanAskAllowsThreeQuestionsByDefault(t *testing.T) {
|
||||||
if MaxAttempts != 1 {
|
if DefaultMaxAttempts != 3 {
|
||||||
t.Fatalf("MaxAttempts = %d, want 1 (Maven asks once, she is not a nag)", MaxAttempts)
|
t.Fatalf("DefaultMaxAttempts = %d, want 3", DefaultMaxAttempts)
|
||||||
}
|
}
|
||||||
q := &PendingQuestion{Asked: base}
|
q := &PendingQuestion{Asked: base} // MaxAttempts unset ⇒ the default
|
||||||
if !q.CanAsk() {
|
for i := 0; i < 3; i++ {
|
||||||
t.Fatal("a fresh question should be askable")
|
if !q.CanAsk() {
|
||||||
|
t.Fatalf("question %d should be allowed", i+1)
|
||||||
|
}
|
||||||
|
q.Attempts++
|
||||||
}
|
}
|
||||||
q.Attempts = MaxAttempts
|
|
||||||
if q.CanAsk() {
|
if q.CanAsk() {
|
||||||
t.Fatal("the question should not be asked twice")
|
t.Fatal("a fourth question must not be allowed")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestCanAskHonoursConfiguredMax(t *testing.T) {
|
||||||
|
q := &PendingQuestion{Asked: base, MaxAttempts: 1, Attempts: 1}
|
||||||
|
if q.CanAsk() {
|
||||||
|
t.Fatal("MaxAttempts 1 means one question only")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -1,8 +1,12 @@
|
|||||||
package dialogue
|
package dialogue
|
||||||
|
|
||||||
import (
|
import (
|
||||||
|
"context"
|
||||||
|
"encoding/json"
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
|
"github.com/kami/maven/internal/store"
|
||||||
)
|
)
|
||||||
|
|
||||||
type Intent string
|
type Intent string
|
||||||
@@ -50,10 +54,22 @@ func (s *Session) IsExpired(now time.Time) bool {
|
|||||||
return now.After(s.Timestamp.Add(s.TTL))
|
return now.After(s.Timestamp.Add(s.TTL))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// SessionPersister — the bit of the store the session needs, as an interface
|
||||||
|
// so tests can swap it out. Data is an opaque blob: the store never looks
|
||||||
|
// inside, we encode the session as JSON here.
|
||||||
|
type SessionPersister interface {
|
||||||
|
SaveDialogueSession(ctx context.Context, id string, data []byte, ts time.Time, ttl time.Duration) error
|
||||||
|
DeleteDialogueSession(ctx context.Context, id string) error
|
||||||
|
LoadDialogueSessions(ctx context.Context, now time.Time) ([]store.DialogueSessionRow, error)
|
||||||
|
}
|
||||||
|
|
||||||
|
// SessionStore keeps the live sessions in a map (the fast path) and mirrors
|
||||||
|
// every write to the persister, so a daemon restart can load them back.
|
||||||
type SessionStore struct {
|
type SessionStore struct {
|
||||||
mu sync.RWMutex
|
mu sync.RWMutex
|
||||||
sessions map[string]*Session
|
sessions map[string]*Session
|
||||||
defaultTTL time.Duration
|
defaultTTL time.Duration
|
||||||
|
persist SessionPersister // may be nil: memory only (tests, no-store paths)
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewSessionStore(defaultTTL time.Duration) *SessionStore {
|
func NewSessionStore(defaultTTL time.Duration) *SessionStore {
|
||||||
@@ -66,6 +82,43 @@ func NewSessionStore(defaultTTL time.Duration) *SessionStore {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// NewPersistentSessionStore — same store, but writes also go to the DB.
|
||||||
|
// Call Load once after this to bring back sessions from a previous run.
|
||||||
|
func NewPersistentSessionStore(defaultTTL time.Duration, p SessionPersister) *SessionStore {
|
||||||
|
s := NewSessionStore(defaultTTL)
|
||||||
|
s.persist = p
|
||||||
|
return s
|
||||||
|
}
|
||||||
|
|
||||||
|
// Load — read the saved sessions back into memory. Anything past its TTL is
|
||||||
|
// dropped (and deleted from the DB by the store), never revived.
|
||||||
|
func (s *SessionStore) Load(ctx context.Context, now time.Time) error {
|
||||||
|
if s.persist == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
rows, err := s.persist.LoadDialogueSessions(ctx, now)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
s.mu.Lock()
|
||||||
|
defer s.mu.Unlock()
|
||||||
|
for _, r := range rows {
|
||||||
|
var sess Session
|
||||||
|
if err := json.Unmarshal(r.Data, &sess); err != nil {
|
||||||
|
// A blob we can't read is not worth failing a startup over.
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if sess.TTL <= 0 {
|
||||||
|
sess.TTL = r.TTL
|
||||||
|
}
|
||||||
|
if sess.IsExpired(now) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
s.sessions[r.ID] = &sess
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
func (s *SessionStore) Get(id string, now time.Time) *Session {
|
func (s *SessionStore) Get(id string, now time.Time) *Session {
|
||||||
s.mu.RLock()
|
s.mu.RLock()
|
||||||
sess, ok := s.sessions[id]
|
sess, ok := s.sessions[id]
|
||||||
@@ -87,12 +140,33 @@ func (s *SessionStore) Put(id string, sess *Session) {
|
|||||||
s.mu.Lock()
|
s.mu.Lock()
|
||||||
s.sessions[id] = sess
|
s.sessions[id] = sess
|
||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
|
s.save(id, sess)
|
||||||
}
|
}
|
||||||
|
|
||||||
func (s *SessionStore) Delete(id string) {
|
func (s *SessionStore) Delete(id string) {
|
||||||
s.mu.Lock()
|
s.mu.Lock()
|
||||||
delete(s.sessions, id)
|
delete(s.sessions, id)
|
||||||
s.mu.Unlock()
|
s.mu.Unlock()
|
||||||
|
if s.persist != nil {
|
||||||
|
_ = s.persist.DeleteDialogueSession(context.Background(), id)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// save — mirror one session to the DB. Best effort: memory already has it, so
|
||||||
|
// a write error costs us the restart safety net, not the current turn.
|
||||||
|
func (s *SessionStore) save(id string, sess *Session) {
|
||||||
|
if s.persist == nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
data, err := json.Marshal(sess)
|
||||||
|
if err != nil {
|
||||||
|
return
|
||||||
|
}
|
||||||
|
ts := sess.Timestamp
|
||||||
|
if ts.IsZero() {
|
||||||
|
ts = time.Now()
|
||||||
|
}
|
||||||
|
_ = s.persist.SaveDialogueSession(context.Background(), id, data, ts, sess.TTL)
|
||||||
}
|
}
|
||||||
|
|
||||||
func InheritSlots(prev, cur Slots) Slots {
|
func InheritSlots(prev, cur Slots) Slots {
|
||||||
|
|||||||
@@ -0,0 +1,118 @@
|
|||||||
|
package dialogue
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"path/filepath"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
|
||||||
|
"github.com/kami/maven/internal/store"
|
||||||
|
)
|
||||||
|
|
||||||
|
// openStore — a store on disk, so a second handle can reopen the same file.
|
||||||
|
func openStore(t *testing.T, path string) *store.Store {
|
||||||
|
t.Helper()
|
||||||
|
s, err := store.Open(context.Background(), path)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("open store: %v", err)
|
||||||
|
}
|
||||||
|
t.Cleanup(func() { _ = s.Close() })
|
||||||
|
return s
|
||||||
|
}
|
||||||
|
|
||||||
|
// A session written before a restart comes back and still merges a follow-up.
|
||||||
|
func TestSessionSurvivesRestart(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
path := filepath.Join(t.TempDir(), "maven_test.db")
|
||||||
|
now := time.Now().UTC().Truncate(time.Millisecond)
|
||||||
|
|
||||||
|
first := openStore(t, path)
|
||||||
|
before := NewPersistentSessionStore(2*time.Minute, first)
|
||||||
|
before.Put("voice", &Session{
|
||||||
|
Intent: IntentReminder,
|
||||||
|
Slots: Slots{Text: "полить цветы", Time: now.Add(time.Hour), HasTime: true},
|
||||||
|
Timestamp: now,
|
||||||
|
TTL: 2 * time.Minute,
|
||||||
|
})
|
||||||
|
if err := first.Close(); err != nil {
|
||||||
|
t.Fatalf("close: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// fresh handle, fresh in-memory map — as after a daemon restart
|
||||||
|
after := openStore(t, path)
|
||||||
|
reloaded := NewPersistentSessionStore(2*time.Minute, after)
|
||||||
|
if err := reloaded.Load(ctx, now.Add(10*time.Second)); err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
sess := reloaded.Get("voice", now.Add(10*time.Second))
|
||||||
|
if sess == nil {
|
||||||
|
t.Fatal("session did not survive the restart")
|
||||||
|
}
|
||||||
|
if sess.Intent != IntentReminder {
|
||||||
|
t.Fatalf("intent = %q, want reminder", sess.Intent)
|
||||||
|
}
|
||||||
|
// the follow-up carries no text of its own; it must inherit the old one
|
||||||
|
merged := InheritSlots(sess.Slots, Slots{Time: now.Add(2 * time.Hour), HasTime: true})
|
||||||
|
if merged.Text != "полить цветы" {
|
||||||
|
t.Fatalf("merged text = %q, want the earlier turn's text", merged.Text)
|
||||||
|
}
|
||||||
|
if !merged.Time.Equal(now.Add(2 * time.Hour)) {
|
||||||
|
t.Fatalf("merged time = %v, want the follow-up's time", merged.Time)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A session past its TTL is dead: a restart must not bring it back.
|
||||||
|
func TestExpiredSessionNotResurrected(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
path := filepath.Join(t.TempDir(), "maven_test.db")
|
||||||
|
now := time.Now().UTC().Truncate(time.Millisecond)
|
||||||
|
|
||||||
|
first := openStore(t, path)
|
||||||
|
before := NewPersistentSessionStore(2*time.Minute, first)
|
||||||
|
before.Put("voice", &Session{
|
||||||
|
Intent: IntentReminder,
|
||||||
|
Slots: Slots{Text: "полить цветы"},
|
||||||
|
Timestamp: now,
|
||||||
|
TTL: time.Minute,
|
||||||
|
})
|
||||||
|
if err := first.Close(); err != nil {
|
||||||
|
t.Fatalf("close: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
after := openStore(t, path)
|
||||||
|
reloaded := NewPersistentSessionStore(2*time.Minute, after)
|
||||||
|
later := now.Add(5 * time.Minute) // well past the 1-min TTL
|
||||||
|
if err := reloaded.Load(ctx, later); err != nil {
|
||||||
|
t.Fatalf("Load: %v", err)
|
||||||
|
}
|
||||||
|
if sess := reloaded.Get("voice", later); sess != nil {
|
||||||
|
t.Fatalf("expired session came back: %+v", sess)
|
||||||
|
}
|
||||||
|
// and it is gone from the DB too, not just from memory
|
||||||
|
rows, err := after.LoadDialogueSessions(ctx, later)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("LoadDialogueSessions: %v", err)
|
||||||
|
}
|
||||||
|
if len(rows) != 0 {
|
||||||
|
t.Fatalf("expired row still in the DB: %+v", rows)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Delete removes the row as well, so an ended conversation stays ended.
|
||||||
|
func TestDeleteRemovesPersistedSession(t *testing.T) {
|
||||||
|
ctx := context.Background()
|
||||||
|
path := filepath.Join(t.TempDir(), "maven_test.db")
|
||||||
|
now := time.Now().UTC().Truncate(time.Millisecond)
|
||||||
|
|
||||||
|
s := openStore(t, path)
|
||||||
|
ss := NewPersistentSessionStore(2*time.Minute, s)
|
||||||
|
ss.Put("voice", &Session{Intent: IntentChat, Timestamp: now, TTL: time.Minute})
|
||||||
|
ss.Delete("voice")
|
||||||
|
rows, err := s.LoadDialogueSessions(ctx, now)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("LoadDialogueSessions: %v", err)
|
||||||
|
}
|
||||||
|
if len(rows) != 0 {
|
||||||
|
t.Fatalf("row survived Delete: %+v", rows)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,38 @@
|
|||||||
|
package memory
|
||||||
|
|
||||||
|
// Confidence gate for a recall. Two checks, both must pass before Maven says a
|
||||||
|
// note back:
|
||||||
|
//
|
||||||
|
// - minScore — an absolute cosine floor.
|
||||||
|
// - minMargin — the top hit must beat the runner-up by more than this.
|
||||||
|
//
|
||||||
|
// The margin is the one that carries the weight. The e5 embedder packs every
|
||||||
|
// score into a narrow high band (0.79-0.89 on the recall fixture), so an
|
||||||
|
// absolute floor cannot tell a real hit from a confident-looking miss: every
|
||||||
|
// value under the band admits everything, every value above it answers nothing.
|
||||||
|
// A margin asks a different question — "is this note clearly the best one, or
|
||||||
|
// is the whole shelf equally close?" — and a made-up question has no clear best.
|
||||||
|
//
|
||||||
|
// With one hit and no runner-up there is nothing to compare, so only the floor
|
||||||
|
// applies.
|
||||||
|
|
||||||
|
// ConfidentScores reports whether the top score clears both gates. scores must
|
||||||
|
// be sorted highest first. minMargin <= 0 turns the margin check off.
|
||||||
|
func ConfidentScores(scores []float64, minScore, minMargin float64) bool {
|
||||||
|
if len(scores) == 0 || scores[0] < minScore {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
if minMargin > 0 && len(scores) > 1 && scores[0]-scores[1] <= minMargin {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// Confident is ConfidentScores for search results.
|
||||||
|
func Confident(results []Result, minScore, minMargin float64) bool {
|
||||||
|
scores := make([]float64, len(results))
|
||||||
|
for i, r := range results {
|
||||||
|
scores[i] = r.Score
|
||||||
|
}
|
||||||
|
return ConfidentScores(scores, minScore, minMargin)
|
||||||
|
}
|
||||||
@@ -0,0 +1,45 @@
|
|||||||
|
package memory
|
||||||
|
|
||||||
|
import "testing"
|
||||||
|
|
||||||
|
func TestConfidentScores(t *testing.T) {
|
||||||
|
cases := []struct {
|
||||||
|
name string
|
||||||
|
scores []float64
|
||||||
|
minScore float64
|
||||||
|
minMargin float64
|
||||||
|
want bool
|
||||||
|
}{
|
||||||
|
{"no hits", nil, 0.55, 0.008, false},
|
||||||
|
{"below the floor", []float64{0.40, 0.10}, 0.55, 0.008, false},
|
||||||
|
{"clear winner", []float64{0.86, 0.70}, 0.55, 0.008, true},
|
||||||
|
{"runner-up too close", []float64{0.860, 0.858}, 0.55, 0.008, false},
|
||||||
|
// The rule is "beats the runner-up by MORE than delta". Not testing an
|
||||||
|
// exactly-equal margin: no pair of these decimals subtracts to exactly
|
||||||
|
// 0.008 in binary float, so such a test would pin rounding, not the rule.
|
||||||
|
{"margin just under delta", []float64{0.8079, 0.8}, 0.55, 0.008, false},
|
||||||
|
{"margin just over delta", []float64{0.8081, 0.8}, 0.55, 0.008, true},
|
||||||
|
// One hit: nothing to compare against, so only the floor applies.
|
||||||
|
{"single hit clears", []float64{0.86}, 0.55, 0.008, true},
|
||||||
|
{"single hit below floor", []float64{0.10}, 0.55, 0.008, false},
|
||||||
|
// Margin off — the old absolute-only behaviour.
|
||||||
|
{"margin off admits a tie", []float64{0.86, 0.86}, 0.55, 0, true},
|
||||||
|
}
|
||||||
|
for _, c := range cases {
|
||||||
|
t.Run(c.name, func(t *testing.T) {
|
||||||
|
if got := ConfidentScores(c.scores, c.minScore, c.minMargin); got != c.want {
|
||||||
|
t.Errorf("got %v, want %v", got, c.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestConfidentReadsResultScores(t *testing.T) {
|
||||||
|
res := []Result{{ID: "a", Score: 0.86}, {ID: "b", Score: 0.858}}
|
||||||
|
if Confident(res, 0.55, 0.008) {
|
||||||
|
t.Error("thin margin passed the gate")
|
||||||
|
}
|
||||||
|
if !Confident(res, 0.55, 0) {
|
||||||
|
t.Error("margin off should fall back to the floor alone")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -177,6 +177,8 @@ type Outcome struct {
|
|||||||
Tied bool
|
Tied bool
|
||||||
TopID string
|
TopID string
|
||||||
TopScor float64
|
TopScor float64
|
||||||
|
// Margin — top1 − top2. 0 when fewer than two hits came back.
|
||||||
|
Margin float64
|
||||||
Reasons []string
|
Reasons []string
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -184,8 +186,10 @@ type Outcome struct {
|
|||||||
// ranks first but is silenced by query_min_score is a threshold problem, and a
|
// ranks first but is silenced by query_min_score is a threshold problem, and a
|
||||||
// note that never ranks first is an embedder problem. Those are different fixes.
|
// note that never ranks first is an embedder problem. Those are different fixes.
|
||||||
type Report struct {
|
type Report struct {
|
||||||
Name string
|
Name string
|
||||||
MinScore float64
|
MinScore float64
|
||||||
|
// MinMargin — how far the top hit must beat the runner-up. 0 ⇒ off.
|
||||||
|
MinMargin float64
|
||||||
Total int
|
Total int
|
||||||
Answerable int
|
Answerable int
|
||||||
Rank1 int
|
Rank1 int
|
||||||
@@ -212,9 +216,14 @@ type Report struct {
|
|||||||
// where the right note ranked first, and for the no-answer cases. The gap
|
// where the right note ranked first, and for the no-answer cases. The gap
|
||||||
// between these two distributions is what a defensible query_min_score
|
// between these two distributions is what a defensible query_min_score
|
||||||
// would have to sit inside; if they overlap, no threshold separates them.
|
// would have to sit inside; if they overlap, no threshold separates them.
|
||||||
CorrectTop []float64
|
CorrectTop []float64
|
||||||
NoAnswerTop []float64
|
NoAnswerTop []float64
|
||||||
P50, P95, Max time.Duration
|
// CorrectMargin / NoAnswerMargin — the same two groups, but top1 − top2
|
||||||
|
// instead of top1. This is the pair the margin gate has to separate, and
|
||||||
|
// unlike the absolute scores it is what the sweep reads.
|
||||||
|
CorrectMargin []float64
|
||||||
|
NoAnswerMargin []float64
|
||||||
|
P50, P95, Max time.Duration
|
||||||
}
|
}
|
||||||
|
|
||||||
// TagStat — passed/total for one slice of the fixture.
|
// TagStat — passed/total for one slice of the fixture.
|
||||||
@@ -245,13 +254,14 @@ func ratio(n, d int) float64 {
|
|||||||
// the run on an embed or search error: an erroring case scores as a miss and is
|
// the run on an embed or search error: an erroring case scores as a miss and is
|
||||||
// counted in Errors, because "the embedder was down" and "the embedder was
|
// counted in Errors, because "the embedder was down" and "the embedder was
|
||||||
// wrong" are different numbers.
|
// wrong" are different numbers.
|
||||||
func Score(ctx context.Context, name string, emb router.Embedder, newStore NewStore, minScore float64, f Fixture) (Report, error) {
|
func Score(ctx context.Context, name string, emb router.Embedder, newStore NewStore, minScore, minMargin float64, f Fixture) (Report, error) {
|
||||||
rep := Report{
|
rep := Report{
|
||||||
Name: name,
|
Name: name,
|
||||||
MinScore: minScore,
|
MinScore: minScore,
|
||||||
Total: len(f.Cases),
|
MinMargin: minMargin,
|
||||||
ByTag: map[string]TagStat{},
|
Total: len(f.Cases),
|
||||||
ByLang: map[string]TagStat{},
|
ByTag: map[string]TagStat{},
|
||||||
|
ByLang: map[string]TagStat{},
|
||||||
}
|
}
|
||||||
lat := make([]time.Duration, 0, len(f.Cases))
|
lat := make([]time.Duration, 0, len(f.Cases))
|
||||||
|
|
||||||
@@ -261,7 +271,7 @@ func Score(ctx context.Context, name string, emb router.Embedder, newStore NewSt
|
|||||||
} else {
|
} else {
|
||||||
rep.NoAnswer++
|
rep.NoAnswer++
|
||||||
}
|
}
|
||||||
o, err := scoreCase(ctx, emb, newStore, minScore, c, f.Filler)
|
o, err := scoreCase(ctx, emb, newStore, minScore, minMargin, c, f.Filler)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return Report{}, err
|
return Report{}, err
|
||||||
}
|
}
|
||||||
@@ -285,6 +295,11 @@ func Score(ctx context.Context, name string, emb router.Embedder, newStore NewSt
|
|||||||
} else if !o.Rank1 {
|
} else if !o.Rank1 {
|
||||||
rep.WrongTop++
|
rep.WrongTop++
|
||||||
}
|
}
|
||||||
|
if o.Rank1 {
|
||||||
|
// Margins are collected on rank, not on the gate, so the
|
||||||
|
// distribution does not move as the sweep changes the gate.
|
||||||
|
rep.CorrectMargin = append(rep.CorrectMargin, o.Margin)
|
||||||
|
}
|
||||||
if o.Rank1 && o.Recalled != "" {
|
if o.Rank1 && o.Recalled != "" {
|
||||||
rep.CorrectTop = append(rep.CorrectTop, o.TopScor)
|
rep.CorrectTop = append(rep.CorrectTop, o.TopScor)
|
||||||
}
|
}
|
||||||
@@ -293,6 +308,7 @@ func Score(ctx context.Context, name string, emb router.Embedder, newStore NewSt
|
|||||||
rep.FalseRecall++
|
rep.FalseRecall++
|
||||||
}
|
}
|
||||||
rep.NoAnswerTop = append(rep.NoAnswerTop, o.TopScor)
|
rep.NoAnswerTop = append(rep.NoAnswerTop, o.TopScor)
|
||||||
|
rep.NoAnswerMargin = append(rep.NoAnswerMargin, o.Margin)
|
||||||
}
|
}
|
||||||
|
|
||||||
if o.Pass {
|
if o.Pass {
|
||||||
@@ -307,6 +323,8 @@ func Score(ctx context.Context, name string, emb router.Embedder, newStore NewSt
|
|||||||
|
|
||||||
sort.Float64s(rep.CorrectTop)
|
sort.Float64s(rep.CorrectTop)
|
||||||
sort.Float64s(rep.NoAnswerTop)
|
sort.Float64s(rep.NoAnswerTop)
|
||||||
|
sort.Float64s(rep.CorrectMargin)
|
||||||
|
sort.Float64s(rep.NoAnswerMargin)
|
||||||
sort.Slice(lat, func(i, j int) bool { return lat[i] < lat[j] })
|
sort.Slice(lat, func(i, j int) bool { return lat[i] < lat[j] })
|
||||||
rep.P50, rep.P95 = percentile(lat, 0.50), percentile(lat, 0.95)
|
rep.P50, rep.P95 = percentile(lat, 0.50), percentile(lat, 0.95)
|
||||||
if len(lat) > 0 {
|
if len(lat) > 0 {
|
||||||
@@ -318,7 +336,7 @@ func Score(ctx context.Context, name string, emb router.Embedder, newStore NewSt
|
|||||||
// scoreCase inserts the case's notes into a fresh store, then runs the read
|
// scoreCase inserts the case's notes into a fresh store, then runs the read
|
||||||
// path the daemon runs. The returned error is fatal (the harness is broken);
|
// path the daemon runs. The returned error is fatal (the harness is broken);
|
||||||
// an embedder or store failure on the query lands in Outcome.Err instead.
|
// an embedder or store failure on the query lands in Outcome.Err instead.
|
||||||
func scoreCase(ctx context.Context, emb router.Embedder, newStore NewStore, minScore float64, c Case, filler []StoredNote) (Outcome, error) {
|
func scoreCase(ctx context.Context, emb router.Embedder, newStore NewStore, minScore, minMargin float64, c Case, filler []StoredNote) (Outcome, error) {
|
||||||
st, release, err := newStore()
|
st, release, err := newStore()
|
||||||
if err != nil {
|
if err != nil {
|
||||||
return Outcome{}, fmt.Errorf("%s: new store: %w", c.ID, err)
|
return Outcome{}, fmt.Errorf("%s: new store: %w", c.ID, err)
|
||||||
@@ -357,7 +375,10 @@ func scoreCase(ctx context.Context, emb router.Embedder, newStore NewStore, minS
|
|||||||
|
|
||||||
if len(hits) > 0 {
|
if len(hits) > 0 {
|
||||||
o.TopID, o.TopScor = hits[0].ID, hits[0].Score
|
o.TopID, o.TopScor = hits[0].ID, hits[0].Score
|
||||||
o.Recalled = bestRecall(hits, minScore)
|
if len(hits) > 1 {
|
||||||
|
o.Margin = hits[0].Score - hits[1].Score
|
||||||
|
}
|
||||||
|
o.Recalled = bestRecall(hits, minScore, minMargin)
|
||||||
}
|
}
|
||||||
for i, h := range hits {
|
for i, h := range hits {
|
||||||
if h.ID != c.Want {
|
if h.ID != c.Want {
|
||||||
@@ -378,14 +399,14 @@ func scoreCase(ctx context.Context, emb router.Embedder, newStore NewStore, minS
|
|||||||
switch {
|
switch {
|
||||||
case !c.Answerable():
|
case !c.Answerable():
|
||||||
if o.Recalled != "" {
|
if o.Recalled != "" {
|
||||||
o.Reasons = append(o.Reasons, fmt.Sprintf("false recall: %q at %.3f, want silence", o.TopID, o.TopScor))
|
o.Reasons = append(o.Reasons, fmt.Sprintf("false recall: %q at %.3f (margin %.3f), want silence", o.TopID, o.TopScor, o.Margin))
|
||||||
}
|
}
|
||||||
case o.Tied:
|
case o.Tied:
|
||||||
o.Reasons = append(o.Reasons, fmt.Sprintf("tie at %.3f — the right note is on top only by sort order", o.TopScor))
|
o.Reasons = append(o.Reasons, fmt.Sprintf("tie at %.3f — the right note is on top only by sort order", o.TopScor))
|
||||||
case !o.Rank1:
|
case !o.Rank1:
|
||||||
o.Reasons = append(o.Reasons, fmt.Sprintf("top hit %q (%.3f), want %q%s", o.TopID, o.TopScor, c.Want, rankNote(o.Rank3)))
|
o.Reasons = append(o.Reasons, fmt.Sprintf("top hit %q (%.3f), want %q%s", o.TopID, o.TopScor, c.Want, rankNote(o.Rank3)))
|
||||||
case o.Recalled == "":
|
case o.Recalled == "":
|
||||||
o.Reasons = append(o.Reasons, fmt.Sprintf("right note ranked first but scored %.3f < gate %.2f — daemon says \"не знаю\"", o.TopScor, minScore))
|
o.Reasons = append(o.Reasons, fmt.Sprintf("right note ranked first at %.3f (margin %.3f) but the gate silenced it — daemon says \"не знаю\"", o.TopScor, o.Margin))
|
||||||
}
|
}
|
||||||
o.Pass = len(o.Reasons) == 0
|
o.Pass = len(o.Reasons) == 0
|
||||||
return o, nil
|
return o, nil
|
||||||
@@ -401,8 +422,10 @@ func rankNote(inTop3 bool) string {
|
|||||||
// bestRecall mirrors cmd/mavend/recall.go — the gate the daemon actually
|
// bestRecall mirrors cmd/mavend/recall.go — the gate the daemon actually
|
||||||
// applies to a memory hit. Duplicated rather than imported because package main
|
// applies to a memory hit. Duplicated rather than imported because package main
|
||||||
// is not importable; recalleval_test.go asserts the two agree in behaviour.
|
// is not importable; recalleval_test.go asserts the two agree in behaviour.
|
||||||
func bestRecall(results []memory.Result, min float64) string {
|
// The daemon returns the whole hit (a note and a fact are said differently);
|
||||||
if len(results) == 0 || results[0].Score < min {
|
// the harness only scores what came back, so it keeps returning the text.
|
||||||
|
func bestRecall(results []memory.Result, minScore, minMargin float64) string {
|
||||||
|
if !memory.Confident(results, minScore, minMargin) {
|
||||||
return ""
|
return ""
|
||||||
}
|
}
|
||||||
return results[0].Meta["text"]
|
return results[0].Meta["text"]
|
||||||
@@ -437,7 +460,7 @@ func percentile(sorted []time.Duration, p float64) time.Duration {
|
|||||||
// the slices that name where the path is weak.
|
// the slices that name where the path is weak.
|
||||||
func (r Report) String() string {
|
func (r Report) String() string {
|
||||||
var b strings.Builder
|
var b strings.Builder
|
||||||
fmt.Fprintf(&b, "%s: %d/%d cases pass (gate %.2f)\n", r.Name, r.Passed, r.Total, r.MinScore)
|
fmt.Fprintf(&b, "%s: %d/%d cases pass (gate %.2f, margin %.3f)\n", r.Name, r.Passed, r.Total, r.MinScore, r.MinMargin)
|
||||||
fmt.Fprintf(&b, " recall@1 %.1f%% (%d/%d) recall@3 %.1f%% (%d/%d) answered after gate %.1f%% (%d/%d)\n",
|
fmt.Fprintf(&b, " recall@1 %.1f%% (%d/%d) recall@3 %.1f%% (%d/%d) answered after gate %.1f%% (%d/%d)\n",
|
||||||
100*r.Recall1(), r.Rank1, r.Answerable,
|
100*r.Recall1(), r.Rank1, r.Answerable,
|
||||||
100*r.Recall3(), r.Rank3, r.Answerable,
|
100*r.Recall3(), r.Rank3, r.Answerable,
|
||||||
@@ -448,6 +471,8 @@ func (r Report) String() string {
|
|||||||
100*r.FalseRecallRate(), r.FalseRecall, r.NoAnswer)
|
100*r.FalseRecallRate(), r.FalseRecall, r.NoAnswer)
|
||||||
fmt.Fprintf(&b, " top-1 score, right note first: %s\n", spread(r.CorrectTop))
|
fmt.Fprintf(&b, " top-1 score, right note first: %s\n", spread(r.CorrectTop))
|
||||||
fmt.Fprintf(&b, " top-1 score, must be silent: %s\n", spread(r.NoAnswerTop))
|
fmt.Fprintf(&b, " top-1 score, must be silent: %s\n", spread(r.NoAnswerTop))
|
||||||
|
fmt.Fprintf(&b, " margin top1-top2, right note first: %s\n", spread(r.CorrectMargin))
|
||||||
|
fmt.Fprintf(&b, " margin top1-top2, must be silent: %s\n", spread(r.NoAnswerMargin))
|
||||||
fmt.Fprintf(&b, " latency: p50 %s p95 %s max %s\n", r.P50, r.P95, r.Max)
|
fmt.Fprintf(&b, " latency: p50 %s p95 %s max %s\n", r.P50, r.P95, r.Max)
|
||||||
fmt.Fprintf(&b, " by lang: %s\n", renderStats(r.ByLang))
|
fmt.Fprintf(&b, " by lang: %s\n", renderStats(r.ByLang))
|
||||||
fmt.Fprintf(&b, " by tag: %s\n", renderStats(r.ByTag))
|
fmt.Fprintf(&b, " by tag: %s\n", renderStats(r.ByTag))
|
||||||
|
|||||||
@@ -142,21 +142,40 @@ func words(s string) []string {
|
|||||||
// cmd/mavend/recall.go (package main is not importable). This pins the copy to
|
// cmd/mavend/recall.go (package main is not importable). This pins the copy to
|
||||||
// the original's three rules: no hits, below the gate, or no text ⇒ silence.
|
// the original's three rules: no hits, below the gate, or no text ⇒ silence.
|
||||||
func TestBestRecallMatchesDaemon(t *testing.T) {
|
func TestBestRecallMatchesDaemon(t *testing.T) {
|
||||||
if got := bestRecall(nil, 0.55); got != "" {
|
if got := bestRecall(nil, 0.55, 0); got != "" {
|
||||||
t.Errorf("no hits: got %q, want silence", got)
|
t.Errorf("no hits: got %q, want silence", got)
|
||||||
}
|
}
|
||||||
low := []memory.Result{{ID: "a", Score: 0.4, Meta: map[string]string{"text": "чай"}}}
|
low := []memory.Result{{ID: "a", Score: 0.4, Meta: map[string]string{"text": "чай"}}}
|
||||||
if got := bestRecall(low, 0.55); got != "" {
|
if got := bestRecall(low, 0.55, 0); got != "" {
|
||||||
t.Errorf("below gate: got %q, want silence", got)
|
t.Errorf("below gate: got %q, want silence", got)
|
||||||
}
|
}
|
||||||
noText := []memory.Result{{ID: "a", Score: 0.9, Meta: map[string]string{}}}
|
noText := []memory.Result{{ID: "a", Score: 0.9, Meta: map[string]string{}}}
|
||||||
if got := bestRecall(noText, 0.55); got != "" {
|
if got := bestRecall(noText, 0.55, 0); got != "" {
|
||||||
t.Errorf("no text: got %q, want silence", got)
|
t.Errorf("no text: got %q, want silence", got)
|
||||||
}
|
}
|
||||||
ok := []memory.Result{{ID: "a", Score: 0.9, Meta: map[string]string{"text": "чай"}}}
|
ok := []memory.Result{{ID: "a", Score: 0.9, Meta: map[string]string{"text": "чай"}}}
|
||||||
if got := bestRecall(ok, 0.55); got != "чай" {
|
if got := bestRecall(ok, 0.55, 0); got != "чай" {
|
||||||
t.Errorf("above gate: got %q, want %q", got, "чай")
|
t.Errorf("above gate: got %q, want %q", got, "чай")
|
||||||
}
|
}
|
||||||
|
// Margin: a close runner-up means the embedder cannot tell the two apart,
|
||||||
|
// so Maven stays silent even though both clear the absolute floor.
|
||||||
|
close := []memory.Result{
|
||||||
|
{ID: "a", Score: 0.86, Meta: map[string]string{"text": "чай"}},
|
||||||
|
{ID: "b", Score: 0.85, Meta: map[string]string{"text": "кофе"}},
|
||||||
|
}
|
||||||
|
if got := bestRecall(close, 0.55, 0.03); got != "" {
|
||||||
|
t.Errorf("thin margin: got %q, want silence", got)
|
||||||
|
}
|
||||||
|
if got := bestRecall(close, 0.55, 0); got != "чай" {
|
||||||
|
t.Errorf("margin off: got %q, want %q", got, "чай")
|
||||||
|
}
|
||||||
|
clear := []memory.Result{
|
||||||
|
{ID: "a", Score: 0.86, Meta: map[string]string{"text": "чай"}},
|
||||||
|
{ID: "b", Score: 0.70, Meta: map[string]string{"text": "кофе"}},
|
||||||
|
}
|
||||||
|
if got := bestRecall(clear, 0.55, 0.03); got != "чай" {
|
||||||
|
t.Errorf("wide margin: got %q, want %q", got, "чай")
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// TestHashRecallBaseline — the CI ratchet. HashEmbedder, so it needs no model
|
// TestHashRecallBaseline — the CI ratchet. HashEmbedder, so it needs no model
|
||||||
@@ -171,14 +190,15 @@ func TestHashRecallBaseline(t *testing.T) {
|
|||||||
t.Fatalf("Load: %v", err)
|
t.Fatalf("Load: %v", err)
|
||||||
}
|
}
|
||||||
rep, err := Score(context.Background(), "recall+hash", router.NewHashEmbedder(hashDim), InMemory,
|
rep, err := Score(context.Background(), "recall+hash", router.NewHashEmbedder(hashDim), InMemory,
|
||||||
config.DefaultQueryMinScore, f)
|
config.DefaultQueryMinScore, config.DefaultQueryMinMargin, f)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Score: %v", err)
|
t.Fatalf("Score: %v", err)
|
||||||
}
|
}
|
||||||
t.Log("\n" + rep.String() + rep.Failures())
|
t.Log("\n" + rep.String() + rep.Failures())
|
||||||
t.Log("\ngate sweep:\n" + sweep(t, router.NewHashEmbedder(hashDim), f))
|
t.Log("\ngate sweep:\n" + sweep(t, router.NewHashEmbedder(hashDim), f))
|
||||||
|
|
||||||
// 0.32 sits under the observed 0.360 recall@1.
|
// 0.32 sits under the observed 0.370 recall@1 (was 0.360 over 25 answerable
|
||||||
|
// cases; the two mixed note+fact cases added with #373 make it 27).
|
||||||
const floorRecall1 = 0.32
|
const floorRecall1 = 0.32
|
||||||
if rep.Recall1() < floorRecall1 {
|
if rep.Recall1() < floorRecall1 {
|
||||||
t.Errorf("recall@1 %.3f below ratchet %.2f — note recall regressed", rep.Recall1(), floorRecall1)
|
t.Errorf("recall@1 %.3f below ratchet %.2f — note recall regressed", rep.Recall1(), floorRecall1)
|
||||||
@@ -201,11 +221,11 @@ func TestPersistentStoreScoresTheSame(t *testing.T) {
|
|||||||
t.Fatalf("Load: %v", err)
|
t.Fatalf("Load: %v", err)
|
||||||
}
|
}
|
||||||
emb := router.NewHashEmbedder(hashDim)
|
emb := router.NewHashEmbedder(hashDim)
|
||||||
inMem, err := Score(context.Background(), "recall+hash+memory", emb, InMemory, config.DefaultQueryMinScore, f)
|
inMem, err := Score(context.Background(), "recall+hash+memory", emb, InMemory, config.DefaultQueryMinScore, config.DefaultQueryMinMargin, f)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Score in-memory: %v", err)
|
t.Fatalf("Score in-memory: %v", err)
|
||||||
}
|
}
|
||||||
persistent, err := Score(context.Background(), "recall+hash+sqlite", emb, sqliteStores(t), config.DefaultQueryMinScore, f)
|
persistent, err := Score(context.Background(), "recall+hash+sqlite", emb, sqliteStores(t), config.DefaultQueryMinScore, config.DefaultQueryMinMargin, f)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Score sqlite: %v", err)
|
t.Fatalf("Score sqlite: %v", err)
|
||||||
}
|
}
|
||||||
@@ -263,14 +283,16 @@ func TestONNXRecall(t *testing.T) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Load: %v", err)
|
t.Fatalf("Load: %v", err)
|
||||||
}
|
}
|
||||||
rep, err := Score(context.Background(), "recall+onnx", emb, InMemory, config.DefaultQueryMinScore, f)
|
rep, err := Score(context.Background(), "recall+onnx", emb, InMemory, config.DefaultQueryMinScore, config.DefaultQueryMinMargin, f)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("Score: %v", err)
|
t.Fatalf("Score: %v", err)
|
||||||
}
|
}
|
||||||
t.Log("\n" + rep.String() + rep.Failures())
|
t.Log("\n" + rep.String() + rep.Failures())
|
||||||
// Cached for the sweep only: the headline run above must pay the real
|
// Cached for the sweeps only: the headline run above must pay the real
|
||||||
// embedder cost so its latency numbers mean something.
|
// embedder cost so its latency numbers mean something.
|
||||||
t.Log("\ngate sweep:\n" + sweep(t, Cache(emb), f))
|
cached := Cache(emb)
|
||||||
|
t.Log("\ngate sweep (margin off):\n" + sweep(t, cached, f))
|
||||||
|
t.Log("\nmargin sweep (gate 0.55):\n" + marginSweep(t, cached, f))
|
||||||
}
|
}
|
||||||
|
|
||||||
// sweep scores the fixture at a range of gates and renders one line each. Two
|
// sweep scores the fixture at a range of gates and renders one line each. Two
|
||||||
@@ -281,7 +303,7 @@ func sweep(t *testing.T, emb router.Embedder, f Fixture) string {
|
|||||||
t.Helper()
|
t.Helper()
|
||||||
var b strings.Builder
|
var b strings.Builder
|
||||||
for _, gate := range []float64{0.0, 0.30, 0.40, 0.50, 0.55, 0.60, 0.70, 0.80, 0.90} {
|
for _, gate := range []float64{0.0, 0.30, 0.40, 0.50, 0.55, 0.60, 0.70, 0.80, 0.90} {
|
||||||
rep, err := Score(context.Background(), "sweep", emb, InMemory, gate, f)
|
rep, err := Score(context.Background(), "sweep", emb, InMemory, gate, 0, f)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("sweep at %.2f: %v", gate, err)
|
t.Fatalf("sweep at %.2f: %v", gate, err)
|
||||||
}
|
}
|
||||||
@@ -290,3 +312,21 @@ func sweep(t *testing.T, emb router.Embedder, f Fixture) string {
|
|||||||
}
|
}
|
||||||
return b.String()
|
return b.String()
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// marginSweep is the same idea for the margin gate (top1 − top2 > delta), with
|
||||||
|
// the absolute gate held at its default. The absolute score cannot separate a
|
||||||
|
// real hit from a made-up question under e5 — every score lands in one narrow
|
||||||
|
// band — so this sweep is the one that picks a number.
|
||||||
|
func marginSweep(t *testing.T, emb router.Embedder, f Fixture) string {
|
||||||
|
t.Helper()
|
||||||
|
var b strings.Builder
|
||||||
|
for _, d := range []float64{0, 0.002, 0.005, 0.008, 0.01, 0.012, 0.015, 0.02, 0.025, 0.03, 0.04, 0.05, 0.06} {
|
||||||
|
rep, err := Score(context.Background(), "margin sweep", emb, InMemory, config.DefaultQueryMinScore, d, f)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("margin sweep at %.3f: %v", d, err)
|
||||||
|
}
|
||||||
|
fmt.Fprintf(&b, " delta %.3f: answered %d/%d (%.0f%%) false recall %d/%d\n",
|
||||||
|
d, rep.Rank1-rep.Gated, rep.Answerable, 100*rep.Answered(), rep.FalseRecall, rep.NoAnswer)
|
||||||
|
}
|
||||||
|
return b.String()
|
||||||
|
}
|
||||||
|
|||||||
@@ -387,6 +387,32 @@
|
|||||||
{"id": "n2", "text": "wifi channel is 6", "kind": "note"},
|
{"id": "n2", "text": "wifi channel is 6", "kind": "note"},
|
||||||
{"id": "n3", "text": "the guest network is off", "kind": "note"}
|
{"id": "n3", "text": "the guest network is off", "kind": "note"}
|
||||||
]
|
]
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"id": "ru-mixed-031",
|
||||||
|
"lang": "ru",
|
||||||
|
"tags": ["mixed", "paraphrase", "hard"],
|
||||||
|
"note": "notes and facts in one store and the note is the answer — the daemon indexes both (Vikunja #373)",
|
||||||
|
"query": "куда я спрятал второй ключ от квартиры",
|
||||||
|
"want": "n1",
|
||||||
|
"notes": [
|
||||||
|
{"id": "n1", "text": "запасной ключ от квартиры лежит в синей коробке на полке", "kind": "note"},
|
||||||
|
{"id": "x1", "text": "поменял замок в двери двадцатого июня", "kind": "fact"},
|
||||||
|
{"id": "x2", "text": "отдал ключ соседке в мае", "kind": "fact"}
|
||||||
|
]
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"id": "ru-mixed-032",
|
||||||
|
"lang": "ru",
|
||||||
|
"tags": ["mixed", "distractor"],
|
||||||
|
"note": "the mirror of ru-mixed-031: the fact answers and the notes are the distractors",
|
||||||
|
"query": "когда я в последний раз заливал бензин",
|
||||||
|
"want": "x1",
|
||||||
|
"notes": [
|
||||||
|
{"id": "x1", "text": "залил полный бак в четверг вечером", "kind": "fact"},
|
||||||
|
{"id": "n1", "text": "на заправке у моста дешевле бензин", "kind": "note"},
|
||||||
|
{"id": "n2", "text": "надо поменять зимние шины", "kind": "note"}
|
||||||
|
]
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -0,0 +1,26 @@
|
|||||||
|
package eval
|
||||||
|
|
||||||
|
import "testing"
|
||||||
|
|
||||||
|
func TestAddressTimeWordDoesNotBlind(t *testing.T) {
|
||||||
|
// A nudge that opens with a time word must still be caught. Without the
|
||||||
|
// time words in the stoplist, "сегодня" was read as the third party.
|
||||||
|
for _, s := range []string{
|
||||||
|
"сегодня он не ел 11 дней",
|
||||||
|
"вчера он не пил воду",
|
||||||
|
"опять он забыл про таблетки",
|
||||||
|
} {
|
||||||
|
if r := checkAddress(s); r.Pass {
|
||||||
|
t.Errorf("checkAddress(%q) passed, want a third-person failure", s)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
// Still must not fire when a third party really is named.
|
||||||
|
for _, s := range []string{
|
||||||
|
"сегодня сервис упал, он не отвечает",
|
||||||
|
"ты не пил воду четыре часа",
|
||||||
|
} {
|
||||||
|
if r := checkAddress(s); !r.Pass {
|
||||||
|
t.Errorf("checkAddress(%q) failed: %s", s, r.Detail)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -17,10 +17,18 @@ const (
|
|||||||
CheckFeminine = "feminine" // her self-reference is feminine (hard constraint)
|
CheckFeminine = "feminine" // her self-reference is feminine (hard constraint)
|
||||||
CheckCringe = "cringe" // DESIGN.md § Non-goals, "not a relationship"
|
CheckCringe = "cringe" // DESIGN.md § Non-goals, "not a relationship"
|
||||||
CheckOnTopic = "ontopic" // says the thing the rule is about
|
CheckOnTopic = "ontopic" // says the thing the rule is about
|
||||||
|
|
||||||
|
// CheckHisGender — the other half of the persona rule: SHE is feminine, HE
|
||||||
|
// is male. "ты давно не отдыхала" addresses the operator as a woman.
|
||||||
|
CheckHisGender = "hisgender"
|
||||||
|
|
||||||
|
// CheckAddress — she talks TO him, informally, one to one. Not "вы", not
|
||||||
|
// "он". See the comment block above checkAddress.
|
||||||
|
CheckAddress = "address"
|
||||||
)
|
)
|
||||||
|
|
||||||
// CheckNames — report order.
|
// CheckNames — report order.
|
||||||
var CheckNames = []string{CheckMood, CheckLang, CheckLength, CheckFeminine, CheckCringe, CheckOnTopic}
|
var CheckNames = []string{CheckMood, CheckLang, CheckLength, CheckFeminine, CheckHisGender, CheckAddress, CheckCringe, CheckOnTopic}
|
||||||
|
|
||||||
// Result — one check on one message.
|
// Result — one check on one message.
|
||||||
type Result struct {
|
type Result struct {
|
||||||
@@ -52,6 +60,8 @@ func RunChecks(c Case, body, mood string) []Result {
|
|||||||
checkLang(body),
|
checkLang(body),
|
||||||
checkLength(body),
|
checkLength(body),
|
||||||
checkFeminine(body),
|
checkFeminine(body),
|
||||||
|
checkHisGender(body),
|
||||||
|
checkAddress(body),
|
||||||
checkCringe(body),
|
checkCringe(body),
|
||||||
checkOnTopic(c, body),
|
checkOnTopic(c, body),
|
||||||
}
|
}
|
||||||
@@ -176,6 +186,280 @@ func checkFeminine(body string) Result {
|
|||||||
return Result{CheckFeminine, true, ""}
|
return Result{CheckFeminine, true, ""}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// --- he is male ----------------------------------------------------------
|
||||||
|
//
|
||||||
|
// The mirror of checkFeminine, and the failure it was written for: the model
|
||||||
|
// wrote "ты давно не отдыхала", which addresses the operator as a woman. That
|
||||||
|
// scored clean, because checkFeminine only ever looks at how SHE speaks about
|
||||||
|
// herself.
|
||||||
|
//
|
||||||
|
// How it works: Russian past tense is gendered by suffix, -л (m) / -ла (f). So
|
||||||
|
// this looks for feminine past-tense words in a sentence that also talks TO him
|
||||||
|
// ("ты", "тебя", "тебе", "твой", …). A feminine verb that belongs to her ("я
|
||||||
|
// заметила", "напомнила тебе") is skipped — that one is correct.
|
||||||
|
//
|
||||||
|
// Honest about the limits: this is a suffix rule, not a parser.
|
||||||
|
// - False positives: a feminine noun can be the subject in the same sentence
|
||||||
|
// ("зарядка была утром, ты её пропустил"). The guard below skips a verb whose
|
||||||
|
// previous word looks like a feminine noun, which helps but will not always
|
||||||
|
// be right.
|
||||||
|
// - False negatives: gender also shows up outside the past tense (short
|
||||||
|
// adjectives, "сама"), and none of that is checked here.
|
||||||
|
//
|
||||||
|
// That is acceptable for an eval check. It is a signal to read the message, not
|
||||||
|
// a grammar verdict, and every hit prints the word it tripped on so a human can
|
||||||
|
// disagree.
|
||||||
|
|
||||||
|
// hisMarkers — words that mean the sentence is addressed to him.
|
||||||
|
var hisMarkers = map[string]bool{
|
||||||
|
"ты": true, "тебя": true, "тебе": true, "тобой": true, "тобою": true,
|
||||||
|
"твой": true, "твоя": true, "твоё": true, "твое": true, "твои": true, "твою": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// notFeminineVerb — ordinary words ending in "-ла" that are not verbs. Small on
|
||||||
|
// purpose: it only has to cover words a nudge might actually use.
|
||||||
|
//
|
||||||
|
// Words that are both a noun and a verb are deliberately NOT here. "села",
|
||||||
|
// "мыла" and "стекла" are nouns on paper, but in a nudge they are almost always
|
||||||
|
// verbs ("ты села", "ты мыла"), and listing them would make the check miss the
|
||||||
|
// exact thing it is for. Missing a real hit is worse than one false alarm.
|
||||||
|
var notFeminineVerb = map[string]bool{
|
||||||
|
"школа": true, "скала": true, "игла": true, "метла": true, "смола": true,
|
||||||
|
"дела": true, "тела": true, "масла": true, "весла": true,
|
||||||
|
"зола": true, "пчела": true, "числа": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// femininePast reports whether a word looks like a feminine past-tense verb:
|
||||||
|
// "отдыхала", "поела", "выспалась".
|
||||||
|
func femininePast(w string) bool {
|
||||||
|
if len([]rune(w)) < 3 || notFeminineVerb[w] {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return strings.HasSuffix(w, "ла") || strings.HasSuffix(w, "лась")
|
||||||
|
}
|
||||||
|
|
||||||
|
// looksFeminineNoun — a crude guard against "зарядка была": a word right before
|
||||||
|
// the verb that ends in "а"/"я" and is not itself a verb is probably the subject.
|
||||||
|
func looksFeminineNoun(w string) bool {
|
||||||
|
if femininePast(w) || len([]rune(w)) < 3 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return strings.HasSuffix(w, "а") || strings.HasSuffix(w, "я")
|
||||||
|
}
|
||||||
|
|
||||||
|
// sentenceRE splits on sentence-ending punctuation, so a feminine verb in one
|
||||||
|
// sentence is not blamed on a "ты" in the next.
|
||||||
|
var sentenceRE = regexp.MustCompile(`[.!?;…]+`)
|
||||||
|
|
||||||
|
func checkHisGender(body string) Result {
|
||||||
|
for _, sentence := range sentenceRE.Split(strings.ToLower(body), -1) {
|
||||||
|
words := wordRE.FindAllString(sentence, -1)
|
||||||
|
addressed := false
|
||||||
|
for _, w := range words {
|
||||||
|
if hisMarkers[w] {
|
||||||
|
addressed = true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if !addressed {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
for i, w := range words {
|
||||||
|
if !femininePast(w) || hersNotHis(words, i) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
if i > 0 && looksFeminineNoun(prevWord(words, i)) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
return Result{CheckHisGender, false,
|
||||||
|
fmt.Sprintf("feminine %q addressed to him — he is male", w)}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return Result{CheckHisGender, true, ""}
|
||||||
|
}
|
||||||
|
|
||||||
|
// hersNotHis — the verb is Maven's own if "я" comes shortly before it, or if the
|
||||||
|
// thing she did was done to him ("напомнила тебе", "проверила за тебя").
|
||||||
|
func hersNotHis(words []string, i int) bool {
|
||||||
|
for j := i - 1; j >= 0 && j >= i-3; j-- {
|
||||||
|
if words[j] == "я" {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if i+1 < len(words) {
|
||||||
|
switch words[i+1] {
|
||||||
|
case "тебе", "тебя", "за", "тобой":
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
// prevWord — the word before i, skipping "не" and punctuation, so "не отдыхала"
|
||||||
|
// still sees the subject.
|
||||||
|
func prevWord(words []string, i int) string {
|
||||||
|
for j := i - 1; j >= 0; j-- {
|
||||||
|
w := words[j]
|
||||||
|
if w == "не" || w == "ни" || !unicode.Is(unicode.Cyrillic, []rune(w)[0]) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
return w
|
||||||
|
}
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
|
// --- how she addresses him ------------------------------------------------
|
||||||
|
//
|
||||||
|
// Persona hard constraint: Maven speaks TO him, informally, one to one. The
|
||||||
|
// phrasing eval produced two breaks of it, and both scored clean:
|
||||||
|
//
|
||||||
|
// - "Приходите… Жду вас" — the formal plural. Correct is ты/тебя/тебе and a
|
||||||
|
// singular imperative ("приходи", "жду тебя").
|
||||||
|
// - "Он не ел 11 дней" — she talks ABOUT him, in the third person, as if
|
||||||
|
// reporting to somebody else. Correct is "ты не ел 11 дней".
|
||||||
|
//
|
||||||
|
// Like checkHisGender this is a keyword + suffix heuristic, NOT a parser. Every
|
||||||
|
// hit prints the word it tripped on, so a false alarm is obvious at a glance and
|
||||||
|
// can be dismissed.
|
||||||
|
//
|
||||||
|
// Part 1, formal address. Two signals:
|
||||||
|
// - the "вы" pronoun family, matched as whole words, so there is nothing to
|
||||||
|
// exclude — "вы" and "вас" are never anything else.
|
||||||
|
// - a plural verb ending: -ите/-ете/-йте/-ьте ("приходите", "выпейте",
|
||||||
|
// "не забудьте", "хотите"). Nouns in the prepositional case share those
|
||||||
|
// endings ("в интернете", "в свете"), so a word right after a preposition is
|
||||||
|
// skipped. That is the whole exclusion list, on purpose: a bigger one would
|
||||||
|
// start swallowing real imperatives.
|
||||||
|
//
|
||||||
|
// Part 2, third person. "он" is perfectly fine when the message really is about
|
||||||
|
// somebody or something else ("сервис упал, он не отвечает"). The way to tell
|
||||||
|
// them apart: a legitimate third person has an ANTECEDENT — the thing it refers
|
||||||
|
// to was named earlier in the message. So "он" is only flagged when nothing
|
||||||
|
// before it in the message could be that thing.
|
||||||
|
//
|
||||||
|
// Where this gives up, plainly:
|
||||||
|
// - it only looks BACKWARD. "Он не отвечает, сервис упал" names the subject
|
||||||
|
// after the pronoun and is flagged wrongly.
|
||||||
|
// - any noun earlier in the message counts as an antecedent, even when it is
|
||||||
|
// not one ("после обеда он не ел" reads as legitimate and is missed). The
|
||||||
|
// common time words are stoplisted so the usual nudge opening does not
|
||||||
|
// blind it, but a message with any other noun in front still slips through.
|
||||||
|
// This is the check's real hole; widening it further would start flagging
|
||||||
|
// legitimate third-party messages, so it stops here.
|
||||||
|
// - a message that opens with "ты" and only later slips into "он" is missed,
|
||||||
|
// because "ты" itself is skipped but the words around it are not.
|
||||||
|
// - formal address outside these endings (short adjectives, "вашими" style
|
||||||
|
// forms not listed) is missed.
|
||||||
|
|
||||||
|
// addressWordRE also takes Latin words, because "him"/"he" is the same break in
|
||||||
|
// English.
|
||||||
|
var addressWordRE = regexp.MustCompile(`[\p{Cyrillic}]+|[a-zA-Z]+|[,.;:!?…—-]`)
|
||||||
|
|
||||||
|
// formalPronouns — the "вы" family. Whole-word match, so no false hits.
|
||||||
|
var formalPronouns = map[string]bool{
|
||||||
|
"вы": true, "вас": true, "вам": true, "вами": true,
|
||||||
|
"ваш": true, "ваша": true, "ваше": true, "ваши": true,
|
||||||
|
"вашего": true, "вашей": true, "вашему": true, "вашим": true,
|
||||||
|
"вашими": true, "вашу": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// prepositions — used twice: to skip prepositional-case nouns that look like
|
||||||
|
// plural verbs, and as words that cannot be what "он" refers to.
|
||||||
|
var prepositions = map[string]bool{
|
||||||
|
"в": true, "во": true, "на": true, "о": true, "об": true, "обо": true,
|
||||||
|
"при": true, "по": true, "за": true, "из": true, "с": true, "со": true,
|
||||||
|
"к": true, "ко": true, "до": true, "от": true, "у": true, "над": true,
|
||||||
|
"под": true, "про": true, "без": true, "для": true, "через": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// pluralVerb reports whether a word looks like a plural/formal verb form:
|
||||||
|
// "приходите", "выпейте", "забудьте", "хотите".
|
||||||
|
func pluralVerb(w string) bool {
|
||||||
|
if len([]rune(w)) < 5 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return strings.HasSuffix(w, "ите") || strings.HasSuffix(w, "ете") ||
|
||||||
|
strings.HasSuffix(w, "йте") || strings.HasSuffix(w, "ьте")
|
||||||
|
}
|
||||||
|
|
||||||
|
// thirdPersonHim — pronouns that would be talking about him instead of to him.
|
||||||
|
var thirdPersonHim = map[string]bool{
|
||||||
|
"он": true, "его": true, "ему": true, "него": true, "нему": true, "ним": true,
|
||||||
|
"he": true, "him": true, "his": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// notAnAntecedent — words that cannot be the thing "он" refers to: pronouns,
|
||||||
|
// particles, conjunctions, adverbs of time. If only these come before "он", the
|
||||||
|
// message never named a third party and "он" is him.
|
||||||
|
var notAnAntecedent = map[string]bool{
|
||||||
|
"не": true, "ни": true, "и": true, "а": true, "но": true, "да": true,
|
||||||
|
"же": true, "бы": true, "ли": true, "вот": true, "уже": true,
|
||||||
|
"ещё": true, "еще": true, "тоже": true, "там": true, "тут": true,
|
||||||
|
"здесь": true, "это": true, "что": true, "как": true, "когда": true,
|
||||||
|
"чтобы": true, "потому": true, "сейчас": true, "потом": true,
|
||||||
|
// Time words. A nudge almost always opens with one ("сегодня он не ел"),
|
||||||
|
// and without them the very next word is read as the person being talked
|
||||||
|
// about, so the check misses the exact break it was written for.
|
||||||
|
"сегодня": true, "вчера": true, "завтра": true, "послезавтра": true,
|
||||||
|
"утром": true, "днём": true, "днем": true, "вечером": true, "ночью": true,
|
||||||
|
"опять": true, "снова": true, "весь": true, "всю": true, "целый": true,
|
||||||
|
"я": true, "мне": true, "меня": true, "мной": true, "мы": true, "нас": true,
|
||||||
|
"ты": true, "тебя": true, "тебе": true, "тобой": true,
|
||||||
|
"твой": true, "твоя": true, "твоё": true, "твое": true, "твои": true, "твою": true,
|
||||||
|
}
|
||||||
|
|
||||||
|
// looksPastVerb — a past-tense verb needs a subject of its own, so it is not an
|
||||||
|
// antecedent either. Keeps "сервис упал, он не отвечает" working off "сервис".
|
||||||
|
func looksPastVerb(w string) bool {
|
||||||
|
if len([]rune(w)) < 3 {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
return strings.HasSuffix(w, "л") || strings.HasSuffix(w, "ла") ||
|
||||||
|
strings.HasSuffix(w, "ло") || strings.HasSuffix(w, "ли")
|
||||||
|
}
|
||||||
|
|
||||||
|
func checkAddress(body string) Result {
|
||||||
|
words := addressWordRE.FindAllString(strings.ToLower(body), -1)
|
||||||
|
|
||||||
|
for i, w := range words {
|
||||||
|
if formalPronouns[w] {
|
||||||
|
return Result{CheckAddress, false,
|
||||||
|
fmt.Sprintf("formal %q — she says ты/тебя/тебе", w)}
|
||||||
|
}
|
||||||
|
if pluralVerb(w) && !(i > 0 && prepositions[words[i-1]]) {
|
||||||
|
return Result{CheckAddress, false,
|
||||||
|
fmt.Sprintf("plural imperative %q — she uses the singular", w)}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
for i, w := range words {
|
||||||
|
if !thirdPersonHim[w] {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
named := false
|
||||||
|
for j := 0; j < i; j++ {
|
||||||
|
p := words[j]
|
||||||
|
if !unicode.Is(unicode.Cyrillic, []rune(p)[0]) && !isLatinWord(p) {
|
||||||
|
continue // punctuation
|
||||||
|
}
|
||||||
|
if notAnAntecedent[p] || prepositions[p] || thirdPersonHim[p] || looksPastVerb(p) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
named = true
|
||||||
|
break
|
||||||
|
}
|
||||||
|
if !named {
|
||||||
|
return Result{CheckAddress, false,
|
||||||
|
fmt.Sprintf("third person %q with nobody else named — she talks to him, not about him", w)}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return Result{CheckAddress, true, ""}
|
||||||
|
}
|
||||||
|
|
||||||
|
func isLatinWord(w string) bool {
|
||||||
|
r := []rune(w)[0]
|
||||||
|
return (r >= 'a' && r <= 'z') || (r >= 'A' && r <= 'Z')
|
||||||
|
}
|
||||||
|
|
||||||
// --- the cringe checks ---------------------------------------------------
|
// --- the cringe checks ---------------------------------------------------
|
||||||
//
|
//
|
||||||
// "Think Jarvis without the cringe part". DESIGN.md § Non-goals: "Not a
|
// "Think Jarvis without the cringe part". DESIGN.md § Non-goals: "Not a
|
||||||
|
|||||||
@@ -281,7 +281,7 @@ func (r Report) String() string {
|
|||||||
fmt.Fprintf(&b, "%s: %d/%d cases pass every check (%.1f%%), %d errors\n",
|
fmt.Fprintf(&b, "%s: %d/%d cases pass every check (%.1f%%), %d errors\n",
|
||||||
r.Name, r.Passed, r.Total, 100*r.Accuracy(), r.Errors)
|
r.Name, r.Passed, r.Total, 100*r.Accuracy(), r.Errors)
|
||||||
for _, name := range CheckNames {
|
for _, name := range CheckNames {
|
||||||
fmt.Fprintf(&b, " %-9s %d/%d\n", name, r.ByCheck[name], r.Total)
|
fmt.Fprintf(&b, " %-10s %d/%d\n", name, r.ByCheck[name], r.Total)
|
||||||
}
|
}
|
||||||
fmt.Fprintf(&b, " latency: p50 %s p95 %s max %s\n", r.P50, r.P95, r.Max)
|
fmt.Fprintf(&b, " latency: p50 %s p95 %s max %s\n", r.P50, r.P95, r.Max)
|
||||||
fmt.Fprintf(&b, " by rule: %s\n", renderStats(r.ByRule))
|
fmt.Fprintf(&b, " by rule: %s\n", renderStats(r.ByRule))
|
||||||
|
|||||||
@@ -72,10 +72,12 @@ func TestStubBaseline(t *testing.T) {
|
|||||||
// ceiling ("you've been at your desk for 4 hours without a break — step
|
// ceiling ("you've been at your desk for 4 hours without a break — step
|
||||||
// away for a bit." is 76 chars but 16 words). Left failing rather than
|
// away for a bit." is 76 chars but 16 words). Left failing rather than
|
||||||
// raising the ceiling to hide it.
|
// raising the ceiling to hide it.
|
||||||
CheckLength: 12,
|
CheckLength: 12,
|
||||||
CheckFeminine: 15,
|
CheckFeminine: 15,
|
||||||
CheckCringe: 15,
|
CheckHisGender: 15,
|
||||||
CheckOnTopic: 12,
|
CheckAddress: 15,
|
||||||
|
CheckCringe: 15,
|
||||||
|
CheckOnTopic: 12,
|
||||||
}
|
}
|
||||||
for name, floor := range floors {
|
for name, floor := range floors {
|
||||||
if rep.ByCheck[name] < floor {
|
if rep.ByCheck[name] < floor {
|
||||||
@@ -104,6 +106,14 @@ func TestChecksCatchWhatTheyClaim(t *testing.T) {
|
|||||||
{"masculine predicative", "я должен сказать: попей воды.", CheckFeminine},
|
{"masculine predicative", "я должен сказать: попей воды.", CheckFeminine},
|
||||||
// The other direction: HE is male, so second-person masculine is right.
|
// The other direction: HE is male, so second-person masculine is right.
|
||||||
{"second person masculine ok", "ты не пил воду четыре часа.", ""},
|
{"second person masculine ok", "ты не пил воду четыре часа.", ""},
|
||||||
|
// The real observed failure: she addressed him as a woman.
|
||||||
|
{"feminine second person", "ты давно не отдыхала — попей воды.", CheckHisGender},
|
||||||
|
{"feminine second person no dash", "ты пила воду четыре часа назад.", CheckHisGender},
|
||||||
|
// Her own feminine verb next to "ты" is correct and must not be flagged.
|
||||||
|
{"her feminine verb near ты", "я заметила, что ты не пил воду.", ""},
|
||||||
|
{"her feminine verb about him", "напомнила тебе про воду.", ""},
|
||||||
|
// A feminine noun subject in the same sentence is not him.
|
||||||
|
{"feminine noun subject ok", "зарядка была утром, ты её пропустил, попей воды.", ""},
|
||||||
{"feminine self ok", "я заметила: воды не было четыре часа.", ""},
|
{"feminine self ok", "я заметила: воды не было четыре часа.", ""},
|
||||||
{"pet name", "милый, попей воды.", CheckCringe},
|
{"pet name", "милый, попей воды.", CheckCringe},
|
||||||
{"emoji", "попей воды 💧", CheckCringe},
|
{"emoji", "попей воды 💧", CheckCringe},
|
||||||
@@ -114,6 +124,10 @@ func TestChecksCatchWhatTheyClaim(t *testing.T) {
|
|||||||
{"asks how he feels", "как ты себя чувствуешь? попей воды.", CheckCringe},
|
{"asks how he feels", "как ты себя чувствуешь? попей воды.", CheckCringe},
|
||||||
{"praise", "молодец! теперь попей воды.", CheckCringe},
|
{"praise", "молодец! теперь попей воды.", CheckCringe},
|
||||||
{"off topic", "пора бы уже что-то сделать.", CheckOnTopic},
|
{"off topic", "пора бы уже что-то сделать.", CheckOnTopic},
|
||||||
|
// The two recorded persona breaks from the phrasing eval run. Pinned as
|
||||||
|
// unit tests because an eval run is sampled and may not reproduce them.
|
||||||
|
{"formal plural", "Приходите… Жду вас", CheckAddress},
|
||||||
|
{"third person about him", "Он не ел 11 дней", CheckAddress},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tc := range cases {
|
for _, tc := range cases {
|
||||||
@@ -135,6 +149,36 @@ func TestChecksCatchWhatTheyClaim(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TestAddressCheck — the address check on its own, so the messages that must NOT
|
||||||
|
// trip it can be written without also having to satisfy the on-topic check.
|
||||||
|
func TestAddressCheck(t *testing.T) {
|
||||||
|
bad := []string{
|
||||||
|
"Приходите… Жду вас", // the recorded formal-plural break
|
||||||
|
"Он не ел 11 дней", // the recorded third-person break
|
||||||
|
"Выпейте воды, пожалуйста.", // plural imperative on its own
|
||||||
|
"Ваш обед был давно.", // formal possessive
|
||||||
|
}
|
||||||
|
for _, body := range bad {
|
||||||
|
if r := checkAddress(body); r.Pass {
|
||||||
|
t.Errorf("persona break not caught: %q", body)
|
||||||
|
} else {
|
||||||
|
t.Logf("%q -> %s", body, r.Detail)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
good := []string{
|
||||||
|
"ты не пил воду четыре часа — попей.", // correct informal address
|
||||||
|
"сервис netdata упал, он не отвечает.", // legitimately about a third party
|
||||||
|
"я заметила, что зарядка была утром.", // no address at all
|
||||||
|
"в интернете опять тихо, всё работает.", // "интернете" is a noun, not an imperative
|
||||||
|
}
|
||||||
|
for _, body := range good {
|
||||||
|
if r := checkAddress(body); !r.Pass {
|
||||||
|
t.Errorf("clean message flagged: %q -> %s", body, r.Detail)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestMoodCheckUsesTheEnum(t *testing.T) {
|
func TestMoodCheckUsesTheEnum(t *testing.T) {
|
||||||
if r := checkMood("cheerful"); r.Pass {
|
if r := checkMood("cheerful"); r.Pass {
|
||||||
t.Error("mood outside the enum passed")
|
t.Error("mood outside the enum passed")
|
||||||
|
|||||||
+136
-13
@@ -184,7 +184,10 @@ func (p *LLMPhraser) PhraseNudge(ctx context.Context, c loop.Candidate) (deliver
|
|||||||
body, _ = parsePhrase(resp)
|
body, _ = parsePhrase(resp)
|
||||||
}
|
}
|
||||||
if body == "" {
|
if body == "" {
|
||||||
body = fmt.Sprintf("%s — %s", c.Rule.Name, sevLabel(c.Severity))
|
// The model said nothing usable. Say it in Russian anyway — this text
|
||||||
|
// goes straight to a Russian piper voice, so the old "water — care"
|
||||||
|
// fallback was unspeakable.
|
||||||
|
body = fallbackNudge(c)
|
||||||
}
|
}
|
||||||
if mood == "" {
|
if mood == "" {
|
||||||
mood = "neutral"
|
mood = "neutral"
|
||||||
@@ -428,8 +431,33 @@ func (p *LLMPhraser) chatWithSystem(ctx context.Context, system, user string, ma
|
|||||||
return stripThink(content), nil
|
return stripThink(content), nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// nudgeSystem — the phrasing contract for nudges.
|
||||||
|
//
|
||||||
|
// Written as filled-in examples, not as a schema with "..." in it. A 0.8B
|
||||||
|
// copies whatever sits in the response slot, so a literal placeholder there
|
||||||
|
// teaches it to answer with the placeholder. Measured: 7/15 nudges came back
|
||||||
|
// as "..." before this. See PHRASING-EVAL-31-07-2026.md.
|
||||||
|
//
|
||||||
|
// Russian only, feminine self-reference, second person masculine (the owner is
|
||||||
|
// a man). One short sentence — the nudge is spoken aloud.
|
||||||
|
const nudgeSystem = `Ты — Maven, домашняя ассистентка. О себе говоришь в женском роде ("я проверила", "я записала"). Владелец — мужчина, обращайся к нему в мужском роде ("ты пил", "ты забыл").
|
||||||
|
|
||||||
|
Пиши ОДНО короткое напоминание по-русски: не больше 120 символов и не больше 16 слов. Только по делу.
|
||||||
|
|
||||||
|
Запрещено: обращения ("дорогой", "милый"), эмодзи, извинения ("прости", "извини"), вопросы о самочувствии, похвала, больше одного восклицательного знака, английские слова кроме имён сервисов.
|
||||||
|
|
||||||
|
Отвечай ТОЛЬКО одним объектом JSON с полями "response" и "mood".
|
||||||
|
"response" — сам текст напоминания.
|
||||||
|
"mood" — ровно одно из: neutral, happy, thinking, tired, confused.
|
||||||
|
|
||||||
|
Так выглядит правильный ответ по форме. Темы здесь посторонние — их в запросе не будет:
|
||||||
|
{"response": "Стиральная машина закончила. Развесь бельё.", "mood": "neutral"}
|
||||||
|
{"response": "Ноутбук на трёх процентах. Я поставила его на зарядку.", "mood": "confused"}
|
||||||
|
|
||||||
|
Это примеры ФОРМЫ, а не темы. Пиши только про ту ситуацию, которую тебе дали в запросе. Не копируй примеры и никогда не пиши "..." в поле response.`
|
||||||
|
|
||||||
func (p *LLMPhraser) systemPrompt() string {
|
func (p *LLMPhraser) systemPrompt() string {
|
||||||
base := `You are maven, a self-hosted personal assistant. Generate brief, natural nudge messages in the user's language (Russian or English). Respond ONLY with valid JSON: {"response": "full voice message", "mood": "neutral"}. "response" is what the user hears; "mood" reflects maven's tone (neutral/happy/thinking/tired/confused).`
|
base := nudgeSystem
|
||||||
if p.cfg.Persona != "" {
|
if p.cfg.Persona != "" {
|
||||||
base = p.cfg.Persona + "\n\n" + base
|
base = p.cfg.Persona + "\n\n" + base
|
||||||
}
|
}
|
||||||
@@ -446,22 +474,117 @@ func (p *LLMPhraser) querySystemPrompt() string {
|
|||||||
return base
|
return base
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// ruleTopics — Russian gloss for each built-in rule name. The rule names are
|
||||||
|
// English identifiers; a 0.8B asked to nudge about "netdata_critical" writes
|
||||||
|
// about nothing. The daemon knows what its own rules mean, so it says so.
|
||||||
|
var ruleTopics = map[string]string{
|
||||||
|
"water": "он давно не пил воду",
|
||||||
|
"meal": "он давно не ел",
|
||||||
|
"break": "он давно без перерыва, пора встать и размяться",
|
||||||
|
"service_down": "сервис не отвечает, лежит",
|
||||||
|
"netdata_critical": "критический алярм в netdata, проблема с диском или местом",
|
||||||
|
}
|
||||||
|
|
||||||
|
// ruleKeywords — the word the message must contain. The 0.8B drifts to
|
||||||
|
// whatever topic it saw last unless the required word is named outright.
|
||||||
|
var ruleKeywords = map[string]string{
|
||||||
|
"water": "воду",
|
||||||
|
"meal": "поешь",
|
||||||
|
"break": "перерыв",
|
||||||
|
"service_down": "сервис",
|
||||||
|
"netdata_critical": "диск",
|
||||||
|
}
|
||||||
|
|
||||||
|
// ruleTopic turns a rule name into a Russian description of the situation.
|
||||||
|
// "routine:зарядка" and "morning:утро" carry their own Russian suffix.
|
||||||
|
func ruleTopic(rule string) string {
|
||||||
|
if t, ok := ruleTopics[rule]; ok {
|
||||||
|
return t
|
||||||
|
}
|
||||||
|
if i := strings.IndexByte(rule, ':'); i > 0 && i+1 < len(rule) {
|
||||||
|
switch rule[:i] {
|
||||||
|
case "morning":
|
||||||
|
return "утро, пора начать день: " + rule[i+1:]
|
||||||
|
default:
|
||||||
|
return "пора сделать по распорядку: " + rule[i+1:]
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return rule
|
||||||
|
}
|
||||||
|
|
||||||
|
// ruleKeyword — the word the nudge must contain, or "" when the rule name's
|
||||||
|
// own Russian suffix already is that word.
|
||||||
|
func ruleKeyword(rule string) string {
|
||||||
|
if k, ok := ruleKeywords[rule]; ok {
|
||||||
|
return k
|
||||||
|
}
|
||||||
|
if i := strings.IndexByte(rule, ':'); i > 0 && i+1 < len(rule) {
|
||||||
|
return rule[i+1:]
|
||||||
|
}
|
||||||
|
return ""
|
||||||
|
}
|
||||||
|
|
||||||
|
// ruDur — duration in Russian. humanDur is English and its output was landing
|
||||||
|
// verbatim in the message.
|
||||||
|
func ruDur(d time.Duration) string {
|
||||||
|
if d < 0 {
|
||||||
|
d = 0
|
||||||
|
}
|
||||||
|
h, m := int(d.Hours()), int(d.Minutes())%60
|
||||||
|
switch {
|
||||||
|
case h >= 2:
|
||||||
|
return fmt.Sprintf("%d ч", h)
|
||||||
|
case h == 1 && m >= 30:
|
||||||
|
return "полтора часа"
|
||||||
|
case h == 1:
|
||||||
|
return "час"
|
||||||
|
default:
|
||||||
|
return fmt.Sprintf("%d мин", m)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// fallbackNudge — plain Russian for when the model returns nothing parseable.
|
||||||
|
var fallbackNudges = map[string]string{
|
||||||
|
"water": "Ты давно не пил воду.",
|
||||||
|
"meal": "Ты давно не ел, поешь.",
|
||||||
|
"break": "Пора сделать перерыв.",
|
||||||
|
"service_down": "Сервис не отвечает.",
|
||||||
|
"netdata_critical": "Критический алярм: проверь диск.",
|
||||||
|
}
|
||||||
|
|
||||||
|
func fallbackNudge(c loop.Candidate) string {
|
||||||
|
if s, ok := fallbackNudges[c.Rule.Name]; ok {
|
||||||
|
return s
|
||||||
|
}
|
||||||
|
if kw := ruleKeyword(c.Rule.Name); kw != "" {
|
||||||
|
return "Напоминаю: " + kw + "."
|
||||||
|
}
|
||||||
|
return "Напоминаю о деле."
|
||||||
|
}
|
||||||
|
|
||||||
func buildNudgePrompt(c loop.Candidate) string {
|
func buildNudgePrompt(c loop.Candidate) string {
|
||||||
var ctxParts []string
|
var ctxParts []string
|
||||||
ctxParts = append(ctxParts, fmt.Sprintf("Rule: %s", c.Rule.Name))
|
ctxParts = append(ctxParts, "Ситуация: "+ruleTopic(c.Rule.Name))
|
||||||
ctxParts = append(ctxParts, fmt.Sprintf("Severity: %s", sevLabel(c.Severity)))
|
if f, ok := c.State.Facts[c.Rule.Name]; ok && f.Key != "" && f.Key != c.Rule.Name {
|
||||||
|
ctxParts = append(ctxParts, "Что именно: "+f.Key)
|
||||||
|
}
|
||||||
if d, ok := c.State.Since(c.Rule.Name); ok {
|
if d, ok := c.State.Since(c.Rule.Name); ok {
|
||||||
ctxParts = append(ctxParts, fmt.Sprintf("Duration since last event: %s", humanDur(d)))
|
ctxParts = append(ctxParts, "Прошло: "+ruDur(d))
|
||||||
|
}
|
||||||
|
switch sevLabel(c.Severity) {
|
||||||
|
case "alarm":
|
||||||
|
ctxParts = append(ctxParts, "Срочно, скажи прямо.")
|
||||||
|
case "ops":
|
||||||
|
ctxParts = append(ctxParts, "Это про сервер, не про здоровье.")
|
||||||
|
}
|
||||||
|
tail := "Напиши напоминание про эту ситуацию. Одно предложение, по-русски, в JSON."
|
||||||
|
if kw := ruleKeyword(c.Rule.Name); kw != "" {
|
||||||
|
// Last line on purpose: a 0.8B weights the end of the prompt hardest,
|
||||||
|
// and without the required word it drifts back to the examples.
|
||||||
|
tail += " Ответ ДОЛЖЕН содержать слово «" + kw + "»."
|
||||||
}
|
}
|
||||||
|
|
||||||
return fmt.Sprintf(
|
return strings.Join(ctxParts, "\n") + "\n\n" + tail
|
||||||
`Generate a nudge message. Context:
|
|
||||||
%s
|
|
||||||
|
|
||||||
Respond as JSON: {"response": "...", "mood": "..."}`,
|
|
||||||
strings.Join(ctxParts, "\n"),
|
|
||||||
)
|
|
||||||
}
|
}
|
||||||
|
|
||||||
type responseMood struct {
|
type responseMood struct {
|
||||||
|
|||||||
@@ -2,6 +2,7 @@ package router
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
|
"fmt"
|
||||||
"math"
|
"math"
|
||||||
"unicode"
|
"unicode"
|
||||||
)
|
)
|
||||||
@@ -19,6 +20,24 @@ type Embedder interface {
|
|||||||
Close() error
|
Close() error
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// IdentifiedEmbedder — an embedder that can name itself. The name goes into
|
||||||
|
// the DB next to the vectors it wrote, so a later model swap is caught instead
|
||||||
|
// of silently returning nonsense scores (Vikunja #378).
|
||||||
|
type IdentifiedEmbedder interface {
|
||||||
|
Embedder
|
||||||
|
ID() string
|
||||||
|
}
|
||||||
|
|
||||||
|
// EmbedderID is the stable string stored alongside the vectors. It comes from
|
||||||
|
// the embedder itself — nobody hand-types a model name twice — and changes
|
||||||
|
// whenever the model or its dimension changes.
|
||||||
|
func EmbedderID(e Embedder) string {
|
||||||
|
if i, ok := e.(IdentifiedEmbedder); ok {
|
||||||
|
return i.ID()
|
||||||
|
}
|
||||||
|
return fmt.Sprintf("unknown@%d", e.Dim())
|
||||||
|
}
|
||||||
|
|
||||||
// AsymmetricEmbedder — an embedder that wants to know whether a text is a
|
// AsymmetricEmbedder — an embedder that wants to know whether a text is a
|
||||||
// search query or a stored passage. Recall is asymmetric: a short question
|
// search query or a stored passage. Recall is asymmetric: a short question
|
||||||
// goes in, a longer note comes out. The e5 family is trained for exactly that
|
// goes in, a longer note comes out. The e5 family is trained for exactly that
|
||||||
@@ -70,6 +89,10 @@ func NewHashEmbedder(dim int) *HashEmbedder {
|
|||||||
|
|
||||||
func (h *HashEmbedder) Dim() int { return h.dim }
|
func (h *HashEmbedder) Dim() int { return h.dim }
|
||||||
|
|
||||||
|
// ID names this embedder for the DB marker. The dimension is part of it
|
||||||
|
// because a HashEmbedder of another width is a different vector space.
|
||||||
|
func (h *HashEmbedder) ID() string { return fmt.Sprintf("hash@%d", h.dim) }
|
||||||
|
|
||||||
func (h *HashEmbedder) Close() error { return nil }
|
func (h *HashEmbedder) Close() error { return nil }
|
||||||
|
|
||||||
func (h *HashEmbedder) Embed(_ context.Context, text string) ([]float32, error) {
|
func (h *HashEmbedder) Embed(_ context.Context, text string) ([]float32, error) {
|
||||||
|
|||||||
@@ -0,0 +1,24 @@
|
|||||||
|
package router
|
||||||
|
|
||||||
|
import "testing"
|
||||||
|
|
||||||
|
func TestEmbedderIDFromModelPath(t *testing.T) {
|
||||||
|
got := modelIDFromPath("/opt/maven/models/embedder/multilingual-e5-small.onnx")
|
||||||
|
if got != "multilingual-e5-small@384" {
|
||||||
|
t.Fatalf("modelIDFromPath = %q", got)
|
||||||
|
}
|
||||||
|
// A different model file must produce a different id, even at 384 dim.
|
||||||
|
old := modelIDFromPath("/opt/maven/models/embedder/paraphrase-multilingual-MiniLM-L12-v2.onnx")
|
||||||
|
if old == got {
|
||||||
|
t.Fatal("two different models share one id")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestEmbedderIDIncludesDim(t *testing.T) {
|
||||||
|
if id := EmbedderID(NewHashEmbedder(1024)); id != "hash@1024" {
|
||||||
|
t.Fatalf("EmbedderID = %q", id)
|
||||||
|
}
|
||||||
|
if EmbedderID(NewHashEmbedder(1024)) == EmbedderID(NewHashEmbedder(384)) {
|
||||||
|
t.Fatal("dimension not part of the id")
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -1,11 +1,8 @@
|
|||||||
package eval
|
package eval
|
||||||
|
|
||||||
import (
|
import (
|
||||||
"bytes"
|
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
|
||||||
"fmt"
|
"fmt"
|
||||||
"net/http"
|
|
||||||
"os"
|
"os"
|
||||||
"strings"
|
"strings"
|
||||||
"testing"
|
"testing"
|
||||||
@@ -29,13 +26,20 @@ import (
|
|||||||
// a bake-off across checkpoints (#278, #250) produces tables you can tell
|
// a bake-off across checkpoints (#278, #250) produces tables you can tell
|
||||||
// apart. Point the variable at one server at a time.
|
// apart. Point the variable at one server at a time.
|
||||||
//
|
//
|
||||||
// Three configurations, because "the LLM router" is ambiguous and the three
|
// Two configurations, because "the LLM router" is ambiguous and the two numbers
|
||||||
// numbers answer different questions:
|
// answer different questions:
|
||||||
//
|
//
|
||||||
// llm-only — the model alone. Measures the prompt + grammar contract.
|
// llm-only — the model alone. Measures the prompt + grammar contract.
|
||||||
// cascade+llm — what #320 would actually ship: stage-0 grammar, then the
|
// cascade+llm — what #320 would actually ship: stage-0 grammar, then the
|
||||||
// model, then the classifier as the failure floor.
|
// model, then the classifier as the failure floor.
|
||||||
// llm-no-thinking — diagnostic only, not a shippable path (see below).
|
//
|
||||||
|
// There used to be a third, "thinking off", which looked 6 points better. It is
|
||||||
|
// gone: it was measured with a hand-rolled HTTP client that quietly dropped
|
||||||
|
// repeat_penalty, so the gap was the missing penalty and not the thinking mode.
|
||||||
|
// Re-measured with everything else held equal, thinking off scores exactly the
|
||||||
|
// same, case for case — and a direct probe shows this llama-server build ignores
|
||||||
|
// enable_thinking / reasoning_budget for this model anyway, so there was nothing
|
||||||
|
// to turn off. Full write-up in ROUTING-EVAL-31-07-2026.md (Vikunja #376).
|
||||||
func TestLLMRouterBaseline(t *testing.T) {
|
func TestLLMRouterBaseline(t *testing.T) {
|
||||||
base := os.Getenv("MAVEN_LLM_URL")
|
base := os.Getenv("MAVEN_LLM_URL")
|
||||||
if base == "" {
|
if base == "" {
|
||||||
@@ -96,104 +100,18 @@ func TestLLMRouterBaseline(t *testing.T) {
|
|||||||
}
|
}
|
||||||
t.Log("\n" + repCascade.String() + repCascade.Failures())
|
t.Log("\n" + repCascade.String() + repCascade.Failures())
|
||||||
|
|
||||||
// llm-no-thinking: same prompt and grammar with the chat template's
|
|
||||||
// thinking mode off. Qwen3.5's template defaults thinking=1, so under a
|
|
||||||
// grammar the constrained JSON lands in reasoning_content with content
|
|
||||||
// empty — llm.Client's ReasoningContent fallback is what makes the router
|
|
||||||
// work at all today, by accident rather than design.
|
|
||||||
//
|
|
||||||
// MEASURED 2026-07-31: this variant scores identically to as-deployed
|
|
||||||
// (18/76, 48.7% intent-only, 2 errors, same p50). Thinking mode is a
|
|
||||||
// non-issue under a grammar — llama.cpp constrains the same token stream
|
|
||||||
// either way. Kept so the question stays answered instead of being
|
|
||||||
// re-asked, and so internal/llm does NOT grow a chat_template_kwargs field
|
|
||||||
// for a problem that does not exist.
|
|
||||||
repNoThink, err := Score(ctx, "llm-only ("+model+", thinking off) [diagnostic]",
|
|
||||||
RouterFunc(func(ctx context.Context, u string, now time.Time) (router.Decision, error) {
|
|
||||||
d, ok, err := router.NewLLMRouter(&noThinkCompleter{base: base, http: &http.Client{Timeout: 60 * time.Second}}).Route(ctx, u, now)
|
|
||||||
if err != nil {
|
|
||||||
return d, err
|
|
||||||
}
|
|
||||||
if !ok {
|
|
||||||
return d, fmt.Errorf("llm router declined without an error")
|
|
||||||
}
|
|
||||||
return d, nil
|
|
||||||
}), f)
|
|
||||||
if err != nil {
|
|
||||||
t.Fatalf("Score no-thinking: %v", err)
|
|
||||||
}
|
|
||||||
t.Log("\n" + repNoThink.String() + repNoThink.Failures())
|
|
||||||
|
|
||||||
// Reports rather than asserts — the numbers are inputs to the #320
|
// Reports rather than asserts — the numbers are inputs to the #320
|
||||||
// decision, and an assertion here would be this test inventing the bar.
|
// decision, and an assertion here would be this test inventing the bar.
|
||||||
// The one thing worth failing on is a harness fault: if every single case
|
// The one thing worth failing on is a harness fault: if every single case
|
||||||
// errors, the run measured infrastructure, not routing, and the report
|
// errors, the run measured infrastructure, not routing, and the report
|
||||||
// must not be mistaken for a score.
|
// must not be mistaken for a score.
|
||||||
for _, rep := range []Report{repLLM, repCascade, repNoThink} {
|
for _, rep := range []Report{repLLM, repCascade} {
|
||||||
if rep.Errors == rep.Total {
|
if rep.Errors == rep.Total {
|
||||||
t.Errorf("%s: all %d cases errored — harness fault, not a measurement", rep.Name, rep.Total)
|
t.Errorf("%s: all %d cases errored — harness fault, not a measurement", rep.Name, rep.Total)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
// noThinkCompleter — llm.Client with chat_template_kwargs.enable_thinking
|
|
||||||
// false. A test-local copy rather than a change to internal/llm: whether the
|
|
||||||
// daemon should send it is the open question, and answering it here by adding
|
|
||||||
// the field would prejudge #320.
|
|
||||||
type noThinkCompleter struct {
|
|
||||||
base string
|
|
||||||
http *http.Client
|
|
||||||
}
|
|
||||||
|
|
||||||
func (c *noThinkCompleter) Complete(ctx context.Context, r llm.Req) (string, error) {
|
|
||||||
payload := map[string]any{
|
|
||||||
"messages": []map[string]string{
|
|
||||||
{"role": "system", "content": r.System},
|
|
||||||
{"role": "user", "content": r.User},
|
|
||||||
},
|
|
||||||
"max_tokens": r.MaxTokens,
|
|
||||||
"temperature": 0,
|
|
||||||
"grammar": r.Grammar,
|
|
||||||
"chat_template_kwargs": map[string]any{"enable_thinking": false},
|
|
||||||
}
|
|
||||||
b, err := json.Marshal(payload)
|
|
||||||
if err != nil {
|
|
||||||
return "", err
|
|
||||||
}
|
|
||||||
req, err := http.NewRequestWithContext(ctx, "POST", c.base+"/v1/chat/completions", bytes.NewReader(b))
|
|
||||||
if err != nil {
|
|
||||||
return "", err
|
|
||||||
}
|
|
||||||
req.Header.Set("Content-Type", "application/json")
|
|
||||||
resp, err := c.http.Do(req)
|
|
||||||
if err != nil {
|
|
||||||
return "", err
|
|
||||||
}
|
|
||||||
defer resp.Body.Close()
|
|
||||||
if resp.StatusCode != 200 {
|
|
||||||
return "", fmt.Errorf("status %d", resp.StatusCode)
|
|
||||||
}
|
|
||||||
var out struct {
|
|
||||||
Choices []struct {
|
|
||||||
Message struct {
|
|
||||||
Content string `json:"content"`
|
|
||||||
ReasoningContent string `json:"reasoning_content"`
|
|
||||||
} `json:"message"`
|
|
||||||
} `json:"choices"`
|
|
||||||
}
|
|
||||||
if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
|
|
||||||
return "", err
|
|
||||||
}
|
|
||||||
if len(out.Choices) == 0 {
|
|
||||||
return "", fmt.Errorf("no choices")
|
|
||||||
}
|
|
||||||
m := out.Choices[0].Message
|
|
||||||
if m.Content != "" {
|
|
||||||
return m.Content, nil
|
|
||||||
}
|
|
||||||
return m.ReasoningContent, nil
|
|
||||||
}
|
|
||||||
|
|
||||||
func ping(ctx context.Context, c *llm.Client) error {
|
func ping(ctx context.Context, c *llm.Client) error {
|
||||||
ctx, cancel := context.WithTimeout(ctx, 90*time.Second)
|
ctx, cancel := context.WithTimeout(ctx, 90*time.Second)
|
||||||
defer cancel()
|
defer cancel()
|
||||||
|
|||||||
@@ -22,6 +22,7 @@
|
|||||||
{ "id": "ru-query-011", "utterance": "почему сервер тормозит", "lang": "ru", "intent": "query", "tags": ["homelab", "hard"], "note": "diagnostic question, not a chat opener" },
|
{ "id": "ru-query-011", "utterance": "почему сервер тормозит", "lang": "ru", "intent": "query", "tags": ["homelab", "hard"], "note": "diagnostic question, not a chat opener" },
|
||||||
{ "id": "ru-query-012", "utterance": "какие заметки я оставил про полив", "lang": "ru", "intent": "query", "tags": ["recall"] },
|
{ "id": "ru-query-012", "utterance": "какие заметки я оставил про полив", "lang": "ru", "intent": "query", "tags": ["recall"] },
|
||||||
{ "id": "ru-query-013", "utterance": "во сколько у меня встреча", "lang": "ru", "intent": "query", "tags": ["calendar"] },
|
{ "id": "ru-query-013", "utterance": "во сколько у меня встреча", "lang": "ru", "intent": "query", "tags": ["calendar"] },
|
||||||
|
{ "id": "ru-query-019", "utterance": "что у меня стоит в календаре на послезавтра", "lang": "ru", "intent": "query", "tags": ["calendar", "hard"], "note": "agenda, not the clock: the daemon answers this from CalendarEvents inside the query branch, so the clock/date system rule must not swallow it" },
|
||||||
{ "id": "ru-query-014", "utterance": "я успеваю до дедлайна", "lang": "ru", "intent": "query", "tags": ["hard", "no-question-word"] },
|
{ "id": "ru-query-014", "utterance": "я успеваю до дедлайна", "lang": "ru", "intent": "query", "tags": ["hard", "no-question-word"] },
|
||||||
{ "id": "ru-query-015", "utterance": "сколько я прошёл шагов", "lang": "ru", "intent": "query", "tags": ["aggregate"] },
|
{ "id": "ru-query-015", "utterance": "сколько я прошёл шагов", "lang": "ru", "intent": "query", "tags": ["aggregate"] },
|
||||||
{ "id": "ru-query-016", "utterance": "покажи давление за неделю", "lang": "ru", "intent": "query", "tags": ["hard", "imperative"], "note": "imperative form but a read — must not route to act" },
|
{ "id": "ru-query-016", "utterance": "покажи давление за неделю", "lang": "ru", "intent": "query", "tags": ["hard", "imperative"], "note": "imperative form but a read — must not route to act" },
|
||||||
|
|||||||
@@ -44,10 +44,21 @@ ws ::= [ \t\n]*
|
|||||||
// Changed again 31-07-2026: added the "unknown" escape hatch so the model can
|
// Changed again 31-07-2026: added the "unknown" escape hatch so the model can
|
||||||
// admit it cannot route (Vikunja #359).
|
// admit it cannot route (Vikunja #359).
|
||||||
//
|
//
|
||||||
|
// Changed again 31-07-2026: added the clock/calendar rule (Vikunja #374). The
|
||||||
|
// prompt never said which side "который час" or "какое число завтра" belong on,
|
||||||
|
// so the model guessed — `system→query ×4` in every eval run. The rule sits
|
||||||
|
// above the question test on purpose: these utterances all carry a question
|
||||||
|
// word, so a later rule would never be reached. The boundary is what the
|
||||||
|
// daemon can actually answer: only replySystem in cmd/mavend/voice.go owns the
|
||||||
|
// clock and the calendar formatter, while the agenda ("что у меня завтра") is
|
||||||
|
// answered inside the query branch, so that side stays query.
|
||||||
|
//
|
||||||
// The training workspace keeps its own copy of this prompt for relabelling, and
|
// The training workspace keeps its own copy of this prompt for relabelling, and
|
||||||
// `llm/check_prompt_parity.py` there compares the two. That copy is in another
|
// `llm/check_prompt_parity.py` there compares the two. That copy is in another
|
||||||
// repo and was not touched, so parity will fail until it gets the same edits —
|
// repo and was not touched, so parity will fail until it gets the same edits —
|
||||||
// both the rule reorder and the "unknown" wording (Vikunja #362).
|
// both the rule reorder and the "unknown" wording (Vikunja #362) — and now the
|
||||||
|
// clock/calendar rule too. The training workspace is not checked out on this
|
||||||
|
// box at all, so it could not be updated here; #362 still covers the catch-up.
|
||||||
const routeSystem = `Классифицируй ровно одно сообщение пользователя. Верни ОДИН JSON-массив действий.
|
const routeSystem = `Классифицируй ровно одно сообщение пользователя. Верни ОДИН JSON-массив действий.
|
||||||
|
|
||||||
Ровно одно намерение: fact, reminder, note, query, act, chat, system.
|
Ровно одно намерение: fact, reminder, note, query, act, chat, system.
|
||||||
@@ -56,19 +67,21 @@ const routeSystem = `Классифицируй ровно одно сообще
|
|||||||
Классифицируй по цели пользователя. Порядок решения:
|
Классифицируй по цели пользователя. Порядок решения:
|
||||||
1. Хочет напоминание в будущем → reminder
|
1. Хочет напоминание в будущем → reminder
|
||||||
2. Явно просит сохранить информацию → note
|
2. Явно просит сохранить информацию → note
|
||||||
3. Задаёт вопрос: есть вопросительное слово (сколько, что, какой, когда, где, кто, почему, как) или знак «?» → query
|
3. Спрашивает только «который час» / «какое число» / «какой день недели» — сами часы или календарная дата, без своих данных → system
|
||||||
4. Хочет получить информацию, в том числе о своих же данных → query
|
4. Задаёт вопрос: есть вопросительное слово (сколько, что, какой, когда, где, кто, почему, как) или знак «?» → query
|
||||||
5. Утверждает: сообщает или обновляет текущее состояние/событие → fact
|
5. Хочет получить информацию, в том числе о своих же данных → query
|
||||||
6. Просит выполнить работу → act
|
6. Утверждает: сообщает или обновляет текущее состояние/событие → fact
|
||||||
7. Про ассистента, настройки или память → system
|
7. Просит выполнить работу → act
|
||||||
8. Реплика — обрывок или указание на неназванное («это», «то», «потом»), и без него непонятно, что именно нужно сделать → unknown
|
8. Про ассистента, настройки или память → system
|
||||||
9. Иначе → chat
|
9. Реплика — обрывок или указание на неназванное («это», «то», «потом»), и без него непонятно, что именно нужно сделать → unknown
|
||||||
|
10. Иначе → chat
|
||||||
|
|
||||||
Различия:
|
Различия:
|
||||||
- note — сохранить информацию, без напоминания. text = суть.
|
- note — сохранить информацию, без напоминания. text = суть.
|
||||||
- reminder — уведомить позже. text = что напомнить.
|
- reminder — уведомить позже. text = что напомнить.
|
||||||
- fact — неявное обновление: пользователь сообщает, что что-то в мире изменилось (текущее/изменённое состояние, случившееся событие). key/value.
|
- fact — неявное обновление: пользователь сообщает, что что-то в мире изменилось (текущее/изменённое состояние, случившееся событие). key/value.
|
||||||
- unknown — редкий случай. Ставь его, только если в самой реплике нет ни предмета, ни действия. Короткая, простая или незнакомая тема — это не причина для unknown: приветствие и болтовня — это chat, вопрос на любую тему — это query, просьба сделать что-то названное — это act.
|
- unknown — редкий случай. Ставь его, только если в самой реплике нет ни предмета, ни действия. Короткая, простая или незнакомая тема — это не причина для unknown: приветствие и болтовня — это chat, вопрос на любую тему — это query, просьба сделать что-то названное — это act.
|
||||||
|
- system против query — часы и календарная дата сами по себе (сколько времени, какое число, какой день недели — можно и про завтра, и про другой город) — это system. А что записано в календаре или в памяти («что у меня завтра», «какие есть напоминания») — это query. Если в реплике есть просьба (напомни, запиши, сделай), то названное время — просто деталь просьбы, и это не system.
|
||||||
- query против fact — решает форма реплики, а не тема. Вопрос о состоянии — это query, даже если названо то же самое, что бывает в fact. Только утверждение — это fact.
|
- query против fact — решает форма реплики, а не тема. Вопрос о состоянии — это query, даже если названо то же самое, что бывает в fact. Только утверждение — это fact.
|
||||||
|
|
||||||
Примеры:
|
Примеры:
|
||||||
@@ -82,6 +95,8 @@ const routeSystem = `Классифицируй ровно одно сообще
|
|||||||
"что такое docker?" → {"intent":"query","text":"что такое docker"}
|
"что такое docker?" → {"intent":"query","text":"что такое docker"}
|
||||||
"напиши письмо" → {"intent":"act","verb":"написать письмо"}
|
"напиши письмо" → {"intent":"act","verb":"написать письмо"}
|
||||||
"очисти память" → {"intent":"system"}
|
"очисти память" → {"intent":"system"}
|
||||||
|
"который час?" → {"intent":"system"}
|
||||||
|
"какое число завтра?" → {"intent":"system"}
|
||||||
"привет" → {"intent":"chat","text":"привет"}
|
"привет" → {"intent":"chat","text":"привет"}
|
||||||
"сделай это" → {"intent":"unknown"}
|
"сделай это" → {"intent":"unknown"}
|
||||||
"ну это" → {"intent":"unknown"}
|
"ну это" → {"intent":"unknown"}
|
||||||
|
|||||||
@@ -175,3 +175,87 @@ func TestLLMRouterLLMError(t *testing.T) {
|
|||||||
t.Fatal("want ok=false, err!=nil on llm error")
|
t.Fatal("want ok=false, err!=nil on llm error")
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// --- slot extraction on top of an LLM decision --------------------------------
|
||||||
|
|
||||||
|
// newLLMTestRouter — a router whose route always comes from the mock model.
|
||||||
|
func newLLMTestRouter(t *testing.T, out string) *Router {
|
||||||
|
t.Helper()
|
||||||
|
c := NewClassifier(NewHashEmbedder(1024))
|
||||||
|
seedClassifier(t, c)
|
||||||
|
acts := DefaultActMatcher{Fns: []string{"restart", "stop", "run", "backup"}}
|
||||||
|
return New(Config{
|
||||||
|
Classifier: c,
|
||||||
|
Extractor: Extractor{Time: StubDateTimeParser{}, Acts: acts, Facts: DefaultFactParser{}},
|
||||||
|
Threshold: 0.4,
|
||||||
|
LLM: NewLLMRouter(mockLLM{out: out}),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
// The model cannot produce a fire time, so without extraction every LLM-routed
|
||||||
|
// reminder was dropped as "no time".
|
||||||
|
func TestLLMDecisionGetsReminderTime(t *testing.T) {
|
||||||
|
r := newLLMTestRouter(t, `{"intent":"reminder","text":"позвонить маме"}`)
|
||||||
|
d, err := r.Route(context.Background(), "напомни позвонить маме через 2 часа", refNow())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("route: %v", err)
|
||||||
|
}
|
||||||
|
if d.Intent != IntentReminder {
|
||||||
|
t.Fatalf("want reminder, got %v", d.Intent)
|
||||||
|
}
|
||||||
|
if !d.Slots.HasTime || !d.Slots.Time.Equal(refNow().Add(2*time.Hour)) {
|
||||||
|
t.Fatalf("want time now+2h, got %+v", d.Slots)
|
||||||
|
}
|
||||||
|
if d.Slots.Text != "позвонить маме" {
|
||||||
|
t.Fatalf("extraction overwrote the model's text: %q", d.Slots.Text)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// No time in the utterance ⇒ no time in the slots. Do not invent one; the
|
||||||
|
// daemon says it could not read the time.
|
||||||
|
func TestLLMReminderWithoutTimeStaysEmpty(t *testing.T) {
|
||||||
|
r := newLLMTestRouter(t, `{"intent":"reminder","text":"позвонить маме"}`)
|
||||||
|
d, err := r.Route(context.Background(), "напомни позвонить маме", refNow())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("route: %v", err)
|
||||||
|
}
|
||||||
|
if d.Slots.HasTime {
|
||||||
|
t.Fatalf("invented a time: %v", d.Slots.Time)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// An act decision arrived with no Fn, so the tool never ran.
|
||||||
|
func TestLLMDecisionGetsActFn(t *testing.T) {
|
||||||
|
r := newLLMTestRouter(t, `{"intent":"act","verb":"restart nginx"}`)
|
||||||
|
d, err := r.Route(context.Background(), "слушай, restart nginx пожалуйста", refNow())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("route: %v", err)
|
||||||
|
}
|
||||||
|
if !d.Slots.HasFn || d.Slots.Fn != "restart" || len(d.Slots.Args) != 1 || d.Slots.Args[0] != "nginx" {
|
||||||
|
t.Fatalf("want fn=restart args=[nginx], got %+v", d.Slots)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The model's own slots win; extraction only fills gaps.
|
||||||
|
func TestLLMSlotsWinOverExtraction(t *testing.T) {
|
||||||
|
r := newLLMTestRouter(t, `{"intent":"fact","key":"hydration","value":"выпил"}`)
|
||||||
|
d, err := r.Route(context.Background(), "я выпил воду", refNow())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("route: %v", err)
|
||||||
|
}
|
||||||
|
if d.Slots.Key != "hydration" {
|
||||||
|
t.Fatalf("extraction overwrote the model's key: %q", d.Slots.Key)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A fact the model left keyless still gets one from the parser.
|
||||||
|
func TestLLMFactGetsKeyFromParser(t *testing.T) {
|
||||||
|
r := newLLMTestRouter(t, `{"intent":"fact","text":"я выпил воду"}`)
|
||||||
|
d, err := r.Route(context.Background(), "я выпил воду", refNow())
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("route: %v", err)
|
||||||
|
}
|
||||||
|
if !d.Slots.HasKey || d.Slots.Key != "water" {
|
||||||
|
t.Fatalf("want key=water, got %+v", d.Slots)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|||||||
@@ -33,6 +33,7 @@ const (
|
|||||||
type onnxEmbedder struct {
|
type onnxEmbedder struct {
|
||||||
tokenizer *unigramTokenizer
|
tokenizer *unigramTokenizer
|
||||||
session *ort.DynamicSession[int64, float32]
|
session *ort.DynamicSession[int64, float32]
|
||||||
|
id string
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewONNXEmbedder(modelPath, tokenizerPath, libPath string) (*onnxEmbedder, error) {
|
func NewONNXEmbedder(modelPath, tokenizerPath, libPath string) (*onnxEmbedder, error) {
|
||||||
@@ -58,11 +59,31 @@ func NewONNXEmbedder(modelPath, tokenizerPath, libPath string) (*onnxEmbedder, e
|
|||||||
return &onnxEmbedder{
|
return &onnxEmbedder{
|
||||||
tokenizer: tok,
|
tokenizer: tok,
|
||||||
session: session,
|
session: session,
|
||||||
|
id: modelIDFromPath(modelPath),
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (e *onnxEmbedder) Dim() int { return embedDim }
|
func (e *onnxEmbedder) Dim() int { return embedDim }
|
||||||
|
|
||||||
|
// ID names the loaded model for the DB marker (Vikunja #378): the model file's
|
||||||
|
// own name plus the dimension, so pointing the config at another model changes
|
||||||
|
// the string on its own.
|
||||||
|
func (e *onnxEmbedder) ID() string { return e.id }
|
||||||
|
|
||||||
|
// modelIDFromPath turns /opt/.../multilingual-e5-small.onnx into
|
||||||
|
// "multilingual-e5-small@384".
|
||||||
|
func modelIDFromPath(modelPath string) string {
|
||||||
|
name := modelPath
|
||||||
|
if i := strings.LastIndexAny(name, "/\\"); i >= 0 {
|
||||||
|
name = name[i+1:]
|
||||||
|
}
|
||||||
|
name = strings.TrimSuffix(name, ".onnx")
|
||||||
|
if name == "" {
|
||||||
|
name = "onnx"
|
||||||
|
}
|
||||||
|
return fmt.Sprintf("%s@%d", name, embedDim)
|
||||||
|
}
|
||||||
|
|
||||||
// Embed treats the text as a query. The classifier compares one short
|
// Embed treats the text as a query. The classifier compares one short
|
||||||
// utterance to another short seed phrase, so both sides get the same prefix
|
// utterance to another short seed phrase, so both sides get the same prefix
|
||||||
// and the comparison stays fair. The recall path must call EmbedQuery and
|
// and the comparison stays fair. The recall path must call EmbedQuery and
|
||||||
|
|||||||
@@ -88,6 +88,7 @@ func (r *Router) Route(ctx context.Context, utterance string, now time.Time) (De
|
|||||||
if r.llm != nil {
|
if r.llm != nil {
|
||||||
if d, ok, err := r.llm.Route(ctx, utterance, now); err == nil && ok {
|
if d, ok, err := r.llm.Route(ctx, utterance, now); err == nil && ok {
|
||||||
d.Utterance = utterance
|
d.Utterance = utterance
|
||||||
|
r.fillSlots(ctx, &d, now)
|
||||||
return d, nil
|
return d, nil
|
||||||
} else if err != nil {
|
} else if err != nil {
|
||||||
log.Printf("router: llm route fell back to classifier: %v", err)
|
log.Printf("router: llm route fell back to classifier: %v", err)
|
||||||
@@ -118,6 +119,39 @@ func (r *Router) Route(ctx context.Context, utterance string, now time.Time) (De
|
|||||||
return d, nil
|
return d, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// fillSlots — run stage-2 extraction on an LLM decision and fill only the slots
|
||||||
|
// the model left empty. The LLM wins where it answered: it saw the sentence, the
|
||||||
|
// parsers are keyword tables. Extraction covers what the model cannot produce at
|
||||||
|
// all — a parsed reminder time and an allowlist fn.
|
||||||
|
//
|
||||||
|
// If a reminder still has no time, leave it missing. The daemon then says it
|
||||||
|
// could not read the time; inventing one would set a wrong alarm.
|
||||||
|
func (r *Router) fillSlots(ctx context.Context, d *Decision, now time.Time) {
|
||||||
|
ex := r.extractor.Extract(ctx, d.Intent, d.Utterance, now)
|
||||||
|
if !d.Slots.HasTime && ex.HasTime {
|
||||||
|
d.Slots.Time, d.Slots.HasTime = ex.Time, ex.HasTime
|
||||||
|
}
|
||||||
|
if !d.Slots.HasKey && ex.HasKey {
|
||||||
|
d.Slots.Key, d.Slots.Value, d.Slots.HasKey = ex.Key, ex.Value, ex.HasKey
|
||||||
|
}
|
||||||
|
if !d.Slots.HasFn && ex.HasFn {
|
||||||
|
d.Slots.Fn, d.Slots.Args, d.Slots.HasFn = ex.Fn, ex.Args, ex.HasFn
|
||||||
|
}
|
||||||
|
// For an act the model returns the verb in Text ("restart nginx"), which is
|
||||||
|
// often cleaner than the raw utterance ("maven, could you restart nginx").
|
||||||
|
// Try it too when the utterance did not match the allowlist.
|
||||||
|
if d.Intent == IntentAct && !d.Slots.HasFn && r.extractor.Acts != nil &&
|
||||||
|
d.Slots.Text != "" && d.Slots.Text != d.Utterance {
|
||||||
|
if fn, args, ok := r.extractor.Acts.Match(d.Slots.Text); ok {
|
||||||
|
d.Slots.Fn, d.Slots.Args, d.Slots.HasFn = fn, args, true
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if d.Slots.Text == "" {
|
||||||
|
d.Slots.Text = ex.Text
|
||||||
|
}
|
||||||
|
// Stage stays 1: it says who decided the route, and that was the LLM.
|
||||||
|
}
|
||||||
|
|
||||||
// CorrectMisroute — the user corrected a bad classification. Appends a new
|
// CorrectMisroute — the user corrected a bad classification. Appends a new
|
||||||
// example for the corrected intent (append-only — grows the classifier, no
|
// example for the corrected intent (append-only — grows the classifier, no
|
||||||
// retrain). Same shape as nudges.outcome tuning cooldowns: more reliable over
|
// retrain). Same shape as nudges.outcome tuning cooldowns: more reliable over
|
||||||
|
|||||||
@@ -449,16 +449,30 @@ func (AnaphoraResolver) Resolve(text string) (ref string, ok bool) {
|
|||||||
return "", false
|
return "", false
|
||||||
}
|
}
|
||||||
|
|
||||||
// ParseCalendarDate detects RU calendar date words in text and returns the
|
// ParseCalendarDate detects RU/EN calendar day words in text and returns
|
||||||
// resolved time (midnight UTC+0 for "сегодня"/"today", next day for "завтра"/"tomorrow").
|
// midnight of that day in now's own time zone. Handles "сегодня", "завтра",
|
||||||
// Returns zero time + false if no match.
|
// "послезавтра", "вчера" (and the English words). Returns zero time + false
|
||||||
|
// if no match.
|
||||||
|
//
|
||||||
|
// "послезавтра" is checked before "завтра" because it contains it.
|
||||||
func ParseCalendarDate(text string, now time.Time) (time.Time, bool) {
|
func ParseCalendarDate(text string, now time.Time) (time.Time, bool) {
|
||||||
lower := strings.ToLower(text)
|
lower := strings.ToLower(text)
|
||||||
if strings.Contains(lower, "сегодня") || strings.Contains(lower, "today") {
|
switch {
|
||||||
return now.Truncate(24 * time.Hour), true
|
case strings.Contains(lower, "сегодня") || strings.Contains(lower, "today"):
|
||||||
}
|
return midnight(now, 0), true
|
||||||
if strings.Contains(lower, "завтра") || strings.Contains(lower, "tomorrow") {
|
case strings.Contains(lower, "послезавтра") || strings.Contains(lower, "day after tomorrow"):
|
||||||
return now.Truncate(24 * time.Hour).Add(24 * time.Hour), true
|
return midnight(now, 2), true
|
||||||
|
case strings.Contains(lower, "завтра") || strings.Contains(lower, "tomorrow"):
|
||||||
|
return midnight(now, 1), true
|
||||||
|
case strings.Contains(lower, "вчера") || strings.Contains(lower, "yesterday"):
|
||||||
|
return midnight(now, -1), true
|
||||||
}
|
}
|
||||||
return time.Time{}, false
|
return time.Time{}, false
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// midnight returns the start of the day that is `days` away from now, in
|
||||||
|
// now's time zone (now.Truncate(24h) would cut on a UTC boundary instead).
|
||||||
|
func midnight(now time.Time, days int) time.Time {
|
||||||
|
y, m, d := now.AddDate(0, 0, days).Date()
|
||||||
|
return time.Date(y, m, d, 0, 0, 0, 0, now.Location())
|
||||||
|
}
|
||||||
|
|||||||
@@ -45,6 +45,9 @@ func TestParseCalendarDate(t *testing.T) {
|
|||||||
{"расписание на завтра", time.Date(2026, 7, 7, 0, 0, 0, 0, time.UTC), true},
|
{"расписание на завтра", time.Date(2026, 7, 7, 0, 0, 0, 0, time.UTC), true},
|
||||||
{"what's today", time.Date(2026, 7, 6, 0, 0, 0, 0, time.UTC), true},
|
{"what's today", time.Date(2026, 7, 6, 0, 0, 0, 0, time.UTC), true},
|
||||||
{"tomorrow plans", time.Date(2026, 7, 7, 0, 0, 0, 0, time.UTC), true},
|
{"tomorrow plans", time.Date(2026, 7, 7, 0, 0, 0, 0, time.UTC), true},
|
||||||
|
{"какое число послезавтра", time.Date(2026, 7, 8, 0, 0, 0, 0, time.UTC), true},
|
||||||
|
{"что было вчера", time.Date(2026, 7, 5, 0, 0, 0, 0, time.UTC), true},
|
||||||
|
{"yesterday plans", time.Date(2026, 7, 5, 0, 0, 0, 0, time.UTC), true},
|
||||||
{"какая погода", time.Time{}, false},
|
{"какая погода", time.Time{}, false},
|
||||||
{"сколько времени", time.Time{}, false},
|
{"сколько времени", time.Time{}, false},
|
||||||
{"", time.Time{}, false},
|
{"", time.Time{}, false},
|
||||||
|
|||||||
@@ -0,0 +1,161 @@
|
|||||||
|
package store
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"encoding/json"
|
||||||
|
"fmt"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// EmbedFunc embeds one piece of stored text. The caller passes
|
||||||
|
// router.EmbedPassage — the STORE side of the query/passage asymmetry, which is
|
||||||
|
// the side every vector in the DB was written with. (Passing the query side
|
||||||
|
// would put the stored vectors in the wrong half of the space and quietly halve
|
||||||
|
// recall.) A func instead of an interface keeps this package free of any
|
||||||
|
// dependency on internal/router.
|
||||||
|
type EmbedFunc func(ctx context.Context, text string) ([]float32, error)
|
||||||
|
|
||||||
|
// BackfillResult is what the re-embed run did, for logging.
|
||||||
|
type BackfillResult struct {
|
||||||
|
Skipped bool // marker already matched — nothing to do
|
||||||
|
Notes int // rows rewritten in the notes table
|
||||||
|
Facts int // fact rows rewritten in memory_vectors
|
||||||
|
MemNotes int // note rows rewritten in memory_vectors
|
||||||
|
NoText int // memory_vectors rows with no text in their meta, left alone
|
||||||
|
Took time.Duration
|
||||||
|
}
|
||||||
|
|
||||||
|
// ReembedAll rewrites every stored vector with the currently configured
|
||||||
|
// embedder and then records that embedder as the one that owns the DB.
|
||||||
|
//
|
||||||
|
// Both places a vector lives are rewritten in the same pass: the `notes` table
|
||||||
|
// `embedding` column and the `memory_vectors` rows (notes AND facts). Doing
|
||||||
|
// only one would leave the two indexes disagreeing, which is worse than leaving
|
||||||
|
// both stale.
|
||||||
|
//
|
||||||
|
// Safe to re-run: if the marker already names the current embedder there is
|
||||||
|
// nothing to fix, so it returns immediately with Skipped set.
|
||||||
|
//
|
||||||
|
// Crash safety: everything — every vector and the marker — happens inside one
|
||||||
|
// transaction. If anything fails or the process dies partway, the transaction
|
||||||
|
// rolls back: no vectors changed and no marker written, so the next run does
|
||||||
|
// the whole job again. The marker is never set unless the full rewrite
|
||||||
|
// committed.
|
||||||
|
func (s *Store) ReembedAll(ctx context.Context, currentID string, embed EmbedFunc) (BackfillResult, error) {
|
||||||
|
start := time.Now()
|
||||||
|
var res BackfillResult
|
||||||
|
|
||||||
|
stored, err := s.Meta(ctx, metaKeyEmbedderID)
|
||||||
|
if err != nil {
|
||||||
|
return res, err
|
||||||
|
}
|
||||||
|
if stored == currentID {
|
||||||
|
res.Skipped = true
|
||||||
|
res.Took = time.Since(start)
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
tx, err := s.db.BeginTx(ctx, nil)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: begin: %w", err)
|
||||||
|
}
|
||||||
|
defer tx.Rollback() // no-op once committed
|
||||||
|
|
||||||
|
// ----- notes table -----
|
||||||
|
type noteRow struct {
|
||||||
|
id int64
|
||||||
|
text string
|
||||||
|
}
|
||||||
|
var notes []noteRow
|
||||||
|
rows, err := tx.QueryContext(ctx, `SELECT id, text FROM notes WHERE text != ''`)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: read notes: %w", err)
|
||||||
|
}
|
||||||
|
for rows.Next() {
|
||||||
|
var n noteRow
|
||||||
|
if err := rows.Scan(&n.id, &n.text); err != nil {
|
||||||
|
rows.Close()
|
||||||
|
return res, fmt.Errorf("reembed: note row: %w", err)
|
||||||
|
}
|
||||||
|
notes = append(notes, n)
|
||||||
|
}
|
||||||
|
rows.Close()
|
||||||
|
if err := rows.Err(); err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: notes: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, n := range notes {
|
||||||
|
vec, err := embed(ctx, n.text)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: embed note %d: %w", n.id, err)
|
||||||
|
}
|
||||||
|
if _, err := tx.ExecContext(ctx,
|
||||||
|
`UPDATE notes SET embedding = ? WHERE id = ?`, floatsToBlob(vec), n.id); err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: write note %d: %w", n.id, err)
|
||||||
|
}
|
||||||
|
res.Notes++
|
||||||
|
}
|
||||||
|
|
||||||
|
// ----- memory_vectors (the unified index: notes AND facts) -----
|
||||||
|
// The text to re-embed is the one carried in the row's meta blob, which is
|
||||||
|
// exactly the text that was embedded when the row was written.
|
||||||
|
type vecRow struct {
|
||||||
|
id, text, kind string
|
||||||
|
}
|
||||||
|
var vecs []vecRow
|
||||||
|
rows, err = tx.QueryContext(ctx, `SELECT id, meta FROM memory_vectors`)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: read memory vectors: %w", err)
|
||||||
|
}
|
||||||
|
for rows.Next() {
|
||||||
|
var id, metaJSON string
|
||||||
|
if err := rows.Scan(&id, &metaJSON); err != nil {
|
||||||
|
rows.Close()
|
||||||
|
return res, fmt.Errorf("reembed: memory row: %w", err)
|
||||||
|
}
|
||||||
|
meta := map[string]string{}
|
||||||
|
if err := json.Unmarshal([]byte(metaJSON), &meta); err != nil {
|
||||||
|
rows.Close()
|
||||||
|
return res, fmt.Errorf("reembed: meta for %q: %w", id, err)
|
||||||
|
}
|
||||||
|
if meta["text"] == "" {
|
||||||
|
res.NoText++
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
vecs = append(vecs, vecRow{id: id, text: meta["text"], kind: meta["type"]})
|
||||||
|
}
|
||||||
|
rows.Close()
|
||||||
|
if err := rows.Err(); err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: memory vectors: %w", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, v := range vecs {
|
||||||
|
vec, err := embed(ctx, v.text)
|
||||||
|
if err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: embed %q: %w", v.id, err)
|
||||||
|
}
|
||||||
|
if _, err := tx.ExecContext(ctx,
|
||||||
|
`UPDATE memory_vectors SET vec = ? WHERE id = ?`, encodeVec(vec), v.id); err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: write %q: %w", v.id, err)
|
||||||
|
}
|
||||||
|
if v.kind == "fact" {
|
||||||
|
res.Facts++
|
||||||
|
} else {
|
||||||
|
res.MemNotes++
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Same transaction as the rewrite, on purpose: the marker can only exist if
|
||||||
|
// every vector above was written.
|
||||||
|
if _, err := tx.ExecContext(ctx,
|
||||||
|
`INSERT INTO meta (key, value) VALUES (?,?)
|
||||||
|
ON CONFLICT(key) DO UPDATE SET value = excluded.value`,
|
||||||
|
metaKeyEmbedderID, currentID); err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: write marker: %w", err)
|
||||||
|
}
|
||||||
|
if err := tx.Commit(); err != nil {
|
||||||
|
return res, fmt.Errorf("reembed: commit: %w", err)
|
||||||
|
}
|
||||||
|
res.Took = time.Since(start)
|
||||||
|
return res, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,171 @@
|
|||||||
|
package store
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"errors"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// markerVec is a recognisable vector: nothing in these tests writes it except
|
||||||
|
// the backfill, so finding it proves the row really was rewritten.
|
||||||
|
var markerVec = []float32{9, 9, 9}
|
||||||
|
|
||||||
|
func newEmbedder(calls *int) EmbedFunc {
|
||||||
|
return func(_ context.Context, _ string) ([]float32, error) {
|
||||||
|
*calls++
|
||||||
|
return markerVec, nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// seedOldVectors puts one note (notes table + unified index) and one fact
|
||||||
|
// (unified index only) in the DB, both carrying obviously-old vectors.
|
||||||
|
func seedOldVectors(t *testing.T, s *Store) {
|
||||||
|
t.Helper()
|
||||||
|
ctx := context.Background()
|
||||||
|
old := []float32{0.1, 0.2, 0.3}
|
||||||
|
id, err := s.WriteNote(ctx, time.Now(), "молоко в холодильнике", old, "voice")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("WriteNote: %v", err)
|
||||||
|
}
|
||||||
|
mem := s.VectorMemory()
|
||||||
|
if err := mem.Insert(ctx, "note:1", old, map[string]string{
|
||||||
|
"type": "note", "text": "молоко в холодильнике",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("Insert note vector: %v", err)
|
||||||
|
}
|
||||||
|
if err := mem.Insert(ctx, "fact:water:1", old, map[string]string{
|
||||||
|
"type": "fact", "text": "я пил воду",
|
||||||
|
}); err != nil {
|
||||||
|
t.Fatalf("Insert fact vector: %v", err)
|
||||||
|
}
|
||||||
|
_ = id
|
||||||
|
}
|
||||||
|
|
||||||
|
func noteVec(t *testing.T, s *Store) []float32 {
|
||||||
|
t.Helper()
|
||||||
|
var blob []byte
|
||||||
|
if err := s.db.QueryRow(`SELECT embedding FROM notes LIMIT 1`).Scan(&blob); err != nil {
|
||||||
|
t.Fatalf("read note embedding: %v", err)
|
||||||
|
}
|
||||||
|
return blobToFloats(blob)
|
||||||
|
}
|
||||||
|
|
||||||
|
func memVec(t *testing.T, s *Store, id string) []float32 {
|
||||||
|
t.Helper()
|
||||||
|
var blob []byte
|
||||||
|
if err := s.db.QueryRow(`SELECT vec FROM memory_vectors WHERE id = ?`, id).Scan(&blob); err != nil {
|
||||||
|
t.Fatalf("read memory vector %s: %v", id, err)
|
||||||
|
}
|
||||||
|
return decodeVec(blob)
|
||||||
|
}
|
||||||
|
|
||||||
|
func sameVec(a, b []float32) bool {
|
||||||
|
if len(a) != len(b) {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
for i := range a {
|
||||||
|
if a[i] != b[i] {
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
|
||||||
|
// The deployed case: old vectors everywhere, no marker. Every vector in both
|
||||||
|
// places must be rewritten and the marker recorded.
|
||||||
|
func TestReembedAllRewritesEveryVector(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
seedOldVectors(t, s)
|
||||||
|
|
||||||
|
calls := 0
|
||||||
|
res, err := s.ReembedAll(ctx, "multilingual-e5-small@384", newEmbedder(&calls))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("ReembedAll: %v", err)
|
||||||
|
}
|
||||||
|
if res.Skipped {
|
||||||
|
t.Fatal("first run should not skip")
|
||||||
|
}
|
||||||
|
if res.Notes != 1 || res.MemNotes != 1 || res.Facts != 1 {
|
||||||
|
t.Fatalf("counts: notes=%d memNotes=%d facts=%d", res.Notes, res.MemNotes, res.Facts)
|
||||||
|
}
|
||||||
|
if calls != 3 {
|
||||||
|
t.Fatalf("embedder called %d times, want 3", calls)
|
||||||
|
}
|
||||||
|
if !sameVec(noteVec(t, s), markerVec) {
|
||||||
|
t.Fatalf("notes table not rewritten: %v", noteVec(t, s))
|
||||||
|
}
|
||||||
|
if !sameVec(memVec(t, s, "note:1"), markerVec) {
|
||||||
|
t.Fatal("unified index note row not rewritten")
|
||||||
|
}
|
||||||
|
if !sameVec(memVec(t, s, "fact:water:1"), markerVec) {
|
||||||
|
t.Fatal("unified index fact row not rewritten")
|
||||||
|
}
|
||||||
|
got, err := s.Meta(ctx, metaKeyEmbedderID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Meta: %v", err)
|
||||||
|
}
|
||||||
|
if got != "multilingual-e5-small@384" {
|
||||||
|
t.Fatalf("marker = %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Re-running must do nothing at all — not a second pass over the same rows.
|
||||||
|
func TestReembedAllSecondRunIsNoop(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
seedOldVectors(t, s)
|
||||||
|
|
||||||
|
calls := 0
|
||||||
|
if _, err := s.ReembedAll(ctx, "e5@384", newEmbedder(&calls)); err != nil {
|
||||||
|
t.Fatalf("first run: %v", err)
|
||||||
|
}
|
||||||
|
first := calls
|
||||||
|
|
||||||
|
res, err := s.ReembedAll(ctx, "e5@384", newEmbedder(&calls))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("second run: %v", err)
|
||||||
|
}
|
||||||
|
if !res.Skipped {
|
||||||
|
t.Fatal("second run should report Skipped")
|
||||||
|
}
|
||||||
|
if calls != first {
|
||||||
|
t.Fatalf("second run embedded %d more rows, want 0", calls-first)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// A failure partway must leave the DB exactly as it was: no marker, and the old
|
||||||
|
// vectors still in place (one transaction, rolled back).
|
||||||
|
func TestReembedAllPartialFailureLeavesMarkerUnset(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
seedOldVectors(t, s)
|
||||||
|
before := noteVec(t, s)
|
||||||
|
|
||||||
|
calls := 0
|
||||||
|
boom := func(_ context.Context, _ string) ([]float32, error) {
|
||||||
|
calls++
|
||||||
|
if calls == 2 {
|
||||||
|
return nil, errors.New("onnx blew up")
|
||||||
|
}
|
||||||
|
return markerVec, nil
|
||||||
|
}
|
||||||
|
if _, err := s.ReembedAll(ctx, "e5@384", boom); err == nil {
|
||||||
|
t.Fatal("expected an error")
|
||||||
|
}
|
||||||
|
got, err := s.Meta(ctx, metaKeyEmbedderID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Meta: %v", err)
|
||||||
|
}
|
||||||
|
if got != "" {
|
||||||
|
t.Fatalf("marker was set to %q after a failed run", got)
|
||||||
|
}
|
||||||
|
if !sameVec(noteVec(t, s), before) {
|
||||||
|
t.Fatal("a failed run left a partially rewritten notes table")
|
||||||
|
}
|
||||||
|
// And the mismatch warning must still fire, so the user knows to re-run.
|
||||||
|
if _, mismatch, err := s.CheckEmbedder(ctx, "e5@384"); err != nil || !mismatch {
|
||||||
|
t.Fatalf("CheckEmbedder after failed backfill: mismatch=%v err=%v", mismatch, err)
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -0,0 +1,74 @@
|
|||||||
|
package store
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// DialogueSessionRow — one saved follow-up session. Data is the session
|
||||||
|
// encoded by the dialogue package; the store does not look inside it.
|
||||||
|
type DialogueSessionRow struct {
|
||||||
|
ID string
|
||||||
|
Data []byte
|
||||||
|
Ts time.Time
|
||||||
|
TTL time.Duration
|
||||||
|
Expires time.Time
|
||||||
|
}
|
||||||
|
|
||||||
|
// SaveDialogueSession — write (or replace) the session for one dialogue id.
|
||||||
|
// One row per id: a newer turn overwrites the older state.
|
||||||
|
func (s *Store) SaveDialogueSession(ctx context.Context, id string, data []byte, ts time.Time, ttl time.Duration) error {
|
||||||
|
expires := ts.Add(ttl)
|
||||||
|
_, err := s.db.ExecContext(ctx, `
|
||||||
|
INSERT INTO dialogue_sessions (id, data, ts, ttl_ms, expires_ts) VALUES (?, ?, ?, ?, ?)
|
||||||
|
ON CONFLICT(id) DO UPDATE SET data = excluded.data,
|
||||||
|
ts = excluded.ts,
|
||||||
|
ttl_ms = excluded.ttl_ms,
|
||||||
|
expires_ts = excluded.expires_ts`,
|
||||||
|
id, data, ts.UnixMilli(), ttl.Milliseconds(), expires.UnixMilli())
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("save dialogue session: %w", err)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// DeleteDialogueSession — drop one session (ended, or expired).
|
||||||
|
func (s *Store) DeleteDialogueSession(ctx context.Context, id string) error {
|
||||||
|
if _, err := s.db.ExecContext(ctx, `DELETE FROM dialogue_sessions WHERE id = ?`, id); err != nil {
|
||||||
|
return fmt.Errorf("delete dialogue session: %w", err)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// LoadDialogueSessions — return the sessions still alive at `now` and delete
|
||||||
|
// the ones that already ran out. An expired session is dead: it never comes
|
||||||
|
// back after a restart.
|
||||||
|
func (s *Store) LoadDialogueSessions(ctx context.Context, now time.Time) ([]DialogueSessionRow, error) {
|
||||||
|
if _, err := s.db.ExecContext(ctx,
|
||||||
|
`DELETE FROM dialogue_sessions WHERE expires_ts <= ?`, now.UnixMilli()); err != nil {
|
||||||
|
return nil, fmt.Errorf("prune dialogue sessions: %w", err)
|
||||||
|
}
|
||||||
|
rows, err := s.db.QueryContext(ctx,
|
||||||
|
`SELECT id, data, ts, ttl_ms, expires_ts FROM dialogue_sessions ORDER BY id`)
|
||||||
|
if err != nil {
|
||||||
|
return nil, fmt.Errorf("load dialogue sessions: %w", err)
|
||||||
|
}
|
||||||
|
defer rows.Close()
|
||||||
|
var out []DialogueSessionRow
|
||||||
|
for rows.Next() {
|
||||||
|
var r DialogueSessionRow
|
||||||
|
var tsMilli, ttlMilli, expMilli int64
|
||||||
|
if err := rows.Scan(&r.ID, &r.Data, &tsMilli, &ttlMilli, &expMilli); err != nil {
|
||||||
|
return nil, fmt.Errorf("scan dialogue session: %w", err)
|
||||||
|
}
|
||||||
|
r.Ts = time.UnixMilli(tsMilli).UTC()
|
||||||
|
r.TTL = time.Duration(ttlMilli) * time.Millisecond
|
||||||
|
r.Expires = time.UnixMilli(expMilli).UTC()
|
||||||
|
out = append(out, r)
|
||||||
|
}
|
||||||
|
if err := rows.Err(); err != nil {
|
||||||
|
return nil, fmt.Errorf("load dialogue sessions: %w", err)
|
||||||
|
}
|
||||||
|
return out, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,97 @@
|
|||||||
|
package store
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"database/sql"
|
||||||
|
"errors"
|
||||||
|
"fmt"
|
||||||
|
)
|
||||||
|
|
||||||
|
// metaKeyEmbedderID names the embedder that wrote the stored vectors.
|
||||||
|
//
|
||||||
|
// Why one value for the whole DB and not a column on every vector row: the
|
||||||
|
// vectors are only ever rewritten all at once (one backfill re-embeds every
|
||||||
|
// note and fact together), so a per-row marker would hold the same string in
|
||||||
|
// every row and cost a column on two tables for nothing.
|
||||||
|
const metaKeyEmbedderID = "embedder_id"
|
||||||
|
|
||||||
|
// Meta reads a single value from the meta table. Missing key ⇒ empty string.
|
||||||
|
func (s *Store) Meta(ctx context.Context, key string) (string, error) {
|
||||||
|
var v string
|
||||||
|
err := s.db.QueryRowContext(ctx, `SELECT value FROM meta WHERE key = ?`, key).Scan(&v)
|
||||||
|
if errors.Is(err, sql.ErrNoRows) {
|
||||||
|
return "", nil
|
||||||
|
}
|
||||||
|
if err != nil {
|
||||||
|
return "", fmt.Errorf("read meta %s: %w", key, err)
|
||||||
|
}
|
||||||
|
return v, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// SetMeta writes (or overwrites) a single meta value.
|
||||||
|
func (s *Store) SetMeta(ctx context.Context, key, value string) error {
|
||||||
|
_, err := s.db.ExecContext(ctx,
|
||||||
|
`INSERT INTO meta (key, value) VALUES (?,?)
|
||||||
|
ON CONFLICT(key) DO UPDATE SET value = excluded.value`, key, value)
|
||||||
|
if err != nil {
|
||||||
|
return fmt.Errorf("write meta %s: %w", key, err)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// EmbedderUnknown is the stored id reported for a DB that already holds
|
||||||
|
// vectors but never recorded who wrote them.
|
||||||
|
const EmbedderUnknown = "unknown (written before this marker existed)"
|
||||||
|
|
||||||
|
// CheckEmbedder compares the embedder now configured against the one that
|
||||||
|
// wrote the stored vectors. Returns the stored id and whether it differs.
|
||||||
|
//
|
||||||
|
// Vectors from two different models live in different spaces, so cosine
|
||||||
|
// between them is noise rather than a low score — and both of our models are
|
||||||
|
// 384-dimensional, so nothing else catches it.
|
||||||
|
//
|
||||||
|
// Three cases, and the middle one is the one that actually matters:
|
||||||
|
//
|
||||||
|
// - marker present ⇒ compare the two ids.
|
||||||
|
// - marker absent but vectors already stored ⇒ this is a DB from before the
|
||||||
|
// marker, so we cannot know who wrote them. Report a mismatch. This is the
|
||||||
|
// real case on the deployed box: those vectors came from the old embedder,
|
||||||
|
// and claiming them for the current one would hide the exact problem the
|
||||||
|
// marker was added to catch.
|
||||||
|
// - marker absent and no vectors ⇒ fresh DB, claim it, nothing to fix.
|
||||||
|
//
|
||||||
|
// On a mismatch the fix is ReembedAll (backfill.go), run explicitly with
|
||||||
|
// `mavend -reembed`. Nothing is re-embedded here: that work is minutes of CPU
|
||||||
|
// on the laptop and must not stall a normal start.
|
||||||
|
func (s *Store) CheckEmbedder(ctx context.Context, currentID string) (stored string, mismatch bool, err error) {
|
||||||
|
stored, err = s.Meta(ctx, metaKeyEmbedderID)
|
||||||
|
if err != nil {
|
||||||
|
return "", false, err
|
||||||
|
}
|
||||||
|
if stored != "" {
|
||||||
|
return stored, stored != currentID, nil
|
||||||
|
}
|
||||||
|
n, err := s.countVectors(ctx)
|
||||||
|
if err != nil {
|
||||||
|
return "", false, err
|
||||||
|
}
|
||||||
|
if n > 0 {
|
||||||
|
return EmbedderUnknown, true, nil
|
||||||
|
}
|
||||||
|
return currentID, false, s.SetMeta(ctx, metaKeyEmbedderID, currentID)
|
||||||
|
}
|
||||||
|
|
||||||
|
// countVectors — how many stored rows carry an embedding. Used only to tell a
|
||||||
|
// fresh DB apart from one that predates the marker.
|
||||||
|
func (s *Store) countVectors(ctx context.Context) (int, error) {
|
||||||
|
var notes, vecs int
|
||||||
|
if err := s.db.QueryRowContext(ctx,
|
||||||
|
`SELECT count(*) FROM notes WHERE embedding IS NOT NULL`).Scan(¬es); err != nil {
|
||||||
|
return 0, fmt.Errorf("count note vectors: %w", err)
|
||||||
|
}
|
||||||
|
if err := s.db.QueryRowContext(ctx,
|
||||||
|
`SELECT count(*) FROM memory_vectors`).Scan(&vecs); err != nil {
|
||||||
|
return 0, fmt.Errorf("count memory vectors: %w", err)
|
||||||
|
}
|
||||||
|
return notes + vecs, nil
|
||||||
|
}
|
||||||
@@ -0,0 +1,100 @@
|
|||||||
|
package store
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"testing"
|
||||||
|
"time"
|
||||||
|
)
|
||||||
|
|
||||||
|
// A fresh DB has no marker yet, so the current embedder is recorded and
|
||||||
|
// nothing is flagged.
|
||||||
|
func TestCheckEmbedderFreshDBRecords(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
stored, mismatch, err := s.CheckEmbedder(ctx, "multilingual-e5-small@384")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("CheckEmbedder: %v", err)
|
||||||
|
}
|
||||||
|
if mismatch {
|
||||||
|
t.Fatal("fresh DB reported a mismatch")
|
||||||
|
}
|
||||||
|
if stored != "multilingual-e5-small@384" {
|
||||||
|
t.Fatalf("stored = %q", stored)
|
||||||
|
}
|
||||||
|
got, err := s.Meta(ctx, metaKeyEmbedderID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Meta: %v", err)
|
||||||
|
}
|
||||||
|
if got != "multilingual-e5-small@384" {
|
||||||
|
t.Fatalf("marker not persisted, got %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The deployed box: notes were written by the old embedder, before the marker
|
||||||
|
// existed. Claiming them for the current one would hide exactly the problem
|
||||||
|
// the marker is for, so an unmarked DB that already holds vectors is a
|
||||||
|
// mismatch.
|
||||||
|
func TestCheckEmbedderUnmarkedDBWithVectorsIsMismatch(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
if _, err := s.WriteNote(ctx, time.Now(), "молоко в холодильнике", []float32{0.1, 0.2}, "voice"); err != nil {
|
||||||
|
t.Fatalf("WriteNote: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
stored, mismatch, err := s.CheckEmbedder(ctx, "multilingual-e5-small@384")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("CheckEmbedder: %v", err)
|
||||||
|
}
|
||||||
|
if !mismatch {
|
||||||
|
t.Fatal("an unmarked DB with stored vectors should report a mismatch")
|
||||||
|
}
|
||||||
|
if stored != EmbedderUnknown {
|
||||||
|
t.Fatalf("stored = %q, want %q", stored, EmbedderUnknown)
|
||||||
|
}
|
||||||
|
// It must NOT claim the DB — that would silence the warning on restart.
|
||||||
|
got, err := s.Meta(ctx, metaKeyEmbedderID)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Meta: %v", err)
|
||||||
|
}
|
||||||
|
if got != "" {
|
||||||
|
t.Fatalf("marker written despite unknown provenance: %q", got)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Both models are 384-dim, so this is the only thing that catches the swap.
|
||||||
|
func TestCheckEmbedderDifferentModelMismatch(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
if err := s.SetMeta(ctx, metaKeyEmbedderID, "paraphrase-multilingual-MiniLM-L12-v2@384"); err != nil {
|
||||||
|
t.Fatalf("SetMeta: %v", err)
|
||||||
|
}
|
||||||
|
stored, mismatch, err := s.CheckEmbedder(ctx, "multilingual-e5-small@384")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("CheckEmbedder: %v", err)
|
||||||
|
}
|
||||||
|
if !mismatch {
|
||||||
|
t.Fatal("different embedder not detected")
|
||||||
|
}
|
||||||
|
if stored != "paraphrase-multilingual-MiniLM-L12-v2@384" {
|
||||||
|
t.Fatalf("stored = %q", stored)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// The same embedder must never raise a false alarm, including on re-check.
|
||||||
|
func TestCheckEmbedderSameModelNoAlarm(t *testing.T) {
|
||||||
|
s := newTestStore(t)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
for i := 0; i < 2; i++ {
|
||||||
|
_, mismatch, err := s.CheckEmbedder(ctx, "multilingual-e5-small@384")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("CheckEmbedder: %v", err)
|
||||||
|
}
|
||||||
|
if mismatch {
|
||||||
|
t.Fatalf("false alarm on pass %d", i)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -74,6 +74,20 @@ ALTER TABLE reminders ADD COLUMN next_fire_ts INTEGER;`, // #2
|
|||||||
`CREATE INDEX IF NOT EXISTS idx_nudges_snoozed ON nudges (outcome_ts) WHERE outcome = 'snoozed';`, // #8 — SnoozedUntil runs every tick; keep it off a full scan (Vikunja #364)
|
`CREATE INDEX IF NOT EXISTS idx_nudges_snoozed ON nudges (outcome_ts) WHERE outcome = 'snoozed';`, // #8 — SnoozedUntil runs every tick; keep it off a full scan (Vikunja #364)
|
||||||
`ALTER TABLE proposed_routines ADD COLUMN accepted_ts INTEGER;
|
`ALTER TABLE proposed_routines ADD COLUMN accepted_ts INTEGER;
|
||||||
ALTER TABLE proposed_routines ADD COLUMN last_fired_ts INTEGER;`, // #9 — accepted routines keep firing (Vikunja #366): the tick loop needs to know when a routine was accepted and when it last nudged
|
ALTER TABLE proposed_routines ADD COLUMN last_fired_ts INTEGER;`, // #9 — accepted routines keep firing (Vikunja #366): the tick loop needs to know when a routine was accepted and when it last nudged
|
||||||
|
|
||||||
|
`CREATE TABLE IF NOT EXISTS dialogue_sessions (
|
||||||
|
id TEXT PRIMARY KEY,
|
||||||
|
data BLOB NOT NULL,
|
||||||
|
ts INTEGER NOT NULL,
|
||||||
|
ttl_ms INTEGER NOT NULL,
|
||||||
|
expires_ts INTEGER NOT NULL
|
||||||
|
);
|
||||||
|
CREATE INDEX IF NOT EXISTS idx_dialogue_sessions_expires ON dialogue_sessions (expires_ts);`, // #10 — the follow-up session survives a restart (Vikunja #363); small, TTL-pruned table, not a history log
|
||||||
|
|
||||||
|
`CREATE TABLE IF NOT EXISTS meta (
|
||||||
|
key TEXT PRIMARY KEY,
|
||||||
|
value TEXT NOT NULL
|
||||||
|
);`, // #11 — small key/value table for facts about the DB itself; first key is embedder_id (Vikunja #378)
|
||||||
}
|
}
|
||||||
|
|
||||||
// migrate applies every migration with a number greater than the DB's current
|
// migrate applies every migration with a number greater than the DB's current
|
||||||
|
|||||||
Reference in New Issue
Block a user