kami/Maven
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Make make test really check gofmt and vet #12

Closed
claude wants to merge 2 commits from overnight/fmt-gate into overnight/routines-fire
pull from: overnight/fmt-gate
merge into: kami:overnight/routines-fire
Conversation 2 Commits 2 Files Changed 8
+72 -48
claude commented 2026-07-31 08:10:29 +02:00
Contributor
Copy Link
Copy Source

DESIGN.md says every change ends with "make test green (gofmt + vet + -race), no exceptions."

make test ran the tests. That is all it ran. So nine files had quietly drifted out of gofmt, and nobody was being sloppy — the check the doc promised simply was not wired up.

Commit 1 runs gofmt over the seven that were still dirty. git diff -w shows nothing but import ordering and one-line statements split out — no logic touched.

Commit 2 makes test depend on fmt-check and vet.

I checked the gate is real rather than decorative: I deliberately unformatted a file, ran it, and confirmed it fails with a non-zero exit and names the file. Then reverted and confirmed clean. A gate nobody has seen fail is not yet known to be a gate.

go vet was already clean across the tree, so that half changes nothing today — it just stops the next thing from slipping through.

Deliberately last of the night's work: reformatting seven files touches everything, and doing it earlier would have collided with every branch in flight.

`DESIGN.md` says every change ends with "`make test` green (gofmt + vet + `-race`), no exceptions." `make test` ran the tests. That is all it ran. So nine files had quietly drifted out of gofmt, and nobody was being sloppy — the check the doc promised simply was not wired up. **Commit 1** runs gofmt over the seven that were still dirty. `git diff -w` shows nothing but import ordering and one-line statements split out — no logic touched. **Commit 2** makes `test` depend on `fmt-check` and `vet`. I checked the gate is real rather than decorative: I deliberately unformatted a file, ran it, and confirmed it fails with a non-zero exit and names the file. Then reverted and confirmed clean. A gate nobody has seen fail is not yet known to be a gate. `go vet` was already clean across the tree, so that half changes nothing today — it just stops the next thing from slipping through. Deliberately last of the night's work: reformatting seven files touches everything, and doing it earlier would have collided with every branch in flight.
kami commented 2026-07-31 18:45:54 +02:00
Owner
Copy Link
Copy Source

this one shouldn't go in master.

this one shouldn't go in master.
kami changed target branch from master to overnight/routines-fire 2026-07-31 19:12:50 +02:00
kami added 2 commits 2026-07-31 19:12:50 +02:00
Run gofmt over the seven files that had drifted f7442c3aea 
Formatting only: import order, and statements that were packed onto one
line split out. `git diff -w` shows nothing but that.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CGeSZxh1DCtRxmFVSYVGvJ
Make make test actually gate on gofmt and vet c860808528 
DESIGN.md has always said `make test` is "gofmt + vet + -race, no
exceptions". It only ever ran the tests, which is how nine files drifted
out of format without anyone noticing.

`test` now depends on `fmt-check` and `vet`. Checked that fmt-check does
fail when a file is unformatted, so the gate is real and not decorative.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CGeSZxh1DCtRxmFVSYVGvJ
kami commented 2026-07-31 20:21:47 +02:00
Owner
Copy Link
Copy Source

Superseded by #47, which landed this whole stack on master as one reviewed integration merge. This PR head is an ancestor of master — its commits are in, nothing here is lost. Closing as merged-by-proxy rather than merged, since the merge came in through #47.

Review threads on this PR were answered or acted on before the merge; the Russian wording fixes went in as #48.

Superseded by #47, which landed this whole stack on master as one reviewed integration merge. This PR head is an ancestor of master — its commits are in, nothing here is lost. Closing as merged-by-proxy rather than merged, since the merge came in through #47. Review threads on this PR were answered or acted on before the merge; the Russian wording fixes went in as #48.
kami closed this pull request 2026-07-31 20:21:48 +02:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kami
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kami/Maven#12
Delete Branch "overnight/fmt-gate"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?