Bug: the router transliterates Latin entity names into Cyrillic before Nexus sees them #131
Reference in New Issue
Block a user
Delete Branch "task/476-bug-the-router-transliterates-latin-enti"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes Vikunja #476.
Opened during an unattended overnight run: the diff-budget block was off (
task overnight). Read the diff, not only the tests.Acceptance criteria and quality gate are in
TASK.mdon this branch.Review the review, not the diff — leave comments and the agent will apply them via
task start 476.Bug: a pending clarify is global, so one unanswerable question swallows the next three utterances from anybodyto Bug: the router transliterates Latin entity names into Cyrillic before Nexus sees them@@ -0,0 +19,4 @@{name: "the model transliterated the name",utterance: "перезапусти muzick indexer",text: "перезагрузить музик индексер",ew.
@@ -0,0 +43,4 @@{name: "the longest Latin run is the name",utterance: "а перезапусти-ка nginx на muzick-indexer, пожалуйста",text: "перезагрузить нгинкс",wtf is this?
The two comments on
entityname_test.goare answered in #163, which is stacked on this branch so nothing here is disturbed.entityReferenceTextpicked the longest Latin run, and length is a guess.перезапусти nginx на muzick-indexernames a service and the host it runs on, and the longer one is not the target. Nexus owns which strings are entities, soentityReferencesnow sends every Latin run in the order he said them (capped at four) and Nexus answers. Two names resolving to different entities is a clarify with the names Nexus spells, not a coin toss. The transliteration signal itself is unchanged.Reviewed as part of a bottom-up pass over the whole open stack (#119 to #168): commits read against the base branch,
make testgreen at the top of the stack. Nothing to raise on this one. Merging.Four findings landed on the PRs they belong to, none of them blocking: #167 (a duplicate
rest-of-day-querygrammar from the merge), #164 (four files the Russian sweep did not reach), #145 (sh -chides an irreversible verb from the tier derivation), #128 (locationCandidatesdrops short city names).