Sweep tail: four files the Russian sweep missed, plus a dead duplicate grammar #169

2026-08-04T19:19:01+02:00

claude commented

2026-08-04 19:19:01 +02:00

Closes Vikunja #530.

Opened during an unattended overnight run: the diff-budget block was off (task overnight). Read the diff, not only the tests.

Acceptance criteria and quality gate are in TASK.md on this branch.
Review the review, not the diff — leave comments and the agent will apply them via task start 530.

Closes Vikunja #530. Opened during an unattended overnight run: the diff-budget block was off (`task overnight`). Read the diff, not only the tests. Acceptance criteria and quality gate are in `TASK.md` on this branch. Review the review, not the diff — leave comments and the agent will apply them via `task start 530`.

claude added 4 commits 2026-08-04 19:19:01 +02:00

stage0: one rest-of-day grammar, not two (V-530) d9ef9ecef2

The textual merge in fe489df left a second rest-of-day-query grammar inside
NarrativeQueryGrammars. buildRouter wires the agenda grammars first, so the
copy never claimed a turn, and narrative_test.go only ever indexed the
narrative rule beside it.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

numbers and reminder markers come from the lexicon (V-530) 997f92f5c4

ruNumerals was a second copy of the number words. It stopped at fifty, had no
oblique forms, and disagreed with lexicon_ru_v1.json about its own members, so
"к семи" was not the hour "в семь" was. The lexicon now carries the oblique
cardinals and numwords.go asks lexicon.Cardinal. "час" and "часу" stay local:
they are the hour noun as often as the number one, and nobody counts "час
яблок".

reminderbody.go built its markers from three inline word lists. Two of them
are new lexicon sets, reminder_verbs and parts_of_day, and the day offsets
were already there. The alternation helper sorts by length so a longer form
wins the regex.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

history questions match verbs by lemma (V-530) 58b546a27e

historyMarkers were truncated Russian prefixes, so "что я читал рассказ" read
as a history question because "рассказ" is a prefix of "рассказывал". That is
the defect V-528 fixed in complaint.go, where "лаг" matched "лагерь".

A history question is now an interrogative, plus a first- or second-person
subject, plus a verb of saying or recording matched through morph.SameWord.
"что записать?" is a verb with nobody saying it and no longer claims the turn.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

weather asks the dictionary before guessing case (V-530) c62c7034fa

locationCandidates reversed endings by hand to turn "в Казани" into the
nominative the geocoder wants. internal/morph knows the answer for the places
it has, so it goes first and the reversals stay behind it for the ones it does
not: "Твери" and "Перми" come back unchanged.

The four-rune floor was there to stop a two-letter stem, so it now tests the
stem instead. "Уфе" was under the floor and "Уфа" was never tried.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

claude merged commit a4d5155029 into master

2026-08-04 19:25:10 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kami/Maven#169