claude
5b0b29dfad
The spare-key note scored 0.832 to 0.867 against a spare passport, a blue shirt, a blue document box and a car key. Score and margin cannot separate those: the right note runs 0.817 to 0.892 and the silent cases 0.787 to 0.874, so the ranges overlap and structure has to decide. RecallAllowed now takes two structural facts from the router. A locative question must corroborate every identity term against the candidate's subject, read up to its first dictionary-proven verb, so a location object in the note cannot answer for the thing being located. A turn that is not question-shaped needs a named shared topic even when it ends in '?', which is what "я отменил напоминание про молоко" lacked when it recalled an unrelated note at 0.825 with no runner-up to fail the margin. query_min_score moves 0.55 to 0.80 for tokenizer rev 2. The held-out fixture answers 14/27 real recalls and 0/14 false ones. LocativeAnswerVerifier is the resident-model second opinion, kept behind the deterministic gate and wired into nothing. The measurement that says why is docs/evals/2026-08-15-locative-answerability-verifier.md. --no-verify: master is the working branch this session by the owner's call. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
66 lines
2.7 KiB
Go
66 lines
2.7 KiB
Go
package main
|
|
|
|
import (
|
|
"github.com/kami/maven/internal/memory"
|
|
"github.com/kami/maven/internal/router"
|
|
)
|
|
|
|
// bestRecall is the read side of the long-term memory store: the top hit when
|
|
// it clears the confidence gate. The index holds BOTH notes and facts, and
|
|
// either can win — the caller looks at the returned hit's meta["type"] to see
|
|
// which. Facts aren't in the notes table, so this is the only path that can
|
|
// answer "when did I last …?" from a captured fact.
|
|
//
|
|
// The whole hit is returned, not just its text, because "which memory answered"
|
|
// decides how the answer is said: a note gets phrased in Maven's voice, a fact
|
|
// is read back as stored.
|
|
//
|
|
// ok=false when the hit fails the confidence gate (see memory.Confident: an
|
|
// absolute floor plus a margin over the runner-up) or carries no text.
|
|
func bestRecall(results []memory.Result, minScore, minMargin float64) (memory.Result, bool) {
|
|
if !memory.Confident(results, minScore, minMargin) {
|
|
return memory.Result{}, false
|
|
}
|
|
if results[0].Meta["text"] == "" {
|
|
return memory.Result{}, false
|
|
}
|
|
return results[0], true
|
|
}
|
|
|
|
// recallWiring — the recall subsystem's dependencies, held as one group on
|
|
// reactiveHandler (Vikunja #433). It is the worked example for the wiring
|
|
// decision in docs/handler-wiring.md: cohesive groups of fields, not thirty
|
|
// loose ones, so a handler names what it needs and the package can be split
|
|
// later without exporting the whole struct.
|
|
//
|
|
// The zero value is usable and means "no recall": no embedder, no vector
|
|
// store, and a gate that is never consulted because nothing is ever searched.
|
|
type recallWiring struct {
|
|
// embedder — reused for note write/query (same model as the classifier).
|
|
embedder router.Embedder
|
|
|
|
// memStore — the vector index over notes and facts.
|
|
memStore memory.Store
|
|
|
|
// topics — the embedded seed sets behind the weather, house and LAN
|
|
// recognisers (topics.go). Same lifecycle as boundary below: zero value is
|
|
// usable, loads on first query, and with no embedder it never loads and
|
|
// each source falls back to its own keyword test.
|
|
topics topicIndex
|
|
|
|
// boundary — the embedded seed sets behind the personal boundary
|
|
// (personalboundary.go). Zero value is usable and loads on first query;
|
|
// with no embedder it never loads and the boundary uses personalMarkers.
|
|
boundary personalBoundary
|
|
|
|
// minScore — the note-recall confidence gate. Top cosine below this ⇒
|
|
// "I don't know" instead of a guess. Tuned for the ONNX embedder; a knob,
|
|
// not load-bearing math (same posture as the presence thresholds). Set by
|
|
// wireVoice from VoiceConfig; default 0.80.
|
|
minScore float64
|
|
|
|
// minMargin — the second half of that gate: how far the top hit must beat
|
|
// the runner-up. 0 ⇒ margin off.
|
|
minMargin float64
|
|
}
|