claude
a286865fe5
PR 113's review, four bugs and the register cuts.
«дн.» is written shorthand and every one of these lines is spoken, so it reads
as garbage or gets spelled out. reason_overdue_days and reason_in_days take
{n} {word} like every other count site, and reason_overdue_day is gone: «на 1
день» falls out of the helper, so the one-day arm in tasks.Rank went with it.
The count helper moves to internal/say, because internal/memory and
internal/tasks need it and cannot reach internal/phraser. Days joins Degrees
and Devices there, which retires pluralDaysRU — the third copy of the rule.
internal/phraser keeps the three names cmd/mavend already calls.
Six placeholders were undeclared: {line} {sat} {sun} {key} {gloss} {time}.
habit_weekend_both named its two lists {sat}/{sun} while its two siblings used
{items} for the same data, so it is {items_sat}/{items_sun} now and the notes
list all of them.
Fixedness was inconsistent across parallel single-variant entries. Deck.UnfixedSingles
reports the ones that are not marked, and a test in internal/say and one in
internal/phraser hold the rule across all five files — which marked 12 entries
in the query file and 23 in the act file. Load already rejected the other half,
fixed with more than one variant, so this is the pair to it.
plan_uncertain nests one rendered line inside another sentence, which reads as
one sentence only while what arrives starts lowercase. Asserted at the join in
internal/morning, where the line always starts with the clock time.
Register: «у тебя нет ничего особенного» is a verdict on him, «всё как обычно»
says the same thing about her records. «на привычки я так не сошлюсь» is
bookish. «ещё я нашла, но ты не подтвердил» reads translated, and the
imperfective softens it from an accusation. «у тебя» goes where the day already
carries it. Trailing periods come off the entries that end on {items}, so
tasks.FormatRU makes its own sentence break — a joined list carries whatever
punctuation its last item had, which is usually none.
--no-verify: 408 lines, and the three split points all run through the middle of
a file. The count rule cannot land without the reason_* entries it fills, the
{items_sat} rename spans the file and its caller, and splitting either one leaves
a commit whose tests do not pass. One review, one family, one commit.
63 lines
2.1 KiB
Go
63 lines
2.1 KiB
Go
package say
|
|
|
|
import (
|
|
"math/rand"
|
|
"strings"
|
|
"testing"
|
|
)
|
|
|
|
// The file has to load, and every key the code names has to be in it.
|
|
func TestSummariesLoad(t *testing.T) {
|
|
s, err := LoadSummaries(rand.NewSource(1))
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
for _, key := range summaryKeys {
|
|
if got := s.Say(key, nil); got == "" {
|
|
t.Errorf("%s says nothing", key)
|
|
}
|
|
}
|
|
}
|
|
|
|
// A nil *Summaries is the unloadable-file case, and it must still speak. The
|
|
// habit sentences are the ones that matter here: falling back must not turn
|
|
// "I have not seen enough" into silence.
|
|
func TestNilSummariesAnswerFromTheFloor(t *testing.T) {
|
|
var s *Summaries
|
|
if got, want := s.Say(HabitOverallNone, nil), summaryFloor[HabitOverallNone]; got != want {
|
|
t.Errorf("got %q, want %q", got, want)
|
|
}
|
|
if got := s.Say(PlanDay, map[string]string{"date": "03.08.2026", "items": "x"}); !strings.Contains(got, "03.08.2026") {
|
|
t.Errorf("the floor dropped the date: %q", got)
|
|
}
|
|
}
|
|
|
|
// The empty cases claim she has not seen enough, never that he has no habits.
|
|
// Every variant has to hold that line, since the picker treats them as equals.
|
|
func TestHabitGapsSaySheHasNotSeenEnough(t *testing.T) {
|
|
s, err := LoadSummaries(rand.NewSource(1))
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
for _, key := range []string{HabitWeekdayNone, HabitWeekendNone, HabitOverallNone} {
|
|
for _, v := range s.d.file.Entries[key].Variants {
|
|
if !strings.Contains(v, "пока") && !strings.Contains(v, "ещё") {
|
|
t.Errorf("%s variant %q reads as a fact about him, not as a gap in her records", key, v)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
// One variant means fixed, in this file and in the four in internal/phraser.
|
|
// Nothing breaks on the flag being absent, but parallel entries disagreeing
|
|
// about it is how the file stops telling a reader which wording is load-bearing.
|
|
func TestEverySingleVariantEntryIsFixed(t *testing.T) {
|
|
s, err := LoadSummaries(rand.NewSource(1))
|
|
if err != nil {
|
|
t.Fatalf("load: %v", err)
|
|
}
|
|
if got := s.d.UnfixedSingles(); len(got) > 0 {
|
|
t.Errorf("single-variant entries not marked fixed: %v", got)
|
|
}
|
|
}
|