claude
33032b859a
The task asked to decide first whether this family should move at all. It
moves, but only half of it, and the half that stays put is the important one.
The prompt is already in acts_ru_v1.json. act_confirm and act_confirm_entity
went there with family 4, which is where they belong: the sentence he has to
hear before he says yes is an act line, and it loads with {name} required, so a
variant that dropped the capability cannot exist. Nothing about that needed
redoing.
What was left in cmd/mavend/confirm.go is the answers. Those are now
confirm_ru_v1.json: cancelled, the two routine answers, and the four
propose-gap lines. Every entry is fixed at one wording. He answered a question
about one specific thing, so variety buys nothing here and costs the property
that matters, which is that the same act reports the same outcome every time.
The three propose lines that name the verb have {name} required, for the same
reason the prompt does.
Two literals also stopped being duplicates. The confirmed tool run said
"готово." and "не получилось выполнить команду." word for word from the acts
family, so it now reports through ActDone and ActFail rather than keeping a
second copy to drift from.
Family 5 was the last one open. The persona scorer sweeps the new variants with
the other five, and the single-variant-means-fixed test now covers it.
76 lines
2.6 KiB
Go
76 lines
2.6 KiB
Go
package eval
|
|
|
|
import (
|
|
"math/rand"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/kami/maven/internal/phraser"
|
|
"github.com/kami/maven/internal/say"
|
|
)
|
|
|
|
// TestFallbackPersona scores every line in every hand-written family on the
|
|
// persona checks the nudges already pass. These lines are heard out loud and
|
|
// they live in a JSON file now, so a reworded variant that says "рад" or "вы"
|
|
// would otherwise reach him with nothing in between.
|
|
//
|
|
// Only the persona checks run. Mood and topic belong to a nudge, and these are
|
|
// not nudges.
|
|
func TestFallbackPersona(t *testing.T) {
|
|
fb, err := phraser.LoadFallbacks(rand.NewSource(20260804))
|
|
if err != nil {
|
|
t.Fatalf("LoadFallbacks: %v", err)
|
|
}
|
|
// No CheckHisGender. It reads a feminine verb near a second-person pronoun
|
|
// as addressing him as a woman, which is right for a nudge and wrong here:
|
|
// "не знаю — не нашла у тебя такой записи" is her own verb in her own
|
|
// sentence. CheckFeminine still holds her side of the rule.
|
|
persona := map[string]bool{
|
|
CheckLang: true, CheckFeminine: true,
|
|
CheckAddress: true, CheckCringe: true, CheckLength: true,
|
|
}
|
|
ack, err := phraser.LoadAcks(rand.NewSource(20260804))
|
|
if err != nil {
|
|
t.Fatalf("LoadAcks: %v", err)
|
|
}
|
|
qry, err := phraser.LoadQueries(rand.NewSource(20260804))
|
|
if err != nil {
|
|
t.Fatalf("LoadQueries: %v", err)
|
|
}
|
|
variants := append(fb.Variants(), ack.Variants()...)
|
|
variants = append(variants, qry.Variants()...)
|
|
act, err := phraser.LoadActs(rand.NewSource(20260804))
|
|
if err != nil {
|
|
t.Fatalf("LoadActs: %v", err)
|
|
}
|
|
variants = append(variants, act.Variants()...)
|
|
con, err := phraser.LoadConfirms(rand.NewSource(20260804))
|
|
if err != nil {
|
|
t.Fatalf("LoadConfirms: %v", err)
|
|
}
|
|
variants = append(variants, con.Variants()...)
|
|
sum, err := say.LoadSummaries(rand.NewSource(20260804))
|
|
if err != nil {
|
|
t.Fatalf("LoadSummaries: %v", err)
|
|
}
|
|
variants = append(variants, sum.Variants()...)
|
|
if len(variants) == 0 {
|
|
t.Fatal("no variants — the file loaded empty")
|
|
}
|
|
for _, v := range variants {
|
|
// The placeholders stand for his own words and carry no persona.
|
|
body := v
|
|
for _, ph := range []string{"{sources}", "{key}", "{value}", "{fn}", "{text}", "{when}", "{items}",
|
|
"{location}", "{temp}", "{condition}", "{tail}", "{out}", "{name}",
|
|
"{entity}", "{count}", "{word}",
|
|
"{date}", "{line}", "{n}", "{day}", "{sat}", "{sun}", "{span}", "{gloss}", "{time}"} {
|
|
body = strings.ReplaceAll(body, ph, "вода")
|
|
}
|
|
for _, r := range RunChecks(Case{}, body, "neutral") {
|
|
if persona[r.Name] && !r.Pass {
|
|
t.Errorf("%q fails %s: %s", v, r.Name, r.Detail)
|
|
}
|
|
}
|
|
}
|
|
}
|