claude
580959f856
"напомни к двум часам позвонить маме" now reads two o'clock. It read no time at all, so the reminder reached the daemon with an empty slot and she asked the open "Когда?" about an hour he had just said. The word that lost it was "часам", the dative plural of "час". Four sets in internal/router listed the hour noun and every one of them stopped at "часу". They are now one lexicon key, hour_units, read by all four through lexicon.HourUnits and lexicon.IsHourUnit. The minute noun had the same gap one word over and gets the same treatment in minute_units: "минутам" was missing everywhere "минут" and "минуты" were present. The slot_value_frame set no longer lists either noun and appends both, so there is one copy of each closed class rather than a copy per caller. Two more sites had to move for the sentence to parse. hourPrepositions knew "в", "во" and "на" and not "к", and the python dateparser rewrite knew the same three. Both now read the fifth preposition and the oblique forms of the hour that follow it. Fixture unchanged: classifier+hash 27/91 before and after, reach 18/30 before and after, no case moved in either direction. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
75 lines
2.7 KiB
Go
75 lines
2.7 KiB
Go
package router
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
"time"
|
|
)
|
|
|
|
// TestDativePluralHourIsAnHour — "напомни к двум часам позвонить маме" reached
|
|
// the daemon with no time at all and she asked the open "Когда?", while "к трём"
|
|
// one word over read fine (V-609). The word that lost it was "часам", the dative
|
|
// plural of "час", which four separate hour sets in this package left out.
|
|
func TestDativePluralHourIsAnHour(t *testing.T) {
|
|
const s = "напомни к двум часам позвонить маме"
|
|
if !MentionsTime(s) {
|
|
t.Errorf("MentionsTime(%q) = false; the sentence names two o'clock", s)
|
|
}
|
|
if !NamesAnHour(s) {
|
|
t.Errorf("NamesAnHour(%q) = false; the sentence names two o'clock", s)
|
|
}
|
|
if got, want := SpellOutDigits(s), "напомни к 2 часам позвонить маме"; got != want {
|
|
t.Errorf("SpellOutDigits(%q) = %q, want %q", s, got, want)
|
|
}
|
|
// The slot itself, which is what the daemon reads. It was empty, so
|
|
// whenGapOf named the hour missing and she asked "Когда?".
|
|
now := time.Date(2026, 8, 6, 3, 39, 0, 0, time.UTC)
|
|
ex := Extractor{Time: StubDateTimeParser{}}
|
|
got := ex.Extract(context.Background(), IntentReminder, s, now)
|
|
if !got.HasTime {
|
|
t.Fatalf("the hour was spoken, so the slot must be filled: %+v", got)
|
|
}
|
|
if h := got.Time.Hour(); h != 2 && h != 14 {
|
|
t.Errorf("fire time = %s, want two o'clock in one half of the day or the other", got.Time.Format("15:04"))
|
|
}
|
|
}
|
|
|
|
// TestHourUnitReachesEverySite — the four sets that read the hour noun now read
|
|
// one lexicon key, so a form added there is a form all four know. "часам" is the
|
|
// form that was missing from every one of them.
|
|
func TestHourUnitReachesEverySite(t *testing.T) {
|
|
for _, w := range []string{"час", "часа", "часов", "часу", "часам"} {
|
|
if !numeralContext[w] {
|
|
t.Errorf("numeralContext is missing %q", w)
|
|
}
|
|
if !hourMarkers[w] {
|
|
t.Errorf("hourMarkers is missing %q", w)
|
|
}
|
|
if !timeMarkers[w] {
|
|
t.Errorf("timeMarkers is missing %q", w)
|
|
}
|
|
if _, ok := unitToDuration(2, w); !ok {
|
|
t.Errorf("unitToDuration does not know %q", w)
|
|
}
|
|
}
|
|
}
|
|
|
|
// TestMinuteUnitHasTheSameForms — the same defect one noun over: "минутам" was
|
|
// missing everywhere "минут" and "минуты" were present.
|
|
func TestMinuteUnitHasTheSameForms(t *testing.T) {
|
|
for _, w := range []string{"минут", "минуты", "минуту", "минутам"} {
|
|
if !numeralContext[w] {
|
|
t.Errorf("numeralContext is missing %q", w)
|
|
}
|
|
if !hourMarkers[w] {
|
|
t.Errorf("hourMarkers is missing %q", w)
|
|
}
|
|
if !timeMarkers[w] {
|
|
t.Errorf("timeMarkers is missing %q", w)
|
|
}
|
|
if _, ok := unitToDuration(20, w); !ok {
|
|
t.Errorf("unitToDuration does not know %q", w)
|
|
}
|
|
}
|
|
}
|