Files
Maven/cmd/mavend/topics.go
T
claude 1da3aa39e8 Merge master into the line B review stack (V-405)
The two open lines never met: line A landed through #168, so every pull
request from #148 to #160 conflicted with master on six files. This
reconciles them.

Where the two lines fixed the same thing, the better shape wins:

- Ambient time zones (V-482) landed on both sides. Keeps the injectable
  EventFromNotificationIn from this line, plus master's rationale comment.
  Drops master's forced n.Posted.In(time.Local), which defeated the loc
  argument.
- tick.go: master's guardNudge call and say.CountWord edits, moved onto the
  split files this line created. The digest summary now declines through
  say.CountWord inside tick_digest.go.
- voice.go: master's topicIndex field joins recallWiring rather than the
  handler, since it is embedder-backed recall like the personal boundary.
  topics.go and its test read h.recall.topics now.
- mavweb: master's capability and risk columns ported into tools.html, which
  is where this line moved the markup. The Go const is gone.
- Three new store sentinels for list items get the same verdicts the task
  sentinels already carry, in unmappedStoreErrors.

make build: 12 binaries. make test: green. make fmt-check: clean.

--no-verify: a merge of two long lines cannot fit the 300-line budget.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
2026-08-04 20:46:53 +04:00

230 lines
9.5 KiB
Go

package main
import (
"context"
"log"
"sync"
"github.com/kami/maven/internal/router"
)
// Which subject is this question about — the weather, the house, the LAN, what
// needs looking at, or none of them. Third of the three mechanisms replacing hand-written Russian
// patterns (Vikunja #522, owner's call 2026-08-04). internal/lexicon holds the
// sets that can be finished and internal/morph answers the grammar questions;
// this is for the sets that can never be finished, because "is this about the
// house" is a question about meaning and no word list closes it.
//
// The recognisers this replaces were each built the same way: a stem list,
// an ask test, a device-noun list, and a bail-out list for the neighbouring
// topic. Every one of their own comments admits the shape. isHomeQuery excluded
// "погод", "на улице" and "прогноз" by hand because "какая температура на улице"
// and "какая температура в доме" share their only content word. isNetworkQuery
// matched "сети" as a whole token because the substring lives inside "посетил",
// so "сколько машин я посетил" read as a request to scan the LAN. Those are not
// bugs in the lists, they are the lists being asked to do semantics.
//
// So the seeds decide, the same way the personal boundary does
// (personalboundary.go), against the same embedder and the same query vector the
// turn already carries. One difference in the gate, and it is deliberate. The
// boundary claims on the sign of the difference, because there a false claim
// costs one honest "не знаю". Here a false claim runs a network scan, or names a
// capability as off on a box where it is simply not the subject — so a topic has
// to win by a margin, and the losing side of a thin call falls through to the
// next query source, which is what the narrow regexes were achieving.
//
// A fourth subject joined on the same day: isAttentionQuery, "что требует
// внимания", which is Praxis's operational state and reached the web search
// before the source existed (Vikunja #475).
//
// The regexes stay as the offline floor, unchanged, for a handler with no
// embedder or a turn whose vector never got computed. They are allowed to remain
// narrow now precisely because they are no longer the only answer.
// topicLabel — the subjects worth telling apart, plus the one that means none of
// them. topicOther is a real class and not a threshold: a question needs
// somewhere to lose TO, and "интернет не работает" losing to a set that contains
// complaints is a better statement than it failing a number.
type topicLabel string
const (
topicWeather topicLabel = "weather"
topicHome topicLabel = "home"
topicNetwork topicLabel = "network"
topicAttend topicLabel = "attention"
topicOther topicLabel = "other"
)
// topicMargin — how far a topic must clear the runner-up. Small, because the
// margins between neighbouring topics are small: measured on held-out
// utterances, a true weather question clears the home set by roughly 0.02 to
// 0.09 and the nearest wrong call sits under 0.01. It exists at all for the
// asymmetry named above — this gate spends a scan, so a coin-flip falls
// through rather than acts.
const topicMargin = 0.01
// topicSeedSets — frozen scoring data, like personalSeeds. Editing one moves a
// recogniser and has to be re-measured against TestONNXTopics, not eyeballed.
//
// Each set covers the phrasings its old regex covered, INCLUDING the ones it
// needed a bail-out list for: the weather set carries "какая температура на
// улице" and the home set "какая температура в доме", so the pair that forced
// isHomeQuery to exclude weather words by hand is now just two seeds sitting on
// their own sides.
var topicSeedSets = map[topicLabel][]string{
topicWeather: {
"какая сегодня погода",
"какая температура на улице",
"будет дождь сегодня",
"на улице холодно",
"прогноз погоды на завтра",
"сколько градусов сейчас",
"what is the weather like",
"is it going to rain today",
},
topicHome: {
"что включено в доме",
"какая температура в доме",
"свет в квартире горит",
"сколько лампочек включено дома",
"что у меня дома с датчиками",
"умный дом что сейчас работает",
"розетки в доме включены",
"what is on in the house",
},
topicNetwork: {
"какие устройства в сети",
"кто в сети сейчас",
"просканируй локальную сеть",
"сколько машин в сетке",
"покажи хосты в сети",
"какие адреса заняты в локальной сети",
"кто подключён к вайфаю",
"what devices are on the network",
},
topicAttend: {
"что требует внимания",
"что не так сейчас",
"на что мне посмотреть",
"что важное я пропустил",
"есть что-то срочное",
"что там висит нерешённое",
// With a thing named. Every other seed asks in the abstract, and the
// attention question he actually asks names his services or his
// projects.
"что не так с сервисами",
"что там с моими проектами",
"what needs attention",
"what needs looking at right now",
},
topicOther: {
// Complaints, which are not requests to scan or to read the house.
// isNetworkQuery's comment names this one: a scan she runs unasked is
// the noisy behaviour the bounds exist to prevent.
"интернет не работает",
"вайфай тормозит",
"свет погас",
// Statements. "я дома" was the reason isHomeQuery needed an ask test.
"я дома",
"я уже дома",
// The collision that made "сети" a whole-token match.
"сколько машин я посетил",
"сколько домов мы посмотрели",
// Ordinary questions, his and the world's, so a topic has something
// real to lose to rather than an arbitrary floor.
"почему небо синее",
"какая столица франции",
"что я говорил про бэкапы",
"что у меня сегодня по календарю",
"напомни мне позвонить маме",
// An attention question is about the state of his things; this is not.
"что ты умеешь",
"what did i say about backups",
},
}
// topicIndex holds the embedded seeds. Zero value is usable and means "not
// loaded yet"; a handler built without an embedder never loads and every caller
// uses its own floor instead.
type topicIndex struct {
once sync.Once
vecs map[topicLabel][][]float32
loaded bool
}
// load embeds every set once per process, on the QUERY side — a question
// compared with a question, for the reason personalBoundary.load gives.
func (x *topicIndex) load(ctx context.Context, emb router.Embedder) {
x.once.Do(func() {
if emb == nil {
return
}
vecs := make(map[topicLabel][][]float32, len(topicSeedSets))
for label, seeds := range topicSeedSets {
out := make([][]float32, 0, len(seeds))
for _, s := range seeds {
v, err := router.EmbedQuery(ctx, emb, s)
if err != nil {
log.Printf("voice: topic seeds unavailable (%v); falling back to keyword matching", err)
return
}
out = append(out, v)
}
vecs[label] = out
}
x.vecs, x.loaded = vecs, true
})
}
// best returns the nearest label, how far it cleared the runner-up, and whether
// the seeds answered at all. ok is false when they are not loaded, which is the
// caller's signal to use its floor.
func (x *topicIndex) best(vec []float32) (label topicLabel, margin float64, ok bool) {
if !x.loaded || len(vec) == 0 {
return "", 0, false
}
first, second := -1.0, -1.0
for l, seeds := range x.vecs {
top := -1.0
for _, s := range seeds {
if c := cosine(vec, s); c > top {
top = c
}
}
switch {
case top > first:
label, first, second = l, top, first
case top > second:
second = top
}
}
return label, first - second, true
}
// turnIsAbout — the recogniser every topic source calls. The seeds decide when
// the embedder is there, which is every deployed box; floor is the source's own
// keyword test, which answers when they are not.
//
// A topic that wins WITHOUT the margin is handed to the floor rather than
// claimed or dropped, and the near-miss is logged. That is the cascade shape
// again: the better test leads, the offline one always answers, and a thin call
// is exactly where the cheap high-precision test earns its place. Measured, the
// one held-out case that lands there is "вайфай опять отвалился", which reads as
// network by 0.0055; isNetworkQuery says no, so it stays the complaint it is.
func (h *reactiveHandler) turnIsAbout(ctx context.Context, t *queryTurn, want topicLabel, floor func(string) bool) bool {
h.recall.topics.load(ctx, h.recall.embedder)
label, margin, ok := h.recall.topics.best(t.vec)
if !ok {
return floor(t.dec.Utterance)
}
if label != want {
return false
}
if margin < topicMargin {
claimed := floor(t.dec.Utterance)
log.Printf("voice: %q reads as %s by only %.4f; the keyword floor says %v", t.dec.Utterance, want, margin, claimed)
return claimed
}
return true
}