docs(backlog): static-first reviewer shipped + QA plan; supersede §C A2

- §B §5 reviewer static-first infra → SHIPPED (pending live-QA) 365eb8a; add §F gate +
  docs/qa/QA-static-first-reviewer.md.
- §C A2 stage-level plan checkpointing → SUPERSEDED (verifyProduces + ManifestContainment
  + validation already reconcile execution vs the compiled plan); A3 consolidated under
  §B §6 calibration (build once, two consumers).
This commit is contained in:
2026-06-14 23:52:53 +04:00
parent 365eb8a279
commit 0696652d54
2 changed files with 97 additions and 9 deletions
+29 -9
View File
@@ -47,9 +47,15 @@ f8fd260) — those are RETRO candidates once live-QA'd. Remaining:
§3 analyst keystone (894969d), entity grounding (b050dc4), §2 write-manifest (4e5e4e5),
and §5 reviewer prompt/needs wiring (3467826) are shipped — RETRO candidates. Remaining:
- [ ] **§5 reviewer static-first INFRA** — run compiler/detekt/formatters as a pipeline
step and *mechanically exclude their findings* from reviewer context. Needs a
static-findings event representation. (Prompt half is done; infra half is unbuilt.)
- [~] **§5 reviewer static-first INFRA** — **SHIPPED (pending live-QA)** `365eb8a`. A stage declares
`static_analysis = [commands]`; after it produces its artifact a deterministic harness gate
(`runStaticAnalysis`) runs each command (compiler/detekt/formatters) in the workspace root,
records a `StaticAnalysisCompletedEvent` (invariant #9; recorded live, folded on replay), and on
any non-clean command fails the stage retryably with the output fed back verbatim (§2). Only
static-clean output reaches the reviewer, so its context excludes static findings *mechanically*
(resolved upstream) — no output-parsing, no shared-findings schema needed. `ProcessStaticAnalysis-
Runner` is the injected adapter (nullable seam; null → logged no-op). Prompt half was `3467826`.
QA gate in §F → `docs/qa/QA-static-first-reviewer.md`.
- [ ] **§6 `CritiqueFinding` schema in code** — only test expectations exist today; no
structured type. Shared by plan critic + code reviewer.
- [ ] **§6 `CriticCalibrationProjection`** (keyed by modelHash, role) — needs runtime
@@ -66,7 +72,8 @@ and §5 reviewer prompt/needs wiring (3467826) are shipped — RETRO candidates.
## C. Plan pipeline addenda — `docs/plans/2026-06-13-plan-pipeline-addenda.md`
A1 is shipped (bcc59d2) — RETRO candidate once live-QA'd. A2/A3 remain.
A1 is shipped (bcc59d2) — RETRO candidate once live-QA'd. A2 is **superseded** (see below);
A3 is the same item as §B §6 calibration (tracked there).
- [~] **A1 brief echo-back gate****SHIPPED (pending live-QA)** `bcc59d2`. New `brief_echo` stage
before the planner in `role_pipeline`: the model restates the analyst brief as a structured
@@ -75,11 +82,19 @@ A1 is shipped (bcc59d2) — RETRO candidate once live-QA'd. A2/A3 remain.
`BriefEchoMismatchEvent` + retryable stage failure, so a misread brief never reaches plan
generation. Pure replay-safe diff (`BriefEchoDiff`); symbols recorded but non-blocking in v1.
QA gate in §F → `docs/qa/QA-brief-echo-gate.md`. `freestyle_planning` wiring is a follow-up.
- [ ] **A2 stage-level plan checkpointing**reconciliation compares produced artifacts vs
the confirmed plan's produces-slots per stage; `StageCheckpointPassedEvent` /
`StageCheckpointFailedEvent` (halt + surface).
- [ ] **A3 critique calibration tracking**`CritiqueOutcomeCorrelatedEvent` +
`CriticCalibrationProjection` (= role-reliability §6; build once, two consumers).
- 🚫 **A2 stage-level plan checkpointing****SUPERSEDED, do not build.** The spec predates the
machinery that now carries this weight. In the current design the "confirmed plan" is the
freestyle `execution_plan``ExecutionPlanCompiler``WorkflowGraph`, and per-stage
reconciliation against the plan's produces-slots *already happens* in phase-2 execution:
`verifyProduces` checks every `stage.produces` slot (sourced from the plan JSON) against
`ArtifactCreatedEvent`s and fails retryably → surfaces on exhaustion; `ManifestContainmentRule`
blocks out-of-plan writes; the validation pipeline checks content vs kind schema. The only net-new
bits A2 adds are a positive `StageCheckpointPassedEvent` + terminal-vs-retryable halt — and the
sole consumer of the former is A3 calibration, which is itself ordering-blocked. Revisit only if a
real consumer for a positive per-stage checkpoint event appears. (Assessed 2026-06-14.)
- [ ] **A3 critique calibration tracking****= §B §6 `CriticCalibrationProjection`** (build once, two
consumers). Tracked under §B §6; needs runtime critique/outcome history first (spec ordering #5).
Not duplicated here.
## D. Research workflow spec — `docs/plans/2026-06-13-research-workflow-spec.md`
@@ -143,6 +158,11 @@ These are SHIPPED in code but prompt-/server-/network-dependent and not yet live
(schema/prompt/artifacts block). Plan: `docs/qa/QA-brief-echo-gate.md` (faithful echo→planner runs,
dropped requirement→`BriefEchoMismatchEvent`+retryable fail, hallucinated file flagged, symbols
non-blocking, replay recomputes identically, non-opted pipeline is a no-op).
- [ ] **Static-first reviewer gate live-QA**`365eb8a`; needs a real implementer-capable model + a
workspace whose configured `static_analysis` commands can be made to pass/fail on demand (and the
gate uncommented in the copied `role_pipeline.toml`). Plan: `docs/qa/QA-static-first-reviewer.md`
(clean→reviewer runs, non-clean→`StaticAnalysisCompleted`+retryable fail w/ output fed back,
gate-OFF absence check, no-runner no-op WARN, replay reads recorded findings without re-running).
- [ ] **TUI kernel-steering + AMD gauge fresh live-QA** — approve+note actually revising the
*same* stage's output; AMD VRAM/RAM gauge on the real box.
- [ ] **Unit-tested-only fixes, not live-verified:** `1a7eb05` (verdict-edge rejection),