docs: reconcile BACKLOG→RETRO for static_check stage + critique producer (e46777e)

Per the hygiene rule: the §B-§5 static_check stage seam + emitter and the §B-§6/A3
critique-outcome producer are built and unit-verified, so move them out of the live
"missing" list. Both narrowed to their remaining live-QA-gated *activations* (a sandboxed
production CommandRunner for §B-§5; model-emitted CritiqueFindingsRecordedEvents for §6),
with a dated RETRO entry + commit map. Updated QA-reviewer-static-first (the producing
stage now exists — check 4 reframed from "blocked on unbuilt seam" to an activation step)
and its README index line.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
2026-06-22 21:52:59 +00:00
parent e46777e29f
commit 33baaed903
4 changed files with 40 additions and 18 deletions
+17 -12
View File
@@ -36,13 +36,13 @@ quick commit map:
- **C-A2** stage-level plan checkpointing — `1a1b5cc`
- **B §4** architect contradiction-check (display-only) — `eae0a0c`, **activated** `4e08510` (server subscribes to the architect `design` artifact → emits the flag)
- **D** dedicated `SourceFetched`/`LowQualityExtraction` events — `b098d87`; dynamic per-session egress allowlist — `027ff1f`, **activated** `ab7e4be` (session state threaded into assessment input); batch source-list fetch-approval — `4b0024f`
- **B §5** reviewer static-first (runner + event + context-exclusion, live-wired) — `447fc7a` *(follow-up: a stage that emits `StaticFindingsRecordedEvent`)*
- **B §5** reviewer static-first (runner + event + context-exclusion, live-wired) — `447fc7a`; the deterministic `static_check` stage seam + emitter — `e46777e` *(remaining: production sandboxed-runner activation, live-QA)*
- **G** narration-lane lag — `eff8f8d`
- **E** tui-go go.mod directive fix — `1e6699a`; markdown rendering — `da72ee5`; session list / resume view — `1f7a5d9`; per-event render-matrix golden tests — `2a99e15`; approval ergonomics (queue + tier-gated confirm) — `d5afcd3`
- **B §2** plan-derived diff manifest — `641051b`
**Remaining (deeper / lower-verifiability):** H freestyle follow-ups (graph re-route, child-session runner — deep session-lifecycle, want live testing); the dormant model-dependent activations (A1 planner prompt, A3 producer, B§5 static_check stage — live-QA-gated, deprioritized to last). §E plan-comparison view is BLOCKED (no plan-candidate event; see §E). All cleanly unit-verifiable deterministic tracks are now landed.
**Remaining (deeper / lower-verifiability):** H freestyle follow-ups (graph re-route, child-session runner — deep session-lifecycle, want live testing); the dormant *activations* whose deterministic halves are now built (A1 planner prompt; A3/§6 critique calibration — correlator + producer landed `e46777e`, awaiting model-emitted findings; B§5 static_check — seam + emitter landed `e46777e`, awaiting a sandboxed production runner — both live-QA-gated). §E plan-comparison view is BLOCKED (no plan-candidate event; see §E). All cleanly unit-verifiable deterministic tracks are now landed.
**Still blocked in this sandbox:** F live-QA gates + D §6 web approval client (need local model / SearXNG / GPU).
**📋 Live-QA plans drafted** (`docs/qa/QA-*.md`, index `docs/qa/README.md`, env `docs/qa/ENV.md` + `scripts/qa/`):
@@ -71,13 +71,17 @@ health probes shipped (`266bbf0`, `64a90e7`) → see RETRO. Remaining:
`CritiqueFinding` type + calibration projection (`f783eed`), and §4 architect
contradiction-check (`eae0a0c`/`4e08510`) are shipped — see RETRO. Remaining:
- [ ] **§5 static_check stage (emitter)** — the runner/event/filter are built and live-wired
(`447fc7a`); what's missing is a deterministic workflow stage that actually runs
compiler/ktlint/detekt and emits `StaticFindingsRecordedEvent` (`// TODO(wiring)` in
`StaticAnalysisRunner.kt`). Needs an event-emitting stage-type seam.
- [ ] **§6 `CritiqueOutcomeCorrelatedEvent` producer** (= pipeline-addenda A3) — the
`CritiqueFinding` type + `CriticCalibrationProjection` exist (`f783eed`) but nothing feeds
them; needs a reviewer-loop producer that records finding outcomes. Build once, two consumers.
- [ ] **§5 static_check stage — production runner activation only** (seam + emitter built
`e46777e`, see RETRO). The deterministic stage-type seam, `StaticCheckStageExecutor`, the
TOML fields, and the role_pipeline stage now exist; the stage is a **no-op until** a
sandboxed, workspace-scoped `CommandRunner` is wired into the orchestrator AND `static_argv`
is set. That activation (ShellTool-style ProcessBuilder + session cwd + timeout) is
live-QA-gated — left for a focused pass with a real workspace.
- [ ] **§6 reviewer must emit structured findings** (correlator + producer built `e46777e`, see
RETRO). `CritiqueOutcomeCorrelator` + the `CritiqueFindingsRecordedEvent` → outcome →
calibration chain is built and unit-verified; it's **dormant until** the reviewer/plan-critic
actually emit `CritiqueFindingsRecordedEvent`s (a `review_report` findings array + prompt
change). That LLM-side emission is model-dependent → live-QA.
- [ ] **§3 symbol grounding** — deferred; needs a real symbol index (file-path grounding done).
- [ ] **§2 dynamic plan-derived diff manifest** — allowed files from the `impl_plan`
artifact. Future refinement; static per-stage `writes = [globs]` form is shipped.
@@ -94,9 +98,10 @@ checkpointing (`1a1b5cc`) → see RETRO. Remaining:
- [ ] **A1 activation** (model-dependent → live-QA) — `planner.md` must emit a `brief_echo`
block and `role_pipeline.toml` must set `briefEcho="true"` / `briefEchoSource` for the gate
to fire live. The gate (`BriefEchoMismatchEvent` + comparator/extractor) is already built.
- [ ] **A3 critique calibration tracking** — the `CriticCalibrationProjection` exists
(`f783eed`); only the `CritiqueOutcomeCorrelatedEvent` producer is missing. Tracked as the
§6 producer follow-up above (build once, two consumers).
- [ ] **A3 critique calibration tracking** — the projection (`f783eed`) AND the producer
(`CritiqueOutcomeCorrelator` + loop-resolution hook, `e46777e`) are now built. Remaining is
only the model-gated reviewer-side emission of `CritiqueFindingsRecordedEvent`s — tracked as
the narrowed §6 item above.
## D. Research workflow spec — `docs/plans/2026-06-13-research-workflow-spec.md`