fix(kernel,talkie,context): three instruction-corruption fixes from the 2026-08-26 context audit

Each of the three lost or rewrote an instruction before the model saw it.

1. Orphan corrective nudges. pushBack() and the final tools-disabled emission
   built their nudge as a toolResult with a fresh sourceId, so it had no matching
   assistantToolCall and reconcileToolPairs() deleted it — the orchestrator
   believed it had corrected the model while the correction never reached the
   prompt. Affected the invalid-emit_artifact, premature-stage_complete,
   missing-write, read-loop, rejection-loop and final-JSON nudges. They are now
   USER turns (sourceType orchestratorCorrection, REQUIRED bucket, STRUCTURED in
   ContextClassifier so pruning cannot shred them), appended last so the builder's
   positional ordinal puts them at the end of the transcript. A superseded nudge
   is dropped rather than stacking stale demands.

2. Steering laundered through the router. The SteeringNoteAddedEvent carried the
   router model's paraphrase of the operator's message, not the message —
   negations, filenames, constraints and priority could change before the
   orchestrator saw them. It now carries the raw input; the router turn is still
   produced and shown as conversational acknowledgement, it is just not the
   mandate. Resolves the ponytail: note at TalkieFacade.kt:220.

3. Journal compaction erased its own history. compactIfNeeded() summarized only
   state.records while the reducer overwrote summaryArtifactId and dropped covered
   records, so the second compaction lost everything the first had preserved — and
   a low-salience-only batch replaced it with the "(no high-salience decisions)"
   fallback. Compaction is cumulative now, and a blank or fallback-only rewrite
   never replaces real history.

Tests: rendered-prompt regression for (1) — verified to fail against the old
toolResult shape — updated steering expectations for (2), two cumulative-compaction
tests for (3). Full build green, 1831 tests, 0 failures.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
2026-08-27 01:33:16 +04:00
parent d892587420
commit 519290368f
7 changed files with 180 additions and 31 deletions
@@ -35,8 +35,13 @@ class ContextClassifier {
// shredded the JSON to a bare id + protected path, giving the model amnesia about what it
// had already done → it re-issued the same call and looped. Structured = format-compress
// ok, never pruned.
// "orchestratorCorrection" is an in-loop corrective USER turn authored by the
// orchestrator (invalid emit_artifact, premature stage_complete, read loop, missing write).
// Pruning it as freeform prose can shred the tool name or the negation that makes it
// actionable, which leaves the model with a vague complaint instead of an instruction.
val STRUCTURED_SOURCES = setOf(
"toolLog", "artifact", "config", "structured", "steeringNote", "assistantToolCall",
"orchestratorCorrection",
)
}
}