kami/correx
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(build): resolve three failing tests across integration and tui modules

Browse Source 
SessionOrchestratorIntegrationTest: wire approvalRepository into
OrchestratorRepositories constructor which gained the field in the kernel
refactor. TambouiKeyMapperTest: correct ctrl-h to alt-h — the mapper has
always placed ToggleApprovalOverlay under the Alt branch, not Ctrl.
SessionOrchestrator.emit: replace substring(0,7) with take(7) to avoid
StringIndexOutOfBoundsException when session IDs are shorter than 7 chars.
This commit is contained in:
kami
2026-05-24 23:11:17 +04:00
parent 14141f2f72
commit 850c6df743
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/tui/src/test/kotlin/com/correx/apps/tui/input/TambouiKeyMapperTest.kt
+2 -2
View File
@@ -60,8 +60,8 @@ class TambouiKeyMapperTest {
} }
@Test @Test
fun `ctrl-h maps to ToggleApprovalOverlay`() { fun `alt-h maps to ToggleApprovalOverlay`() {
assertEquals(KeyEvent.ToggleApprovalOverlay, mapKey(TambouiKeyEvent(KeyCode.CHAR, KeyModifiers.CTRL, 'h'.code))) assertEquals(KeyEvent.ToggleApprovalOverlay, mapKey(TambouiKeyEvent(KeyCode.CHAR, KeyModifiers.ALT, 'h'.code)))
} }
@Test @Test
core/kernel/src/main/kotlin/com/correx/core/kernel/orchestration/SessionOrchestrator.kt
+1 -1
View File
@@ -646,7 +646,7 @@ abstract class SessionOrchestrator(
// --- event emission --- // --- event emission ---
internal suspend fun emit(sessionId: SessionId, payload: EventPayload) { internal suspend fun emit(sessionId: SessionId, payload: EventPayload) {
log.debug("[session {}] emitting event, payload: {}", sessionId.value.substring(0, 7), payload) log.debug("[session {}] emitting event, payload: {}", sessionId.value.take(7), payload)
eventStore.append( eventStore.append(
NewEvent( NewEvent(
metadata = EventMetadata( metadata = EventMetadata(
testing/integration/src/test/kotlin/SessionOrchestratorIntegrationTest.kt
+8
View File
@@ -1,5 +1,8 @@
import com.correx.core.approvals.ApprovalOutcome import com.correx.core.approvals.ApprovalOutcome
import com.correx.core.approvals.ApprovalProjector
import com.correx.core.approvals.ApprovalStatus import com.correx.core.approvals.ApprovalStatus
import com.correx.core.approvals.DefaultApprovalReducer
import com.correx.core.approvals.DefaultApprovalRepository
import com.correx.core.approvals.Tier import com.correx.core.approvals.Tier
import com.correx.core.approvals.domain.DefaultApprovalEngine import com.correx.core.approvals.domain.DefaultApprovalEngine
import com.correx.core.approvals.model.ApprovalContext import com.correx.core.approvals.model.ApprovalContext
@@ -87,12 +90,17 @@ class SessionOrchestratorIntegrationTest {
private val riskAssessor = DefaultRiskAssessor() private val riskAssessor = DefaultRiskAssessor()
private val artifactStore = NoopArtifactStore() private val artifactStore = NoopArtifactStore()
private val approvalRepository = DefaultApprovalRepository(
DefaultEventReplayer(eventStore, ApprovalProjector(DefaultApprovalReducer())),
)
private val repositories = OrchestratorRepositories( private val repositories = OrchestratorRepositories(
eventStore = eventStore, eventStore = eventStore,
inferenceRepository = inferenceRepository, inferenceRepository = inferenceRepository,
orchestrationRepository = orchestrationRepository, orchestrationRepository = orchestrationRepository,
sessionRepository = sessionRepository, sessionRepository = sessionRepository,
artifactRepository = LiveArtifactRepository(eventStore, DefaultArtifactReducer()), artifactRepository = LiveArtifactRepository(eventStore, DefaultArtifactReducer()),
approvalRepository = approvalRepository,
) )
private val engines = OrchestratorEngines( private val engines = OrchestratorEngines(