feat(workflow): sample review_report schema + implementer↔reviewer loop

2026-06-04 00:56:50 +04:00
parent fac6a29178
commit 8d67f5b03e
4 changed files with 173 additions and 0 deletions
@@ -0,0 +1,96 @@
+package com.correx.infrastructure.workflow
+
+import com.correx.core.artifacts.kind.ConfigArtifactKind
+import com.correx.core.artifacts.kind.DefaultArtifactKindRegistry
+import com.correx.core.artifacts.kind.JsonSchema
+import com.correx.core.artifacts.kind.JsonSchemaProperty
+import com.correx.core.events.types.StageId
+import com.correx.core.transitions.conditions.ArtifactFieldEquals
+import com.correx.core.transitions.conditions.FieldOperator
+import org.junit.jupiter.api.Test
+import java.nio.file.Files
+import kotlin.io.path.writeText
+import kotlin.test.assertEquals
+import kotlin.test.assertTrue
+
+class ReviewLoopWorkflowTest {
+
+    private val registry = DefaultArtifactKindRegistry().apply {
+        register(
+            ConfigArtifactKind(
+                id = "review_report",
+                schema = JsonSchema(
+                    type = "object",
+                    properties = mapOf("verdict" to JsonSchemaProperty(type = "string")),
+                    required = listOf("verdict"),
+                    additionalProperties = true,
+                ),
+                llmEmitted = true,
+            ),
+        )
+    }
+    private val loader = TomlWorkflowLoader(registry)
+
+    private val toml = """
+        id = "review_loop"
+        start = "implement"
+
+        [[stages]]
+        id = "implement"
+        prompt = "prompts/implement.md"
+        produces = [{ name = "patch", kind = "file_written" }]
+        allowed_tools = ["file_write"]
+        max_retries = 3
+
+        [[stages]]
+        id = "review"
+        prompt = "prompts/review.md"
+        needs = ["patch"]
+        produces = [{ name = "review_report", kind = "review_report" }]
+        max_retries = 3
+
+        [[transitions]]
+        id = "implement-to-review"
+        from = "implement"
+        to = "review"
+        condition_type = "artifact_validated"
+        condition_artifact_id = "patch"
+
+        [[transitions]]
+        id = "review-approved"
+        from = "review"
+        to = "done"
+        condition_type = "artifact_field_equals"
+        condition_artifact_id = "review_report"
+        condition_field = "verdict"
+        condition_value = "approved"
+        condition_operator = "eq"
+
+        [[transitions]]
+        id = "review-changes-requested"
+        from = "review"
+        to = "implement"
+        condition_type = "artifact_field_equals"
+        condition_artifact_id = "review_report"
+        condition_field = "verdict"
+        condition_value = "approved"
+        condition_operator = "neq"
+    """.trimIndent()
+
+    @Test
+    fun `review loop parses with verdict-gated edges`() {
+        val path = Files.createTempFile("review_loop", ".toml").also { it.writeText(toml) }
+        val graph = loader.load(path)
+
+        val review = graph.stages[StageId("review")]!!
+        assertTrue(review.produces.any { it.name.value == "review_report" && it.kind.llmEmitted })
+
+        val approved = graph.transitions.first { it.to == StageId("done") }.condition as ArtifactFieldEquals
+        assertEquals("verdict", approved.field)
+        assertEquals("approved", approved.value)
+        assertEquals(FieldOperator.EQ, approved.operator)
+
+        val changes = graph.transitions.first { it.to == StageId("implement") }.condition as ArtifactFieldEquals
+        assertEquals(FieldOperator.NEQ, changes.operator)
+    }
+}