refactor(detekt): extract magic-number constants, wrap long lines, drop legit suppressions

Mechanical detekt cleanup across apps/core/infrastructure (behavior-preserving):
- MagicNumber 62->10: named constants + removed 'legit' MagicNumber suppressions
  (Tier level from ordinal, ReplayInferenceProvider CHARS_PER_TOKEN, ConfigLoader
  DEFAULT_* consts, capability scores, HTTP ranges, column widths, etc.)
- MaxLineLength cut to ~0 in production modules (line wraps, no logic change)
- Dropped one dead parameter (ConfigLoader.parseArray lineNum)

Structural findings (ReturnCount/LongMethod/Complexity/LargeClass) left for a
deliberate decomposition pass. Full build + detekt gate green.
This commit is contained in:
2026-07-12 23:12:28 +04:00
parent 135a34eb2f
commit aee2e67c66
70 changed files with 1034 additions and 236 deletions
@@ -81,12 +81,14 @@ class FileSystemContractEvaluator : ContractAssertionEvaluator {
private fun scriptDefined(path: Path, exists: Boolean, name: String): ContractAssertionVerdict {
val scripts = jsonObj(path, exists)?.get("scripts")?.let { runCatching { it.jsonObject }.getOrNull() }
?: return verdict(false, "no scripts block")
return verdict(scripts.containsKey(name), if (scripts.containsKey(name)) "script '$name' defined" else "missing script '$name'")
val hasScript = scripts.containsKey(name)
return verdict(hasScript, if (hasScript) "script '$name' defined" else "missing script '$name'")
}
private fun contains(path: Path, exists: Boolean, pattern: String): ContractAssertionVerdict {
val text = readOrNull(path, exists) ?: return verdict(false, "file does not exist")
return verdict(text.contains(pattern), if (text.contains(pattern)) "contains '$pattern'" else "missing '$pattern'")
val hasPattern = text.contains(pattern)
return verdict(hasPattern, if (hasPattern) "contains '$pattern'" else "missing '$pattern'")
}
private fun textMatch(path: Path, exists: Boolean, needle: String, failMsg: String): ContractAssertionVerdict {
@@ -158,7 +158,9 @@ class ReplayOrchestrator(
session: Session,
): ReplayStepResult {
log.debug("[Orchestrator] executeStage session=${ctx.sessionId.value} stage=${stageId.value}")
return when (val result = executeStage(ctx.sessionId, stageId, ctx.graph, session, ctx.config, effectivesFor(ctx.config))) {
val result =
executeStage(ctx.sessionId, stageId, ctx.graph, session, ctx.config, effectivesFor(ctx.config))
return when (result) {
is StageExecutionResult.Success -> ReplayStepResult.Continue(
ctx.copy(stageCount = ctx.stageCount + 1),
)
@@ -20,13 +20,17 @@ class ReplayInferenceProvider(
override val id: ProviderId = ProviderId("replay-provider")
@Suppress("MagicNumber")
private companion object {
/** Rough char→token ratio for the replay tokenizer (no real BPE at replay time). */
const val CHARS_PER_TOKEN = 4
}
override val tokenizer: Tokenizer = object : Tokenizer {
override suspend fun tokenize(text: String): List<Token> =
List(text.chunked(4).size) { i -> Token(i) } // 1 token ≈ 4 chars
List(text.chunked(CHARS_PER_TOKEN).size) { i -> Token(i) }
override suspend fun countTokens(text: String): Int =
(text.length + 3) / 4
(text.length + CHARS_PER_TOKEN - 1) / CHARS_PER_TOKEN
}
override suspend fun infer(request: InferenceRequest): InferenceResponse {
@@ -6,7 +6,8 @@ import org.junit.jupiter.api.Test
class ArtifactPolicyDecisionTest {
private fun decideFresh(f: ArtifactFailure) = decide(f, attemptsSoFar = 0, maxAttempts = Int.MAX_VALUE, hasApprover = false)
private fun decideFresh(f: ArtifactFailure) =
decide(f, attemptsSoFar = 0, maxAttempts = Int.MAX_VALUE, hasApprover = false)
@Test
fun `unsafe always aborts, even with budget and approver`() {
@@ -51,7 +51,8 @@ class JournalCompactionServiceTest {
}
@Test
fun `emits JournalCompactedEvent with correct coversThroughSequence and lowSalienceOmittedCount`(): Unit = runBlocking {
fun `emits JournalCompactedEvent with correct coversThroughSequence and lowSalienceOmittedCount`():
Unit = runBlocking {
val svc = JournalCompactionService(fakeArtifactStore(), { "summary" }, tokenThreshold = { 100 })
val state = stateWithRecords(
makeRecord(1, DecisionKind.INTENT), // HIGH