refactor(detekt): extract magic-number constants, wrap long lines, drop legit suppressions

Mechanical detekt cleanup across apps/core/infrastructure (behavior-preserving):
- MagicNumber 62->10: named constants + removed 'legit' MagicNumber suppressions
  (Tier level from ordinal, ReplayInferenceProvider CHARS_PER_TOKEN, ConfigLoader
  DEFAULT_* consts, capability scores, HTTP ranges, column widths, etc.)
- MaxLineLength cut to ~0 in production modules (line wraps, no logic change)
- Dropped one dead parameter (ConfigLoader.parseArray lineNum)

Structural findings (ReturnCount/LongMethod/Complexity/LargeClass) left for a
deliberate decomposition pass. Full build + detekt gate green.
This commit is contained in:
2026-07-12 23:12:28 +04:00
parent 135a34eb2f
commit aee2e67c66
70 changed files with 1034 additions and 236 deletions
@@ -43,7 +43,8 @@ class ManifestContainmentRule : ToolCallRule {
for (raw in candidatePathStrings(input.paramRoles, input.request.parameters)) {
val candidate = Path.of(raw)
val resolvedInput = if (candidate.isAbsolute) candidate else input.workspace.workspaceRoot.resolve(candidate)
val resolvedInput =
if (candidate.isAbsolute) candidate else input.workspace.workspaceRoot.resolve(candidate)
val resolvedReal = input.probe.resolveReal(resolvedInput)
val inWorkspace = resolvedReal.startsWith(workspaceReal)
val relative = if (inWorkspace) workspaceReal.relativize(resolvedReal).toString() else raw
@@ -35,7 +35,8 @@ class PathContainmentRule : ToolCallRule {
for (raw in candidatePathStrings(input.paramRoles, input.request.parameters)) {
val candidate = Path.of(raw)
val resolvedInput = if (candidate.isAbsolute) candidate else input.workspace.workspaceRoot.resolve(candidate)
val resolvedInput =
if (candidate.isAbsolute) candidate else input.workspace.workspaceRoot.resolve(candidate)
val resolvedReal = input.probe.resolveReal(resolvedInput)
val exists = input.probe.exists(resolvedInput)
val privileged = privilegedReal.any { resolvedReal.startsWith(it) }
@@ -26,7 +26,13 @@ class ReferenceExistsRuleTest {
private fun abs(p: String): Path = Path.of(p).toAbsolutePath().normalize()
private fun input(pathArg: String, probe: WorldProbe) = ToolCallAssessmentInput(
request = ToolRequest(ToolInvocationId("i"), SessionId("s"), StageId("st"), "file_read", mapOf("path" to pathArg)),
request = ToolRequest(
ToolInvocationId("i"),
SessionId("s"),
StageId("st"),
"file_read",
mapOf("path" to pathArg),
),
capabilities = setOf(ToolCapability.FILE_READ),
workspace = WorkspacePolicy(workspace, emptyList()),
probe = probe,
@@ -27,7 +27,13 @@ class StaleWriteRuleTest {
private fun abs(p: String): Path = Path.of(p).toAbsolutePath().normalize()
private fun input(onDisk: String, session: SessionContext) = ToolCallAssessmentInput(
request = ToolRequest(ToolInvocationId("i"), SessionId("s"), StageId("st"), "file_edit", mapOf("path" to target)),
request = ToolRequest(
ToolInvocationId("i"),
SessionId("s"),
StageId("st"),
"file_edit",
mapOf("path" to target),
),
capabilities = setOf(ToolCapability.FILE_WRITE),
workspace = WorkspacePolicy(workspace, emptyList()),
probe = FakeProbe(mapOf(abs(target) to onDisk)),
@@ -23,7 +23,13 @@ class WriteScopeRuleTest {
}
private fun input(pathArg: String, active: ActiveTask?) = ToolCallAssessmentInput(
request = ToolRequest(ToolInvocationId("i"), SessionId("s"), StageId("st"), "file_write", mapOf("path" to pathArg)),
request = ToolRequest(
ToolInvocationId("i"),
SessionId("s"),
StageId("st"),
"file_write",
mapOf("path" to pathArg),
),
capabilities = setOf(ToolCapability.FILE_WRITE),
workspace = WorkspacePolicy(workspace, emptyList()),
probe = FakeProbe(),
@@ -34,7 +40,10 @@ class WriteScopeRuleTest {
@Test
fun `no active task means nothing to enforce`() {
assertEquals(RiskAction.PROCEED, rule.assess(input("/work/project/core/billing/X.kt", active = null)).disposition)
assertEquals(
RiskAction.PROCEED,
rule.assess(input("/work/project/core/billing/X.kt", active = null)).disposition,
)
}
@Test