refactor(detekt): extract magic-number constants, wrap long lines, drop legit suppressions

Mechanical detekt cleanup across apps/core/infrastructure (behavior-preserving):
- MagicNumber 62->10: named constants + removed 'legit' MagicNumber suppressions
  (Tier level from ordinal, ReplayInferenceProvider CHARS_PER_TOKEN, ConfigLoader
  DEFAULT_* consts, capability scores, HTTP ranges, column widths, etc.)
- MaxLineLength cut to ~0 in production modules (line wraps, no logic change)
- Dropped one dead parameter (ConfigLoader.parseArray lineNum)

Structural findings (ReturnCount/LongMethod/Complexity/LargeClass) left for a
deliberate decomposition pass. Full build + detekt gate green.
This commit is contained in:
2026-07-12 23:12:28 +04:00
parent 135a34eb2f
commit aee2e67c66
70 changed files with 1034 additions and 236 deletions
@@ -20,7 +20,10 @@ class ArtifactExtractionPipelineTest {
)
private fun resolved(raw: String) =
assertInstanceOf(ArtifactExtractionPipeline.ExtractionResult.Resolved::class.java, pipeline.run(raw, fileWritten))
assertInstanceOf(
ArtifactExtractionPipeline.ExtractionResult.Resolved::class.java,
pipeline.run(raw, fileWritten),
)
@Test
fun `clean json passes through`() {
@@ -45,7 +45,10 @@ class JsonSchemaValidatorTest {
@Test
fun `unknown property is allowed when additionalProperties is true`() {
val open = schema.copy(additionalProperties = true)
val result = JsonSchemaValidator.validate(open, Json.parseToJsonElement("""{"summary":"ok","score":3,"extra":1}"""))
val result = JsonSchemaValidator.validate(
open,
Json.parseToJsonElement("""{"summary":"ok","score":3,"extra":1}"""),
)
assertTrue(result.isEmpty())
}