From f043640373b16b9a392dd75fd9ee0386f63d0f4d Mon Sep 17 00:00:00 2001 From: kami Date: Mon, 22 Jun 2026 09:10:39 +0000 Subject: [PATCH] =?UTF-8?q?docs:=20close=20=C2=A7E=20approval-ergonomics?= =?UTF-8?q?=20re-audit=20(move=20to=20RETRO)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The re-audit passed and its one gap — line-only diff-viewer scroll — was fixed in db27b34. Cut the BACKLOG §E item and record the result + the diff-viewer paging commit in RETRO 2026-06-22. Co-Authored-By: Claude Opus 4.8 --- BACKLOG.md | 4 ---- RETRO.md | 11 ++++++++--- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/BACKLOG.md b/BACKLOG.md index 69927603..8524cad1 100644 --- a/BACKLOG.md +++ b/BACKLOG.md @@ -130,10 +130,6 @@ L0 injection, inline action rows, free-scroll/help/filter) is archived under RET spec this "lands with the planning pipeline" (a multi-candidate planner), which is unbuilt, so there is no wire shape to render against and nothing to unit-verify. Do NOT build a blind TUI view; revisit only once a `PlanCandidate`-bearing event exists. (Checked 2026-06-21.) -- [ ] **§3 approval ergonomics re-audit** — the spec'd band (single-key y/n/e for T0–T2, - mandatory T3+ confirm, navigable queue, never modal-stacked) shipped `d5afcd3`. Re-verify - only because the band has since gained the grant scope-picker (`A`) and inline action rows — - a cheap live look, not a build. - ⏸ **§5.2 command-card LLM annotation layer** — deferred by spec ("ship layer 1, live with it, then decide whether layer 2 earns its place"). Build only after using layer 1. diff --git a/RETRO.md b/RETRO.md index ca92cfde..8ddb0d3d 100644 --- a/RETRO.md +++ b/RETRO.md @@ -36,10 +36,15 @@ test` green and rendered via `cmd/preview` before commit: | `6a06f2e` | Inline action rows in the OUTPUT transcript (tool results / approvals / writes / grants as `RouterEntry` role `action`, interleaved by arrival). | | `f14a83c` | Drop the inline tool-*start* rows (they doubled up with the result rows). | | `531910d` | Transcript free-scroll (`PgUp/PgDn`, `^u/^d`, `esc` snaps to tail-follow; clamped via `outputViewport()`/`buildTranscriptRows`, 2 tests) + help overlay (`?`) + event-inspector `/` filter. | +| `db27b34` | Page-scroll the `^x` diff/preview/command fullscreen viewer (`↑↓` line, `PgUp/PgDn` page, `^u/^d` half, `g/G` ends; `scrollDiff()` clamp, 2 tests) + advertise it in the modal hint and the `?` help overlay. Closes the §E approval-ergonomics re-audit. | -These are mostly deterministic render/UX changes (verifiable by `go test` + `cmd/preview`); the -only remaining live look is the §E approval-ergonomics re-audit noted in BACKLOG (the band gained -the grant scope-picker + action rows since `d5afcd3`). +These are mostly deterministic render/UX changes (verifiable by `go test` + `cmd/preview`). + +**§E approval-ergonomics re-audit — DONE (`db27b34`).** Re-checked the band after it gained the +grant scope-picker (`A`) and inline action rows: the spec still holds — single-key `y/n/e` for +T0–T2, mandatory second-key confirm for T3+ (`HighTier`), navigable queue with an `i/n` indicator, +docked band never modal-stacks. All covered green by `approval_test.go`. The one gap was the diff +viewer scrolling one line at a time; `db27b34` adds paging. Item moved out of BACKLOG. ---