chore(damn): detekt, build, tests, formatting

fixed detekt issues where possible.
fixed disttar failing build because tools is added twice in the server module.
added workflowId where required.
fixed some tests not being recognized because of runBlocking without explicit return type.
formatting + imports.

core/transitions/src/main/kotlin/com/correx/core/transitions/analysis/CycleExtractor.kt

@@ -31,4 +31,4 @@ internal class CycleExtractor(
 
         return canonicalize(cycles)
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/analysis/DetectedCycle.kt

@@ -6,4 +6,4 @@ import com.correx.core.transitions.graph.TransitionEdge
 data class DetectedCycle(
     val nodes: List<StageId>,
     val edges: List<TransitionEdge>
-)
+)

core/transitions/src/main/kotlin/com/correx/core/transitions/analysis/DeterministicAdjacencyBuilder.kt

@@ -18,4 +18,4 @@ internal class DeterministicAdjacencyBuilder {
             )
         }
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/analysis/canonicalization/CycleCanonicalizer.kt

@@ -33,4 +33,4 @@ internal object CycleCanonicalizer {
             }
             .sortedBy { it.nodes.first().value }
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/evaluation/EvaluationContext.kt

@@ -10,4 +10,4 @@ data class EvaluationContext(
     val currentStage: StageId,
     val artifacts: Map<ArtifactId, ArtifactState> = emptyMap(),
     val variables: Map<String, String> = emptyMap(),
-)
+)

core/transitions/src/main/kotlin/com/correx/core/transitions/evaluation/TransitionConditionEvaluator.kt

@@ -7,4 +7,4 @@ fun interface TransitionConditionEvaluator {
         condition: TransitionCondition,
         context: EvaluationContext
     ): Boolean
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/execution/StageExecutionResult.kt

@@ -9,4 +9,4 @@ sealed interface StageExecutionResult {
         val reason: String,
         val retryable: Boolean,
     ) : StageExecutionResult
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/execution/StageExecutor.kt

@@ -4,4 +4,4 @@ interface StageExecutor {
     fun execute(
         request: StageExecutionRequest
     ): StageExecutionResult
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/graph/GraphOrdering.kt

@@ -12,4 +12,4 @@ internal fun WorkflowGraph.sortedTransitions(): List<TransitionEdge> =
             { it.id.value },
             { it.to.value }
         )
-    )
+    )

core/transitions/src/main/kotlin/com/correx/core/transitions/graph/TransitionCondition.kt

@@ -4,4 +4,4 @@ import com.correx.core.transitions.evaluation.EvaluationContext
 
 fun interface TransitionCondition {
     fun evaluate(context: EvaluationContext): Boolean
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/graph/TransitionEdge.kt

@@ -8,4 +8,4 @@ data class TransitionEdge(
     val from: StageId,
     val to: StageId,
     val condition: TransitionCondition
-)
+)

core/transitions/src/main/kotlin/com/correx/core/transitions/graph/WorkflowGraph.kt

@@ -10,6 +10,7 @@ data class WorkflowGraph(
 ) {
     val stageIds: Set<StageId> get() = stages.keys
     init {
+        require(id.isNotBlank()) { "workflow id must not be blank" }
         require(start in stages) { "start stage must exist in stages" }
     }
 }

core/transitions/src/main/kotlin/com/correx/core/transitions/mapper/DefaultStageExecutionEventMapper.kt

@@ -44,4 +44,4 @@ class DefaultStageExecutionEventMapper : StageExecutionEventMapper {
             )
         }
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/mapper/StageExecutionEventMapper.kt

@@ -9,4 +9,4 @@ interface StageExecutionEventMapper {
         request: StageExecutionRequest,
         result: StageExecutionResult
     ): List<EventPayload>
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/policy/CyclePolicy.kt

@@ -12,4 +12,4 @@ sealed interface CyclePolicy {
     data class Approval(
         val timeoutMs: Long
     ) : CyclePolicy
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/policy/CyclePolicyBinding.kt

@@ -3,4 +3,4 @@ package com.correx.core.transitions.policy
 data class CyclePolicyBinding(
     val cycle: CycleSignature,
     val policy: CyclePolicy
-)
+)

core/transitions/src/main/kotlin/com/correx/core/transitions/policy/CyclePolicyResolver.kt

@@ -9,4 +9,4 @@ class CyclePolicyResolver(
             .firstOrNull { it.cycle == signature }
             ?.policy
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/policy/PolicyValidation.kt

@@ -20,4 +20,4 @@ class PolicyValidation {
 
         return errors
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/resolution/DefaultTransitionResolver.kt

@@ -32,4 +32,4 @@ class DefaultTransitionResolver(
         }
         return TransitionDecision.Stay
     }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/resolution/TransitionDecision.kt

@@ -17,4 +17,4 @@ sealed interface TransitionDecision {
     ) : TransitionDecision
 
     data object NoMatch : TransitionDecision
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/resolution/TransitionOrdering.kt

@@ -7,4 +7,4 @@ object TransitionOrdering {
         compareBy<TransitionEdge> { it.from.value }
             .thenBy { it.id.value }
             .thenBy { it.to.value }
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/resolution/TransitionResolver.kt

@@ -8,4 +8,4 @@ interface TransitionResolver {
         graph: WorkflowGraph,
         context: EvaluationContext
     ): TransitionDecision
-}
+}

core/transitions/src/main/kotlin/com/correx/core/transitions/state/VisitState.kt

@@ -3,4 +3,4 @@ package com.correx.core.transitions.state
 internal enum class VisitState {
     VISITING,
     VISITED
-}
+}