chore(damn): detekt, build, tests, formatting

fixed detekt issues where possible.
fixed disttar failing build because tools is added twice in the server module.
added workflowId where required.
fixed some tests not being recognized because of runBlocking without explicit return type.
formatting + imports.

testing/integration/src/test/kotlin/SessionOrchestratorIntegrationTest.kt

@@ -5,13 +5,18 @@ import com.correx.core.approvals.domain.DefaultApprovalEngine
 import com.correx.core.approvals.model.ApprovalContext
 import com.correx.core.approvals.model.ApprovalDecision
 import com.correx.core.approvals.model.ApprovalScopeIdentity
+import com.correx.core.artifacts.DefaultArtifactReducer
+import com.correx.core.artifactstore.ArtifactStore
 import com.correx.core.events.events.ApprovalRequestedEvent
+import com.correx.core.events.events.InferenceCompletedEvent
+import com.correx.core.events.events.InferenceStartedEvent
 import com.correx.core.events.events.OrchestrationPausedEvent
 import com.correx.core.events.events.OrchestrationResumedEvent
 import com.correx.core.events.events.WorkflowCompletedEvent
 import com.correx.core.events.events.WorkflowFailedEvent
 import com.correx.core.events.events.WorkflowStartedEvent
 import com.correx.core.events.execution.RetryPolicy
+import com.correx.core.events.types.ArtifactId
 import com.correx.core.events.types.SessionId
 import com.correx.core.events.types.StageId
 import com.correx.core.inference.InferenceRepository
@@ -32,23 +37,19 @@ import com.correx.core.sessions.DefaultSessionRepository
 import com.correx.core.sessions.projections.replay.DefaultEventReplayer
 import com.correx.core.sessions.projections.replay.EventReplayer
 import com.correx.core.transitions.graph.StageConfig
+import com.correx.core.transitions.graph.TransitionEdge
 import com.correx.core.transitions.graph.WorkflowGraph
+import com.correx.core.utils.TypeId
 import com.correx.core.validation.approval.ApprovalTrigger
 import com.correx.core.validation.pipeline.ValidationPipeline
-import com.correx.core.artifacts.DefaultArtifactReducer
 import com.correx.infrastructure.persistence.InMemoryEventStore
 import com.correx.infrastructure.persistence.artifact.LiveArtifactRepository
+import com.correx.testing.contracts.fixtures.artifactstore.NoopArtifactStore
 import com.correx.testing.fixtures.InferenceFixtures
 import com.correx.testing.fixtures.context.ContextFixtures
 import com.correx.testing.fixtures.cyclePolicyMissingValidator
 import com.correx.testing.fixtures.inference.MockInferenceProvider
 import com.correx.testing.fixtures.transitions.TransitionFixtures
-import com.correx.core.artifactstore.ArtifactStore
-import com.correx.core.events.events.InferenceCompletedEvent
-import com.correx.core.events.events.InferenceStartedEvent
-import com.correx.core.events.types.ArtifactId
-import com.correx.core.utils.TypeId
-import com.correx.testing.contracts.fixtures.artifactstore.NoopArtifactStore
 import com.correx.testing.fixtures.transitions.TransitionFixtures.threeStageGraph
 import com.correx.testing.kernel.MockSessionEventReplayer
 import kotlinx.coroutines.launch
@@ -209,9 +210,10 @@ class SessionOrchestratorIntegrationTest {
         // Single-stage graph: enterStage(A) triggers exactly one approval; after resume,
         // the always-true transition moves to the terminal "done" and the workflow completes.
         val graph = WorkflowGraph(
+            id = "workflow-test",
             stages = mapOf(StageId("A") to StageConfig()),
             transitions = setOf(
-                com.correx.core.transitions.graph.TransitionEdge(
+                TransitionEdge(
                     id = com.correx.core.events.types.TransitionId("t1"),
                     from = StageId("A"),
                     to = StageId("done"),
@@ -268,6 +270,7 @@ class SessionOrchestratorIntegrationTest {
     @Test
     fun `workflow with empty graph fails immediately`(): Unit = runBlocking {
         val emptyGraph = WorkflowGraph(
+            id = "workflow-test",
             stages = mapOf(StageId("start") to StageConfig()),
             transitions = emptySet(),
             start = StageId("start"),
@@ -310,8 +313,8 @@ class SessionOrchestratorIntegrationTest {
         assertTrue(recordingStore.puts.size >= 2, "Expected at least 2 puts, got ${recordingStore.puts.size}")
 
         val events = eventStore.read(sessionId)
-        val started = events.mapNotNull { it.payload as? InferenceStartedEvent }.first()
-        val completed = events.mapNotNull { it.payload as? InferenceCompletedEvent }.first()
+        val started = events.firstNotNullOf { it.payload as? InferenceStartedEvent }
+        val completed = events.firstNotNullOf { it.payload as? InferenceCompletedEvent }
 
         assertEquals(recordingStore.idForIndex(0), started.promptArtifactId)
         assertEquals(recordingStore.idForIndex(1), completed.responseArtifactId)
@@ -325,17 +328,18 @@ class SessionOrchestratorIntegrationTest {
         val z = StageId("Z")
         // ghost is missing from stages map but has an outgoing transition so it is non-terminal
         val brokenGraph = WorkflowGraph(
+            id = "workflow-test",
             stages = mapOf(a to StageConfig(), b to StageConfig()),
             transitions = setOf(
-                com.correx.core.transitions.graph.TransitionEdge(
+                TransitionEdge(
                     id = com.correx.core.events.types.TransitionId("t1"), from = a, to = b,
                     condition = { true },
                 ),
-                com.correx.core.transitions.graph.TransitionEdge(
+                TransitionEdge(
                     id = com.correx.core.events.types.TransitionId("t2"), from = b, to = ghost,
                     condition = { true },
                 ),
-                com.correx.core.transitions.graph.TransitionEdge(
+                TransitionEdge(
                     id = com.correx.core.events.types.TransitionId("t3"), from = ghost, to = z,
                     condition = { true },
                 ),
@@ -391,5 +395,7 @@ private class RecordingArtifactStore : ArtifactStore {
 
     override suspend fun get(id: ArtifactId): ByteArray? = byId[id]
 
-    override suspend fun flushBefore(commit: suspend () -> Unit) { commit() }
+    override suspend fun flushBefore(commit: suspend () -> Unit) {
+        commit()
+    }
 }

testing/integration/src/test/kotlin/ValidationPipelineIntegrationTest.kt

@@ -59,6 +59,7 @@ class ValidationPipelineIntegrationTest {
         val a = StageId("A")
         val ghost = StageId("GHOST")
         val graphWithDanglingTransition = WorkflowGraph(
+            id = "workflow-test",
             stages = mapOf(a to StageConfig()),
             transitions = setOf(TransitionEdge(TransitionId("t1"), from = a, to = ghost) { true }),
             start = a,
@@ -69,4 +70,4 @@ class ValidationPipelineIntegrationTest {
         assertInstanceOf(ValidationOutcome.Rejected::class.java, outcome)
         assertFalse((outcome as ValidationOutcome.Rejected).retryable)
     }
-}
+}