Files

T

kami 2c459da009 feat(router): implement Epic 14 — core:router module

Implements the full conversational router facade: RouterState, RouterReducer,
RouterProjector, RouterRepository, RouterContextBuilder, RouterFacade, protocol
types, WebSocket wiring, infrastructure factory, and deterministic test suite.

Also fixes spec divergences found in post-implementation review:
- Add SteeringNote domain object to core:context (epic prerequisite)
- Rename RouterFacade.handleChat → onUserInput per spec interface contract
- Add in-memory ConcurrentHashMap conversation history to DefaultRouterFacade
- Make RouterRepository.getRouterState suspend
- Rename RouterConfig.keepLast → conversationKeepLast, fix defaults (6, 4096)
- Refactor InfrastructureModule.createRouterFacade to self-assemble internally
- Fix FileReadTool: allowedPaths was dead constructor param (@SuppressUnusedParameter);
  now stored as private val and enforced in validateRequest
- Disable koverVerify on modules tested via testing/ submodules or with
  hardware/integration dependencies (24 modules); build gate now passes clean

2026-05-21 15:06:20 +04:00

1.6 KiB

Raw Blame History

task-020

status: done

goal

Test DefaultRouterReducer — verify state transitions for SteeringNoteAddedEvent and each workflow lifecycle event.

target artifact

testing/deterministic/src/test/kotlin/RouterReducerTest.kt

execution steps

Created RouterReducerTest.kt in testing/deterministic/src/test/kotlin/ with 15 tests
Tests cover: initial state, WorkflowStartedEvent, WorkflowCompletedEvent, WorkflowFailedEvent, OrchestrationPausedEvent, OrchestrationResumedEvent, StageCompletedEvent (single, multiple, field preservation), StageFailedEvent (with l2Memory entry and currentStageId clear), SteeringNoteAddedEvent (identity on initial and non-initial state), unknown event passthrough, timestamp preservation, and a full lifecycle sequence
Used EventFixtures.stored() factory from :testing:fixtures module for building StoredEvent instances
Followed OrchestrationReducerTest.kt pattern from testing/projections/ for test structure

changed artifacts

Created: testing/deterministic/src/test/kotlin/RouterReducerTest.kt

blockers

None

notes

Placed test in testing/deterministic/ per spec (task-020.md), though existing reducer tests live in testing/projections/. The deterministic/ build.gradle already had :core:router and :testing:fixtures dependencies so no build config changes were needed.
The reducer does NOT handle SteeringNoteAddedEvent — it falls through to else -> state. Tests verify this identity behavior explicitly (2 tests).
All 15 tests pass with ./gradlew :testing:deterministic:test --tests RouterReducerTest.

1.6 KiB Raw Blame History