kami
cdee5f2245
Event log integrity (sole source of truth): - SqliteEventStore: serialize append/appendAll under a Mutex, enable WAL + busy_timeout + synchronous=NORMAL, roll back on any Throwable. Replaces the app-computed `SELECT MAX(seq)+1` read-modify-write that dropped events under concurrent appends (race was invisible to CI: only the in-memory store and single-threaded :memory: tests were ever exercised). - Serialization: encodeDefaults + ignoreUnknownKeys, explicit @SerialName on all 46 EventPayload subclasses and event-referenced enum constants, @Serializable on RiskLevel/RiskAction. Guards the append-only log against silent corruption from future class renames, field removals, or default-value changes. Approval/grant security (Invariant: approvals cannot widen authority): - Tier authorization is now a ceiling (request.tier.level <= max granted) instead of set membership; SESSION grants bind to a specific toolName instead of matching everything; handleCreateGrant rejects empty/over-tier/scopeless grants. Router chat wiring (Phase 0-2): ChatInput round-trip, StartChatSession from IDLE, router-panel layout, workflows behind Ctrl+W. Tests: SqliteEventStore concurrency, serialization round-trip + discriminator stability + unknown-key tolerance, adversarial grant scope/tier; updated existing approval and reducer tests for the new grant semantics and StartChatSession effect.
93 lines
3.3 KiB
Kotlin
93 lines
3.3 KiB
Kotlin
import com.correx.core.approvals.ApprovalOutcome
|
|
import com.correx.core.approvals.ApprovalStatus
|
|
import com.correx.core.approvals.GrantScope
|
|
import com.correx.core.approvals.Tier
|
|
import com.correx.core.approvals.domain.DefaultApprovalEngine
|
|
import com.correx.core.approvals.model.ApprovalContext
|
|
import com.correx.core.approvals.model.ApprovalGrant
|
|
import com.correx.core.approvals.model.ApprovalScopeIdentity
|
|
import com.correx.core.events.types.GrantId
|
|
import com.correx.core.events.types.SessionId
|
|
import com.correx.core.sessions.ApprovalMode
|
|
import com.correx.testing.fixtures.request
|
|
import kotlinx.datetime.Instant
|
|
import org.junit.jupiter.api.Assertions.assertEquals
|
|
import org.junit.jupiter.api.Assertions.assertNull
|
|
import org.junit.jupiter.api.Test
|
|
|
|
class GrantSemanticsTest {
|
|
|
|
private val engine = DefaultApprovalEngine()
|
|
|
|
@Test
|
|
fun `grant permits exact tier - auto_approved`() {
|
|
val req = request("r1", Tier.T2).copy(toolName = "shell")
|
|
val grant = ApprovalGrant(
|
|
id = GrantId("g1"),
|
|
scope = GrantScope.SESSION(toolName = "shell"),
|
|
permittedTiers = setOf(Tier.T2),
|
|
reason = "test",
|
|
timestamp = Instant.parse("2026-01-01T00:00:00Z")
|
|
)
|
|
val ctx = ApprovalContext(
|
|
ApprovalScopeIdentity(SessionId("s1"), null, null),
|
|
ApprovalMode.DENY
|
|
)
|
|
val now = Instant.parse("2026-01-01T00:00:01Z")
|
|
|
|
val decision = engine.evaluate(req, ctx, listOf(grant), now)
|
|
assertEquals(ApprovalOutcome.AUTO_APPROVED, decision.outcome)
|
|
assertEquals(ApprovalStatus.COMPLETED, decision.state)
|
|
}
|
|
|
|
@Test
|
|
fun `grant does not permit other tiers`() {
|
|
val req = request("r1", Tier.T3)
|
|
val grant = ApprovalGrant(
|
|
id = GrantId("g1"),
|
|
scope = GrantScope.SESSION(),
|
|
permittedTiers = setOf(Tier.T2),
|
|
reason = "test",
|
|
timestamp = Instant.parse("2026-01-01T00:00:00Z")
|
|
)
|
|
val ctx = ApprovalContext(
|
|
ApprovalScopeIdentity(SessionId("s1"), null, null),
|
|
ApprovalMode.DENY
|
|
)
|
|
val now = Instant.parse("2026-01-01T00:00:01Z")
|
|
|
|
val decision = engine.evaluate(req, ctx, listOf(grant), now)
|
|
assertEquals(ApprovalStatus.PENDING, decision.state)
|
|
assertNull(decision.outcome)
|
|
}
|
|
|
|
@Test
|
|
fun `multiple grants - any match is enough`() {
|
|
val req = request("r1", Tier.T4).copy(toolName = "write_file")
|
|
val grants = listOf(
|
|
ApprovalGrant(
|
|
GrantId("g1"),
|
|
GrantScope.SESSION(toolName = "shell"),
|
|
setOf(Tier.T3),
|
|
"",
|
|
Instant.parse("2026-01-01T00:00:00Z")
|
|
),
|
|
ApprovalGrant(
|
|
GrantId("g2"),
|
|
GrantScope.SESSION(toolName = "write_file"),
|
|
setOf(Tier.T4),
|
|
"",
|
|
Instant.parse("2026-01-01T00:00:00Z")
|
|
)
|
|
)
|
|
val ctx = ApprovalContext(
|
|
ApprovalScopeIdentity(SessionId("s1"), null, null),
|
|
ApprovalMode.DENY
|
|
)
|
|
val now = Instant.parse("2026-01-01T00:00:01Z")
|
|
|
|
val decision = engine.evaluate(req, ctx, grants, now)
|
|
assertEquals(ApprovalOutcome.AUTO_APPROVED, decision.outcome)
|
|
}
|
|
}
|