Validate execution targets against Nexus instead of accepting free text
Finding 3 of REVIEW-2026-07-30.md. target_entity_id was accepted as any non-empty string; the engine only compared it against a pinned TargetEntityID, which is empty for every registered capability. Spec §4.3: "Hexis never accepts a free-text target. Ever." Targets are now checked in order: ent_ shape (free, never touches the network), pinned target, existence in Nexus, entity still active, and a match against the capability's TargetTypes. Validation runs before a confirmation is consumed, so a bad target cannot burn one, and at confirmation-mint time too, since a confirmation binds a target. Two deliberate calls: Nexus unreachable fails closed (503, ErrTargetUnverifiable). Failing open would reinstate exactly this hole the moment Nexus blips, and hand it to anyone able to degrade Nexus. Hexis holds no entity table, so "unreachable" and "I cannot tell if this target is real" are the same statement. The cost is that executes now require Nexus liveness; the lookup is bounded at 5s so a hung Nexus fails fast rather than consuming the capability timeout. An empty TargetTypes means no type constraint, not a bypass — the entity must still exist, be canonical and be active. Rejecting empty outright would disable 16 of the 19 registered capabilities, since only the docker.* entries declare a target type. The spec's stronger blessing guard is not implementable: Nexus has no blessing concept at all. This is the achievable guard, and strictly weaker. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uea55zaiWuEByEDC4UBSdd
This commit is contained in:
@@ -8,15 +8,27 @@ import (
|
||||
"bytes"
|
||||
"context"
|
||||
"encoding/json"
|
||||
"errors"
|
||||
"fmt"
|
||||
"net/http"
|
||||
"net/url"
|
||||
"time"
|
||||
)
|
||||
|
||||
// ErrEntityNotFound is returned by GetEntity when Nexus answers 404 — the
|
||||
// entity ID is well-formed but no such entity exists. It is deliberately
|
||||
// distinct from a transport error, so callers can tell "this target is not
|
||||
// real" from "I could not reach Nexus to find out".
|
||||
var ErrEntityNotFound = errors.New("entity not found")
|
||||
|
||||
type Entity struct {
|
||||
ID string `json:"id"`
|
||||
Type string `json:"type"`
|
||||
DisplayName string `json:"display_name"`
|
||||
// State is "active", "merged", "retired" or "deleted". Empty when the
|
||||
// value comes from a /resolve response, which does not carry it.
|
||||
State string `json:"state,omitempty"`
|
||||
MergedInto string `json:"merged_into,omitempty"`
|
||||
}
|
||||
|
||||
type Candidate struct {
|
||||
@@ -34,6 +46,10 @@ type ResolveResult struct {
|
||||
|
||||
type Client interface {
|
||||
Resolve(ctx context.Context, query string, types []string) (*ResolveResult, error)
|
||||
// GetEntity fetches a single entity by canonical ID. It returns
|
||||
// ErrEntityNotFound if Nexus reports 404, and a transport/protocol error
|
||||
// otherwise.
|
||||
GetEntity(ctx context.Context, id string) (*Entity, error)
|
||||
}
|
||||
|
||||
type httpClient struct {
|
||||
@@ -78,3 +94,31 @@ func (c *httpClient) Resolve(ctx context.Context, query string, types []string)
|
||||
}
|
||||
return &result, nil
|
||||
}
|
||||
|
||||
func (c *httpClient) GetEntity(ctx context.Context, id string) (*Entity, error) {
|
||||
req, err := http.NewRequestWithContext(ctx, http.MethodGet, c.baseURL+"/api/v1/entities/"+url.PathEscape(id), nil)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
req.Header.Set("X-Nexus-Version", "v1")
|
||||
|
||||
resp, err := c.http.Do(req)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
|
||||
switch resp.StatusCode {
|
||||
case http.StatusOK:
|
||||
case http.StatusNotFound:
|
||||
return nil, ErrEntityNotFound
|
||||
default:
|
||||
return nil, fmt.Errorf("nexus get entity: %s", http.StatusText(resp.StatusCode))
|
||||
}
|
||||
|
||||
var entity Entity
|
||||
if err := json.NewDecoder(resp.Body).Decode(&entity); err != nil {
|
||||
return nil, fmt.Errorf("decode nexus entity response: %w", err)
|
||||
}
|
||||
return &entity, nil
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user