Files

T

kami 0d281016e7 Cut the dead attic workers, and file what the audit left standing

attic/worker_ocr.py and attic/worker_parse.py are 224 lines imported by nothing
and named in no doc. The OCR stage was removed when narration moved to the
director beat. The two design notes in attic/ stay, they are history.

worker_vision._panel_size had one reference and it was the definition.

The audit's larger finding is filed rather than fixed: call_gemma4,
_extract_json and _strip_thought exist in both worker_vision and worker_script
and have already diverged. That matters because the JSON repair pass can
fabricate dialogue, so a fix would land in one copy and not the other. It is
caveats/audit-open.md#gemma-helpers-duplicated with its revisit trigger.

HANDOFF.md carries the rest: _wrap2 against textwrap, the duplicated ONNX
preprocessing, and worker_layers pointing at a legacy/ directory that was never
tracked in git.

Checked: ruff clean, worker_vision and worker_render self-checks pass.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

2026-08-13 23:06:34 +04:00

3.6 KiB

Raw Blame History

caveats/

One entry per known breakage, deferral, or trap. An entry names what fails, who pays for it, and the concrete trigger that makes fixing it worth the time.

A caveat that gets resolved moves to decisions/ or gets deleted. A caveat with no revisit trigger is a complaint, so give it one or drop it.

Rules for this directory

One file per source, one ## section per limit.
State the limit as what fails, not as a topic. "Reconcile deletes the losing character" beats "Reconcile".
Delete an entry the moment its trigger fires and the work lands.

Index

caveat	source
Reconcile deletes the losing character irreversibly	AUDIT.md
Clearing a stage does not undo what it wrote	AUDIT.md
ComfyUI uses the GPU outside the session mutex	AUDIT.md
The JSON repair pass can fabricate dialogue	AUDIT.md
`/review/preview` pins a solo clip into the final video	AUDIT.md
Stored embeddings carry no model or pooling version	AUDIT.md
Worker endpoints block the event loop	AUDIT.md
SQLite has no busy timeout, so parallelism will surface as lock errors	AUDIT.md
`layers` runs after `tts`, so pipelined solo beats lose parallax	AUDIT.md
`completed` means something different in each stage	AUDIT.md
Identity worker caches characters the orchestrator has deleted	AUDIT.md
The gemma helpers exist twice and have diverged	repo audit
A character seen once gets no assignment at all	AUDIT.md
MinIO credentials are hardcoded in committed source	AUDIT.md
Assemble marks a job completed with no clips	AUDIT.md
Reviewer timestamps drift against the crossfaded video	AUDIT.md
Nothing attributes a speaker in a multi-character panel	2026-08-11 run
One character id covers two different women	2026-08-11 run
The character registry carries five weeks of wrong names	2026-08-11 run
One invented word still halts the chapter	2026-08-11 run
A completed job keeps the error from an earlier failure	2026-08-11 run
`layers` reports success on an empty bucket	2026-08-11 run
Every `bbox` is read in the wrong coordinate space	resolved, rerun pending
Identity cannot say "a person with no name"	2026-08-12 panel 7
Vision does not separate a background extra from cast	2026-08-12 panel 7
Cast reference profiles are enrolled from wrong crops	2026-08-12 panel 7
Identity coverage has fallen on every run since the gate landed	before the next downstream run
Embedding cosine on a person crop cannot tell two people apart	before building on cosine

3.6 KiB Raw Blame History

caveats/

Rules for this directory

Index

3.6 KiB

Raw Blame History