From d32887a91dad499f168daaf2f0c9e61722fed0a4 Mon Sep 17 00:00:00 2001
From: kami <kami@kvmx.ru>
Date: Sun, 26 Jul 2026 20:43:52 +0400
Subject: [PATCH] test explicit orchestration contracts

---
 internal/provider/contract_test.go | 33 +++++++++++++++
 internal/router/contract_test.go   | 66 ++++++++++++++++++++++++++++++
 2 files changed, 99 insertions(+)
 create mode 100644 internal/provider/contract_test.go
 create mode 100644 internal/router/contract_test.go

diff --git a/internal/provider/contract_test.go b/internal/provider/contract_test.go
new file mode 100644
index 0000000..55ea751
--- /dev/null
+++ b/internal/provider/contract_test.go
@@ -0,0 +1,33 @@
+package provider
+
+import (
+	"errors"
+	"testing"
+
+	"orchestra/internal/domain"
+)
+
+type appendThenReflectSink struct{ appended bool }
+
+func (s *appendThenReflectSink) Append(domain.Event) error { s.appended = true; return nil }
+
+type failingReflector struct{}
+
+func (failingReflector) ReflectTask(domain.Task, domain.Event) error {
+	return errors.New("provider unavailable")
+}
+
+type taskLookup struct{}
+
+func (taskLookup) Task(string) (domain.Task, bool) { return domain.Task{ID: "task"}, true }
+
+func TestReflectingSinkAppendsBeforeReflection(t *testing.T) {
+	sink := &appendThenReflectSink{}
+	err := (ReflectingSink{Sink: sink, Tasks: taskLookup{}, Reflector: failingReflector{}}).Append(domain.Event{TaskID: "task", Type: "TaskCompleted"})
+	if !sink.appended {
+		t.Fatal("reflection was attempted before canonical append")
+	}
+	if err == nil {
+		t.Fatal("reflection failure was hidden")
+	}
+}
diff --git a/internal/router/contract_test.go b/internal/router/contract_test.go
new file mode 100644
index 0000000..d3f308d
--- /dev/null
+++ b/internal/router/contract_test.go
@@ -0,0 +1,66 @@
+package router
+
+import (
+	"encoding/json"
+	"testing"
+	"time"
+
+	"orchestra/internal/domain"
+	"orchestra/internal/registry"
+	"orchestra/internal/store"
+)
+
+func TestAssignPendingUsesProjectAffinityAndCapability(t *testing.T) {
+	s, err := store.Open(t.TempDir())
+	if err != nil {
+		t.Fatal(err)
+	}
+	add := func(id, project string, caps []string) {
+		b, _ := json.Marshal(map[string]any{"source": "test", "external_id": id, "project": project, "capability": caps})
+		if err := s.Append(domain.Event{Type: "TaskCreated", TaskID: id, Version: 1, Payload: b}); err != nil {
+			t.Fatal(err)
+		}
+	}
+	add("task", "mechanical", []string{"mechanical"})
+	r, err := registry.New(registry.Config{
+		Projects: []registry.Project{{ID: "mechanical", MachineAffinity: []string{"homesrv"}}},
+		Machines: []registry.Machine{{ID: "homesrv", Address: "homesrv:1"}, {ID: "workpc", Address: "workpc:1"}},
+		Herdrs:   []registry.Herdr{{ID: "wrong-machine", MachineID: "workpc", Capabilities: []string{"mechanical"}}, {ID: "wrong-cap", MachineID: "homesrv", Capabilities: []string{"correlation"}}},
+	})
+	if err != nil {
+		t.Fatal(err)
+	}
+	out, err := (&Router{Store: s, Registry: r}).AssignPending()
+	if err != nil {
+		t.Fatal(err)
+	}
+	if len(out) != 0 {
+		t.Fatalf("assigned despite affinity/capability mismatch: %#v", out)
+	}
+}
+
+func TestAssignPendingDoesNotPreemptRunningWork(t *testing.T) {
+	s, err := store.Open(t.TempDir())
+	if err != nil {
+		t.Fatal(err)
+	}
+	b, _ := json.Marshal(map[string]any{"source": "test", "external_id": "queued", "project": "p", "capability": []string{}})
+	if err := s.Append(domain.Event{Type: "TaskCreated", TaskID: "queued", Version: 1, Payload: b}); err != nil {
+		t.Fatal(err)
+	}
+	r, err := registry.New(registry.Config{Projects: []registry.Project{{ID: "p", MachineAffinity: []string{"m"}}}, Machines: []registry.Machine{{ID: "m", Address: "m:1"}}, Herdrs: []registry.Herdr{{ID: "h", MachineID: "m", Concurrency: 1}}})
+	if err != nil {
+		t.Fatal(err)
+	}
+	_, err = s.Lease("queued", "h", time.Minute)
+	if err != nil {
+		t.Fatal(err)
+	}
+	if _, err := (&Router{Store: s, Registry: r}).AssignPending(); err != nil {
+		t.Fatal(err)
+	}
+	task, ok := s.Task("queued")
+	if !ok || task.State != domain.StateLeased || task.Lease == nil || task.Lease.HarnessID != "h" {
+		t.Fatalf("running lease was changed while assigning: %#v", task)
+	}
+}