Give the reviewed change a path to the human
The completion tail ended at TaskCompleted with no pull request. Nothing in the running system ever called the review or submission endpoints: the whole event log holds zero ReviewRecorded and zero TaskSubmitted, so the merge reflection, the publisher and the human trust boundary had no entry point. Four links, in the order the tail needs them: - finalize commits first and runs the quality gate against the committed tree, so the gate result is bound to the commit being submitted. CheckSubmission requires gate sha, review sha and head sha to be one commit, which a gate run on the pre-commit tree can never satisfy. - The worker seals the reviewer's findings and submits, through a new /v1/federation/workers/<id>/submit. A blocking review returns the task to implementation instead; a project with no forge still completes directly. - The reviewing session is told where findings go. The brief asked for findings and named no file, and it described a diff nobody supplied. - GiteaPublisher.Push asks the forge what the branch holds before reaching for a local checkout. A worker-owned worktree is on another machine and has already pushed the commit; the coordinator has no such directory. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CVbaKucEYBjMqVeUgJUsc1
This commit is contained in:
@@ -9,6 +9,7 @@ import (
|
||||
"net/http"
|
||||
"net/url"
|
||||
"orchestra/internal/domain"
|
||||
"orchestra/internal/review"
|
||||
"strings"
|
||||
)
|
||||
|
||||
@@ -291,6 +292,40 @@ func (c Client) Complete(ctx context.Context, taskID, reportRef, resultSHA, bran
|
||||
return err
|
||||
}
|
||||
|
||||
// Submit outcomes. Sealing a review and submitting are one call because a
|
||||
// review that blocks has no submission to make, and splitting them would let a
|
||||
// lost response leave a sealed review with nothing acting on it.
|
||||
const (
|
||||
// SubmitSubmitted: the pull request is open and TaskSubmitted is recorded.
|
||||
SubmitSubmitted = "submitted"
|
||||
// SubmitChangesRequested: the review blocked and the task is back in
|
||||
// implementation.
|
||||
SubmitChangesRequested = "changes_requested"
|
||||
// SubmitNoPublisher: the project has no forge, so the caller completes the
|
||||
// task directly instead.
|
||||
SubmitNoPublisher = "no_publisher"
|
||||
)
|
||||
|
||||
// Submit seals the review against resultSHA and submits that commit for human
|
||||
// review. The coordinator owns both events; the worker supplies evidence.
|
||||
func (c Client) Submit(ctx context.Context, taskID, epoch string, expectedVersion int, resultSHA, remote string, result review.Result, gate domain.GateResult) (string, error) {
|
||||
resp, err := c.request(ctx, http.MethodPost, "/v1/federation/workers/"+url.PathEscape(c.WorkerID)+"/submit", map[string]any{
|
||||
"task_id": taskID, "lease_epoch": epoch, "expected_version": expectedVersion,
|
||||
"result_sha": resultSHA, "remote": remote, "review": result, "gate": gate,
|
||||
})
|
||||
if err != nil {
|
||||
return "", err
|
||||
}
|
||||
defer resp.Body.Close()
|
||||
var out struct {
|
||||
Status string `json:"status"`
|
||||
}
|
||||
if err := json.NewDecoder(resp.Body).Decode(&out); err != nil {
|
||||
return "", err
|
||||
}
|
||||
return out.Status, nil
|
||||
}
|
||||
|
||||
func (c Client) PublishCapture(ctx context.Context, capture Capture) (Capture, error) {
|
||||
resp, err := c.request(ctx, http.MethodPost, "/v1/federation/workers/"+url.PathEscape(c.WorkerID)+"/captures", capture)
|
||||
if err != nil {
|
||||
|
||||
Reference in New Issue
Block a user