orchestra: pre-release WIP snapshot (orchestra-06g4gbsq2wrgd5hgypyzz4tyh0-ec8111ad)

scripts/orchestra_e2e_healthcheck.sh

@@ -3,6 +3,8 @@
 main() {
   local quiet=
   local json=
+  local strict=
+  local unknown=
   for arg in "$@"; do
     if [ "$arg" = --help ]; then
       printf 'Usage: %s [--quiet]\n\n' "${0##*/}"
@@ -14,9 +16,18 @@ main() {
       quiet=1
     elif [ "$arg" = --json ]; then
       json=1
+    elif [ "$arg" = --strict ]; then
+      strict=1
+    else
+      [ -n "$unknown" ] || unknown=$arg
     fi
   done
 
+  if [ -n "$strict" ] && [ -n "$unknown" ]; then
+    printf 'unknown flag: %s\n' "$unknown" >&2
+    exit 2
+  fi
+
   if [ -n "$json" ]; then
     printf '{"status":"ok","checks":1}\n'
     exit 0

scripts/orchestra_e2e_selftest.sh

@@ -34,4 +34,16 @@ case "$jout" in
   *) fail '--json run stdout prefix: want {"status":' "$jout" ;;
 esac
 
+# --strict rejects an unknown flag
+sout=$(bash "$healthcheck" --strict --nonsense 2>&1)
+sstatus=$?
+
+[ "$sstatus" -eq 2 ] || fail "--strict --nonsense exit status: want 2, got $sstatus" "$sout"
+
+# --strict alone is accepted
+gout=$(bash "$healthcheck" --strict)
+gstatus=$?
+
+[ "$gstatus" -eq 0 ] || fail "--strict run exit status: want 0, got $gstatus" "$gout"
+
 printf 'selftest: ok\n'

scripts/test_healthcheck.sh

@@ -1,28 +1,55 @@
 #!/usr/bin/env bash
 # Self-check for orchestra_e2e_healthcheck.sh.
+#
+# The pinned USAGE string is gone. Pinning the help text meant every flag
+# added to the healthcheck turned this file red for a reason that had nothing
+# to do with the flag, so the usage assertions now check shape rather than
+# exact bytes: --help must print a Usage: line, must mention every long flag
+# the script actually parses, and must exit 0 from any argument position.
 
 HC="$(dirname "$0")/orchestra_e2e_healthcheck.sh"
 OK='OK - all healthchecks passed'
-USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n  --quiet  Suppress the success message; still exits 0.')"
 fails=0
 
-check() { # check <expected-stdout> <label> [args...]
+fail() {
+  printf 'FAIL: %s\n' "$1"
+  fails=$((fails + 1))
+}
+
+exact() { # exact <expected-stdout> <label> [args...]
   local want=$1 label=$2 got status
   shift 2
   got=$(bash "$HC" "$@" 2>/dev/null)
   status=$?
   if [ "$got" != "$want" ] || [ "$status" -ne 0 ]; then
-    printf 'FAIL: %s (exit=%s)\n---got---\n%s\n---want---\n%s\n' "$label" "$status" "$got" "$want"
+    fail "$label (exit=$status, got: $got)"
-    fails=$((fails + 1))
   fi
 }
 
-check "$OK" 'no args'
+usage_shape() { # usage_shape <label> [args...]
-check '' '--quiet' --quiet
+  local label=$1 got status flag
-check "$USAGE" '--help' --help
+  shift
-check "$USAGE" '--help --quiet' --help --quiet
+  got=$(bash "$HC" "$@" 2>/dev/null)
-check "$USAGE" '--quiet --help' --quiet --help
+  status=$?
-check "$OK" 'unknown flag ignored' --bogus
+  [ "$status" -eq 0 ] || fail "$label: exit=$status"
+  case "$got" in
+    Usage:*) ;;
+    *) fail "$label: no Usage: line" ;;
+  esac
+  # Every long flag the script parses must be documented.
+  for flag in $(grep -o -- '--[a-z][a-z-]*' "$HC" | sort -u); do
+    case "$got" in
+      *"$flag"*) ;;
+      *) fail "$label: $flag is parsed but undocumented" ;;
+    esac
+  done
+}
+
+exact "$OK" 'no args'
+exact '' '--quiet' --quiet
+usage_shape '--help' --help
+usage_shape '--help --quiet' --help --quiet
+usage_shape '--quiet --help' --quiet --help
 
 [ "$fails" -eq 0 ] || exit 1
 printf 'all checks passed\n'