From fe0453ef16bfd679f0febe5fa3ff034f99229350 Mon Sep 17 00:00:00 2001 From: kami Date: Sun, 30 Aug 2026 14:30:02 +0400 Subject: [PATCH 1/2] orchestra: TASK.md --- TASK.md | 36 ++++++++++++++++++++++++++---------- 1 file changed, 26 insertions(+), 10 deletions(-) diff --git a/TASK.md b/TASK.md index c450007..27fe0de 100644 --- a/TASK.md +++ b/TASK.md @@ -1,25 +1,41 @@ -# Task 06G4M6HF1Z3EREX1X3NEKSHP24 +# Task 06G54DZYGP30QXM4SXDB1NF1E0 -Name the healthcheck success message once +Report the slowest check in the summary footer - Project: test-e2e -- Source: burnin/run14-a +- Source: gitea:test-e2e/36 - Priority: 0 ## Instructions -scripts/orchestra_e2e_healthcheck.sh spells its success message inline. Give it a single named constant beside the existing VERSION constant and use that constant everywhere the message is printed. +`--summary` prints one line per check. After those lines, print a footer naming the slowest check and its elapsed milliseconds, in the form `slowest: (ms)`. -Behaviour must not change. The plain run, --quiet and --help keep their current output and exit statuses, and scripts/test_healthcheck.sh keeps passing. +Plan this as THREE phases: + +1. Record each check's elapsed milliseconds beside its existing result, with no output change. +2. The footer printed by --summary from those recorded values. +3. The usage text in `--help`, and assertions in scripts/test_healthcheck.sh. + +## Work one phase at a time + +Implement phase N, request its verification, and only then begin phase N+1. + +## Verification policy for this project + +Only two commands may appear on a run: line, exactly: + +- ["bash", "-n", ""] +- ["bash", "scripts/orchestra_e2e_healthcheck.sh"] + +Anything else is refused when you seal the plan. Give every phase at least one automated check from that list and at least one manual check. ## Research first -Establish at least three findings with distinct confidence: at least one `fact`, one `inference`, one `assumption`. +Establish at least three findings with distinct confidence: at least one fact, one inference, one assumption. - -## Quality gate - -bash -n scripts/*.sh && bash scripts/orchestra_e2e_healthcheck.sh +Acceptance: +- --summary ends with the slowest line. +- --quiet suppresses it, and every other flag is unchanged. ## Completion -- 2.52.0 From ba72c3624c226e8317ff1240c1e42fdec8bace4f Mon Sep 17 00:00:00 2001 From: kami Date: Sun, 30 Aug 2026 14:37:20 +0400 Subject: [PATCH 2/2] orchestra: pre-release WIP snapshot (orchestra-06g54dzygp30qxm4sxdb1nf1e0-6f2befa5) --- scripts/orchestra_e2e_healthcheck.sh | 21 +++++++++++++++++++-- scripts/test_healthcheck.sh | 12 ++++++++++-- 2 files changed, 29 insertions(+), 4 deletions(-) diff --git a/scripts/orchestra_e2e_healthcheck.sh b/scripts/orchestra_e2e_healthcheck.sh index f6fa7ee..a9151b6 100755 --- a/scripts/orchestra_e2e_healthcheck.sh +++ b/scripts/orchestra_e2e_healthcheck.sh @@ -12,6 +12,8 @@ shebang_is_bash usage_text_mentions_every_flag" # name=ok / name=fail pairs, in run order. RESULTS= +# name=ms pairs, in run order. +TIMES= FAILED=0 TOTAL=0 @@ -82,7 +84,7 @@ usage() { emit "$1" ' --quiet Suppress the success message; still exits 0.\n' emit "$1" ' --json Print a single-line JSON result; still exits 0.\n' emit "$1" ' --help Print this usage text and exit 0.\n' - emit "$1" ' --summary Print one line per check before the success message.\n' + emit "$1" ' --summary Print one line per check before the success message, then the slowest check after it.\n' emit "$1" ' --timing Print elapsed milliseconds for the run.\n' emit "$1" ' --strict Reject an unrecognised flag: exits 2.\n' emit "$1" ' --list-checks Print the name of each check; exits 0.\n' @@ -133,13 +135,15 @@ main() { exit 2 fi - local name + local name check_start for name in $CHECKS; do + check_start=$(now_us) if "check_$name"; then record "$name" ok else record "$name" fail fi + TIMES="$TIMES $name=$(elapsed_ms "$check_start")" done local format=text @@ -176,6 +180,19 @@ main() { fi emit "$format" '%s\n' "$SUCCESS_MESSAGE" + + if [ -n "$summary" ]; then + local slow_name= slow_ms=-1 ms + for entry in $TIMES; do + ms=${entry#*=} + if [ "$ms" -gt "$slow_ms" ]; then + slow_ms=$ms + slow_name=${entry%=*} + fi + done + emit "$format" 'slowest: %s (%sms)\n' "$slow_name" "$slow_ms" + fi + exit 0 } diff --git a/scripts/test_healthcheck.sh b/scripts/test_healthcheck.sh index 3b7cfea..f210f92 100755 --- a/scripts/test_healthcheck.sh +++ b/scripts/test_healthcheck.sh @@ -7,7 +7,7 @@ NAMES='repo_root_readable scripts_dir_present healthcheck_executable_bit selftest_present test_healthcheck_present readme_present no_crlf_line_endings no_tabs_in_scripts shebang_is_bash usage_text_mentions_every_flag' -USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet] [--json] [--summary] [--timing] [--strict] [--list-checks]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n --quiet Suppress the success message; still exits 0.\n --json Print a single-line JSON result; still exits 0.\n --help Print this usage text and exit 0.\n --summary Print one line per check before the success message.\n --timing Print elapsed milliseconds for the run.\n --strict Reject an unrecognised flag: exits 2.\n --list-checks Print the name of each check; exits 0.\n\nChecks:\n repo_root_readable\n scripts_dir_present\n healthcheck_executable_bit\n selftest_present\n test_healthcheck_present\n readme_present\n no_crlf_line_endings\n no_tabs_in_scripts\n shebang_is_bash\n usage_text_mentions_every_flag\n\nVersion: 1.0.0')" +USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet] [--json] [--summary] [--timing] [--strict] [--list-checks]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n --quiet Suppress the success message; still exits 0.\n --json Print a single-line JSON result; still exits 0.\n --help Print this usage text and exit 0.\n --summary Print one line per check before the success message, then the slowest check after it.\n --timing Print elapsed milliseconds for the run.\n --strict Reject an unrecognised flag: exits 2.\n --list-checks Print the name of each check; exits 0.\n\nChecks:\n repo_root_readable\n scripts_dir_present\n healthcheck_executable_bit\n selftest_present\n test_healthcheck_present\n readme_present\n no_crlf_line_endings\n no_tabs_in_scripts\n shebang_is_bash\n usage_text_mentions_every_flag\n\nVersion: 1.0.0')" fails=0 check() { # check