2.2 KiB
Task 06G4FZA825XMTCQ8ME8NN82YM8
Add a --strict mode to the healthcheck and keep the pinned usage text honest
- Project: test-e2e
- Source: gitea:test-e2e/12
- Priority: 0
Instructions
Three phases, in this order.
Phase 1 — --strict on the healthcheck
scripts/orchestra_e2e_healthcheck.sh --strict must reject an unrecognised flag: print unknown flag: <flag> on stderr and exit 2. Without --strict the current silent-ignore behaviour is unchanged, and --help still wins over everything.
Automated verification only:
- run: ["bash", "-n", "scripts/orchestra_e2e_healthcheck.sh"]
- run: ["bash", "scripts/orchestra_e2e_healthcheck.sh"]
Phase 2 — cover --strict in the self-test
Extend scripts/orchestra_e2e_selftest.sh so it asserts that --strict --nonsense exits 2 and that --strict alone still exits 0.
Automated verification only:
- run: ["bash", "-n", "scripts/orchestra_e2e_selftest.sh"]
Phase 3 — keep the pinned usage text honest
scripts/test_healthcheck.sh pins the healthcheck's exact --help output in a hardcoded USAGE variable and compares with string equality. Phase 1 adds --strict, so that pinned text must be updated in place to match, and the pinned comparison must keep passing.
Work from the USAGE variable that is already in scripts/test_healthcheck.sh. Do not rewrite the file's structure.
Automated verification for this phase must run the pinned test itself:
- run: ["bash", "scripts/test_healthcheck.sh"]
Constraints
The project's verification policy allows exactly two command shapes:
["bash", "-n", "<one file>"]
["bash", "scripts/orchestra_e2e_healthcheck.sh"]
A run: line outside those is refused when the plan seals, not later.
Research first
Establish at least three findings with distinct confidence: at least one fact, one inference, one assumption. Cite at least two in References.
Completion
Run the configured quality gate. When the task is ready for the worker to verify and deliver, create .orchestra/done. Do not write a prose completion report.
This file is immutable for the lifetime of the task (§6.2) — its hash is carried in every handoff and re-verified on every pickup. Do not edit it.