loop, store: read a fact family by prefix (V-444)
A rule over a key set that only exists at read time cannot declare its keys at wiring time. Kuma has one monitor per service and the names live in the gauge, so the rule declares a prefix and the gatherer resolves the family per tick. ServiceDownRule now fires on any monitor reading down, names it through DownServices, and is edge-triggered: a service that stays down is one nudge, not one per tick with cooldown as the only brake.
This commit is contained in:
@@ -254,6 +254,41 @@ func (s *Store) LatestFactBySource(ctx context.Context, key, source string) (Fac
|
||||
return scanFact(row)
|
||||
}
|
||||
|
||||
// LatestFactsByPrefix — the latest non-voided fact for every key that starts
|
||||
// with prefix, newest-per-key, ordered by key.
|
||||
//
|
||||
// The loop's gatherer loads the keys its rules declare, which works while the
|
||||
// key set is static. Kuma's monitors are not: one fact per monitor means the
|
||||
// keys are only known once the gauge is read, so the rule declares the prefix
|
||||
// and this read resolves it per tick. `_` and `%` are escaped — a monitor name
|
||||
// is user text and must not act as a LIKE wildcard.
|
||||
func (s *Store) LatestFactsByPrefix(ctx context.Context, prefix string) ([]Fact, error) {
|
||||
esc := strings.NewReplacer(`\`, `\\`, `%`, `\%`, `_`, `\_`).Replace(prefix)
|
||||
rows, err := s.db.QueryContext(ctx, `
|
||||
SELECT id, ts, kind, key, value, source, confidence, voids_id
|
||||
FROM facts f
|
||||
WHERE key LIKE ? ESCAPE '\'
|
||||
AND id NOT IN (SELECT voids_id FROM facts WHERE voids_id IS NOT NULL)
|
||||
AND id = (SELECT id FROM facts g
|
||||
WHERE g.key = f.key
|
||||
AND g.id NOT IN (SELECT voids_id FROM facts WHERE voids_id IS NOT NULL)
|
||||
ORDER BY g.ts DESC, g.id DESC LIMIT 1)
|
||||
ORDER BY key`, esc+"%")
|
||||
if err != nil {
|
||||
return nil, fmt.Errorf("facts by prefix %q: %w", prefix, err)
|
||||
}
|
||||
defer rows.Close()
|
||||
var out []Fact
|
||||
for rows.Next() {
|
||||
f, err := scanFact(rows)
|
||||
if err != nil {
|
||||
return nil, err
|
||||
}
|
||||
out = append(out, f)
|
||||
}
|
||||
return out, rows.Err()
|
||||
}
|
||||
|
||||
// Since returns how long ago the latest non-voided fact for key landed, or
|
||||
// (0, ErrNoFact). Implements the `since(key)==null → don't fire` guard from
|
||||
// the spec — silence on no-data is "shuts up when uncertain".
|
||||
|
||||
@@ -0,0 +1,62 @@
|
||||
package store
|
||||
|
||||
import (
|
||||
"context"
|
||||
"testing"
|
||||
"time"
|
||||
)
|
||||
|
||||
// One fact per kuma monitor means the loop cannot name its keys at wiring time,
|
||||
// so it asks for the family by prefix. The read must return the newest row per
|
||||
// key and stop at the prefix boundary.
|
||||
func TestLatestFactsByPrefix(t *testing.T) {
|
||||
s := newTestStore(t)
|
||||
ctx := context.Background()
|
||||
now := time.Now().UTC().Truncate(time.Millisecond)
|
||||
write := func(key, val string, at time.Time) int64 {
|
||||
id, err := s.SetValue(ctx, KindEnv, key, "poll:uptimekuma", val, at)
|
||||
if err != nil {
|
||||
t.Fatalf("SetValue %s: %v", key, err)
|
||||
}
|
||||
return id
|
||||
}
|
||||
write("service_down:db", "up", now.Add(-2*time.Hour))
|
||||
write("service_down:db", "down", now.Add(-time.Hour)) // newer wins
|
||||
write("service_down:web", "up", now.Add(-time.Hour))
|
||||
write("service_downtime", "irrelevant", now) // no colon, not in the family
|
||||
write("water", "250ml", now)
|
||||
|
||||
got, err := s.LatestFactsByPrefix(ctx, "service_down:")
|
||||
if err != nil {
|
||||
t.Fatalf("LatestFactsByPrefix: %v", err)
|
||||
}
|
||||
if len(got) != 2 {
|
||||
t.Fatalf("got %d facts, want 2: %+v", len(got), got)
|
||||
}
|
||||
if got[0].Key != "service_down:db" || got[0].Value != `"down"` {
|
||||
t.Errorf("first = %s=%s, want the newest db row", got[0].Key, got[0].Value)
|
||||
}
|
||||
if got[1].Key != "service_down:web" {
|
||||
t.Errorf("second = %s, want service_down:web", got[1].Key)
|
||||
}
|
||||
}
|
||||
|
||||
// A monitor name is user text. An underscore in it must match itself, not act
|
||||
// as a LIKE wildcard and drag in every other monitor.
|
||||
func TestLatestFactsByPrefixEscapesWildcards(t *testing.T) {
|
||||
s := newTestStore(t)
|
||||
ctx := context.Background()
|
||||
now := time.Now().UTC().Truncate(time.Millisecond)
|
||||
for _, k := range []string{"a_b:one", "axb:two"} {
|
||||
if _, err := s.SetValue(ctx, KindEnv, k, "poll:uptimekuma", "down", now); err != nil {
|
||||
t.Fatalf("SetValue %s: %v", k, err)
|
||||
}
|
||||
}
|
||||
got, err := s.LatestFactsByPrefix(ctx, "a_b:")
|
||||
if err != nil {
|
||||
t.Fatalf("LatestFactsByPrefix: %v", err)
|
||||
}
|
||||
if len(got) != 1 || got[0].Key != "a_b:one" {
|
||||
t.Fatalf("got %+v, want only a_b:one", got)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user