Merge PR #117 into task/491 (V-383)

Slots.Text was the raw utterance for every intent, so a reminder could not
have an empty subject. StillMissing never reported SlotText, the question
"О чём напомнить?" was unaskable, and the branch in PendingQuestion.Answer
that fills a text slot could only overwrite the whole request.

The LLM path now keeps the model's own text, empty included, and the gate
turns a subjectless reminder into a question. The classifier path is
unchanged: it has no subject parser, so the utterance is the only signal it
has.

cmd/mavend/ack.go

@@ -16,7 +16,6 @@ import (
 	"log"
 
 	"github.com/kami/maven/internal/loop"
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 	"github.com/kami/maven/internal/store"
 )
@@ -36,10 +35,10 @@ func (h *reactiveHandler) resolveAck(ctx context.Context, text string, src turnS
 	}
 	if err := h.api.ResolveNudge(ctx, target.ID, store.NudgeActed, now); err != nil {
 		log.Printf("voice: ack nudge %d (%s, %s): %v", target.ID, target.Rule, src, err)
-		return phraser.Ack(phraser.FailAck, nil), true
+		return "не получилось отметить.", true
 	}
 	log.Printf("voice: acked nudge %d (rule %s) from %s", target.ID, target.Rule, src)
-	return phraser.Ack(phraser.AckNudge, nil), true
+	return "отлично, отметила.", true
 }
 
 // ackFromFact — post-action hook, called once the turn's decision has been

cmd/mavend/actions.go

@@ -40,7 +40,6 @@ import (
 	"context"
 	"log"
 
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 )
 
@@ -59,14 +58,10 @@ func (h *reactiveHandler) actionChat(ctx context.Context, dec router.Decision) s
 	// Conversational: build history from dialogue session (prior user turns)
 	// and let the LLM respond from general knowledge + context.
 	history := h.chatHistory()
-	// The phraser hands back its own fallback text alongside the error, so the
-	// turn survives a dead server and the failure still reaches the log.
 	reply, err := h.phraser.PhraseChat(ctx, dec.Utterance, history)
 	if err != nil {
 		log.Printf("voice: chat: %v", err)
-	}
-	if reply == "" {
-		return phraser.ChatFallback()
+		return "поговорили."
 	}
 	return reply
 }

cmd/mavend/actions_fact.go

@@ -6,7 +6,6 @@ import (
 	"strconv"
 
 	"github.com/kami/maven/internal/ipc"
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 	"github.com/kami/maven/internal/store"
 )
@@ -15,7 +14,7 @@ import (
 // it for recall, and let pattern detection propose a routine.
 func (h *reactiveHandler) actionFact(ctx context.Context, dec router.Decision) string {
 	if !dec.Slots.HasKey {
-		return phraser.Ack(phraser.FailFactUnparsed, nil)
+		return "не разобрала, что записать — попробуй иначе."
 	}
 	// A question is never a fact about him (#470). "какая последняя версия
 	// языка Go?" used to land here, and the value stored was whatever the
@@ -63,7 +62,7 @@ func (h *reactiveHandler) actionFact(ctx context.Context, dec router.Decision) s
 	factID, err := h.api.WriteFact(ctx, req)
 	if err != nil {
 		log.Printf("voice: write fact: %v", err)
-		return phraser.Ack(phraser.FailFact, nil)
+		return "не получилось сохранить факт."
 	}
 	// Index the fact in long-term memory (best-effort, must not fail the fact
 	// write). Facts aren't in the notes table, so this is the only recall path

cmd/mavend/actions_note.go

@@ -5,7 +5,6 @@ import (
 	"log"
 	"strconv"
 
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 )
 
@@ -24,13 +23,13 @@ func (h *reactiveHandler) actionNote(ctx context.Context, dec router.Decision) s
 	vec, err := router.EmbedPassage(ctx, h.embedder, dec.Utterance)
 	if err != nil {
 		log.Printf("voice: embed note: %v", err)
-		return phraser.Ack(phraser.FailNote, nil)
+		return "не получилось сохранить заметку."
 	}
 	noteTs := h.now()
 	noteID, err := h.api.WriteNote(ctx, noteTs, dec.Utterance, vec, "tap:voice")
 	if err != nil {
 		log.Printf("voice: write note: %v", err)
-		return phraser.Ack(phraser.FailNote, nil)
+		return "не получилось сохранить заметку."
 	}
 	// Insert into long-term memory (best-effort, must not fail the note write).
 	// text/ts in the meta make a Search hit self-describing (see bestRecall).

cmd/mavend/actions_query.go

@@ -445,13 +445,7 @@ func (h *reactiveHandler) queryMemory(ctx context.Context, t *queryTurn) (string
 	// A note is phrased in Maven's voice; a fact is read back as it was
 	// stored.
 	if hit.Meta["type"] == "note" {
-		reply, perr := h.phraser.PhraseQuery(ctx, t.dec.Utterance, []string{text})
-		switch {
-		case perr != nil:
-			// Reading the note back verbatim beats the phraser's own fallback,
-			// which only wraps the same text in "вот что я нашла:".
-			log.Printf("voice: recall phrase: %v", perr)
-		case reply != "":
+		if reply, perr := h.phraser.PhraseQuery(ctx, t.dec.Utterance, []string{text}); perr == nil && reply != "" {
 			return reply, true
 		}
 	}
@@ -798,7 +792,7 @@ func (h *reactiveHandler) queryGeneral(ctx context.Context, t *queryTurn) (strin
 	reply, err := h.phraseWorld(ctx, t.dec.Utterance, nil)
 	if errors.Is(err, phraser.ErrNoWorldModel) {
 		log.Printf("voice: %q needs the world model and it is not available", t.dec.Utterance)
-		return worldGap(), true
+		return worldGap, true
 	}
 	if err != nil || reply == "" {
 		return "не знаю.", true

cmd/mavend/actions_reminder.go

@@ -4,7 +4,6 @@ import (
 	"context"
 	"log"
 
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 )
 
@@ -22,13 +21,13 @@ func (h *reactiveHandler) actionReminder(ctx context.Context, dec router.Decisio
 			}
 		}
 		if !dec.Slots.HasTime {
-			return phraser.Ack(phraser.FailReminderTime, nil)
+			return "не получилось разобрать время напоминания."
 		}
 	}
 	payload := `{"text":` + jsonString(dec.Utterance) + `}`
 	if _, err := h.api.CreateReminder(ctx, dec.Slots.Time, payload, ""); err != nil {
 		log.Printf("voice: create reminder: %v", err)
-		return phraser.Ack(phraser.FailReminder, nil)
+		return "не получилось поставить напоминание."
 	}
 	return ""
 }

cmd/mavend/actions_task.go

@@ -5,7 +5,6 @@ import (
 	"log"
 
 	"github.com/kami/maven/internal/ipc"
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 	"github.com/kami/maven/internal/store"
 	"github.com/kami/maven/internal/tasks"
@@ -41,18 +40,18 @@ func (h *reactiveHandler) captureTaskFromNote(ctx context.Context, dec router.De
 	})
 	if err != nil {
 		log.Printf("voice: capture task: %v", err)
-		return phraser.Ack(phraser.FailTask, nil), true
+		return "не получилось записать задачу.", true
 	}
 	if resp.Promoted {
 		// It was a candidate Maven derived from something she read, and he has
 		// now said it himself. Saying "уже в списке" here would be answering a
 		// confirmation with a shrug.
-		return phraser.Ack(phraser.AckTaskUrgent, map[string]string{"text": cap.Text}), true
+		return "поняла, беру в работу: " + cap.Text, true
 	}
 	if !resp.Created {
-		return phraser.Ack(phraser.AckTaskDuplicate, nil), true
+		return "это уже в списке.", true
 	}
-	return phraser.Ack(phraser.AckTask, map[string]string{"text": cap.Text}), true
+	return "записала: " + cap.Text, true
 }
 
 // queryTasks — "какие у меня задачи?", "что мне нужно сделать?".

cmd/mavend/actions_task_test.go

@@ -8,7 +8,6 @@ import (
 	"time"
 
 	"github.com/kami/maven/internal/ipc"
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 )
 
@@ -109,7 +108,7 @@ func TestCaptureTaskFromNoteReportsStoreFailure(t *testing.T) {
 	if !ok {
 		t.Fatal("a failed capture still claims the turn — the note path must not double-write")
 	}
-	if !phraser.IsAck(phraser.FailTask, nil, reply) {
+	if !strings.Contains(reply, "не получилось") {
 		t.Errorf("reply = %q, want an honest failure", reply)
 	}
 }

cmd/mavend/clarify_test.go

@@ -465,3 +465,39 @@ func TestExpiryNoticeSurvivesAConfirmTurn(t *testing.T) {
 		t.Fatal("the expired question must be gone")
 	}
 }
+
+// The other half of the subject question: his answer must fill the empty slot,
+// not replace the request. Slots.Text used to be the whole raw utterance for
+// every intent, so the branch that fills a text slot could only ever overwrite
+// (Vikunja #383). Here the parked request holds the hour and the answer holds
+// what to say at it, and the reminder that lands has both.
+func TestClarifySubjectAnswerFillsRatherThanClobbers(t *testing.T) {
+	ctx := context.Background()
+	h, st, _ := newClarifyHandler(t)
+	at := h.now().Add(2 * time.Hour)
+
+	question, asked := h.askClarify(clarifyDec(router.IntentReminder,
+		router.Slots{Time: at, HasTime: true}, "напомни в 11"))
+	if !asked || question != "О чём напомнить?" {
+		t.Fatalf("expected the subject question, got %q asked=%v", question, asked)
+	}
+
+	reply, handled := h.resolveClarifyAnswer(ctx, "позвонить маме")
+	if !handled {
+		t.Fatal("the answer to an open question must be consumed as an answer")
+	}
+	if reply == clarifyGaveUp {
+		t.Fatalf("a good answer must not drop the request: %q", reply)
+	}
+
+	reminders, err := st.DueReminders(ctx, h.now().Add(48*time.Hour))
+	if err != nil || len(reminders) != 1 {
+		t.Fatalf("clarified reminder was not created: reminders=%v err=%v", reminders, err)
+	}
+	if !strings.Contains(reminders[0].Payload, "маме") {
+		t.Fatalf("the answer never reached the reminder: %q", reminders[0].Payload)
+	}
+	if !strings.Contains(reminders[0].Payload, "11") {
+		t.Fatalf("the answer clobbered the original request: %q", reminders[0].Payload)
+	}
+}

cmd/mavend/query_recall_test.go

@@ -121,8 +121,8 @@ func TestQueryRecallNoteCanWin(t *testing.T) {
 			{text: "выучил пару аккордов", score: 0.50, kind: "note"},
 		})
 		reply := askQuery(t, h, q)
-		if !phraser.IsSourcesFallback(reply, "молоко стоит в холодильнике") {
-			t.Errorf("reply %q, want the note read back", reply)
+		if want := "вот что я нашла: молоко стоит в холодильнике"; reply != want {
+			t.Errorf("reply %q, want %q", reply, want)
 		}
 		// One text, the winning memory's — the answer came from the memory
 		// pass, not from handing the phraser every note in the table.
@@ -151,7 +151,7 @@ func TestQueryRecallNoteCanWin(t *testing.T) {
 			{text: "молоко стоит в холодильнике", score: 0.860, kind: "note"},
 			{text: "молоко закончилось", score: 0.858, kind: "note"},
 		})
-		if reply := askQuery(t, h, q); !phraser.IsUnknownFallback(reply) {
+		if reply := askQuery(t, h, q); reply != "не знаю." {
 			t.Errorf("reply %q, want silence", reply)
 		}
 	})

cmd/mavend/quiet_toggle.go

@@ -11,7 +11,6 @@ import (
 	"unicode"
 
 	"github.com/kami/maven/internal/ipc"
-	"github.com/kami/maven/internal/phraser"
 )
 
 // resolveQuietToggle — pre-route keyword check. Returns (reply, true) when
@@ -33,10 +32,10 @@ func (h *reactiveHandler) resolveQuietToggle(ctx context.Context, text string, s
 		return "", false
 	}
 	val := "false"
-	reply := phraser.Ack(phraser.AckQuietOff, nil)
+	reply := "тихий режим выключен."
 	if on {
 		val = "true"
-		reply = phraser.Ack(phraser.AckQuietOn, nil)
+		reply = "тихий режим включён. буду реже напоминать."
 	}
 	if _, err := h.api.WriteFact(ctx, ipc.WriteFactReq{
 		Ts:         h.now(),
@@ -47,7 +46,7 @@ func (h *reactiveHandler) resolveQuietToggle(ctx context.Context, text string, s
 		Confidence: 1.0,
 	}); err != nil {
 		log.Printf("voice: write quiet_hours: %v", err)
-		return phraser.Ack(phraser.FailQuiet, nil), true
+		return "не получилось переключить тихий режим.", true
 	}
 	return reply, true
 }

cmd/mavend/replier_llm_test.go

@@ -5,7 +5,6 @@ import (
 	"testing"
 
 	"github.com/kami/maven/internal/llm"
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/router"
 	"github.com/kami/maven/internal/voice"
 )
@@ -30,12 +29,12 @@ func TestLLMReplierPassesTheModelReplyThrough(t *testing.T) {
 
 func TestLLMReplierFallsBackToStubOnError(t *testing.T) {
 	r := newLLMReplier(stubCompleter{err: errReplierTest}, nil)
-	assertAck(t, r, router.Decision{Intent: router.IntentNote}, phraser.AckNote, "llm error")
+	assertStub(t, r, router.Decision{Intent: router.IntentNote}, "llm error")
 }
 
 func TestLLMReplierFallsBackToStubOnEmpty(t *testing.T) {
 	r := newLLMReplier(stubCompleter{out: ""}, nil)
-	assertAck(t, r, router.Decision{Intent: router.IntentNote}, phraser.AckNote, "empty llm")
+	assertStub(t, r, router.Decision{Intent: router.IntentNote}, "empty llm")
 }
 
 func TestLLMReplierClarifyUsesStub(t *testing.T) {
@@ -43,16 +42,6 @@ func TestLLMReplierClarifyUsesStub(t *testing.T) {
 	assertStub(t, r, router.Decision{Clarify: true}, "clarify")
 }
 
-// assertAck — the stub picks between variants now, so two calls to it are not
-// expected to match. What must hold is that the reply is a line that entry can
-// produce, which is the same claim without pinning one wording.
-func assertAck(t *testing.T, r *llmReplier, d router.Decision, key, what string) {
-	t.Helper()
-	if got := r.Reply(d); !phraser.IsAck(key, nil, got) {
-		t.Errorf("on %s: got %q, want a %q line", what, got, key)
-	}
-}
-
 func assertStub(t *testing.T, r *llmReplier, d router.Decision, what string) {
 	t.Helper()
 	got, want := r.Reply(d), voice.NewStubReplier().Reply(d)

cmd/mavend/snooze.go

@@ -11,7 +11,6 @@ import (
 	"time"
 
 	"github.com/kami/maven/internal/ipc"
-	"github.com/kami/maven/internal/phraser"
 	"github.com/kami/maven/internal/store"
 )
 
@@ -52,10 +51,10 @@ func (h *reactiveHandler) resolveSnooze(ctx context.Context, text string, src tu
 	}
 	if err := h.api.ResolveNudge(ctx, target.ID, store.NudgeSnoozed, now); err != nil {
 		log.Printf("voice: snooze nudge %d (%s, %s): %v", target.ID, target.Rule, src, err)
-		return phraser.Ack(phraser.FailSnooze, nil), true
+		return "не получилось отложить.", true
 	}
 	log.Printf("voice: snoozed nudge %d (rule %s) from %s", target.ID, target.Rule, src)
-	return phraser.Ack(phraser.AckSnooze, nil), true
+	return "хорошо, вернусь к этому позже.", true
 }
 
 // pendingNudge — the newest still-pending nudge sent inside snoozeWindow.

cmd/mavend/worldmodel.go

@@ -23,11 +23,7 @@ type worldPhraser interface {
 // question about his meeting came back as a swimming competition in Nottingham.
 // Naming the gap is the rule CLAUDE.md already applies to a sibling service
 // being down.
-//
-// The wording lives in fallbacks_ru_v1.json and is fixed there, not picked from
-// variants: this sentence names one specific gap and must not drift into a
-// general "I don't know".
-func worldGap() string { return phraser.WorldGap() }
+const worldGap = "сейчас не могу ответить — большая модель недоступна, а придумывать не хочу."
 
 // phraseWorld asks the world model, or reports the gap.
 //
@@ -58,11 +54,7 @@ func (h *reactiveHandler) phraseSource(ctx context.Context, name, utterance stri
 		log.Printf("voice: %s: no world model, reading the source back instead", name)
 		return ""
 	case err != nil:
-		// The resident phraser answers this call with its fallback text and the
-		// error together. Drop the text: these callers hold the passage itself
-		// and read it back better than "вот что я нашла: <passage>" does.
 		log.Printf("voice: %s: phrase: %v", name, err)
-		return ""
 	}
 	return reply
 }

cmd/mavend/worldmodel_test.go

@@ -35,7 +35,7 @@ func TestQueryGeneralNamesTheGap(t *testing.T) {
 	if !ok {
 		t.Fatal("queryGeneral passed on the last source in the chain")
 	}
-	if reply != worldGap() {
+	if reply != worldGap {
 		t.Fatalf("reply = %q, want the named gap", reply)
 	}
 	if g.worldCalls != 1 {
@@ -51,7 +51,7 @@ func TestQueryGeneralWithoutAWorldModelIsUnchanged(t *testing.T) {
 	if !ok {
 		t.Fatal("queryGeneral passed on the last source in the chain")
 	}
-	if !phraser.IsUnknownFallback(reply) {
+	if reply != "не знаю." {
 		t.Fatalf("reply = %q, want the Stub's answer", reply)
 	}
 }
@@ -61,12 +61,12 @@ func TestQueryGeneralWithoutAWorldModelIsUnchanged(t *testing.T) {
 // English in it.
 func TestWorldGapIsInPersona(t *testing.T) {
 	for _, bad := range []string{"вы", "ваш", "рад ", "дорогой", "милый"} {
-		if strings.Contains(worldGap(), bad) {
-			t.Errorf("the gap phrase contains %q: %s", bad, worldGap())
+		if strings.Contains(worldGap, bad) {
+			t.Errorf("the gap phrase contains %q: %s", bad, worldGap)
 		}
 	}
-	if strings.ContainsAny(worldGap(), "abcdefghijklmnopqrstuvwxyz") {
-		t.Errorf("the gap phrase has Latin letters in it: %s", worldGap())
+	if strings.ContainsAny(worldGap, "abcdefghijklmnopqrstuvwxyz") {
+		t.Errorf("the gap phrase has Latin letters in it: %s", worldGap)
 	}
 }
 

cmd/mavgpud/runner.go

@@ -24,7 +24,12 @@ type runner struct {
 	mu    sync.Mutex
 	cmd   *exec.Cmd
 	ready bool
-	http  *http.Client
+	// yielding — stop() has sent the signal and the exit that follows is ours.
+	// llama-server aborts on SIGTERM (its static teardown throws, upstream
+	// ggml-org/llama.cpp), so a routine yield and a real crash produce the same
+	// "signal: aborted" and used to log identically (Vikunja #491).
+	yielding bool
+	http     *http.Client
 }
 
 func newRunner(bin string, args []string, readyURL string) *runner {
@@ -70,13 +75,18 @@ func (r *runner) start() error {
 	if err := cmd.Start(); err != nil {
 		return err
 	}
-	r.cmd, r.ready = cmd, false
+	r.cmd, r.ready, r.yielding = cmd, false, false
 	log.Printf("mavgpud: started llama-server pid=%d", cmd.Process.Pid)
 	go func() {
 		err := cmd.Wait()
 		r.mu.Lock()
-		r.cmd, r.ready = nil, false
+		yielded := r.yielding
+		r.cmd, r.ready, r.yielding = nil, false, false
 		r.mu.Unlock()
+		if yielded {
+			log.Printf("mavgpud: llama-server stopped, card yielded (%v)", err)
+			return
+		}
 		log.Printf("mavgpud: llama-server exited: %v", err)
 	}()
 	return nil
@@ -90,6 +100,10 @@ func (r *runner) stop(grace time.Duration) {
 	r.mu.Lock()
 	cmd := r.cmd
 	r.ready = false
+	if cmd != nil && cmd.Process != nil {
+		// The exit that follows is ours, not a crash.
+		r.yielding = true
+	}
 	r.mu.Unlock()
 	if cmd == nil || cmd.Process == nil {
 		return

cmd/mavgpud/runner_test.go

@@ -0,0 +1,59 @@
+package main
+
+import (
+	"os"
+	"path/filepath"
+	"testing"
+	"time"
+)
+
+// fakeServer writes an executable standing in for llama-server: it ignores
+// SIGTERM the way the real one effectively does — by dying messily rather than
+// cleanly — and reports a non-zero status.
+func fakeServer(t *testing.T, body string) string {
+	t.Helper()
+	path := filepath.Join(t.TempDir(), "fake-llama-server")
+	if err := os.WriteFile(path, []byte("#!/bin/sh\n"+body+"\n"), 0o755); err != nil {
+		t.Fatal(err)
+	}
+	return path
+}
+
+// A deliberate stop is a yield, and the log has to say so.
+//
+// llama-server aborts inside its own static teardown on SIGTERM, so the exit
+// status of a routine yield is identical to that of a real crash. Reading the
+// mavgpud log, the two were indistinguishable (Vikunja #491).
+func TestStopMarksTheExitAsAYield(t *testing.T) {
+	r := newRunner(fakeServer(t, "while : ; do sleep 1 ; done"), nil, "")
+	if err := r.start(); err != nil {
+		t.Fatalf("start: %v", err)
+	}
+	r.mu.Lock()
+	if r.yielding {
+		t.Error("a freshly started server is already marked as yielding")
+	}
+	r.mu.Unlock()
+
+	r.stop(2 * time.Second)
+	deadline := time.Now().Add(2 * time.Second)
+	for time.Now().Before(deadline) {
+		if !r.running() {
+			return
+		}
+		time.Sleep(10 * time.Millisecond)
+	}
+	t.Fatal("the child outlived stop")
+}
+
+// Stopping when nothing is running must not arm the flag for the next child.
+// The next exit after that would be a real crash logged as a yield.
+func TestStopWithNoChildDoesNotArmTheFlag(t *testing.T) {
+	r := newRunner("/nonexistent", nil, "")
+	r.stop(10 * time.Millisecond)
+	r.mu.Lock()
+	defer r.mu.Unlock()
+	if r.yielding {
+		t.Error("stop armed the yield flag with no child running")
+	}
+}

deploy/mavgpud.service

@@ -19,6 +19,10 @@ RestartSec=5
 # llama-server on SIGTERM, so give it longer than stop_grace to do that.
 KillSignal=SIGTERM
 TimeoutStopSec=60
+# llama-server aborts inside its own static teardown on SIGTERM, so every
+# routine yield used to write a multi-gigabyte core into systemd-coredump
+# (Vikunja #491). Yielding is meant to happen several times a day.
+LimitCORE=0
 
 [Install]
 WantedBy=default.target

internal/phraser/ack_ru_v1.json

@@ -1,84 +0,0 @@
-{
-  "schema_version": 1,
-  "name": "russian capture acknowledgements v1",
-  "notes": [
-    "What she says after storing something he said, and what she says when storing it failed. Edit the wording here, no Go changes needed.",
-    "Rules: she is feminine about herself, he is a man addressed as ты. Never вы/вас/ваш, never он/его about him. No pet names.",
-    "He hears these many times a day, so most entries carry variants: identical wording is what makes a confirmation stop registering as one.",
-    "Placeholders: {key} {value} the fact he stated, {fn} the action, {text} the task title. His data is interpolated Go-side — the file holds the frame, never his words.",
-    "An acknowledgement confirms and stops. It does not ask a follow-up question and it does not editorialise about what he stored."
-  ],
-  "entries": {
-    "ack_fact": {
-      "variants": ["записала факт.", "записала.", "запомнила."]
-    },
-    "ack_fact_key": {
-      "variants": ["отметила: {key}", "записала: {key}", "запомнила: {key}"]
-    },
-    "ack_fact_kv": {
-      "variants": ["отметила: {key} = {value}", "записала: {key} — {value}", "запомнила: {key} — {value}"]
-    },
-    "ack_note": {
-      "variants": ["сохранила заметку.", "заметка сохранена.", "записала в заметки."]
-    },
-    "ack_reminder": {
-      "variants": ["напомню.", "напомню, не забуду.", "хорошо, напомню."]
-    },
-    "ack_act": {
-      "variants": ["ок, записала действие: {fn}", "приняла действие: {fn}"]
-    },
-    "ack_task": {
-      "variants": ["записала: {text}", "добавила в задачи: {text}", "внесла в список: {text}"]
-    },
-    "ack_task_urgent": {
-      "variants": ["поняла, беру в работу: {text}", "поняла, это срочно: {text}"]
-    },
-    "ack_task_duplicate": {
-      "variants": ["это уже в списке.", "такое уже есть в задачах."]
-    },
-    "ack_nudge": {
-      "variants": ["отлично, отметила.", "отметила.", "хорошо, отметила."]
-    },
-    "ack_snooze": {
-      "variants": ["хорошо, вернусь к этому позже.", "ладно, напомню попозже.", "хорошо, отложила."]
-    },
-    "ack_generic": {
-      "variants": ["приняла.", "поняла."]
-    },
-    "quiet_on": {
-      "fixed": true,
-      "variants": ["тихий режим включён. буду реже напоминать."]
-    },
-    "quiet_off": {
-      "fixed": true,
-      "variants": ["тихий режим выключен."]
-    },
-    "fail_fact": {
-      "variants": ["не получилось сохранить факт.", "факт не сохранился."]
-    },
-    "fail_note": {
-      "variants": ["не получилось сохранить заметку.", "заметка не сохранилась."]
-    },
-    "fail_reminder": {
-      "variants": ["не получилось поставить напоминание.", "напоминание не поставилось."]
-    },
-    "fail_reminder_time": {
-      "variants": ["не получилось разобрать время напоминания.", "не поняла, на когда напомнить."]
-    },
-    "fail_task": {
-      "variants": ["не получилось записать задачу.", "задача не записалась."]
-    },
-    "fail_ack": {
-      "variants": ["не получилось отметить.", "не смогла отметить."]
-    },
-    "fail_snooze": {
-      "variants": ["не получилось отложить.", "не смогла отложить."]
-    },
-    "fail_quiet": {
-      "variants": ["не получилось переключить тихий режим.", "тихий режим не переключился."]
-    },
-    "fail_fact_unparsed": {
-      "variants": ["не разобрала, что записать — попробуй иначе.", "не поняла, что записать. скажи иначе?"]
-    }
-  }
-}

internal/phraser/acks.go

@@ -1,162 +0,0 @@
-package phraser
-
-// The capture acknowledgements — what she says after storing something he said,
-// and what she says when storing it failed.
-//
-// They were string literals in eight files under cmd/mavend plus the stub
-// replier in internal/voice. He hears them many times a day, which is exactly
-// why they need variants and exactly why rewording one must not be a rebuild.
-// Same shape as fallbacks_ru_v1.json, on the shared deck (deck.go).
-//
-// His data stays Go-side. The file holds "отметила: {key} = {value}"; the key
-// and the value are interpolated here, so nothing he said lives in the copy.
-
-import (
-	_ "embed"
-	"log"
-	"math/rand"
-	"sync"
-)
-
-//go:embed ack_ru_v1.json
-var ackJSON []byte
-
-// AckSchemaVersion — this family's own version. A file that changes on a
-// different day than the fallbacks cannot share their number (Vikunja #397).
-const AckSchemaVersion = 1
-
-// The entry keys. Namespaced by family, because the floor map behind a nil deck
-// is process-wide.
-const (
-	AckFact          = "ack_fact"
-	AckFactKey       = "ack_fact_key"
-	AckFactValue     = "ack_fact_kv"
-	AckNote          = "ack_note"
-	AckReminder      = "ack_reminder"
-	AckAct           = "ack_act"
-	AckTask          = "ack_task"
-	AckTaskUrgent    = "ack_task_urgent"
-	AckTaskDuplicate = "ack_task_duplicate"
-	AckNudge         = "ack_nudge"
-	AckSnooze        = "ack_snooze"
-	AckGeneric       = "ack_generic"
-	AckQuietOn       = "quiet_on"
-	AckQuietOff      = "quiet_off"
-
-	FailFact         = "fail_fact"
-	FailFactUnparsed = "fail_fact_unparsed"
-	FailNote         = "fail_note"
-	FailReminder     = "fail_reminder"
-	FailReminderTime = "fail_reminder_time"
-	FailTask         = "fail_task"
-	FailAck          = "fail_ack"
-	FailSnooze       = "fail_snooze"
-	FailQuiet        = "fail_quiet"
-)
-
-// ackKeys — every key the code requires the file to define.
-var ackKeys = []string{
-	AckFact, AckFactKey, AckFactValue, AckNote, AckReminder, AckAct,
-	AckTask, AckTaskUrgent, AckTaskDuplicate, AckNudge, AckSnooze, AckGeneric,
-	AckQuietOn, AckQuietOff,
-	FailFact, FailFactUnparsed, FailNote, FailReminder, FailReminderTime,
-	FailTask, FailAck, FailSnooze, FailQuiet,
-}
-
-// ackFloor — the literal each key falls back to when the file is unusable.
-// These are the exact strings that lived in Go before this file existed.
-var ackFloor = registerFloor(map[string]string{
-	AckFact:          "записала факт.",
-	AckFactKey:       "отметила: {key}",
-	AckFactValue:     "отметила: {key} = {value}",
-	AckNote:          "сохранила заметку.",
-	AckReminder:      "напомню.",
-	AckAct:           "ок, записала действие: {fn}",
-	AckTask:          "записала: {text}",
-	AckTaskUrgent:    "поняла, беру в работу: {text}",
-	AckTaskDuplicate: "это уже в списке.",
-	AckNudge:         "отлично, отметила.",
-	AckSnooze:        "хорошо, вернусь к этому позже.",
-	AckGeneric:       "приняла.",
-	AckQuietOn:       "тихий режим включён. буду реже напоминать.",
-	AckQuietOff:      "тихий режим выключен.",
-
-	FailFact:         "не получилось сохранить факт.",
-	FailFactUnparsed: "не разобрала, что записать — попробуй иначе.",
-	FailNote:         "не получилось сохранить заметку.",
-	FailReminder:     "не получилось поставить напоминание.",
-	FailReminderTime: "не получилось разобрать время напоминания.",
-	FailTask:         "не получилось записать задачу.",
-	FailAck:          "не получилось отметить.",
-	FailSnooze:       "не получилось отложить.",
-	FailQuiet:        "не получилось переключить тихий режим.",
-})
-
-// Acks picks a hand-written Russian acknowledgement. Safe for concurrent use.
-type Acks struct{ d *deck }
-
-// LoadAcks reads the embedded file. Pass a source to make the picking
-// reproducible in tests; nil seeds from the clock.
-func LoadAcks(src rand.Source) (*Acks, error) {
-	d, err := loadDeck(ackJSON, AckSchemaVersion, ackKeys, ackFloor, src)
-	if err != nil {
-		return nil, err
-	}
-	// The three entries that exist to read his own words back. A variant
-	// without the placeholder would confirm the capture and drop what was
-	// captured, which reads as a successful save of nothing.
-	for _, req := range []struct{ key, ph string }{
-		{AckFactKey, "{key}"}, {AckFactValue, "{key}"}, {AckFactValue, "{value}"},
-		{AckAct, "{fn}"}, {AckTask, "{text}"}, {AckTaskUrgent, "{text}"},
-	} {
-		if err := d.requirePlaceholder(req.key, req.ph); err != nil {
-			return nil, err
-		}
-	}
-	return &Acks{d: d}, nil
-}
-
-// deck reads through a nil *Acks, which is the unloadable-file case.
-func (a *Acks) deck() *deck {
-	if a == nil {
-		return nil
-	}
-	return a.d
-}
-
-// Say returns one line for key, with his data filled into the frame. Pass nil
-// when the entry takes none.
-func (a *Acks) Say(key string, vars map[string]string) string {
-	return a.deck().text(key, vars)
-}
-
-// Variants returns every line the file can produce, for the persona scorer.
-func (a *Acks) Variants() []string { return a.deck().variants() }
-
-var (
-	ackOnce sync.Once
-	acks    *Acks
-)
-
-// DefaultAcks returns the shared instance, loading it on first use. A broken
-// file logs once and leaves a nil *Acks, which still answers from ackFloor.
-func DefaultAcks() *Acks {
-	ackOnce.Do(func() {
-		a, err := LoadAcks(nil)
-		if err != nil {
-			log.Printf("phraser: acknowledgements unavailable, using the built-in lines: %v", err)
-			return
-		}
-		acks = a
-	})
-	return acks
-}
-
-// Ack — one acknowledgement line, the way every caller says it.
-func Ack(key string, vars map[string]string) string { return DefaultAcks().Say(key, vars) }
-
-// IsAck reports whether text is a line key could have produced. For the daemon
-// tests, which can no longer compare against one literal.
-func IsAck(key string, vars map[string]string, text string) bool {
-	return DefaultAcks().deck().matches(key, vars, text)
-}

internal/phraser/deck.go

@@ -1,181 +0,0 @@
-package phraser
-
-// deck — the mechanics every family of hand-written Russian lines shares.
-//
-// A family is one embedded JSON file: schema-versioned, several variants per
-// entry, never the same variant twice running, and a hard floor of Go literals
-// under it so a broken file cannot take her words away. fallbacks.go was the
-// first family (Vikunja #501) and acks.go the second, at which point copying
-// eighty lines of loader per family stopped being defensible.
-//
-// What stays per family: the file, the keys, the floor literals, the accessor
-// names, and any validation only that family can state.
-
-import (
-	"encoding/json"
-	"fmt"
-	"math/rand"
-	"strings"
-	"sync"
-	"time"
-)
-
-// deckEntry — one line she can say, in as many wordings as the file gives.
-type deckEntry struct {
-	// Fixed — one variant, never picked between. For wording that must not
-	// drift from turn to turn, like a phrase naming one specific gap.
-	Fixed    bool     `json:"fixed"`
-	Variants []string `json:"variants"`
-}
-
-type deckFile struct {
-	SchemaVersion int                  `json:"schema_version"`
-	Name          string               `json:"name"`
-	Notes         []string             `json:"notes"`
-	Entries       map[string]deckEntry `json:"entries"`
-}
-
-// deck picks a line. Safe for concurrent use. A nil *deck answers from the
-// floor, which is what an unloadable file leaves behind.
-type deck struct {
-	mu    sync.Mutex
-	rnd   *rand.Rand
-	last  map[string]string
-	file  deckFile
-	keys  []string
-	floor map[string]string
-}
-
-// loadDeck parses raw, checks the version and every required key, and seeds the
-// picker. Pass a source to make the picking reproducible in tests; nil seeds
-// from the clock.
-func loadDeck(raw []byte, version int, keys []string, floor map[string]string, src rand.Source) (*deck, error) {
-	var f deckFile
-	if err := json.Unmarshal(raw, &f); err != nil {
-		return nil, fmt.Errorf("parse: %w", err)
-	}
-	if f.SchemaVersion != version {
-		return nil, fmt.Errorf("schema_version %d, want %d", f.SchemaVersion, version)
-	}
-	for _, k := range keys {
-		e, ok := f.Entries[k]
-		if !ok || len(e.Variants) == 0 {
-			return nil, fmt.Errorf("entry %q is missing or empty", k)
-		}
-		if e.Fixed && len(e.Variants) != 1 {
-			return nil, fmt.Errorf("entry %q is fixed but has %d variants", k, len(e.Variants))
-		}
-	}
-	if src == nil {
-		src = rand.NewSource(time.Now().UnixNano())
-	}
-	return &deck{rnd: rand.New(src), last: map[string]string{}, file: f, keys: keys, floor: floor}, nil
-}
-
-// requirePlaceholder fails the load when a variant of key does not use ph. For
-// an entry whose whole job is to read something back, a variant without the
-// placeholder silently drops it.
-func (d *deck) requirePlaceholder(key, ph string) error {
-	for _, v := range d.file.Entries[key].Variants {
-		if !strings.Contains(v, ph) {
-			return fmt.Errorf("%q variant %q does not use %s", key, v, ph)
-		}
-	}
-	return nil
-}
-
-// text returns one variant for key with the placeholders filled in. A nil
-// receiver answers from the floor, so no caller checks whether the file loaded.
-func (d *deck) text(key string, vars map[string]string) string {
-	tmpl := ""
-	if d != nil {
-		if e, ok := d.file.Entries[key]; ok && len(e.Variants) > 0 {
-			tmpl = d.pick(key, e)
-		}
-	}
-	if tmpl == "" {
-		tmpl = floorOf(d, key)
-	}
-	return fill(tmpl, vars)
-}
-
-// matches reports whether text is a line key could have produced. A caller that
-// has to recognise one of these lines cannot compare against a literal any more.
-func (d *deck) matches(key string, vars map[string]string, text string) bool {
-	if fill(floorOf(d, key), vars) == text {
-		return true
-	}
-	if d == nil {
-		return false
-	}
-	for _, v := range d.file.Entries[key].Variants {
-		if fill(v, vars) == text {
-			return true
-		}
-	}
-	return false
-}
-
-// variants returns every line the file can produce, in key order, for the
-// persona scorer. Stable order so a failure names the same variant twice.
-func (d *deck) variants() []string {
-	if d == nil {
-		return nil
-	}
-	var out []string
-	for _, k := range d.keys {
-		out = append(out, d.file.Entries[k].Variants...)
-	}
-	return out
-}
-
-// pick chooses at random, skipping whatever this entry said last time.
-func (d *deck) pick(key string, e deckEntry) string {
-	d.mu.Lock()
-	defer d.mu.Unlock()
-
-	choices := e.Variants
-	if len(choices) > 1 {
-		fresh := make([]string, 0, len(choices))
-		for _, v := range choices {
-			if v != d.last[key] {
-				fresh = append(fresh, v)
-			}
-		}
-		if len(fresh) > 0 {
-			choices = fresh
-		}
-	}
-	got := choices[d.rnd.Intn(len(choices))]
-	d.last[key] = got
-	return got
-}
-
-// floorOf reads the Go literal behind key, and works on a nil deck because that
-// is exactly the case it exists for. The per-family map is the source of truth.
-func floorOf(d *deck, key string) string {
-	if d != nil && d.floor != nil {
-		return d.floor[key]
-	}
-	return deckFloors[key]
-}
-
-// deckFloors — every family's floor literals in one map, so a nil deck still
-// finds them. Families register at init; the keys are namespaced by family.
-var deckFloors = map[string]string{}
-
-func registerFloor(floor map[string]string) map[string]string {
-	for k, v := range floor {
-		deckFloors[k] = v
-	}
-	return floor
-}
-
-// fill substitutes {name} for each var. A placeholder with no value is left
-// alone rather than blanked, so a missing value is visible instead of silent.
-func fill(tmpl string, vars map[string]string) string {
-	for k, v := range vars {
-		tmpl = strings.ReplaceAll(tmpl, "{"+k+"}", v)
-	}
-	return tmpl
-}

internal/phraser/eval/fallbacks_test.go

@@ -1,47 +0,0 @@
-package eval
-
-import (
-	"math/rand"
-	"strings"
-	"testing"
-
-	"github.com/kami/maven/internal/phraser"
-)
-
-// TestFallbackPersona scores every line in fallbacks_ru_v1.json and
-// ack_ru_v1.json on the persona checks the nudges already pass. These lines are
-// heard out loud and they live in a JSON file now, so a reworded variant that
-// says "рад" or "вы" would otherwise reach him with nothing in between.
-//
-// Only the persona checks run. Mood and topic belong to a nudge, and these are
-// not nudges.
-func TestFallbackPersona(t *testing.T) {
-	fb, err := phraser.LoadFallbacks(rand.NewSource(20260804))
-	if err != nil {
-		t.Fatalf("LoadFallbacks: %v", err)
-	}
-	persona := map[string]bool{
-		CheckLang: true, CheckFeminine: true, CheckHisGender: true,
-		CheckAddress: true, CheckCringe: true, CheckLength: true,
-	}
-	ack, err := phraser.LoadAcks(rand.NewSource(20260804))
-	if err != nil {
-		t.Fatalf("LoadAcks: %v", err)
-	}
-	variants := append(fb.Variants(), ack.Variants()...)
-	if len(variants) == 0 {
-		t.Fatal("no variants — the file loaded empty")
-	}
-	for _, v := range variants {
-		// The placeholders stand for his own words and carry no persona.
-		body := v
-		for _, ph := range []string{"{sources}", "{key}", "{value}", "{fn}", "{text}"} {
-			body = strings.ReplaceAll(body, ph, "вода")
-		}
-		for _, r := range RunChecks(Case{}, body, "neutral") {
-			if persona[r.Name] && !r.Pass {
-				t.Errorf("%q fails %s: %s", v, r.Name, r.Detail)
-			}
-		}
-	}
-}

internal/phraser/eval/talk.go

@@ -78,12 +78,6 @@ type TalkCase struct {
 	Note      string   `json:"note,omitempty"`
 }
 
-// TalkSchemaVersion — the version this loader understands. Separate from the
-// nudge fixture's SchemaVersion: the two fixtures have different shapes and
-// change on different days, and one shared constant would force a bump on the
-// fixture that did not move.
-const TalkSchemaVersion = 1
-
 // TalkFixture — the versioned envelope, same gating as Fixture.
 type TalkFixture struct {
 	SchemaVersion int        `json:"schema_version"`
@@ -98,8 +92,8 @@ func LoadTalk() (TalkFixture, error) {
 	if err := json.Unmarshal(talkFixtureJSON, &f); err != nil {
 		return TalkFixture{}, fmt.Errorf("parse talk fixture: %w", err)
 	}
-	if f.SchemaVersion != TalkSchemaVersion {
-		return TalkFixture{}, fmt.Errorf("talk fixture schema_version %d, want %d", f.SchemaVersion, TalkSchemaVersion)
+	if f.SchemaVersion != SchemaVersion {
+		return TalkFixture{}, fmt.Errorf("talk fixture schema_version %d, want %d", f.SchemaVersion, SchemaVersion)
 	}
 	if len(f.Cases) == 0 {
 		return TalkFixture{}, fmt.Errorf("talk fixture has no cases")

internal/phraser/eval/talk_test.go

@@ -142,13 +142,19 @@ func TestLLMTalkBaseline(t *testing.T) {
 	p := phraser.NewLLMPhraserAt(base, cfg)
 	defer p.Close()
 
-	// The model id names the run in the report. Since Vikunja #397 every path
-	// returns its errors, so a server that dies mid-run shows up in the Errors
-	// column instead of scoring as bad phrasing — the before-and-after probe that
-	// used to stand in for that is gone.
+	// Unreachable server is fatal here, not a logged warning, and that differs
+	// from the nudge test on purpose. PhraseNudge returns its errors, so a dead
+	// server there shows up honestly in the Errors column. PhraseChat and
+	// PhraseQuery do NOT: they swallow every failure and return a canned string
+	// ("поговорили.", "не знаю.", "вот что я нашла: …"). So on these three paths
+	// a dead server produces a full report with 0 errors and a terrible score —
+	// a number that looks like bad phrasing and is really no phrasing at all.
+	// Refusing to score without a confirmed model is the only guard available
+	// until the phraser reports its failures (Vikunja #397).
 	model, err := llm.ModelID(ctx, base)
 	if err != nil {
-		t.Fatalf("no model at %s: %v", base, err)
+		t.Fatalf("no model at %s: %v — refusing to score, these paths hide their errors "+
+			"and would report a plausible-looking result off a dead server", base, err)
 	}
 	t.Logf("scoring model %s at %s", model, base)
 
@@ -163,11 +169,10 @@ func TestLLMTalkBaseline(t *testing.T) {
 	}
 	t.Log("\n" + rep.String() + "\nreplies:\n" + rep.Replies() + "\nfailures:\n" + rep.Failures())
 
-	// A run where nothing was phrased is not a low score, it is no measurement.
-	if rep.Errors == rep.Total {
-		t.Fatalf("every case errored — nothing was measured, the score above is not a phrasing result")
-	}
-	if rep.Errors > 0 {
-		t.Logf("%d/%d cases errored — those are model failures, not phrasing failures", rep.Errors, rep.Total)
+	// And again afterwards: the run takes minutes, and a server that died or got
+	// OOM-killed halfway through would leave the first cases scored and the rest
+	// silently canned. Checking only at the start would not catch that.
+	if _, err := llm.ModelID(ctx, base); err != nil {
+		t.Fatalf("model at %s went away during the run: %v — the score above is not trustworthy", base, err)
 	}
 }

internal/phraser/failure_test.go

@@ -1,80 +0,0 @@
-package phraser
-
-import (
-	"context"
-	"net/http"
-	"net/http/httptest"
-	"strings"
-	"testing"
-)
-
-// isFallback — the text she says is picked from that entry's variants, so a test
-// pins the entry rather than the wording. Pinning one line would make editing
-// fallbacks_ru_v1.json break Go tests, which is the coupling this file removed.
-func isFallback(t *testing.T, key, sources, got string) bool {
-	t.Helper()
-	return DefaultFallbacks().deck().matches(key, map[string]string{"sources": sources}, got)
-}
-
-// A dead server must be distinguishable from bad phrasing. Both PhraseChat and
-// PhraseQuery keep the turn alive with canned text — and every one of those
-// lines is also a legitimate reply, so the text alone cannot say which happened.
-// The error is the only signal, and before Vikunja #397 it was dropped: the talk
-// scorer reported a full run with zero errors off a server that answered nothing.
-func TestPhrasingReportsTheFailureWithTheFallback(t *testing.T) {
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		http.Error(w, "model not loaded", http.StatusServiceUnavailable)
-	}))
-	t.Cleanup(srv.Close)
-	p := NewLLMPhraserAt(srv.URL, Config{})
-
-	cases := []struct {
-		name    string
-		call    func() (string, error)
-		key     string
-		sources string
-	}{
-		{"chat", func() (string, error) {
-			return p.PhraseChat(context.Background(), "как дела", nil)
-		}, fbChat, ""},
-		{"knowledge", func() (string, error) {
-			return p.PhraseQuery(context.Background(), "кто написал войну и мир", nil)
-		}, fbQueryUnknown, ""},
-		{"evidence", func() (string, error) {
-			return p.PhraseQuery(context.Background(), "сколько воды я выпил", []string{"два литра"})
-		}, fbQuerySources, "два литра"},
-	}
-	for _, c := range cases {
-		t.Run(c.name, func(t *testing.T) {
-			got, err := c.call()
-			if err == nil {
-				t.Fatalf("no error from a dead server; the scorer would count this as bad phrasing")
-			}
-			if !isFallback(t, c.key, c.sources, got) {
-				t.Errorf("fallback text = %q, want a %q variant — the daemon still has to say something", got, c.key)
-			}
-		})
-	}
-}
-
-// An empty answer is a failure too: the server is up and produced no tokens,
-// which is not an answer and must not score as one.
-func TestEmptyKnowledgeAnswerIsAnError(t *testing.T) {
-	srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
-		w.Header().Set("Content-Type", "application/json")
-		w.Write([]byte(`{"choices":[{"message":{"content":""}}]}`))
-	}))
-	t.Cleanup(srv.Close)
-	p := NewLLMPhraserAt(srv.URL, Config{})
-
-	got, err := p.PhraseQuery(context.Background(), "кто написал войну и мир", nil)
-	if err == nil {
-		t.Fatal("an empty response scored as an answer")
-	}
-	if !isFallback(t, fbQueryUnknown, "", got) {
-		t.Errorf("fallback text = %q, want a %q variant", got, fbQueryUnknown)
-	}
-	if !strings.Contains(err.Error(), "empty") {
-		t.Errorf("error = %v; want it to name the empty response", err)
-	}
-}

internal/phraser/fallbacks.go

@@ -1,138 +0,0 @@
-package phraser
-
-// The phrasing fallbacks — what she says when the model gave her nothing usable.
-//
-// They were four string literals spread across phraser.go, llmphraser.go and
-// cmd/mavend/worldmodel.go. Every one of them is a line he hears out loud, so
-// rewording one was a Go edit, a rebuild and a redeploy for what is product copy.
-//
-// The floor under the floor is deliberate. These strings exist because something
-// already failed, so a broken template file must not be able to take the last
-// words she has: every accessor falls back to the literal it replaced.
-
-import (
-	_ "embed"
-	"log"
-	"math/rand"
-	"sync"
-)
-
-//go:embed fallbacks_ru_v1.json
-var fallbackJSON []byte
-
-// FallbackSchemaVersion — the version this code understands. Its own constant,
-// not shared with the nudge templates or the eval fixtures: two files that change
-// on different days cannot be versioned by one number (Vikunja #397).
-const FallbackSchemaVersion = 1
-
-// The entry keys. Every one of them is read by a method below, so a typo in the
-// file is caught at load rather than at the moment she needs the words.
-const (
-	fbChat         = "chat"
-	fbQueryUnknown = "query_unknown"
-	fbQuerySources = "query_sources"
-	fbWorldGap     = "world_gap"
-)
-
-// fbKeys — every key the code requires the file to define.
-var fbKeys = []string{fbChat, fbQueryUnknown, fbQuerySources, fbWorldGap}
-
-// hardFloor — the literal each key falls back to when the file is unusable.
-// These are the exact strings that lived in Go before this file existed.
-var hardFloor = registerFloor(map[string]string{
-	fbChat:         "даже не знаю, что сказать.",
-	fbQueryUnknown: "не знаю.",
-	fbQuerySources: "вот что я нашла: {sources}",
-	fbWorldGap:     "сейчас не могу ответить — большая модель недоступна, а придумывать не хочу.",
-})
-
-// Fallbacks picks a hand-written Russian fallback line. Safe for concurrent use.
-type Fallbacks struct{ d *deck }
-
-// LoadFallbacks reads the embedded file. Pass a source to make the picking
-// reproducible in tests; nil seeds from the clock.
-func LoadFallbacks(src rand.Source) (*Fallbacks, error) {
-	d, err := loadDeck(fallbackJSON, FallbackSchemaVersion, fbKeys, hardFloor, src)
-	if err != nil {
-		return nil, err
-	}
-	// query_sources is the one entry whose whole job is to read something back.
-	if err := d.requirePlaceholder(fbQuerySources, "{sources}"); err != nil {
-		return nil, err
-	}
-	return &Fallbacks{d: d}, nil
-}
-
-// deck reads through a nil *Fallbacks, which is the unloadable-file case.
-func (f *Fallbacks) deck() *deck {
-	if f == nil {
-		return nil
-	}
-	return f.d
-}
-
-// Chat — nothing usable came back on the chat path.
-func (f *Fallbacks) Chat() string { return f.deck().text(fbChat, nil) }
-
-// Unknown — a question she cannot answer and will not guess at.
-func (f *Fallbacks) Unknown() string { return f.deck().text(fbQueryUnknown, nil) }
-
-// FromSources — read back what she was handed, because phrasing it failed.
-func (f *Fallbacks) FromSources(sources string) string {
-	return f.deck().text(fbQuerySources, map[string]string{"sources": sources})
-}
-
-// WorldGap — the world model is the one configured to answer and it is not
-// answering. Fixed wording: it names a specific gap, and a variant set here
-// would let "the big model is asleep" drift into "I don't know".
-func (f *Fallbacks) WorldGap() string { return f.deck().text(fbWorldGap, nil) }
-
-// Variants returns every line the file can produce, for the persona scorer.
-func (f *Fallbacks) Variants() []string { return f.deck().variants() }
-
-// The process-wide instance. Package-level because these lines are needed on
-// paths that have no phraser to hand — cmd/mavend names the world gap without
-// one — and because a template file that is embedded and validated at load has
-// nothing per-instance to configure.
-var (
-	fallbackOnce sync.Once
-	fallbacks    *Fallbacks
-)
-
-// DefaultFallbacks returns the shared instance, loading it on first use. A
-// broken file logs once and leaves a nil *Fallbacks, which still answers from
-// hardFloor — a daemon must not fail to boot over its own copy deck.
-func DefaultFallbacks() *Fallbacks {
-	fallbackOnce.Do(func() {
-		fb, err := LoadFallbacks(nil)
-		if err != nil {
-			log.Printf("phraser: fallbacks unavailable, using the built-in lines: %v", err)
-			return
-		}
-		fallbacks = fb
-	})
-	return fallbacks
-}
-
-// ChatFallback — what she says when the chat path produced nothing.
-func ChatFallback() string { return DefaultFallbacks().Chat() }
-
-// UnknownFallback — what she says when she has no answer and will not invent one.
-func UnknownFallback() string { return DefaultFallbacks().Unknown() }
-
-// SourcesFallback — read the sources back rather than ship a broken fragment.
-func SourcesFallback(sources string) string { return DefaultFallbacks().FromSources(sources) }
-
-// WorldGap — what he hears when the world model is configured and unreachable.
-func WorldGap() string { return DefaultFallbacks().WorldGap() }
-
-// IsUnknownFallback reports whether text is one of her "I do not know" lines.
-// The daemon tests read it to tell an answer from a shrug.
-func IsUnknownFallback(text string) bool {
-	return DefaultFallbacks().deck().matches(fbQueryUnknown, nil, text)
-}
-
-// IsSourcesFallback reports whether text is sources read back verbatim.
-func IsSourcesFallback(text, sources string) bool {
-	return DefaultFallbacks().deck().matches(fbQuerySources, map[string]string{"sources": sources}, text)
-}

internal/phraser/fallbacks_ru_v1.json

@@ -1,42 +0,0 @@
-{
-  "schema_version": 1,
-  "name": "russian phrasing fallbacks v1",
-  "notes": [
-    "What she says when the model gave her nothing usable. Edit the wording here, no Go changes needed.",
-    "Rules: she is feminine about herself, he is a man addressed as ты. Never вы/вас/ваш, never plural imperatives, never он/его about him. No pet names.",
-    "These are heard after a failure, so they stay short and admit the gap. None of them may claim knowledge she does not have.",
-    "Placeholders: {sources} the notes or passages she was handed. A variant whose placeholder has no value is skipped, so every entry needs at least one variant with no placeholder — except query_sources, which exists only to read sources back.",
-    "fixed: true means exactly one variant and no picking. Used where the wording is load-bearing and must not drift between turns."
-  ],
-  "entries": {
-    "chat": {
-      "variants": [
-        "даже не знаю, что сказать.",
-        "не могу найти слов.",
-        "мысль ускользнула, повтори?",
-        "у меня сейчас пусто в голове."
-      ]
-    },
-    "query_unknown": {
-      "variants": [
-        "не знаю.",
-        "не знаю, честно.",
-        "тут я пас.",
-        "не скажу, не знаю."
-      ]
-    },
-    "query_sources": {
-      "variants": [
-        "вот что я нашла: {sources}",
-        "нашла вот это: {sources}",
-        "есть только это: {sources}"
-      ]
-    },
-    "world_gap": {
-      "fixed": true,
-      "variants": [
-        "сейчас не могу ответить — большая модель недоступна, а придумывать не хочу."
-      ]
-    }
-  }
-}

internal/phraser/fallbacks_test.go

@@ -1,74 +0,0 @@
-package phraser
-
-import (
-	"math/rand"
-	"strings"
-	"testing"
-)
-
-// The embedded file must load, or the daemon speaks from hardFloor and nobody
-// finds out until he hears the wrong words.
-func TestFallbacksLoad(t *testing.T) {
-	fb, err := LoadFallbacks(rand.NewSource(1))
-	if err != nil {
-		t.Fatalf("LoadFallbacks: %v", err)
-	}
-	if got := fb.FromSources("два литра"); !strings.Contains(got, "два литра") {
-		t.Errorf("FromSources = %q, want the sources in it", got)
-	}
-	if fb.WorldGap() != hardFloor[fbWorldGap] {
-		t.Errorf("WorldGap = %q, want the fixed wording %q", fb.WorldGap(), hardFloor[fbWorldGap])
-	}
-}
-
-// A broken or missing file must not take her last words away: every accessor
-// answers from the literal it replaced.
-func TestNilFallbacksAnswerFromTheHardFloor(t *testing.T) {
-	var fb *Fallbacks
-	if got := fb.Chat(); got != hardFloor[fbChat] {
-		t.Errorf("Chat = %q, want %q", got, hardFloor[fbChat])
-	}
-	if got := fb.Unknown(); got != hardFloor[fbQueryUnknown] {
-		t.Errorf("Unknown = %q, want %q", got, hardFloor[fbQueryUnknown])
-	}
-	if got := fb.FromSources("два литра"); got != "вот что я нашла: два литра" {
-		t.Errorf("FromSources = %q", got)
-	}
-	if got := fb.WorldGap(); got != hardFloor[fbWorldGap] {
-		t.Errorf("WorldGap = %q", got)
-	}
-}
-
-// Hearing the identical words every time a request fails is how a failure stops
-// registering as one.
-func TestFallbacksDoNotRepeat(t *testing.T) {
-	fb, err := LoadFallbacks(rand.NewSource(7))
-	if err != nil {
-		t.Fatalf("LoadFallbacks: %v", err)
-	}
-	prev := fb.Chat()
-	for i := 0; i < 20; i++ {
-		got := fb.Chat()
-		if got == prev {
-			t.Fatalf("chat repeated %q on turn %d", got, i)
-		}
-		prev = got
-	}
-}
-
-// The acknowledgements load, fill his words into the frame, and answer from the
-// floor when the file is gone.
-func TestAcksLoad(t *testing.T) {
-	a, err := LoadAcks(rand.NewSource(1))
-	if err != nil {
-		t.Fatalf("LoadAcks: %v", err)
-	}
-	got := a.Say(AckFactValue, map[string]string{"key": "вода", "value": "2л"})
-	if !strings.Contains(got, "вода") || !strings.Contains(got, "2л") {
-		t.Errorf("Say(%s) = %q, want his key and value in it", AckFactValue, got)
-	}
-	var nilAcks *Acks
-	if got := nilAcks.Say(AckNote, nil); got != ackFloor[AckNote] {
-		t.Errorf("nil Acks said %q, want the floor %q", got, ackFloor[AckNote])
-	}
-}

internal/phraser/llmphraser.go

@@ -5,7 +5,6 @@ import (
 	"bytes"
 	"context"
 	"encoding/json"
-	"errors"
 	"fmt"
 	"io"
 	"log"
@@ -27,11 +26,6 @@ import (
 
 var listenRE = regexp.MustCompile(`listening on (https?://\S+)`)
 
-// errEmptyResponse — the server answered and said nothing. Separate from a
-// transport failure: the model is up and produced no tokens, which is still not
-// an answer and must not score as one.
-var errEmptyResponse = errors.New("phraser: empty response from the model")
-
 type LLMPhraser struct {
 	cfg    Config
 	client *http.Client
@@ -434,11 +428,8 @@ func (p *LLMPhraser) PhraseNudge(ctx context.Context, c loop.Candidate) (deliver
 }
 
 // PhraseQuery prompts the LLM with the user's utterance and matching notes to
-// compose a natural answer. On any LLM error it returns the fallback text —
-// "вот что я нашла: <notes>", or "не знаю." with no notes — and the error
-// together. The daemon uses the text and keeps the turn alive; a caller that is
-// measuring counts the failure. Until Vikunja #397 the error was dropped, so a
-// dead server scored as bad phrasing.
+// compose a natural answer. Falls back to "вот что я нашла: <notes>" on any
+// LLM error — better to give the raw data than silence.
 func (p *LLMPhraser) PhraseQuery(ctx context.Context, utterance string, notes []string) (string, error) {
 	// Blank sources are no sources. A caller that hands over one empty string —
 	// a page that fetched to nothing, a snippet trimmed away — used to take the
@@ -448,15 +439,13 @@ func (p *LLMPhraser) PhraseQuery(ctx context.Context, utterance string, notes []
 	if len(notes) == 0 {
 		sys, prompt := p.knowledgePrompt(utterance)
 		resp, err := p.chatWithSystem(ctx, sys, prompt, 768)
-		if err != nil {
-			return UnknownFallback(), fmt.Errorf("phrase query (knowledge): %w", err)
-		}
-		if resp == "" {
-			return UnknownFallback(), errEmptyResponse
+		if err != nil || resp == "" {
+			return "не знаю.", nil
 		}
 		text, _, perr := parseResponseMood(resp)
 		if perr != nil {
-			return UnknownFallback(), fmt.Errorf("phrase query (knowledge): %w", perr)
+			log.Printf("phraser: PhraseQuery: %v", perr)
+			return "не знаю.", nil
 		}
 		if text != "" {
 			return text, nil
@@ -468,12 +457,13 @@ func (p *LLMPhraser) PhraseQuery(ctx context.Context, utterance string, notes []
 	text, _, perr := parseResponseMood(resp)
 	if err != nil || perr != nil {
 		// Read the notes out rather than ship a broken fragment.
-		cause := err
-		if cause == nil {
-			cause = perr
+		if perr != nil {
+			log.Printf("phraser: PhraseQuery: %v", perr)
 		}
-		return SourcesFallback(strings.Join(notes, "; ")),
-			fmt.Errorf("phrase query (evidence): %w", cause)
+		if len(notes) == 1 {
+			return "вот что я нашла: " + notes[0], nil
+		}
+		return "вот что я нашла: " + strings.Join(notes, "; "), nil
 	}
 	if text != "" {
 		return text, nil
@@ -482,9 +472,8 @@ func (p *LLMPhraser) PhraseQuery(ctx context.Context, utterance string, notes []
 }
 
 // PhraseChat uses the LLM to respond conversationally, building a multi-turn
-// message array from dialogue history + the current user utterance. On any LLM
-// error it returns both ChatFallback and the error, on the same rule as
-// PhraseQuery: the fallback keeps the turn alive, the error stays visible.
+// message array from dialogue history + the current user utterance. Falls back
+// to a simple greeting on any LLM error — better to say something than nothing.
 func (p *LLMPhraser) PhraseChat(ctx context.Context, utterance string, history []dialogue.Turn) (string, error) {
 	sys := chatSystemPrompt(p.cfg.ContextBlock)
 	msgs := []chatMsg{
@@ -501,11 +490,13 @@ func (p *LLMPhraser) PhraseChat(ctx context.Context, utterance string, history [
 
 	resp, err := p.chatWithMessages(ctx, msgs, 768)
 	if err != nil {
-		return ChatFallback(), fmt.Errorf("phrase chat: %w", err)
+		log.Printf("phraser: PhraseChat: %v", err)
+		return "поговорили.", nil
 	}
 	text, _, perr := parseResponseMood(resp)
 	if perr != nil {
-		return ChatFallback(), fmt.Errorf("phrase chat: %w", perr)
+		log.Printf("phraser: PhraseChat: %v", perr)
+		return "поговорили.", nil
 	}
 	if text != "" {
 		return text, nil

internal/phraser/phraser.go

@@ -70,15 +70,18 @@ func NewStub() *Stub { return &Stub{} }
 // prompted response from the model. The history parameter is accepted but
 // ignored at the stub level (the production impl uses it for multi-turn).
 func (s *Stub) PhraseChat(_ context.Context, _ string, _ []dialogue.Turn) (string, error) {
-	return ChatFallback(), nil
+	return "поговорили.", nil
 }
 
 // PhraseQuery returns a deterministic summary of the best matching notes.
 func (s *Stub) PhraseQuery(_ context.Context, _ string, notes []string) (string, error) {
 	if len(notes) == 0 {
-		return UnknownFallback(), nil
+		return "не знаю.", nil
 	}
-	return SourcesFallback(strings.Join(notes, "; ")), nil
+	if len(notes) == 1 {
+		return "вот что я нашла: " + notes[0], nil
+	}
+	return "вот что я нашла: " + strings.Join(notes, "; "), nil
 }
 
 // Close implements Phraser.Close (no-op for the stub).

internal/phraser/swap_test.go

@@ -215,12 +215,10 @@ func TestSwap_RollbackFailureLeavesNoBackendAndDegrades(t *testing.T) {
 	if _, _, aerr := p.acquire(); !errors.Is(aerr, ErrNoBackend) {
 		t.Errorf("acquire error = %v; want ErrNoBackend", aerr)
 	}
-	// Phrasing degrades to its fallback instead of failing the turn, and since
-	// Vikunja #397 it reports the error next to that fallback so a measuring
-	// caller can tell "no model" from "bad phrasing".
+	// Phrasing degrades to its fallback instead of failing the turn.
 	got, err := p.PhraseChat(context.Background(), "привет", nil)
-	if !errors.Is(err, ErrNoBackend) {
-		t.Errorf("PhraseChat error = %v; want ErrNoBackend alongside the fallback", err)
+	if err != nil {
+		t.Fatalf("PhraseChat after a total failure returned an error: %v", err)
 	}
 	if got == "" {
 		t.Error("PhraseChat returned empty; the fallback must still say something")

internal/router/llmrouter.go

@@ -210,7 +210,11 @@ func (lr *LLMRouter) Route(ctx context.Context, utterance string, now time.Time)
 		d.Slots.HasKey = a.Key != ""
 	case IntentReminder:
 		d.Intent = IntentReminder
-		d.Slots.Text = firstNonEmpty(a.Text, utterance)
+		// No utterance fallback here, unlike every other intent below. The
+		// model returning no text for a reminder means it found no subject,
+		// and "напомни в 11" is not a subject. Leaving Text empty is what
+		// lets the gate turn that into a question (Vikunja #383).
+		d.Slots.Text = a.Text
 	case IntentNote:
 		d.Intent = IntentNote
 		d.Slots.Text = firstNonEmpty(a.Text, utterance)

internal/router/llmrouter_test.go

@@ -356,3 +356,35 @@ func TestRouterLLMFactWithResolvedKeyStaysConfident(t *testing.T) {
 		t.Fatalf("a fact the parser could key must not clarify: %+v", d)
 	}
 }
+
+// A reminder with a time and no subject must come back empty and gated, not
+// backfilled with the raw words. "напомни в 11" carries an hour and nothing to
+// say at that hour; parking the utterance in Text made the request look
+// complete, so the daemon set a reminder that fires saying "напомни в 11"
+// (Vikunja #383).
+func TestLLMReminderWithoutSubjectAsksInsteadOfGuessing(t *testing.T) {
+	r := newLLMTestRouter(t, `{"intent":"reminder"}`)
+	d, err := r.Route(context.Background(), "напомни в 11", refNow())
+	if err != nil {
+		t.Fatalf("route: %v", err)
+	}
+	if d.Slots.Text != "" {
+		t.Fatalf("subject backfilled from the utterance: %q", d.Slots.Text)
+	}
+	if !d.Clarify {
+		t.Fatalf("a subjectless reminder was accepted, confidence %v", d.Confidence)
+	}
+}
+
+// The gate is about the subject, not about reminders in general: one that has
+// both halves still runs without a question.
+func TestLLMReminderWithSubjectIsNotGated(t *testing.T) {
+	r := newLLMTestRouter(t, `{"intent":"reminder","text":"позвонить маме"}`)
+	d, err := r.Route(context.Background(), "напомни в 11 позвонить маме", refNow())
+	if err != nil {
+		t.Fatalf("route: %v", err)
+	}
+	if d.Clarify {
+		t.Fatalf("a complete reminder was sent back as a question: %+v", d.Slots)
+	}
+}

internal/router/router.go

@@ -147,7 +147,15 @@ func (r *Router) fillSlots(ctx context.Context, d *Decision, now time.Time) {
 			d.Slots.Fn, d.Slots.Args, d.Slots.HasFn = fn, args, true
 		}
 	}
-	if d.Slots.Text == "" {
+	// The extractor's Text is the raw utterance, which is the payload for a
+	// note, a query or a chat turn but not for a reminder — there Text is the
+	// subject, what she says at the hour. Backfilling it made Text impossible
+	// to be empty, so StillMissing never reported SlotText and "О чём
+	// напомнить?" was unaskable; the answer to a question she did manage to
+	// ask then overwrote the whole request instead of filling one gap
+	// (Vikunja #383). A reminder with no subject stays empty and is gated
+	// below into a question.
+	if d.Slots.Text == "" && d.Intent != IntentReminder {
 		d.Slots.Text = ex.Text
 	}
 	// Stage stays 1: it says who decided the route, and that was the LLM.
@@ -177,6 +185,12 @@ func (r *Router) gateLLMDecision(d *Decision) {
 	if d.Intent == IntentAct && !d.Slots.HasFn && d.Confidence > llmThinConfidence {
 		d.Confidence = llmThinConfidence
 	}
+	// A reminder with no subject: she knows when but not what to say then.
+	// Setting it anyway fires an empty reminder at the hour, which reads as a
+	// bug to him and cannot be repaired after the fact. Ask (Vikunja #383).
+	if d.Intent == IntentReminder && d.Slots.Text == "" && d.Confidence > llmThinConfidence {
+		d.Confidence = llmThinConfidence
+	}
 	if d.Confidence < r.threshold {
 		d.Clarify = true
 	}

internal/voice/replier.go

@@ -25,10 +25,7 @@
 // the daemon seam (config wiring, no CoreAPI or voice-package change).
 package voice
 
-import (
-	"github.com/kami/maven/internal/phraser"
-	"github.com/kami/maven/internal/router"
-)
+import "github.com/kami/maven/internal/router"
 
 // Replier — the reactive reply phrasing seam. The daemon's reactive handler
 // calls Reply with the router's Decision; the impl produces a terse reply
@@ -63,24 +60,27 @@ func (s *StubReplier) Reply(d router.Decision) string {
 		if !d.Slots.HasFn {
 			return "не могу это сделать — не разобрала действие."
 		}
-		return phraser.Ack(phraser.AckAct, map[string]string{"fn": d.Slots.Fn})
+		return "ок, записала действие: " + d.Slots.Fn
 	case router.IntentReminder:
-		return phraser.Ack(phraser.AckReminder, nil)
+		if d.Slots.HasTime {
+			return "напомню."
+		}
+		return "напомню."
 	case router.IntentFact:
 		if d.Slots.HasKey {
 			if d.Slots.Value != "" {
-				return phraser.Ack(phraser.AckFactValue, map[string]string{"key": d.Slots.Key, "value": d.Slots.Value})
+				return "отметила: " + d.Slots.Key + " = " + d.Slots.Value
 			}
-			return phraser.Ack(phraser.AckFactKey, map[string]string{"key": d.Slots.Key})
+			return "отметила: " + d.Slots.Key
 		}
-		return phraser.Ack(phraser.AckFact, nil)
+		return "записала факт."
 	case router.IntentNote:
-		return phraser.Ack(phraser.AckNote, nil)
+		return "сохранила заметку."
 	case router.IntentQuery:
 		return "поискала в заметках — ничего не нашла."
 	case router.IntentChat:
 		return "поговорили." // stub — LLMReplier replaces this
 	default:
-		return phraser.Ack(phraser.AckGeneric, nil)
+		return "приняла."
 	}
 }