SlotText in clarify Answer would clobber the original request #117

2026-08-04T00:49:08+02:00

claude commented

2026-08-04 00:49:08 +02:00

Closes Vikunja #383.

Opened during an unattended overnight run: the diff-budget block was off (task overnight). Read the diff, not only the tests.

Acceptance criteria and quality gate are in TASK.md on this branch.
Review the review, not the diff — leave comments and the agent will apply them via task start 383.

Closes Vikunja #383. Opened during an unattended overnight run: the diff-budget block was off (`task overnight`). Read the diff, not only the tests. Acceptance criteria and quality gate are in `TASK.md` on this branch. Review the review, not the diff — leave comments and the agent will apply them via `task start 383`.

claude added 1 commit 2026-08-04 00:49:09 +02:00

router: a reminder with no subject asks instead of guessing (V-383) 6d3f5b5b01

Slots.Text was the raw utterance for every intent, so a reminder could not
have an empty subject. StillMissing never reported SlotText, the question
"О чём напомнить?" was unaskable, and the branch in PendingQuestion.Answer
that fills a text slot could only overwrite the whole request.

The LLM path now keeps the model's own text, empty included, and the gate
turns a subjectless reminder into a question. The classifier path is
unchanged: it has no subject parser, so the utterance is the only signal it
has.

kami requested review from kami 2026-08-04 12:47:49 +02:00

kami approved these changes 2026-08-04 12:48:13 +02:00

claude merged commit c69023c310 into task/491-llama-server-core-dumps-on-every-sigterm

2026-08-04 14:09:01 +02:00

Sign in to join this conversation.

2 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kami/Maven#117