kami/Maven
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Decide whether a parked clarify question should survive a restart #130

Merged
claude merged 1 commits from task/385-decide-whether-a-parked-clarify-question into master 2026-08-04 18:23:12 +02:00
Conversation 2 Commits 1 Files Changed 4
+56 -1
claude commented 2026-08-04 01:33:25 +02:00
Contributor
Copy Link
Copy Source

Closes Vikunja #385.

Opened during an unattended overnight run: the diff-budget block was off (task overnight). Read the diff, not only the tests.

Acceptance criteria and quality gate are in TASK.md on this branch.
Review the review, not the diff — leave comments and the agent will apply them via task start 385.

Closes Vikunja #385. Opened during an unattended overnight run: the diff-budget block was off (`task overnight`). Read the diff, not only the tests. Acceptance criteria and quality gate are in `TASK.md` on this branch. Review the review, not the diff — leave comments and the agent will apply them via `task start 385`.
claude changed title from Bug: a pending clarify is global, so one unanswerable question swallows the next three utterances from anybody to Decide whether a parked clarify question should survive a restart 2026-08-04 03:03:33 +02:00
kami approved these changes 2026-08-04 12:56:55 +02:00
kami left a comment
Owner
Copy Link
Copy Source

what do you want from me?

what do you want from me?
claude commented 2026-08-04 18:19:47 +02:00
Author
Contributor
Copy Link
Copy Source

Reviewed as part of a bottom-up pass over the whole open stack (#119 to #168): commits read against the base branch, make test green at the top of the stack. Nothing to raise on this one. Merging.

Four findings landed on the PRs they belong to, none of them blocking: #167 (a duplicate rest-of-day-query grammar from the merge), #164 (four files the Russian sweep did not reach), #145 (sh -c hides an irreversible verb from the tier derivation), #128 (locationCandidates drops short city names).

Reviewed as part of a bottom-up pass over the whole open stack (#119 to #168): commits read against the base branch, `make test` green at the top of the stack. Nothing to raise on this one. Merging. Four findings landed on the PRs they belong to, none of them blocking: #167 (a duplicate `rest-of-day-query` grammar from the merge), #164 (four files the Russian sweep did not reach), #145 (`sh -c` hides an irreversible verb from the tier derivation), #128 (`locationCandidates` drops short city names).
claude changed target branch from task/377-backfill-routines to master 2026-08-04 18:23:11 +02:00
claude added 1 commit 2026-08-04 18:23:11 +02:00
dialogue: a restart expires the parked question (V-385) 5b622389c5 
The decision, not a behaviour change: ClarifyStore stays in memory, and she
does not announce the loss either.

The TTL and the attempt count measure a pause in one conversation. A restart
is a gap of unknown length, so a restored question is either dead already or
lying about its age, and the request behind it is one he has likely given up
on. Announcing it would mean storing a marker that outlives the thing it
describes, to say one sentence in the rare window where he speaks within 90s
of a restart. His next words route fresh, which is right either way.

Written down in docs/design.md, pinned at both ends by a comment, and held by
a test that builds a second handler over the same store.
claude merged commit 6eba79b332 into master 2026-08-04 18:23:12 +02:00
Sign in to join this conversation.
Reviewers
No Reviewers
kami
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kami
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kami/Maven#130
Delete Branch "task/385-decide-whether-a-parked-clarify-question"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?