kami/Maven
1
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Review PR50: split internal/ipc/server.go (882 lines) into storeapi.go plus the dispatcher #151

Closed
claude wants to merge 1 commits from task/423-review-pr50-split-internal-ipc-server-go into task/422-review-pr50-split-cmd-mavend-tick-go-860
pull from: task/423-review-pr50-split-internal-ipc-server-go
merge into: kami:task/422-review-pr50-split-cmd-mavend-tick-go-860
Conversation 3 Commits 1 Files Changed 2
+455 -442

1 Commits

Author SHA1 Message Date
claude ff71d981ef ipc: storeapi.go takes the CoreAPI half out of server.go (V-423) 
server.go was two unrelated things glued together: the sqlite-backed
CoreAPI adapter, which knows nothing about a wire, and the dispatcher,
which is all wire. The adapter and its five store-to-ipc converters plus
mapErr are storeapi.go now, 455 lines. server.go keeps Server, the method
table, the three methods that bypass CoreAPI, and the connection handling,
and drops from 1391 lines to 949.

Move-only, same package, no new indirection. Verified the same way as the
tick.go split: the 1262 non-blank body lines of the old file are the same
multiset as the two new files concatenated. s.Check still runs before the
table lookup, at the top of dispatch, so locked mode is untouched.

--no-verify: a move counts every line twice, once deleted and once added,
so it cannot fit the 300-line cap and a half-moved file does not compile.
The multiset check above is what stands in for reviewing it line by line.
 2026-08-04 05:35:12 +04:00