QA: phraser coverage is 65.3% but the llama-server subprocess lifecycle is 0% — the suspicion in this task was correct #90

2026-08-02T08:15:37+02:00

claude commented

2026-08-02 08:15:37 +02:00

Closes Vikunja #323.

Acceptance criteria and quality gate are in TASK.md on this branch.
Review the review, not the diff — leave comments and the agent will apply them via task start 323.

Closes Vikunja #323. Acceptance criteria and quality gate are in `TASK.md` on this branch. Review the review, not the diff — leave comments and the agent will apply them via `task start 323`.

claude added 1 commit 2026-08-02 08:15:37 +02:00

phraser: test the spawn path, the one thing coverage never touched (V-323) feb6f2c03d

Every phraser test built the phraser with NewLLMPhraserAt, which starts no
process, so NewLLMPhraser, spawnLlamaServer, startLlamaProc, llamaProc.Close
and extractPort sat at 0% while the package headline read 65.3%.

These drive the real spawn code against a fake llama-server script: the port
scrape, the three reachable startup-race arms (start failure, stderr EOF,
context cancel), and Close actually reaping the child. The orphan test
re-execs the test binary as the daemon, SIGKILLs it, and asserts Pdeathsig
killed the grandchild. The last test rebuilds the production command line and
checks kill-maven.sh's pattern still matches it — that pattern has gone stale
twice and leaked orphans both times.

Package coverage 65.3% -> 76.9%. The 60s timeout arm stays untested; it needs
an injectable clock in production code.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_012YQGVXu5J1iCMCff5J4S1R

kami commented

2026-08-02 11:30:18 +02:00

good to merge.

kami merged commit 5c05163266 into master

2026-08-02 11:39:21 +02:00

kami referenced this issue from a commit

2026-08-02 11:56:09 +02:00

docs: refresh the QA plan against the live task list (V-459)

kami referenced this pull request

2026-08-04 00:02:00 +02:00

Stale-task sweep 2026-08-04: what is left, and who it is blocked on #106

Sign in to join this conversation.