orchestra: TASK.md

TASK.md

@@ -1,15 +1,50 @@
-# Task 06G4E6F69AKP2PA00S28D7ASBC
+# Task 06G4E83E4KRXM8DS90M2648MGM
 
 Add a --quiet flag to the healthcheck script
 
 - Project: test-e2e
-- Source: gitea:test-e2e/7
+- Source: gitea:test-e2e/8
 - Priority: 0
 
 ## Instructions
 
+## Goal
+
+Add a --quiet flag to the healthcheck script
+
 scripts/orchestra_e2e_healthcheck.sh already handles --help. Add a --quiet flag alongside it that suppresses the success line and still exits 0. Leave the default behaviour and the --help output unchanged.
 
+## Verification
+
+- `bash -n scripts/*.sh && bash scripts/orchestra_e2e_healthcheck.sh` exited 0
+- commit: 41dee802416aaa9020a2e31ae5b79fa084a4f150
+- independent review of 41dee802416aaa9020a2e31ae5b79fa084a4f150: pass
+- accepted plan: 6c62e3cde23ed9aca296ed5b60295384b35cdad9fe0e1e45fa381d5801fb9af3
+
+## Behavioural changes
+
+- none reported
+
+## Deviations from plan
+
+- none reported
+
+## Remaining risks
+
+- none reported
+
+## Review hotspots
+
+- none reported
+
+The sections above are derived from Orchestra state. The reported
+changes, deviations, risks, and hotspots are the implementing agent's
+own account and are not verified.
+
+## Acceptance criteria
+
+- not stated in the task contract
+
 ## Completion
 
 Run the configured quality gate. When the task is ready for the worker to verify and deliver, create `.orchestra/done`. Do not write a prose completion report.

scripts/orchestra_e2e_healthcheck.sh

@@ -1,20 +1,16 @@
 #!/usr/bin/env bash
 
 main() {
-  local quiet=
   for arg in "$@"; do
     if [ "$arg" = --help ]; then
-      printf 'Usage: %s [--quiet]\n\n' "${0##*/}"
+      printf 'Usage: %s\n\n' "${0##*/}"
       printf 'Healthcheck script for Orchestra E2E tests.\n'
       printf 'Exits 0 with a success message if all checks pass.\n'
-      printf '  --quiet  Suppress the success message; still exits 0.\n'
       exit 0
-    elif [ "$arg" = --quiet ]; then
-      quiet=1
     fi
   done
 
-  [ -n "$quiet" ] || printf 'OK - all healthchecks passed\n'
+  printf 'OK - all healthchecks passed\n'
   exit 0
 }
 

scripts/test_healthcheck.sh

@@ -1,28 +0,0 @@
-#!/usr/bin/env bash
-# Self-check for orchestra_e2e_healthcheck.sh.
-
-HC="$(dirname "$0")/orchestra_e2e_healthcheck.sh"
-OK='OK - all healthchecks passed'
-USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n  --quiet  Suppress the success message; still exits 0.')"
-fails=0
-
-check() { # check <expected-stdout> <label> [args...]
-  local want=$1 label=$2 got status
-  shift 2
-  got=$(bash "$HC" "$@" 2>/dev/null)
-  status=$?
-  if [ "$got" != "$want" ] || [ "$status" -ne 0 ]; then
-    printf 'FAIL: %s (exit=%s)\n---got---\n%s\n---want---\n%s\n' "$label" "$status" "$got" "$want"
-    fails=$((fails + 1))
-  fi
-}
-
-check "$OK" 'no args'
-check '' '--quiet' --quiet
-check "$USAGE" '--help' --help
-check "$USAGE" '--help --quiet' --help --quiet
-check "$USAGE" '--quiet --help' --quiet --help
-check "$OK" 'unknown flag ignored' --bogus
-
-[ "$fails" -eq 0 ] || exit 1
-printf 'all checks passed\n'