orchestra: pre-release WIP snapshot (orchestra-06g4m8whgq4p3gqmpeeh0rjrhm-70ced771)

Reviewed-on: #17

TASK.md

@@ -1,22 +1,38 @@
-# Task 06G4GWWJ8SWFREF06HDYEBAG0C
+# Task 06G4M8WHGQ4P3GQMPEEH0RJRHM
 
-Route the healthcheck output through one helper
+Give the healthcheck a --list-checks flag
 
 - Project: test-e2e
-- Source: gitea:test-e2e/15
+- Source: burnin/run14-c
 - Priority: 0
 
 ## Instructions
 
-`scripts/orchestra_e2e_healthcheck.sh` prints its success line from more than one place. Centralise the output so every path goes through one helper, and give that helper an explicit format argument rather than reading a global.
+Give `scripts/orchestra_e2e_healthcheck.sh` a `--list-checks` flag that prints the name of each check it performs, one per line, and exits 0.
 
-Behaviour must not change. The plain run, `--quiet`, `--help` and `--json` all keep their current output and exit statuses, and `scripts/test_healthcheck.sh` keeps passing.
+This is deliberately two pieces of work, and the plan should carry two phases:
+
+1. Name the checks. The script performs its checks inline. Introduce one list of check names and drive the existing run from that list, with no change to any output or exit status.
+2. Add the flag. `--list-checks` prints the names from that list and exits 0. Add one line to the usage text describing it.
+
+## Verification policy for this project
+
+Only two commands may appear on a `- run:` line, exactly:
+
+- `["bash", "-n", "<path>"]`
+- `["bash", "scripts/orchestra_e2e_healthcheck.sh"]`
+
+Anything else is refused when you seal the plan. `scripts/test_healthcheck.sh` is NOT permitted as an automated command. Update it as a manual step so its expected `--help` text matches, and list that as a manual check.
 
 ## Research first
 
 Establish at least three findings with distinct confidence: at least one `fact`, one `inference`, one `assumption`.
 
 
+## Quality gate
+
+bash -n scripts/*.sh && bash scripts/orchestra_e2e_healthcheck.sh
+
 ## Completion
 
 Run the configured quality gate. When the task is ready for the worker to verify and deliver, create `.orchestra/done`. Do not write a prose completion report.

scripts/orchestra_e2e_healthcheck.sh

@@ -1,5 +1,8 @@
 #!/usr/bin/env bash
 
+readonly VERSION=1.0.0
+readonly CHECKS=(script-runs)
+
 # emit <format> <template> [args...]: the single output path.
 # format: text or json print; none suppresses (--quiet). Explicit argument,
 # never read from an enclosing variable.
@@ -18,6 +21,13 @@ main() {
       emit text 'Healthcheck script for Orchestra E2E tests.\n'
       emit text 'Exits 0 with a success message if all checks pass.\n'
       emit text '  --quiet  Suppress the success message; still exits 0.\n'
+      emit text '  --list-checks  Print the name of each check; exits 0.\n'
+      emit text 'Version: %s\n' "$VERSION"
+      exit 0
+    elif [ "$arg" = --list-checks ]; then
+      for name in "${CHECKS[@]}"; do
+        emit text '%s\n' "$name"
+      done
       exit 0
     elif [ "$arg" = --quiet ]; then
       quiet=1
@@ -31,7 +41,7 @@ main() {
   [ -n "$json" ] && format=json
 
   if [ "$format" = json ]; then
-    emit "$format" '{"status":"ok","checks":1}\n'
+    emit "$format" '{"status":"ok","checks":%d}\n' "${#CHECKS[@]}"
     exit 0
   fi
 

scripts/test_healthcheck.sh

@@ -3,7 +3,7 @@
 
 HC="$(dirname "$0")/orchestra_e2e_healthcheck.sh"
 OK='OK - all healthchecks passed'
-USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n  --quiet  Suppress the success message; still exits 0.')"
+USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n  --quiet  Suppress the success message; still exits 0.\n  --list-checks  Print the name of each check; exits 0.\nVersion: 1.0.0')"
 fails=0
 
 check() { # check <expected-stdout> <label> [args...]