orchestra: pre-release WIP snapshot (orchestra-06g4m6hf1z3erex1x3nekshp24-c19bf648)

TASK.md

@@ -1,33 +1,20 @@
-# Task 06G4SWEVP71FYYKAV5FV0ZK5ZG
+# Task 06G4M6HF1Z3EREX1X3NEKSHP24
 
-Give the healthcheck a --summary flag
+Name the healthcheck success message once
 
 - Project: test-e2e
-- Source: burnin/run16-rotation
+- Source: burnin/run14-a
 - Priority: 0
 
 ## Instructions
 
-Give scripts/orchestra_e2e_healthcheck.sh a --summary flag that prints one line per check with its result, then the usual success line.
+scripts/orchestra_e2e_healthcheck.sh spells its success message inline. Give it a single named constant beside the existing VERSION constant and use that constant everywhere the message is printed.
 
-Plan this as three phases, because each piece is independently verifiable:
-
-1. Introduce a results list. Record each check's name and outcome as it runs, with no change to any existing output or exit status.
-2. Add the --summary flag. It prints one line per recorded result, then the existing success line.
-3. Update the usage text and scripts/test_healthcheck.sh so the expected --help output matches.
-
-## Verification policy for this project
-
-Only two commands may appear on a run: line, exactly:
-
-- ["bash", "-n", "<path>"]
-- ["bash", "scripts/orchestra_e2e_healthcheck.sh"]
-
-Anything else is refused when you seal the plan. Give every phase at least one automated check from that list, and add a manual check where a human should confirm the printed text.
+Behaviour must not change. The plain run, --quiet and --help keep their current output and exit statuses, and scripts/test_healthcheck.sh keeps passing.
 
 ## Research first
 
-Establish at least three findings with distinct confidence: at least one fact, one inference, one assumption.
+Establish at least three findings with distinct confidence: at least one `fact`, one `inference`, one `assumption`.
 
 
 ## Quality gate

scripts/orchestra_e2e_healthcheck.sh

@@ -1,6 +1,7 @@
 #!/usr/bin/env bash
 
 readonly VERSION=1.0.0
+readonly SUCCESS_MESSAGE='OK - all healthchecks passed'
 
 # emit <format> <template> [args...]: the single output path.
 # format: text or json print; none suppresses (--quiet). Explicit argument,
@@ -14,28 +15,21 @@ emit() {
 main() {
   local quiet=
   local json=
-  local summary=
-  local -a results=()
   for arg in "$@"; do
     if [ "$arg" = --help ]; then
-      emit text 'Usage: %s [--quiet] [--summary]\n\n' "${0##*/}"
+      emit text 'Usage: %s [--quiet]\n\n' "${0##*/}"
       emit text 'Healthcheck script for Orchestra E2E tests.\n'
       emit text 'Exits 0 with a success message if all checks pass.\n'
       emit text '  --quiet  Suppress the success message; still exits 0.\n'
-      emit text '  --summary  Print one line per check before the success message.\n'
       emit text 'Version: %s\n' "$VERSION"
       exit 0
     elif [ "$arg" = --quiet ]; then
       quiet=1
     elif [ "$arg" = --json ]; then
       json=1
-    elif [ "$arg" = --summary ]; then
-      summary=1
     fi
   done
 
-  results+=("healthcheck ok")
-
   local format=text
   [ -n "$quiet" ] && format=none
   [ -n "$json" ] && format=json
@@ -45,13 +39,7 @@ main() {
     exit 0
   fi
 
-  if [ -n "$summary" ]; then
-    for r in "${results[@]}"; do
-      emit "$format" '%s: %s\n' "${r%% *}" "${r#* }"
-    done
-  fi
-
-  emit "$format" 'OK - all healthchecks passed\n'
+  emit "$format" '%s\n' "$SUCCESS_MESSAGE"
   exit 0
 }
 

scripts/test_healthcheck.sh

@@ -3,7 +3,7 @@
 
 HC="$(dirname "$0")/orchestra_e2e_healthcheck.sh"
 OK='OK - all healthchecks passed'
-USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet] [--summary]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n  --quiet  Suppress the success message; still exits 0.\n  --summary  Print one line per check before the success message.\nVersion: 1.0.0')"
+USAGE="$(printf 'Usage: orchestra_e2e_healthcheck.sh [--quiet]\n\nHealthcheck script for Orchestra E2E tests.\nExits 0 with a success message if all checks pass.\n  --quiet  Suppress the success message; still exits 0.\nVersion: 1.0.0')"
 fails=0
 
 check() { # check <expected-stdout> <label> [args...]