kami/test-e2e
1
0
Fork 0
Code Issues 20 Pull Requests 7 Actions Packages Projects Releases Wiki Activity

Print the healthcheck version in --json output #33

Open
kami wants to merge 2 commits from orchestra/06G4WW6TND26M16CZA6WE5T458 into master
pull from: orchestra/06G4WW6TND26M16CZA6WE5T458
merge into: kami:master
Conversation 0 Commits 2 Files Changed 3
+36 -13
kami commented 2026-08-29 19:03:45 +02:00
Owner
Copy Link
Copy Source

Goal

Print the healthcheck version in --json output

--json prints {"status":"ok","checks":<n>}. Add the script's VERSION to that object as a version field, leaving every other output untouched. Plan this as THREE phases: 1. A helper that returns the JSON body as a string, with the current fields and no behaviour change. 2. The version field added to that helper's output. 3. The usage text in --help, and assertions in scripts/test_healthcheck.sh. ## Work one phase at a time Implement phase N, request its verification, and only then begin phase N+1. ## Verification policy for this project Only two commands may appear on a run: line, exactly: - ["bash", "-n", ""] - ["bash", "scripts/orchestra_e2e_healthcheck.sh"] Anything else is refused when you seal the plan. Give every phase at least one automated check from that list and at least one manual check. ## Research first Establish at least three findings with distinct confidence: at least one fact, one inference, one assumption. Acceptance: - --json carries a version field with the script's VERSION. - --quiet, --summary, --timing, --strict and --help are unchanged.

Acceptance

  • not stated in the task contract

Verification

  • bash -n scripts/*.sh && bash scripts/orchestra_e2e_healthcheck.sh exited 0
  • commit: a9a732eb05
  • independent review of a9a732eb05: pass
  • minor findings, not fixed: 1
  • accepted plan: 2f42bd86c38fd9c1a7d500b68b7cc996a27c3b0f0d324ac02e3bd911c04bacef

Behavioural changes

  • none reported

Deviations from plan

  • none reported

Remaining risks

  • none reported

Review hotspots

  • none reported

Reviewer findings

  • minor: scripts/orchestra_e2e_healthcheck.sh:88 The --help output changed, which the acceptance list names as unchanged.

The sections above are derived from Orchestra state. The reported
changes, deviations, risks, and hotspots are the implementing agent's
own account and are not verified.

## Goal Print the healthcheck version in --json output `--json` prints `{"status":"ok","checks":<n>}`. Add the script's VERSION to that object as a `version` field, leaving every other output untouched. Plan this as THREE phases: 1. A helper that returns the JSON body as a string, with the current fields and no behaviour change. 2. The `version` field added to that helper's output. 3. The usage text in `--help`, and assertions in scripts/test_healthcheck.sh. ## Work one phase at a time Implement phase N, request its verification, and only then begin phase N+1. ## Verification policy for this project Only two commands may appear on a run: line, exactly: - ["bash", "-n", "<path>"] - ["bash", "scripts/orchestra_e2e_healthcheck.sh"] Anything else is refused when you seal the plan. Give every phase at least one automated check from that list and at least one manual check. ## Research first Establish at least three findings with distinct confidence: at least one fact, one inference, one assumption. Acceptance: - `--json` carries a version field with the script's VERSION. - --quiet, --summary, --timing, --strict and --help are unchanged. ## Acceptance - not stated in the task contract ## Verification - `bash -n scripts/*.sh && bash scripts/orchestra_e2e_healthcheck.sh` exited 0 - commit: a9a732eb0529e60ae193fefe0c818bbb4cb0c2b2 - independent review of a9a732eb0529e60ae193fefe0c818bbb4cb0c2b2: pass - minor findings, not fixed: 1 - accepted plan: 2f42bd86c38fd9c1a7d500b68b7cc996a27c3b0f0d324ac02e3bd911c04bacef ## Behavioural changes - none reported ## Deviations from plan - none reported ## Remaining risks - none reported ## Review hotspots - none reported ## Reviewer findings - minor: `scripts/orchestra_e2e_healthcheck.sh:88` The --help output changed, which the acceptance list names as unchanged. The sections above are derived from Orchestra state. The reported changes, deviations, risks, and hotspots are the implementing agent's own account and are not verified.
kami added 2 commits 2026-08-29 19:03:45 +02:00
orchestra: TASK.md f66c9a49ce
orchestra: pre-release WIP snapshot (orchestra-06g4ww6tnd26m16cza6we5t458-be13b045) a9a732eb05
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin orchestra/06G4WW6TND26M16CZA6WE5T458:orchestra/06G4WW6TND26M16CZA6WE5T458
git checkout orchestra/06G4WW6TND26M16CZA6WE5T458
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
kami
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: kami/test-e2e#33
Delete Branch "orchestra/06G4WW6TND26M16CZA6WE5T458"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?