Bug: the memory index stores the raw utterance as a fact's recall text, and nothing ever deletes a fact vector #100

2026-08-03T20:37:46+02:00

claude commented

2026-08-03 20:37:46 +02:00

Closes Vikunja #493.

Acceptance criteria and quality gate are in TASK.md on this branch.
Review the review, not the diff — leave comments and the agent will apply them via task start 493.

Closes Vikunja #493. Acceptance criteria and quality gate are in `TASK.md` on this branch. Review the review, not the diff — leave comments and the agent will apply them via `task start 493`.

claude added 4 commits 2026-08-03 20:37:46 +02:00

Merge pull request 'Bug: a question writes invented knowledge into memory as a self fact, and recall then serves it back for unrelated questions' (#99 ) from task/470-bug-a-question-writes-invented-knowledge into master b9371dcac6

Reviewed-on: #99

store, mavend: a fact is indexed as the fact, not as the utterance (V-493) dbdab2d570

queryMemory returns a fact's stored text verbatim, so the text the write path
indexed is what he hears. It was the utterance, which made recall of any
voice-tapped fact answer with the sentence he said: go_version = 1.20 was
indexed as "какая последняя версия языка Go?", and that question came back.

FactRecallText renders the fact instead, and the utterance stays in meta as
provenance. Correcting a value now drops the key's vectors the way voiding one
does, since the superseded value was still answering.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

store: repair fact vectors against the facts they name (V-493) 1528697287

Every write-path fix leaves the rows already stored wrong, and a box in that
state looks fine: recall answers with the wrong text and nothing logs an error.
That is how the original poison survived four restarts.

RepairFactVectors resolves each fact vector against the fact it names,
re-embeds the ones whose text is stale, and deletes the voided, superseded and
orphaned ones. Marker-guarded and idempotent, so it runs once per box and a run
that dies partway is simply redone.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

mavend: run the fact vector repair on start, and test what it does (V-493) ad60e10e95

Automatic rather than a flag, unlike -reembed: only voice-tapped facts are in
this index, so it is tens of embeddings rather than thousands of notes. And
waiting for an operator to know the repair exists is the failure being fixed.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

kami merged commit 453919db20 into task/470-bug-a-question-writes-invented-knowledge

2026-08-03 20:41:10 +02:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: kami/Maven#100